2018-02-20 13:30:22 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* ipmi_si.c
|
|
|
|
*
|
|
|
|
* The interface to the IPMI driver for the system interfaces (KCS, SMIC,
|
|
|
|
* BT).
|
|
|
|
*
|
|
|
|
* Author: MontaVista Software, Inc.
|
|
|
|
* Corey Minyard <minyard@mvista.com>
|
|
|
|
* source@mvista.com
|
|
|
|
*
|
|
|
|
* Copyright 2002 MontaVista Software Inc.
|
2007-05-08 07:23:51 +00:00
|
|
|
* Copyright 2006 IBM Corp., Christian Krafft <krafft@de.ibm.com>
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This file holds the "policy" for the interface to the SMI state
|
|
|
|
* machine. It does the configuration, handles timers and interrupts,
|
|
|
|
* and drives the real SMI state machine.
|
|
|
|
*/
|
|
|
|
|
2018-05-09 15:15:48 +00:00
|
|
|
#define pr_fmt(fmt) "ipmi_si: " fmt
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/moduleparam.h>
|
|
|
|
#include <linux/sched.h>
|
2011-05-26 23:25:55 +00:00
|
|
|
#include <linux/seq_file.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/timer.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/spinlock.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/list.h>
|
2005-11-07 08:59:59 +00:00
|
|
|
#include <linux/notifier.h>
|
2006-03-26 09:37:20 +00:00
|
|
|
#include <linux/mutex.h>
|
2005-11-07 09:00:04 +00:00
|
|
|
#include <linux/kthread.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <asm/irq.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/rcupdate.h>
|
2010-12-08 02:10:16 +00:00
|
|
|
#include <linux/ipmi.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/ipmi_smi.h>
|
2017-09-12 18:52:13 +00:00
|
|
|
#include "ipmi_si.h"
|
2006-12-07 04:41:07 +00:00
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/ctype.h>
|
2007-05-08 07:23:51 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Measure times between events in the driver. */
|
|
|
|
#undef DEBUG_TIMING
|
|
|
|
|
|
|
|
/* Call every 10 ms. */
|
|
|
|
#define SI_TIMEOUT_TIME_USEC 10000
|
|
|
|
#define SI_USEC_PER_JIFFY (1000000/HZ)
|
|
|
|
#define SI_TIMEOUT_JIFFIES (SI_TIMEOUT_TIME_USEC/SI_USEC_PER_JIFFY)
|
|
|
|
#define SI_SHORT_TIMEOUT_USEC 250 /* .25ms when the SM request a
|
2008-04-29 08:01:10 +00:00
|
|
|
short timeout */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
enum si_intf_state {
|
|
|
|
SI_NORMAL,
|
|
|
|
SI_GETTING_FLAGS,
|
|
|
|
SI_GETTING_EVENTS,
|
|
|
|
SI_CLEARING_FLAGS,
|
|
|
|
SI_GETTING_MESSAGES,
|
2014-11-19 10:03:26 +00:00
|
|
|
SI_CHECKING_ENABLES,
|
|
|
|
SI_SETTING_ENABLES
|
2005-04-16 22:20:36 +00:00
|
|
|
/* FIXME - add watchdog stuff. */
|
|
|
|
};
|
|
|
|
|
2005-05-01 15:59:11 +00:00
|
|
|
/* Some BT-specific defines we need here. */
|
|
|
|
#define IPMI_BT_INTMASK_REG 2
|
|
|
|
#define IPMI_BT_INTMASK_CLEAR_IRQ_BIT 2
|
|
|
|
#define IPMI_BT_INTMASK_ENABLE_IRQ_BIT 1
|
|
|
|
|
2017-09-18 17:38:17 +00:00
|
|
|
static const char * const si_to_str[] = { "invalid", "kcs", "smic", "bt" };
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-13 02:37:02 +00:00
|
|
|
static int initialized;
|
|
|
|
|
2008-04-29 08:01:07 +00:00
|
|
|
/*
|
|
|
|
* Indexes into stats[] in smi_info below.
|
|
|
|
*/
|
2008-04-29 08:01:08 +00:00
|
|
|
enum si_stat_indexes {
|
|
|
|
/*
|
|
|
|
* Number of times the driver requested a timer while an operation
|
|
|
|
* was in progress.
|
|
|
|
*/
|
|
|
|
SI_STAT_short_timeouts = 0,
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Number of times the driver requested a timer while nothing was in
|
|
|
|
* progress.
|
|
|
|
*/
|
|
|
|
SI_STAT_long_timeouts,
|
|
|
|
|
|
|
|
/* Number of times the interface was idle while being polled. */
|
|
|
|
SI_STAT_idles,
|
|
|
|
|
|
|
|
/* Number of interrupts the driver handled. */
|
|
|
|
SI_STAT_interrupts,
|
|
|
|
|
|
|
|
/* Number of time the driver got an ATTN from the hardware. */
|
|
|
|
SI_STAT_attentions,
|
2008-04-29 08:01:07 +00:00
|
|
|
|
2008-04-29 08:01:08 +00:00
|
|
|
/* Number of times the driver requested flags from the hardware. */
|
|
|
|
SI_STAT_flag_fetches,
|
|
|
|
|
|
|
|
/* Number of times the hardware didn't follow the state machine. */
|
|
|
|
SI_STAT_hosed_count,
|
|
|
|
|
|
|
|
/* Number of completed messages. */
|
|
|
|
SI_STAT_complete_transactions,
|
|
|
|
|
|
|
|
/* Number of IPMI events received from the hardware. */
|
|
|
|
SI_STAT_events,
|
|
|
|
|
|
|
|
/* Number of watchdog pretimeouts. */
|
|
|
|
SI_STAT_watchdog_pretimeouts,
|
|
|
|
|
2012-09-20 01:48:02 +00:00
|
|
|
/* Number of asynchronous messages received. */
|
2008-04-29 08:01:08 +00:00
|
|
|
SI_STAT_incoming_messages,
|
|
|
|
|
|
|
|
|
|
|
|
/* This *must* remain last, add new values above this. */
|
|
|
|
SI_NUM_STATS
|
|
|
|
};
|
2008-04-29 08:01:07 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
struct smi_info {
|
2018-04-11 18:28:34 +00:00
|
|
|
int si_num;
|
2018-04-06 01:54:04 +00:00
|
|
|
struct ipmi_smi *intf;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct si_sm_data *si_sm;
|
2015-06-13 15:34:25 +00:00
|
|
|
const struct si_sm_handlers *handlers;
|
2005-04-16 22:20:36 +00:00
|
|
|
spinlock_t si_lock;
|
2014-11-06 23:01:59 +00:00
|
|
|
struct ipmi_smi_msg *waiting_msg;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct ipmi_smi_msg *curr_msg;
|
|
|
|
enum si_intf_state si_state;
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Used to handle the various types of I/O that can occur with
|
|
|
|
* IPMI
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
struct si_sm_io io;
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Per-OEM handler, called from handle_flags(). Returns 1
|
|
|
|
* when handle_flags() needs to be re-run or 0 indicating it
|
|
|
|
* set si_state itself.
|
|
|
|
*/
|
2005-09-06 22:18:41 +00:00
|
|
|
int (*oem_data_avail_handler)(struct smi_info *smi_info);
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Flags from the last GET_MSG_FLAGS command, used when an ATTN
|
|
|
|
* is set to hold the flags until we are done handling everything
|
|
|
|
* from the flags.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
#define RECEIVE_MSG_AVAIL 0x01
|
|
|
|
#define EVENT_MSG_BUFFER_FULL 0x02
|
|
|
|
#define WDT_PRE_TIMEOUT_INT 0x08
|
2005-09-06 22:18:41 +00:00
|
|
|
#define OEM0_DATA_AVAIL 0x20
|
|
|
|
#define OEM1_DATA_AVAIL 0x40
|
|
|
|
#define OEM2_DATA_AVAIL 0x80
|
|
|
|
#define OEM_DATA_AVAIL (OEM0_DATA_AVAIL | \
|
2008-04-29 08:01:10 +00:00
|
|
|
OEM1_DATA_AVAIL | \
|
|
|
|
OEM2_DATA_AVAIL)
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned char msg_flags;
|
|
|
|
|
2009-04-21 19:24:03 +00:00
|
|
|
/* Does the BMC have an event buffer? */
|
2014-04-14 14:46:56 +00:00
|
|
|
bool has_event_buffer;
|
2009-04-21 19:24:03 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* If set to true, this will request events the next time the
|
|
|
|
* state machine is idle.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
atomic_t req_events;
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* If true, run the state machine to completion on every send
|
|
|
|
* call. Generally used after a panic to make sure stuff goes
|
|
|
|
* out.
|
|
|
|
*/
|
2014-04-14 14:46:56 +00:00
|
|
|
bool run_to_completion;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* The timer for this si. */
|
|
|
|
struct timer_list si_timer;
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
/* This flag is set, if the timer can be set */
|
|
|
|
bool timer_can_start;
|
|
|
|
|
2014-04-14 14:46:51 +00:00
|
|
|
/* This flag is set, if the timer is running (timer_pending() isn't enough) */
|
|
|
|
bool timer_running;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* The time (in jiffies) the last timeout occurred at. */
|
|
|
|
unsigned long last_timeout_jiffies;
|
|
|
|
|
2014-04-14 14:46:54 +00:00
|
|
|
/* Are we waiting for the events, pretimeouts, received msgs? */
|
|
|
|
atomic_t need_watch;
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* The driver will disable interrupts when it gets into a
|
|
|
|
* situation where it cannot handle messages due to lack of
|
|
|
|
* memory. Once that situation clears up, it will re-enable
|
|
|
|
* interrupts.
|
|
|
|
*/
|
2014-04-14 14:46:56 +00:00
|
|
|
bool interrupt_disabled;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
/*
|
|
|
|
* Does the BMC support events?
|
|
|
|
*/
|
|
|
|
bool supports_event_msg_buff;
|
|
|
|
|
2015-04-03 17:13:48 +00:00
|
|
|
/*
|
2015-08-18 19:29:10 +00:00
|
|
|
* Can we disable interrupts the global enables receive irq
|
|
|
|
* bit? There are currently two forms of brokenness, some
|
|
|
|
* systems cannot disable the bit (which is technically within
|
|
|
|
* the spec but a bad idea) and some systems have the bit
|
|
|
|
* forced to zero even though interrupts work (which is
|
|
|
|
* clearly outside the spec). The next bool tells which form
|
|
|
|
* of brokenness is present.
|
2015-04-03 17:13:48 +00:00
|
|
|
*/
|
2015-08-18 19:29:10 +00:00
|
|
|
bool cannot_disable_irq;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Some systems are broken and cannot set the irq enable
|
|
|
|
* bit, even if they support interrupts.
|
|
|
|
*/
|
|
|
|
bool irq_enable_broken;
|
2015-04-03 17:13:48 +00:00
|
|
|
|
2014-11-19 17:47:17 +00:00
|
|
|
/*
|
|
|
|
* Did we get an attention that we did not handle?
|
|
|
|
*/
|
|
|
|
bool got_attn;
|
|
|
|
|
2006-03-26 09:37:21 +00:00
|
|
|
/* From the get device id response... */
|
2005-09-06 22:18:41 +00:00
|
|
|
struct ipmi_device_id device_id;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
/* Default driver model device. */
|
2006-03-26 09:37:21 +00:00
|
|
|
struct platform_device *pdev;
|
|
|
|
|
2018-02-28 14:09:49 +00:00
|
|
|
/* Have we added the device group to the device? */
|
|
|
|
bool dev_group_added;
|
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
/* Have we added the platform device? */
|
|
|
|
bool pdev_registered;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Counters and things for the proc filesystem. */
|
2008-04-29 08:01:07 +00:00
|
|
|
atomic_t stats[SI_NUM_STATS];
|
2005-11-07 09:00:03 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
struct task_struct *thread;
|
2006-03-26 09:37:20 +00:00
|
|
|
|
|
|
|
struct list_head link;
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2008-04-29 08:01:07 +00:00
|
|
|
#define smi_inc_stat(smi, stat) \
|
|
|
|
atomic_inc(&(smi)->stats[SI_STAT_ ## stat])
|
|
|
|
#define smi_get_stat(smi, stat) \
|
|
|
|
((unsigned int) atomic_read(&(smi)->stats[SI_STAT_ ## stat]))
|
|
|
|
|
2017-09-13 03:46:29 +00:00
|
|
|
#define IPMI_MAX_INTFS 4
|
|
|
|
static int force_kipmid[IPMI_MAX_INTFS];
|
2006-10-03 08:13:59 +00:00
|
|
|
static int num_force_kipmid;
|
|
|
|
|
2017-09-13 03:46:29 +00:00
|
|
|
static unsigned int kipmid_max_busy_us[IPMI_MAX_INTFS];
|
2010-03-10 23:23:06 +00:00
|
|
|
static int num_max_busy_us;
|
|
|
|
|
2014-04-14 14:46:56 +00:00
|
|
|
static bool unload_when_empty = true;
|
2006-12-07 04:41:07 +00:00
|
|
|
|
2006-03-26 09:37:20 +00:00
|
|
|
static int try_smi_init(struct smi_info *smi);
|
2018-02-28 17:40:16 +00:00
|
|
|
static void cleanup_one_si(struct smi_info *smi_info);
|
2011-02-10 22:08:38 +00:00
|
|
|
static void cleanup_ipmi_si(void);
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2015-01-07 22:24:28 +00:00
|
|
|
#ifdef DEBUG_TIMING
|
|
|
|
void debug_timestamp(char *msg)
|
|
|
|
{
|
2015-01-07 22:24:29 +00:00
|
|
|
struct timespec64 t;
|
2015-01-07 22:24:28 +00:00
|
|
|
|
2018-06-18 14:27:09 +00:00
|
|
|
ktime_get_ts64(&t);
|
2015-01-07 22:24:29 +00:00
|
|
|
pr_debug("**%s: %lld.%9.9ld\n", msg, (long long) t.tv_sec, t.tv_nsec);
|
2015-01-07 22:24:28 +00:00
|
|
|
}
|
|
|
|
#else
|
|
|
|
#define debug_timestamp(x)
|
|
|
|
#endif
|
|
|
|
|
[PATCH] Notifier chain update: API changes
The kernel's implementation of notifier chains is unsafe. There is no
protection against entries being added to or removed from a chain while the
chain is in use. The issues were discussed in this thread:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113018709002036&w=2
We noticed that notifier chains in the kernel fall into two basic usage
classes:
"Blocking" chains are always called from a process context
and the callout routines are allowed to sleep;
"Atomic" chains can be called from an atomic context and
the callout routines are not allowed to sleep.
We decided to codify this distinction and make it part of the API. Therefore
this set of patches introduces three new, parallel APIs: one for blocking
notifiers, one for atomic notifiers, and one for "raw" notifiers (which is
really just the old API under a new name). New kinds of data structures are
used for the heads of the chains, and new routines are defined for
registration, unregistration, and calling a chain. The three APIs are
explained in include/linux/notifier.h and their implementation is in
kernel/sys.c.
With atomic and blocking chains, the implementation guarantees that the chain
links will not be corrupted and that chain callers will not get messed up by
entries being added or removed. For raw chains the implementation provides no
guarantees at all; users of this API must provide their own protections. (The
idea was that situations may come up where the assumptions of the atomic and
blocking APIs are not appropriate, so it should be possible for users to
handle these things in their own way.)
There are some limitations, which should not be too hard to live with. For
atomic/blocking chains, registration and unregistration must always be done in
a process context since the chain is protected by a mutex/rwsem. Also, a
callout routine for a non-raw chain must not try to register or unregister
entries on its own chain. (This did happen in a couple of places and the code
had to be changed to avoid it.)
Since atomic chains may be called from within an NMI handler, they cannot use
spinlocks for synchronization. Instead we use RCU. The overhead falls almost
entirely in the unregister routine, which is okay since unregistration is much
less frequent that calling a chain.
Here is the list of chains that we adjusted and their classifications. None
of them use the raw API, so for the moment it is only a placeholder.
ATOMIC CHAINS
-------------
arch/i386/kernel/traps.c: i386die_chain
arch/ia64/kernel/traps.c: ia64die_chain
arch/powerpc/kernel/traps.c: powerpc_die_chain
arch/sparc64/kernel/traps.c: sparc64die_chain
arch/x86_64/kernel/traps.c: die_chain
drivers/char/ipmi/ipmi_si_intf.c: xaction_notifier_list
kernel/panic.c: panic_notifier_list
kernel/profile.c: task_free_notifier
net/bluetooth/hci_core.c: hci_notifier
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_chain
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_expect_chain
net/ipv6/addrconf.c: inet6addr_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_expect_chain
net/netlink/af_netlink.c: netlink_chain
BLOCKING CHAINS
---------------
arch/powerpc/platforms/pseries/reconfig.c: pSeries_reconfig_chain
arch/s390/kernel/process.c: idle_chain
arch/x86_64/kernel/process.c idle_notifier
drivers/base/memory.c: memory_chain
drivers/cpufreq/cpufreq.c cpufreq_policy_notifier_list
drivers/cpufreq/cpufreq.c cpufreq_transition_notifier_list
drivers/macintosh/adb.c: adb_client_list
drivers/macintosh/via-pmu.c sleep_notifier_list
drivers/macintosh/via-pmu68k.c sleep_notifier_list
drivers/macintosh/windfarm_core.c wf_client_list
drivers/usb/core/notify.c usb_notifier_list
drivers/video/fbmem.c fb_notifier_list
kernel/cpu.c cpu_chain
kernel/module.c module_notify_list
kernel/profile.c munmap_notifier
kernel/profile.c task_exit_notifier
kernel/sys.c reboot_notifier_list
net/core/dev.c netdev_chain
net/decnet/dn_dev.c: dnaddr_chain
net/ipv4/devinet.c: inetaddr_chain
It's possible that some of these classifications are wrong. If they are,
please let us know or submit a patch to fix them. Note that any chain that
gets called very frequently should be atomic, because the rwsem read-locking
used for blocking chains is very likely to incur cache misses on SMP systems.
(However, if the chain's callout routines may sleep then the chain cannot be
atomic.)
The patch set was written by Alan Stern and Chandra Seetharaman, incorporating
material written by Keith Owens and suggestions from Paul McKenney and Andrew
Morton.
[jes@sgi.com: restructure the notifier chain initialization macros]
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-03-27 09:16:30 +00:00
|
|
|
static ATOMIC_NOTIFIER_HEAD(xaction_notifier_list);
|
2008-04-29 08:01:10 +00:00
|
|
|
static int register_xaction_notifier(struct notifier_block *nb)
|
2005-11-07 08:59:59 +00:00
|
|
|
{
|
[PATCH] Notifier chain update: API changes
The kernel's implementation of notifier chains is unsafe. There is no
protection against entries being added to or removed from a chain while the
chain is in use. The issues were discussed in this thread:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113018709002036&w=2
We noticed that notifier chains in the kernel fall into two basic usage
classes:
"Blocking" chains are always called from a process context
and the callout routines are allowed to sleep;
"Atomic" chains can be called from an atomic context and
the callout routines are not allowed to sleep.
We decided to codify this distinction and make it part of the API. Therefore
this set of patches introduces three new, parallel APIs: one for blocking
notifiers, one for atomic notifiers, and one for "raw" notifiers (which is
really just the old API under a new name). New kinds of data structures are
used for the heads of the chains, and new routines are defined for
registration, unregistration, and calling a chain. The three APIs are
explained in include/linux/notifier.h and their implementation is in
kernel/sys.c.
With atomic and blocking chains, the implementation guarantees that the chain
links will not be corrupted and that chain callers will not get messed up by
entries being added or removed. For raw chains the implementation provides no
guarantees at all; users of this API must provide their own protections. (The
idea was that situations may come up where the assumptions of the atomic and
blocking APIs are not appropriate, so it should be possible for users to
handle these things in their own way.)
There are some limitations, which should not be too hard to live with. For
atomic/blocking chains, registration and unregistration must always be done in
a process context since the chain is protected by a mutex/rwsem. Also, a
callout routine for a non-raw chain must not try to register or unregister
entries on its own chain. (This did happen in a couple of places and the code
had to be changed to avoid it.)
Since atomic chains may be called from within an NMI handler, they cannot use
spinlocks for synchronization. Instead we use RCU. The overhead falls almost
entirely in the unregister routine, which is okay since unregistration is much
less frequent that calling a chain.
Here is the list of chains that we adjusted and their classifications. None
of them use the raw API, so for the moment it is only a placeholder.
ATOMIC CHAINS
-------------
arch/i386/kernel/traps.c: i386die_chain
arch/ia64/kernel/traps.c: ia64die_chain
arch/powerpc/kernel/traps.c: powerpc_die_chain
arch/sparc64/kernel/traps.c: sparc64die_chain
arch/x86_64/kernel/traps.c: die_chain
drivers/char/ipmi/ipmi_si_intf.c: xaction_notifier_list
kernel/panic.c: panic_notifier_list
kernel/profile.c: task_free_notifier
net/bluetooth/hci_core.c: hci_notifier
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_chain
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_expect_chain
net/ipv6/addrconf.c: inet6addr_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_expect_chain
net/netlink/af_netlink.c: netlink_chain
BLOCKING CHAINS
---------------
arch/powerpc/platforms/pseries/reconfig.c: pSeries_reconfig_chain
arch/s390/kernel/process.c: idle_chain
arch/x86_64/kernel/process.c idle_notifier
drivers/base/memory.c: memory_chain
drivers/cpufreq/cpufreq.c cpufreq_policy_notifier_list
drivers/cpufreq/cpufreq.c cpufreq_transition_notifier_list
drivers/macintosh/adb.c: adb_client_list
drivers/macintosh/via-pmu.c sleep_notifier_list
drivers/macintosh/via-pmu68k.c sleep_notifier_list
drivers/macintosh/windfarm_core.c wf_client_list
drivers/usb/core/notify.c usb_notifier_list
drivers/video/fbmem.c fb_notifier_list
kernel/cpu.c cpu_chain
kernel/module.c module_notify_list
kernel/profile.c munmap_notifier
kernel/profile.c task_exit_notifier
kernel/sys.c reboot_notifier_list
net/core/dev.c netdev_chain
net/decnet/dn_dev.c: dnaddr_chain
net/ipv4/devinet.c: inetaddr_chain
It's possible that some of these classifications are wrong. If they are,
please let us know or submit a patch to fix them. Note that any chain that
gets called very frequently should be atomic, because the rwsem read-locking
used for blocking chains is very likely to incur cache misses on SMP systems.
(However, if the chain's callout routines may sleep then the chain cannot be
atomic.)
The patch set was written by Alan Stern and Chandra Seetharaman, incorporating
material written by Keith Owens and suggestions from Paul McKenney and Andrew
Morton.
[jes@sgi.com: restructure the notifier chain initialization macros]
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-03-27 09:16:30 +00:00
|
|
|
return atomic_notifier_chain_register(&xaction_notifier_list, nb);
|
2005-11-07 08:59:59 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static void deliver_recv_msg(struct smi_info *smi_info,
|
|
|
|
struct ipmi_smi_msg *msg)
|
|
|
|
{
|
2012-03-28 21:42:49 +00:00
|
|
|
/* Deliver the message to the upper layer. */
|
2018-04-11 18:24:27 +00:00
|
|
|
ipmi_smi_msg_received(smi_info->intf, msg);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2006-12-07 04:41:14 +00:00
|
|
|
static void return_hosed_msg(struct smi_info *smi_info, int cCode)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct ipmi_smi_msg *msg = smi_info->curr_msg;
|
|
|
|
|
2006-12-07 04:41:14 +00:00
|
|
|
if (cCode < 0 || cCode > IPMI_ERR_UNSPECIFIED)
|
|
|
|
cCode = IPMI_ERR_UNSPECIFIED;
|
|
|
|
/* else use it as is */
|
|
|
|
|
2011-03-31 01:57:33 +00:00
|
|
|
/* Make it a response */
|
2005-04-16 22:20:36 +00:00
|
|
|
msg->rsp[0] = msg->data[0] | 4;
|
|
|
|
msg->rsp[1] = msg->data[1];
|
2006-12-07 04:41:14 +00:00
|
|
|
msg->rsp[2] = cCode;
|
2005-04-16 22:20:36 +00:00
|
|
|
msg->rsp_size = 3;
|
|
|
|
|
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
deliver_recv_msg(smi_info, msg);
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum si_sm_result start_next_msg(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
int rv;
|
|
|
|
|
2014-11-06 23:01:59 +00:00
|
|
|
if (!smi_info->waiting_msg) {
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
rv = SI_SM_IDLE;
|
|
|
|
} else {
|
|
|
|
int err;
|
|
|
|
|
2014-11-06 23:01:59 +00:00
|
|
|
smi_info->curr_msg = smi_info->waiting_msg;
|
|
|
|
smi_info->waiting_msg = NULL;
|
2015-01-07 22:24:28 +00:00
|
|
|
debug_timestamp("Start2");
|
[PATCH] Notifier chain update: API changes
The kernel's implementation of notifier chains is unsafe. There is no
protection against entries being added to or removed from a chain while the
chain is in use. The issues were discussed in this thread:
http://marc.theaimsgroup.com/?l=linux-kernel&m=113018709002036&w=2
We noticed that notifier chains in the kernel fall into two basic usage
classes:
"Blocking" chains are always called from a process context
and the callout routines are allowed to sleep;
"Atomic" chains can be called from an atomic context and
the callout routines are not allowed to sleep.
We decided to codify this distinction and make it part of the API. Therefore
this set of patches introduces three new, parallel APIs: one for blocking
notifiers, one for atomic notifiers, and one for "raw" notifiers (which is
really just the old API under a new name). New kinds of data structures are
used for the heads of the chains, and new routines are defined for
registration, unregistration, and calling a chain. The three APIs are
explained in include/linux/notifier.h and their implementation is in
kernel/sys.c.
With atomic and blocking chains, the implementation guarantees that the chain
links will not be corrupted and that chain callers will not get messed up by
entries being added or removed. For raw chains the implementation provides no
guarantees at all; users of this API must provide their own protections. (The
idea was that situations may come up where the assumptions of the atomic and
blocking APIs are not appropriate, so it should be possible for users to
handle these things in their own way.)
There are some limitations, which should not be too hard to live with. For
atomic/blocking chains, registration and unregistration must always be done in
a process context since the chain is protected by a mutex/rwsem. Also, a
callout routine for a non-raw chain must not try to register or unregister
entries on its own chain. (This did happen in a couple of places and the code
had to be changed to avoid it.)
Since atomic chains may be called from within an NMI handler, they cannot use
spinlocks for synchronization. Instead we use RCU. The overhead falls almost
entirely in the unregister routine, which is okay since unregistration is much
less frequent that calling a chain.
Here is the list of chains that we adjusted and their classifications. None
of them use the raw API, so for the moment it is only a placeholder.
ATOMIC CHAINS
-------------
arch/i386/kernel/traps.c: i386die_chain
arch/ia64/kernel/traps.c: ia64die_chain
arch/powerpc/kernel/traps.c: powerpc_die_chain
arch/sparc64/kernel/traps.c: sparc64die_chain
arch/x86_64/kernel/traps.c: die_chain
drivers/char/ipmi/ipmi_si_intf.c: xaction_notifier_list
kernel/panic.c: panic_notifier_list
kernel/profile.c: task_free_notifier
net/bluetooth/hci_core.c: hci_notifier
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_chain
net/ipv4/netfilter/ip_conntrack_core.c: ip_conntrack_expect_chain
net/ipv6/addrconf.c: inet6addr_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_chain
net/netfilter/nf_conntrack_core.c: nf_conntrack_expect_chain
net/netlink/af_netlink.c: netlink_chain
BLOCKING CHAINS
---------------
arch/powerpc/platforms/pseries/reconfig.c: pSeries_reconfig_chain
arch/s390/kernel/process.c: idle_chain
arch/x86_64/kernel/process.c idle_notifier
drivers/base/memory.c: memory_chain
drivers/cpufreq/cpufreq.c cpufreq_policy_notifier_list
drivers/cpufreq/cpufreq.c cpufreq_transition_notifier_list
drivers/macintosh/adb.c: adb_client_list
drivers/macintosh/via-pmu.c sleep_notifier_list
drivers/macintosh/via-pmu68k.c sleep_notifier_list
drivers/macintosh/windfarm_core.c wf_client_list
drivers/usb/core/notify.c usb_notifier_list
drivers/video/fbmem.c fb_notifier_list
kernel/cpu.c cpu_chain
kernel/module.c module_notify_list
kernel/profile.c munmap_notifier
kernel/profile.c task_exit_notifier
kernel/sys.c reboot_notifier_list
net/core/dev.c netdev_chain
net/decnet/dn_dev.c: dnaddr_chain
net/ipv4/devinet.c: inetaddr_chain
It's possible that some of these classifications are wrong. If they are,
please let us know or submit a patch to fix them. Note that any chain that
gets called very frequently should be atomic, because the rwsem read-locking
used for blocking chains is very likely to incur cache misses on SMP systems.
(However, if the chain's callout routines may sleep then the chain cannot be
atomic.)
The patch set was written by Alan Stern and Chandra Seetharaman, incorporating
material written by Keith Owens and suggestions from Paul McKenney and Andrew
Morton.
[jes@sgi.com: restructure the notifier chain initialization macros]
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-03-27 09:16:30 +00:00
|
|
|
err = atomic_notifier_call_chain(&xaction_notifier_list,
|
|
|
|
0, smi_info);
|
2005-11-07 08:59:59 +00:00
|
|
|
if (err & NOTIFY_STOP_MASK) {
|
|
|
|
rv = SI_SM_CALL_WITHOUT_DELAY;
|
|
|
|
goto out;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
err = smi_info->handlers->start_transaction(
|
|
|
|
smi_info->si_sm,
|
|
|
|
smi_info->curr_msg->data,
|
|
|
|
smi_info->curr_msg->data_size);
|
2008-04-29 08:01:10 +00:00
|
|
|
if (err)
|
2006-12-07 04:41:14 +00:00
|
|
|
return_hosed_msg(smi_info, err);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
rv = SI_SM_CALL_WITHOUT_DELAY;
|
|
|
|
}
|
2016-04-27 03:40:15 +00:00
|
|
|
out:
|
2005-04-16 22:20:36 +00:00
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2015-09-05 22:44:13 +00:00
|
|
|
static void smi_mod_timer(struct smi_info *smi_info, unsigned long new_val)
|
|
|
|
{
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
if (!smi_info->timer_can_start)
|
|
|
|
return;
|
2015-09-05 22:44:13 +00:00
|
|
|
smi_info->last_timeout_jiffies = jiffies;
|
|
|
|
mod_timer(&smi_info->si_timer, new_val);
|
|
|
|
smi_info->timer_running = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Start a new message and (re)start the timer and thread.
|
|
|
|
*/
|
|
|
|
static void start_new_msg(struct smi_info *smi_info, unsigned char *msg,
|
|
|
|
unsigned int size)
|
|
|
|
{
|
|
|
|
smi_mod_timer(smi_info, jiffies + SI_TIMEOUT_JIFFIES);
|
|
|
|
|
|
|
|
if (smi_info->thread)
|
|
|
|
wake_up_process(smi_info->thread);
|
|
|
|
|
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, size);
|
|
|
|
}
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
static void start_check_enables(struct smi_info *smi_info)
|
2007-05-08 07:23:54 +00:00
|
|
|
{
|
|
|
|
unsigned char msg[2];
|
|
|
|
|
|
|
|
msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
msg[1] = IPMI_GET_BMC_GLOBAL_ENABLES_CMD;
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_new_msg(smi_info, msg, 2);
|
2014-11-19 10:03:26 +00:00
|
|
|
smi_info->si_state = SI_CHECKING_ENABLES;
|
2007-05-08 07:23:54 +00:00
|
|
|
}
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
static void start_clear_flags(struct smi_info *smi_info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned char msg[3];
|
|
|
|
|
|
|
|
/* Make sure the watchdog pre-timeout flag is not set at startup. */
|
|
|
|
msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
msg[1] = IPMI_CLEAR_MSG_FLAGS_CMD;
|
|
|
|
msg[2] = WDT_PRE_TIMEOUT_INT;
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_new_msg(smi_info, msg, 3);
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_CLEARING_FLAGS;
|
|
|
|
}
|
|
|
|
|
2014-11-07 01:06:00 +00:00
|
|
|
static void start_getting_msg_queue(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
smi_info->curr_msg->data[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
smi_info->curr_msg->data[1] = IPMI_GET_MSG_CMD;
|
|
|
|
smi_info->curr_msg->data_size = 2;
|
|
|
|
|
2015-09-05 22:44:13 +00:00
|
|
|
start_new_msg(smi_info, smi_info->curr_msg->data,
|
|
|
|
smi_info->curr_msg->data_size);
|
2014-11-07 01:06:00 +00:00
|
|
|
smi_info->si_state = SI_GETTING_MESSAGES;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void start_getting_events(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
smi_info->curr_msg->data[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
smi_info->curr_msg->data[1] = IPMI_READ_EVENT_MSG_BUFFER_CMD;
|
|
|
|
smi_info->curr_msg->data_size = 2;
|
|
|
|
|
2015-09-05 22:44:13 +00:00
|
|
|
start_new_msg(smi_info, smi_info->curr_msg->data,
|
|
|
|
smi_info->curr_msg->data_size);
|
2014-11-07 01:06:00 +00:00
|
|
|
smi_info->si_state = SI_GETTING_EVENTS;
|
|
|
|
}
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* When we have a situtaion where we run out of memory and cannot
|
|
|
|
* allocate messages, we just leave them in the BMC and run the system
|
|
|
|
* polled until we can allocate some memory. Once we have some
|
|
|
|
* memory, we will re-enable the interrupt.
|
2015-04-03 17:13:48 +00:00
|
|
|
*
|
|
|
|
* Note that we cannot just use disable_irq(), since the interrupt may
|
|
|
|
* be shared.
|
2008-04-29 08:01:10 +00:00
|
|
|
*/
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
static inline bool disable_si_irq(struct smi_info *smi_info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2017-09-12 19:41:56 +00:00
|
|
|
if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {
|
2014-04-14 14:46:56 +00:00
|
|
|
smi_info->interrupt_disabled = true;
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_check_enables(smi_info);
|
2014-11-07 01:06:00 +00:00
|
|
|
return true;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2014-11-07 01:06:00 +00:00
|
|
|
return false;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2014-11-07 01:06:00 +00:00
|
|
|
static inline bool enable_si_irq(struct smi_info *smi_info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2017-09-12 19:41:56 +00:00
|
|
|
if ((smi_info->io.irq) && (smi_info->interrupt_disabled)) {
|
2014-04-14 14:46:56 +00:00
|
|
|
smi_info->interrupt_disabled = false;
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_check_enables(smi_info);
|
2014-11-07 01:06:00 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Allocate a message. If unable to allocate, start the interrupt
|
|
|
|
* disable process and return NULL. If able to allocate but
|
|
|
|
* interrupts are disabled, free the message and return NULL after
|
|
|
|
* starting the interrupt enable process.
|
|
|
|
*/
|
|
|
|
static struct ipmi_smi_msg *alloc_msg_handle_irq(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
struct ipmi_smi_msg *msg;
|
|
|
|
|
|
|
|
msg = ipmi_alloc_smi_msg();
|
|
|
|
if (!msg) {
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
if (!disable_si_irq(smi_info))
|
2014-11-07 01:06:00 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
} else if (enable_si_irq(smi_info)) {
|
|
|
|
ipmi_free_smi_msg(msg);
|
|
|
|
msg = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2014-11-07 01:06:00 +00:00
|
|
|
return msg;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void handle_flags(struct smi_info *smi_info)
|
|
|
|
{
|
2016-04-27 03:40:15 +00:00
|
|
|
retry:
|
2005-04-16 22:20:36 +00:00
|
|
|
if (smi_info->msg_flags & WDT_PRE_TIMEOUT_INT) {
|
|
|
|
/* Watchdog pre-timeout */
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, watchdog_pretimeouts);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_clear_flags(smi_info);
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->msg_flags &= ~WDT_PRE_TIMEOUT_INT;
|
2018-04-11 18:24:27 +00:00
|
|
|
ipmi_smi_watchdog_pretimeout(smi_info->intf);
|
2005-04-16 22:20:36 +00:00
|
|
|
} else if (smi_info->msg_flags & RECEIVE_MSG_AVAIL) {
|
|
|
|
/* Messages available. */
|
2014-11-07 01:06:00 +00:00
|
|
|
smi_info->curr_msg = alloc_msg_handle_irq(smi_info);
|
|
|
|
if (!smi_info->curr_msg)
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
|
2014-11-07 01:06:00 +00:00
|
|
|
start_getting_msg_queue(smi_info);
|
2005-04-16 22:20:36 +00:00
|
|
|
} else if (smi_info->msg_flags & EVENT_MSG_BUFFER_FULL) {
|
|
|
|
/* Events available. */
|
2014-11-07 01:06:00 +00:00
|
|
|
smi_info->curr_msg = alloc_msg_handle_irq(smi_info);
|
|
|
|
if (!smi_info->curr_msg)
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
|
2014-11-07 01:06:00 +00:00
|
|
|
start_getting_events(smi_info);
|
2006-09-16 19:15:41 +00:00
|
|
|
} else if (smi_info->msg_flags & OEM_DATA_AVAIL &&
|
2008-04-29 08:01:10 +00:00
|
|
|
smi_info->oem_data_avail_handler) {
|
2006-09-16 19:15:41 +00:00
|
|
|
if (smi_info->oem_data_avail_handler(smi_info))
|
|
|
|
goto retry;
|
2008-04-29 08:01:10 +00:00
|
|
|
} else
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
}
|
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
/*
|
|
|
|
* Global enables we care about.
|
|
|
|
*/
|
|
|
|
#define GLOBAL_ENABLES_MASK (IPMI_BMC_EVT_MSG_BUFF | IPMI_BMC_RCV_MSG_INTR | \
|
|
|
|
IPMI_BMC_EVT_MSG_INTR)
|
|
|
|
|
2014-11-20 13:19:44 +00:00
|
|
|
static u8 current_global_enables(struct smi_info *smi_info, u8 base,
|
|
|
|
bool *irq_on)
|
2014-11-19 10:03:26 +00:00
|
|
|
{
|
|
|
|
u8 enables = 0;
|
|
|
|
|
|
|
|
if (smi_info->supports_event_msg_buff)
|
|
|
|
enables |= IPMI_BMC_EVT_MSG_BUFF;
|
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
if (((smi_info->io.irq && !smi_info->interrupt_disabled) ||
|
2015-08-18 19:29:10 +00:00
|
|
|
smi_info->cannot_disable_irq) &&
|
|
|
|
!smi_info->irq_enable_broken)
|
2014-11-19 10:03:26 +00:00
|
|
|
enables |= IPMI_BMC_RCV_MSG_INTR;
|
|
|
|
|
|
|
|
if (smi_info->supports_event_msg_buff &&
|
2017-09-12 19:41:56 +00:00
|
|
|
smi_info->io.irq && !smi_info->interrupt_disabled &&
|
2015-08-18 19:29:10 +00:00
|
|
|
!smi_info->irq_enable_broken)
|
2014-11-19 10:03:26 +00:00
|
|
|
enables |= IPMI_BMC_EVT_MSG_INTR;
|
|
|
|
|
2014-11-20 13:19:44 +00:00
|
|
|
*irq_on = enables & (IPMI_BMC_EVT_MSG_INTR | IPMI_BMC_RCV_MSG_INTR);
|
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
return enables;
|
|
|
|
}
|
|
|
|
|
2014-11-20 13:19:44 +00:00
|
|
|
static void check_bt_irq(struct smi_info *smi_info, bool irq_on)
|
|
|
|
{
|
|
|
|
u8 irqstate = smi_info->io.inputb(&smi_info->io, IPMI_BT_INTMASK_REG);
|
|
|
|
|
|
|
|
irqstate &= IPMI_BT_INTMASK_ENABLE_IRQ_BIT;
|
|
|
|
|
|
|
|
if ((bool)irqstate == irq_on)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (irq_on)
|
|
|
|
smi_info->io.outputb(&smi_info->io, IPMI_BT_INTMASK_REG,
|
|
|
|
IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
|
|
|
|
else
|
|
|
|
smi_info->io.outputb(&smi_info->io, IPMI_BT_INTMASK_REG, 0);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static void handle_transaction_done(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
struct ipmi_smi_msg *msg;
|
|
|
|
|
2015-01-07 22:24:28 +00:00
|
|
|
debug_timestamp("Done");
|
2005-04-16 22:20:36 +00:00
|
|
|
switch (smi_info->si_state) {
|
|
|
|
case SI_NORMAL:
|
2006-03-26 09:37:20 +00:00
|
|
|
if (!smi_info->curr_msg)
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
smi_info->curr_msg->rsp_size
|
|
|
|
= smi_info->handlers->get_result(
|
|
|
|
smi_info->si_sm,
|
|
|
|
smi_info->curr_msg->rsp,
|
|
|
|
IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do this here becase deliver_recv_msg() releases the
|
|
|
|
* lock, and a new message can be put in during the
|
|
|
|
* time the lock is released.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
msg = smi_info->curr_msg;
|
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
deliver_recv_msg(smi_info, msg);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case SI_GETTING_FLAGS:
|
|
|
|
{
|
|
|
|
unsigned char msg[4];
|
|
|
|
unsigned int len;
|
|
|
|
|
|
|
|
/* We got the flags from the SMI, now handle them. */
|
|
|
|
len = smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
|
|
|
|
if (msg[2] != 0) {
|
2008-04-29 08:01:10 +00:00
|
|
|
/* Error fetching flags, just give up for now. */
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
} else if (len < 4) {
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Hmm, no flags. That's technically illegal, but
|
|
|
|
* don't use uninitialized data.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
} else {
|
|
|
|
smi_info->msg_flags = msg[3];
|
|
|
|
handle_flags(smi_info);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SI_CLEARING_FLAGS:
|
|
|
|
{
|
|
|
|
unsigned char msg[3];
|
|
|
|
|
|
|
|
/* We cleared the flags. */
|
|
|
|
smi_info->handlers->get_result(smi_info->si_sm, msg, 3);
|
|
|
|
if (msg[2] != 0) {
|
|
|
|
/* Error clearing flags */
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2010-05-26 21:43:52 +00:00
|
|
|
"Error clearing flags: %2.2x\n", msg[2]);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2014-11-19 10:03:26 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SI_GETTING_EVENTS:
|
|
|
|
{
|
|
|
|
smi_info->curr_msg->rsp_size
|
|
|
|
= smi_info->handlers->get_result(
|
|
|
|
smi_info->si_sm,
|
|
|
|
smi_info->curr_msg->rsp,
|
|
|
|
IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do this here becase deliver_recv_msg() releases the
|
|
|
|
* lock, and a new message can be put in during the
|
|
|
|
* time the lock is released.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
msg = smi_info->curr_msg;
|
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
if (msg->rsp[2] != 0) {
|
|
|
|
/* Error getting event, probably done. */
|
|
|
|
msg->done(msg);
|
|
|
|
|
|
|
|
/* Take off the event flag. */
|
|
|
|
smi_info->msg_flags &= ~EVENT_MSG_BUFFER_FULL;
|
|
|
|
handle_flags(smi_info);
|
|
|
|
} else {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, events);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do this before we deliver the message
|
|
|
|
* because delivering the message releases the
|
|
|
|
* lock and something else can mess with the
|
|
|
|
* state.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
handle_flags(smi_info);
|
|
|
|
|
|
|
|
deliver_recv_msg(smi_info, msg);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
case SI_GETTING_MESSAGES:
|
|
|
|
{
|
|
|
|
smi_info->curr_msg->rsp_size
|
|
|
|
= smi_info->handlers->get_result(
|
|
|
|
smi_info->si_sm,
|
|
|
|
smi_info->curr_msg->rsp,
|
|
|
|
IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do this here becase deliver_recv_msg() releases the
|
|
|
|
* lock, and a new message can be put in during the
|
|
|
|
* time the lock is released.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
msg = smi_info->curr_msg;
|
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
if (msg->rsp[2] != 0) {
|
|
|
|
/* Error getting event, probably done. */
|
|
|
|
msg->done(msg);
|
|
|
|
|
|
|
|
/* Take off the msg flag. */
|
|
|
|
smi_info->msg_flags &= ~RECEIVE_MSG_AVAIL;
|
|
|
|
handle_flags(smi_info);
|
|
|
|
} else {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, incoming_messages);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do this before we deliver the message
|
|
|
|
* because delivering the message releases the
|
|
|
|
* lock and something else can mess with the
|
|
|
|
* state.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
handle_flags(smi_info);
|
|
|
|
|
|
|
|
deliver_recv_msg(smi_info, msg);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
case SI_CHECKING_ENABLES:
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned char msg[4];
|
2014-11-19 10:03:26 +00:00
|
|
|
u8 enables;
|
2014-11-20 13:19:44 +00:00
|
|
|
bool irq_on;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* We got the flags from the SMI, now handle them. */
|
|
|
|
smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
|
|
|
|
if (msg[2] != 0) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2013-05-16 19:04:26 +00:00
|
|
|
"Couldn't get irq info: %x.\n", msg[2]);
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2013-05-16 19:04:26 +00:00
|
|
|
"Maybe ok, but ipmi might run very slowly.\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
2014-11-19 10:03:26 +00:00
|
|
|
break;
|
|
|
|
}
|
2014-11-20 13:19:44 +00:00
|
|
|
enables = current_global_enables(smi_info, 0, &irq_on);
|
2017-09-12 19:41:56 +00:00
|
|
|
if (smi_info->io.si_type == SI_BT)
|
2014-11-20 13:19:44 +00:00
|
|
|
/* BT has its own interrupt enable bit. */
|
|
|
|
check_bt_irq(smi_info, irq_on);
|
2014-11-19 10:03:26 +00:00
|
|
|
if (enables != (msg[3] & GLOBAL_ENABLES_MASK)) {
|
|
|
|
/* Enables are not correct, fix them. */
|
2005-04-16 22:20:36 +00:00
|
|
|
msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
msg[1] = IPMI_SET_BMC_GLOBAL_ENABLES_CMD;
|
2014-11-19 10:03:26 +00:00
|
|
|
msg[2] = enables | (msg[3] & ~GLOBAL_ENABLES_MASK);
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->handlers->start_transaction(
|
|
|
|
smi_info->si_sm, msg, 3);
|
2014-11-19 10:03:26 +00:00
|
|
|
smi_info->si_state = SI_SETTING_ENABLES;
|
|
|
|
} else if (smi_info->supports_event_msg_buff) {
|
|
|
|
smi_info->curr_msg = ipmi_alloc_smi_msg();
|
|
|
|
if (!smi_info->curr_msg) {
|
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
break;
|
|
|
|
}
|
2016-10-27 15:12:18 +00:00
|
|
|
start_getting_events(smi_info);
|
2014-11-19 10:03:26 +00:00
|
|
|
} else {
|
|
|
|
smi_info->si_state = SI_NORMAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
case SI_SETTING_ENABLES:
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
unsigned char msg[4];
|
|
|
|
|
|
|
|
smi_info->handlers->get_result(smi_info->si_sm, msg, 4);
|
2014-11-19 10:03:26 +00:00
|
|
|
if (msg[2] != 0)
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2014-11-19 10:03:26 +00:00
|
|
|
"Could not set the global enables: 0x%x.\n",
|
|
|
|
msg[2]);
|
|
|
|
|
|
|
|
if (smi_info->supports_event_msg_buff) {
|
|
|
|
smi_info->curr_msg = ipmi_alloc_smi_msg();
|
|
|
|
if (!smi_info->curr_msg) {
|
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
break;
|
|
|
|
}
|
2016-10-27 15:12:18 +00:00
|
|
|
start_getting_events(smi_info);
|
2007-05-08 07:23:54 +00:00
|
|
|
} else {
|
2014-11-19 10:03:26 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
2007-05-08 07:23:54 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Called on timeouts and events. Timeouts should pass the elapsed
|
|
|
|
* time, interrupts should pass in zero. Must be called with
|
|
|
|
* si_lock held and interrupts disabled.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
static enum si_sm_result smi_event_handler(struct smi_info *smi_info,
|
|
|
|
int time)
|
|
|
|
{
|
|
|
|
enum si_sm_result si_sm_result;
|
|
|
|
|
2016-04-27 03:40:15 +00:00
|
|
|
restart:
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* There used to be a loop here that waited a little while
|
|
|
|
* (around 25us) before giving up. That turned out to be
|
|
|
|
* pointless, the minimum delays I was seeing were in the 300us
|
|
|
|
* range, which is far too long to wait in an interrupt. So
|
|
|
|
* we just run until the state machine tells us something
|
|
|
|
* happened or it needs a delay.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
si_sm_result = smi_info->handlers->event(smi_info->si_sm, time);
|
|
|
|
time = 0;
|
|
|
|
while (si_sm_result == SI_SM_CALL_WITHOUT_DELAY)
|
|
|
|
si_sm_result = smi_info->handlers->event(smi_info->si_sm, 0);
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
if (si_sm_result == SI_SM_TRANSACTION_COMPLETE) {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, complete_transactions);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
handle_transaction_done(smi_info);
|
2016-01-25 22:11:20 +00:00
|
|
|
goto restart;
|
2008-04-29 08:01:10 +00:00
|
|
|
} else if (si_sm_result == SI_SM_HOSED) {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, hosed_count);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Do the before return_hosed_msg, because that
|
|
|
|
* releases the lock.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_info->si_state = SI_NORMAL;
|
|
|
|
if (smi_info->curr_msg != NULL) {
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* If we were handling a user message, format
|
|
|
|
* a response to send to the upper layer to
|
|
|
|
* tell it about the error.
|
|
|
|
*/
|
2006-12-07 04:41:14 +00:00
|
|
|
return_hosed_msg(smi_info, IPMI_ERR_UNSPECIFIED);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2016-01-25 22:11:20 +00:00
|
|
|
goto restart;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-04-29 08:01:01 +00:00
|
|
|
/*
|
|
|
|
* We prefer handling attn over new messages. But don't do
|
|
|
|
* this if there is not yet an upper layer to handle anything.
|
|
|
|
*/
|
2018-04-11 18:24:27 +00:00
|
|
|
if (si_sm_result == SI_SM_ATTN || smi_info->got_attn) {
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned char msg[2];
|
|
|
|
|
2014-11-19 17:47:17 +00:00
|
|
|
if (smi_info->si_state != SI_NORMAL) {
|
|
|
|
/*
|
|
|
|
* We got an ATTN, but we are doing something else.
|
|
|
|
* Handle the ATTN later.
|
|
|
|
*/
|
|
|
|
smi_info->got_attn = true;
|
|
|
|
} else {
|
|
|
|
smi_info->got_attn = false;
|
|
|
|
smi_inc_stat(smi_info, attentions);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-11-19 17:47:17 +00:00
|
|
|
/*
|
|
|
|
* Got a attn, send down a get message flags to see
|
|
|
|
* what's causing it. It would be better to handle
|
|
|
|
* this in the upper layer, but due to the way
|
|
|
|
* interrupts work with the SMI, that's not really
|
|
|
|
* possible.
|
|
|
|
*/
|
|
|
|
msg[0] = (IPMI_NETFN_APP_REQUEST << 2);
|
|
|
|
msg[1] = IPMI_GET_MSG_FLAGS_CMD;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-09-05 22:44:13 +00:00
|
|
|
start_new_msg(smi_info, msg, 2);
|
2014-11-19 17:47:17 +00:00
|
|
|
smi_info->si_state = SI_GETTING_FLAGS;
|
|
|
|
goto restart;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* If we are currently idle, try to start the next message. */
|
|
|
|
if (si_sm_result == SI_SM_IDLE) {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, idles);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
si_sm_result = start_next_msg(smi_info);
|
|
|
|
if (si_sm_result != SI_SM_IDLE)
|
|
|
|
goto restart;
|
2008-04-29 08:01:10 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if ((si_sm_result == SI_SM_IDLE)
|
2008-04-29 08:01:10 +00:00
|
|
|
&& (atomic_read(&smi_info->req_events))) {
|
|
|
|
/*
|
|
|
|
* We are idle and the upper layer requested that I fetch
|
|
|
|
* events, so do so.
|
|
|
|
*/
|
2006-12-07 04:41:04 +00:00
|
|
|
atomic_set(&smi_info->req_events, 0);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
/*
|
|
|
|
* Take this opportunity to check the interrupt and
|
|
|
|
* message enable state for the BMC. The BMC can be
|
|
|
|
* asynchronously reset, and may thus get interrupts
|
|
|
|
* disable and messages disabled.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
if (smi_info->supports_event_msg_buff || smi_info->io.irq) {
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_check_enables(smi_info);
|
2014-11-19 10:03:26 +00:00
|
|
|
} else {
|
|
|
|
smi_info->curr_msg = alloc_msg_handle_irq(smi_info);
|
|
|
|
if (!smi_info->curr_msg)
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
start_getting_events(smi_info);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
goto restart;
|
|
|
|
}
|
2015-09-05 22:58:13 +00:00
|
|
|
|
|
|
|
if (si_sm_result == SI_SM_IDLE && smi_info->timer_running) {
|
|
|
|
/* Ok it if fails, the timer will just go off. */
|
|
|
|
if (del_timer(&smi_info->si_timer))
|
|
|
|
smi_info->timer_running = false;
|
|
|
|
}
|
|
|
|
|
2016-04-27 03:40:15 +00:00
|
|
|
out:
|
2005-04-16 22:20:36 +00:00
|
|
|
return si_sm_result;
|
|
|
|
}
|
|
|
|
|
2014-04-14 14:46:54 +00:00
|
|
|
static void check_start_timer_thread(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
if (smi_info->si_state == SI_NORMAL && smi_info->curr_msg == NULL) {
|
|
|
|
smi_mod_timer(smi_info, jiffies + SI_TIMEOUT_JIFFIES);
|
|
|
|
|
|
|
|
if (smi_info->thread)
|
|
|
|
wake_up_process(smi_info->thread);
|
|
|
|
|
|
|
|
start_next_msg(smi_info);
|
|
|
|
smi_event_handler(smi_info, 0);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-07-27 05:55:16 +00:00
|
|
|
static void flush_messages(void *send_info)
|
2015-07-27 05:55:16 +00:00
|
|
|
{
|
2015-07-27 05:55:16 +00:00
|
|
|
struct smi_info *smi_info = send_info;
|
2015-07-27 05:55:16 +00:00
|
|
|
enum si_sm_result result;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Currently, this function is called only in run-to-completion
|
|
|
|
* mode. This means we are single-threaded, no need for locks.
|
|
|
|
*/
|
|
|
|
result = smi_event_handler(smi_info, 0);
|
|
|
|
while (result != SI_SM_IDLE) {
|
|
|
|
udelay(SI_SHORT_TIMEOUT_USEC);
|
|
|
|
result = smi_event_handler(smi_info, SI_SHORT_TIMEOUT_USEC);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static void sender(void *send_info,
|
2014-11-07 13:57:31 +00:00
|
|
|
struct ipmi_smi_msg *msg)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2015-01-07 22:24:28 +00:00
|
|
|
debug_timestamp("Enqueue");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (smi_info->run_to_completion) {
|
2008-04-29 08:01:02 +00:00
|
|
|
/*
|
2015-07-27 05:55:16 +00:00
|
|
|
* If we are running to completion, start it. Upper
|
|
|
|
* layer will call flush_messages to clear it out.
|
2008-04-29 08:01:02 +00:00
|
|
|
*/
|
2015-04-23 02:16:44 +00:00
|
|
|
smi_info->waiting_msg = msg;
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-03-28 21:42:50 +00:00
|
|
|
spin_lock_irqsave(&smi_info->si_lock, flags);
|
2015-02-19 14:25:49 +00:00
|
|
|
/*
|
|
|
|
* The following two lines don't need to be under the lock for
|
|
|
|
* the lock's sake, but they do need SMP memory barriers to
|
|
|
|
* avoid getting things out of order. We are already claiming
|
|
|
|
* the lock, anyway, so just do it under the lock to avoid the
|
|
|
|
* ordering problem.
|
|
|
|
*/
|
|
|
|
BUG_ON(smi_info->waiting_msg);
|
|
|
|
smi_info->waiting_msg = msg;
|
2014-04-14 14:46:54 +00:00
|
|
|
check_start_timer_thread(smi_info);
|
2008-04-29 08:01:02 +00:00
|
|
|
spin_unlock_irqrestore(&smi_info->si_lock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2014-04-14 14:46:56 +00:00
|
|
|
static void set_run_to_completion(void *send_info, bool i_run_to_completion)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
|
|
|
|
|
|
|
smi_info->run_to_completion = i_run_to_completion;
|
2015-07-27 05:55:16 +00:00
|
|
|
if (i_run_to_completion)
|
|
|
|
flush_messages(smi_info);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-03-10 23:23:06 +00:00
|
|
|
/*
|
|
|
|
* Use -1 in the nsec value of the busy waiting timespec to tell that
|
|
|
|
* we are spinning in kipmid looking for something and not delaying
|
|
|
|
* between checks
|
|
|
|
*/
|
2015-01-07 22:24:29 +00:00
|
|
|
static inline void ipmi_si_set_not_busy(struct timespec64 *ts)
|
2010-03-10 23:23:06 +00:00
|
|
|
{
|
|
|
|
ts->tv_nsec = -1;
|
|
|
|
}
|
2015-01-07 22:24:29 +00:00
|
|
|
static inline int ipmi_si_is_busy(struct timespec64 *ts)
|
2010-03-10 23:23:06 +00:00
|
|
|
{
|
|
|
|
return ts->tv_nsec != -1;
|
|
|
|
}
|
|
|
|
|
2014-10-06 19:17:52 +00:00
|
|
|
static inline int ipmi_thread_busy_wait(enum si_sm_result smi_result,
|
|
|
|
const struct smi_info *smi_info,
|
2015-01-07 22:24:29 +00:00
|
|
|
struct timespec64 *busy_until)
|
2010-03-10 23:23:06 +00:00
|
|
|
{
|
|
|
|
unsigned int max_busy_us = 0;
|
|
|
|
|
2018-04-11 18:28:34 +00:00
|
|
|
if (smi_info->si_num < num_max_busy_us)
|
|
|
|
max_busy_us = kipmid_max_busy_us[smi_info->si_num];
|
2010-03-10 23:23:06 +00:00
|
|
|
if (max_busy_us == 0 || smi_result != SI_SM_CALL_WITH_DELAY)
|
|
|
|
ipmi_si_set_not_busy(busy_until);
|
|
|
|
else if (!ipmi_si_is_busy(busy_until)) {
|
2018-06-18 14:27:09 +00:00
|
|
|
ktime_get_ts64(busy_until);
|
2015-01-07 22:24:29 +00:00
|
|
|
timespec64_add_ns(busy_until, max_busy_us*NSEC_PER_USEC);
|
2010-03-10 23:23:06 +00:00
|
|
|
} else {
|
2015-01-07 22:24:29 +00:00
|
|
|
struct timespec64 now;
|
|
|
|
|
2018-06-18 14:27:09 +00:00
|
|
|
ktime_get_ts64(&now);
|
2015-01-07 22:24:29 +00:00
|
|
|
if (unlikely(timespec64_compare(&now, busy_until) > 0)) {
|
2010-03-10 23:23:06 +00:00
|
|
|
ipmi_si_set_not_busy(busy_until);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A busy-waiting loop for speeding up IPMI operation.
|
|
|
|
*
|
|
|
|
* Lousy hardware makes this hard. This is only enabled for systems
|
|
|
|
* that are not BT and do not have interrupts. It starts spinning
|
|
|
|
* when an operation is complete or until max_busy tells it to stop
|
|
|
|
* (if that is enabled). See the paragraph on kimid_max_busy_us in
|
|
|
|
* Documentation/IPMI.txt for details.
|
|
|
|
*/
|
2005-11-07 09:00:03 +00:00
|
|
|
static int ipmi_thread(void *data)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = data;
|
2005-11-07 09:00:04 +00:00
|
|
|
unsigned long flags;
|
2005-11-07 09:00:03 +00:00
|
|
|
enum si_sm_result smi_result;
|
2015-01-07 22:24:29 +00:00
|
|
|
struct timespec64 busy_until;
|
2005-11-07 09:00:03 +00:00
|
|
|
|
2010-03-10 23:23:06 +00:00
|
|
|
ipmi_si_set_not_busy(&busy_until);
|
2014-03-11 10:09:12 +00:00
|
|
|
set_user_nice(current, MAX_NICE);
|
2005-11-07 09:00:04 +00:00
|
|
|
while (!kthread_should_stop()) {
|
2010-03-10 23:23:06 +00:00
|
|
|
int busy_wait;
|
|
|
|
|
2005-11-07 09:00:03 +00:00
|
|
|
spin_lock_irqsave(&(smi_info->si_lock), flags);
|
2006-03-31 10:30:40 +00:00
|
|
|
smi_result = smi_event_handler(smi_info, 0);
|
2014-04-14 14:46:51 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the driver is doing something, there is a possible
|
|
|
|
* race with the timer. If the timer handler see idle,
|
|
|
|
* and the thread here sees something else, the timer
|
|
|
|
* handler won't restart the timer even though it is
|
|
|
|
* required. So start it here if necessary.
|
|
|
|
*/
|
|
|
|
if (smi_result != SI_SM_IDLE && !smi_info->timer_running)
|
|
|
|
smi_mod_timer(smi_info, jiffies + SI_TIMEOUT_JIFFIES);
|
|
|
|
|
2005-11-07 09:00:03 +00:00
|
|
|
spin_unlock_irqrestore(&(smi_info->si_lock), flags);
|
2010-03-10 23:23:06 +00:00
|
|
|
busy_wait = ipmi_thread_busy_wait(smi_result, smi_info,
|
|
|
|
&busy_until);
|
2008-04-29 08:01:10 +00:00
|
|
|
if (smi_result == SI_SM_CALL_WITHOUT_DELAY)
|
|
|
|
; /* do nothing */
|
2010-03-10 23:23:06 +00:00
|
|
|
else if (smi_result == SI_SM_CALL_WITH_DELAY && busy_wait)
|
2006-06-27 09:54:04 +00:00
|
|
|
schedule();
|
2014-04-14 14:46:54 +00:00
|
|
|
else if (smi_result == SI_SM_IDLE) {
|
|
|
|
if (atomic_read(&smi_info->need_watch)) {
|
|
|
|
schedule_timeout_interruptible(100);
|
|
|
|
} else {
|
|
|
|
/* Wait to be woken up when we are needed. */
|
|
|
|
__set_current_state(TASK_INTERRUPTIBLE);
|
|
|
|
schedule();
|
|
|
|
}
|
|
|
|
} else
|
2010-06-29 22:05:31 +00:00
|
|
|
schedule_timeout_interruptible(1);
|
2005-11-07 09:00:03 +00:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static void poll(void *send_info)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
2012-03-28 21:42:50 +00:00
|
|
|
unsigned long flags = 0;
|
2014-04-14 14:46:56 +00:00
|
|
|
bool run_to_completion = smi_info->run_to_completion;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-12-07 04:41:06 +00:00
|
|
|
/*
|
|
|
|
* Make sure there is some delay in the poll loop so we can
|
|
|
|
* drive time forward and timeout things.
|
|
|
|
*/
|
|
|
|
udelay(10);
|
2012-03-28 21:42:50 +00:00
|
|
|
if (!run_to_completion)
|
|
|
|
spin_lock_irqsave(&smi_info->si_lock, flags);
|
2006-12-07 04:41:06 +00:00
|
|
|
smi_event_handler(smi_info, 10);
|
2012-03-28 21:42:50 +00:00
|
|
|
if (!run_to_completion)
|
|
|
|
spin_unlock_irqrestore(&smi_info->si_lock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void request_events(void *send_info)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
|
|
|
|
2014-11-06 23:01:59 +00:00
|
|
|
if (!smi_info->has_event_buffer)
|
2006-12-07 04:41:07 +00:00
|
|
|
return;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
atomic_set(&smi_info->req_events, 1);
|
|
|
|
}
|
|
|
|
|
2014-04-14 14:46:56 +00:00
|
|
|
static void set_need_watch(void *send_info, bool enable)
|
2014-04-14 14:46:54 +00:00
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
atomic_set(&smi_info->need_watch, enable);
|
|
|
|
spin_lock_irqsave(&smi_info->si_lock, flags);
|
|
|
|
check_start_timer_thread(smi_info);
|
|
|
|
spin_unlock_irqrestore(&smi_info->si_lock, flags);
|
|
|
|
}
|
|
|
|
|
treewide: setup_timer() -> timer_setup()
This converts all remaining cases of the old setup_timer() API into using
timer_setup(), where the callback argument is the structure already
holding the struct timer_list. These should have no behavioral changes,
since they just change which pointer is passed into the callback with
the same available pointers after conversion. It handles the following
examples, in addition to some other variations.
Casting from unsigned long:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
setup_timer(&ptr->my_timer, my_callback, ptr);
and forced object casts:
void my_callback(struct something *ptr)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);
become:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
Direct function assignments:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
ptr->my_timer.function = my_callback;
have a temporary cast added, along with converting the args:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;
And finally, callbacks without a data assignment:
void my_callback(unsigned long data)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, 0);
have their argument renamed to verify they're unused during conversion:
void my_callback(struct timer_list *unused)
{
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
The conversion is done with the following Coccinelle script:
spatch --very-quiet --all-includes --include-headers \
-I ./arch/x86/include -I ./arch/x86/include/generated \
-I ./include -I ./arch/x86/include/uapi \
-I ./arch/x86/include/generated/uapi -I ./include/uapi \
-I ./include/generated/uapi --include ./include/linux/kconfig.h \
--dir . \
--cocci-file ~/src/data/timer_setup.cocci
@fix_address_of@
expression e;
@@
setup_timer(
-&(e)
+&e
, ...)
// Update any raw setup_timer() usages that have a NULL callback, but
// would otherwise match change_timer_function_usage, since the latter
// will update all function assignments done in the face of a NULL
// function initialization in setup_timer().
@change_timer_function_usage_NULL@
expression _E;
identifier _timer;
type _cast_data;
@@
(
-setup_timer(&_E->_timer, NULL, _E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E->_timer, NULL, (_cast_data)_E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, &_E);
+timer_setup(&_E._timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, (_cast_data)&_E);
+timer_setup(&_E._timer, NULL, 0);
)
@change_timer_function_usage@
expression _E;
identifier _timer;
struct timer_list _stl;
identifier _callback;
type _cast_func, _cast_data;
@@
(
-setup_timer(&_E->_timer, _callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
_E->_timer@_stl.function = _callback;
|
_E->_timer@_stl.function = &_callback;
|
_E->_timer@_stl.function = (_cast_func)_callback;
|
_E->_timer@_stl.function = (_cast_func)&_callback;
|
_E._timer@_stl.function = _callback;
|
_E._timer@_stl.function = &_callback;
|
_E._timer@_stl.function = (_cast_func)_callback;
|
_E._timer@_stl.function = (_cast_func)&_callback;
)
// callback(unsigned long arg)
@change_callback_handle_cast
depends on change_timer_function_usage@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
identifier _handle;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
(
... when != _origarg
_handletype *_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
)
}
// callback(unsigned long arg) without existing variable
@change_callback_handle_cast_no_arg
depends on change_timer_function_usage &&
!change_callback_handle_cast@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
+ _handletype *_origarg = from_timer(_origarg, t, _timer);
+
... when != _origarg
- (_handletype *)_origarg
+ _origarg
... when != _origarg
}
// Avoid already converted callbacks.
@match_callback_converted
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier t;
@@
void _callback(struct timer_list *t)
{ ... }
// callback(struct something *handle)
@change_callback_handle_arg
depends on change_timer_function_usage &&
!match_callback_converted &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
@@
void _callback(
-_handletype *_handle
+struct timer_list *t
)
{
+ _handletype *_handle = from_timer(_handle, t, _timer);
...
}
// If change_callback_handle_arg ran on an empty function, remove
// the added handler.
@unchange_callback_handle_arg
depends on change_timer_function_usage &&
change_callback_handle_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
identifier t;
@@
void _callback(struct timer_list *t)
{
- _handletype *_handle = from_timer(_handle, t, _timer);
}
// We only want to refactor the setup_timer() data argument if we've found
// the matching callback. This undoes changes in change_timer_function_usage.
@unchange_timer_function_usage
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg &&
!change_callback_handle_arg@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type change_timer_function_usage._cast_data;
@@
(
-timer_setup(&_E->_timer, _callback, 0);
+setup_timer(&_E->_timer, _callback, (_cast_data)_E);
|
-timer_setup(&_E._timer, _callback, 0);
+setup_timer(&_E._timer, _callback, (_cast_data)&_E);
)
// If we fixed a callback from a .function assignment, fix the
// assignment cast now.
@change_timer_function_assignment
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_func;
typedef TIMER_FUNC_TYPE;
@@
(
_E->_timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-&_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
)
// Sometimes timer functions are called directly. Replace matched args.
@change_timer_function_calls
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression _E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_data;
@@
_callback(
(
-(_cast_data)_E
+&_E->_timer
|
-(_cast_data)&_E
+&_E._timer
|
-_E
+&_E->_timer
)
)
// If a timer has been configured without a data argument, it can be
// converted without regard to the callback argument, since it is unused.
@match_timer_function_unused_data@
expression _E;
identifier _timer;
identifier _callback;
@@
(
-setup_timer(&_E->_timer, _callback, 0);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0L);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0UL);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0L);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0UL);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0L);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0UL);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0L);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0UL);
+timer_setup(_timer, _callback, 0);
)
@change_callback_unused_data
depends on match_timer_function_unused_data@
identifier match_timer_function_unused_data._callback;
type _origtype;
identifier _origarg;
@@
void _callback(
-_origtype _origarg
+struct timer_list *unused
)
{
... when != _origarg
}
Signed-off-by: Kees Cook <keescook@chromium.org>
2017-10-16 21:43:17 +00:00
|
|
|
static void smi_timeout(struct timer_list *t)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
treewide: setup_timer() -> timer_setup()
This converts all remaining cases of the old setup_timer() API into using
timer_setup(), where the callback argument is the structure already
holding the struct timer_list. These should have no behavioral changes,
since they just change which pointer is passed into the callback with
the same available pointers after conversion. It handles the following
examples, in addition to some other variations.
Casting from unsigned long:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
setup_timer(&ptr->my_timer, my_callback, ptr);
and forced object casts:
void my_callback(struct something *ptr)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);
become:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
Direct function assignments:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
ptr->my_timer.function = my_callback;
have a temporary cast added, along with converting the args:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;
And finally, callbacks without a data assignment:
void my_callback(unsigned long data)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, 0);
have their argument renamed to verify they're unused during conversion:
void my_callback(struct timer_list *unused)
{
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
The conversion is done with the following Coccinelle script:
spatch --very-quiet --all-includes --include-headers \
-I ./arch/x86/include -I ./arch/x86/include/generated \
-I ./include -I ./arch/x86/include/uapi \
-I ./arch/x86/include/generated/uapi -I ./include/uapi \
-I ./include/generated/uapi --include ./include/linux/kconfig.h \
--dir . \
--cocci-file ~/src/data/timer_setup.cocci
@fix_address_of@
expression e;
@@
setup_timer(
-&(e)
+&e
, ...)
// Update any raw setup_timer() usages that have a NULL callback, but
// would otherwise match change_timer_function_usage, since the latter
// will update all function assignments done in the face of a NULL
// function initialization in setup_timer().
@change_timer_function_usage_NULL@
expression _E;
identifier _timer;
type _cast_data;
@@
(
-setup_timer(&_E->_timer, NULL, _E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E->_timer, NULL, (_cast_data)_E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, &_E);
+timer_setup(&_E._timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, (_cast_data)&_E);
+timer_setup(&_E._timer, NULL, 0);
)
@change_timer_function_usage@
expression _E;
identifier _timer;
struct timer_list _stl;
identifier _callback;
type _cast_func, _cast_data;
@@
(
-setup_timer(&_E->_timer, _callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
_E->_timer@_stl.function = _callback;
|
_E->_timer@_stl.function = &_callback;
|
_E->_timer@_stl.function = (_cast_func)_callback;
|
_E->_timer@_stl.function = (_cast_func)&_callback;
|
_E._timer@_stl.function = _callback;
|
_E._timer@_stl.function = &_callback;
|
_E._timer@_stl.function = (_cast_func)_callback;
|
_E._timer@_stl.function = (_cast_func)&_callback;
)
// callback(unsigned long arg)
@change_callback_handle_cast
depends on change_timer_function_usage@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
identifier _handle;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
(
... when != _origarg
_handletype *_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
)
}
// callback(unsigned long arg) without existing variable
@change_callback_handle_cast_no_arg
depends on change_timer_function_usage &&
!change_callback_handle_cast@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
+ _handletype *_origarg = from_timer(_origarg, t, _timer);
+
... when != _origarg
- (_handletype *)_origarg
+ _origarg
... when != _origarg
}
// Avoid already converted callbacks.
@match_callback_converted
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier t;
@@
void _callback(struct timer_list *t)
{ ... }
// callback(struct something *handle)
@change_callback_handle_arg
depends on change_timer_function_usage &&
!match_callback_converted &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
@@
void _callback(
-_handletype *_handle
+struct timer_list *t
)
{
+ _handletype *_handle = from_timer(_handle, t, _timer);
...
}
// If change_callback_handle_arg ran on an empty function, remove
// the added handler.
@unchange_callback_handle_arg
depends on change_timer_function_usage &&
change_callback_handle_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
identifier t;
@@
void _callback(struct timer_list *t)
{
- _handletype *_handle = from_timer(_handle, t, _timer);
}
// We only want to refactor the setup_timer() data argument if we've found
// the matching callback. This undoes changes in change_timer_function_usage.
@unchange_timer_function_usage
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg &&
!change_callback_handle_arg@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type change_timer_function_usage._cast_data;
@@
(
-timer_setup(&_E->_timer, _callback, 0);
+setup_timer(&_E->_timer, _callback, (_cast_data)_E);
|
-timer_setup(&_E._timer, _callback, 0);
+setup_timer(&_E._timer, _callback, (_cast_data)&_E);
)
// If we fixed a callback from a .function assignment, fix the
// assignment cast now.
@change_timer_function_assignment
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_func;
typedef TIMER_FUNC_TYPE;
@@
(
_E->_timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-&_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
)
// Sometimes timer functions are called directly. Replace matched args.
@change_timer_function_calls
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression _E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_data;
@@
_callback(
(
-(_cast_data)_E
+&_E->_timer
|
-(_cast_data)&_E
+&_E._timer
|
-_E
+&_E->_timer
)
)
// If a timer has been configured without a data argument, it can be
// converted without regard to the callback argument, since it is unused.
@match_timer_function_unused_data@
expression _E;
identifier _timer;
identifier _callback;
@@
(
-setup_timer(&_E->_timer, _callback, 0);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0L);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0UL);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0L);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0UL);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0L);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0UL);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0L);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0UL);
+timer_setup(_timer, _callback, 0);
)
@change_callback_unused_data
depends on match_timer_function_unused_data@
identifier match_timer_function_unused_data._callback;
type _origtype;
identifier _origarg;
@@
void _callback(
-_origtype _origarg
+struct timer_list *unused
)
{
... when != _origarg
}
Signed-off-by: Kees Cook <keescook@chromium.org>
2017-10-16 21:43:17 +00:00
|
|
|
struct smi_info *smi_info = from_timer(smi_info, t, si_timer);
|
2005-04-16 22:20:36 +00:00
|
|
|
enum si_sm_result smi_result;
|
|
|
|
unsigned long flags;
|
|
|
|
unsigned long jiffies_now;
|
2005-11-07 08:59:56 +00:00
|
|
|
long time_diff;
|
2010-05-26 21:43:49 +00:00
|
|
|
long timeout;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
spin_lock_irqsave(&(smi_info->si_lock), flags);
|
2015-01-07 22:24:28 +00:00
|
|
|
debug_timestamp("Timer");
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
jiffies_now = jiffies;
|
2005-11-07 08:59:56 +00:00
|
|
|
time_diff = (((long)jiffies_now - (long)smi_info->last_timeout_jiffies)
|
2005-04-16 22:20:36 +00:00
|
|
|
* SI_USEC_PER_JIFFY);
|
|
|
|
smi_result = smi_event_handler(smi_info, time_diff);
|
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Running with interrupts, only do long timeouts. */
|
2010-05-26 21:43:49 +00:00
|
|
|
timeout = jiffies + SI_TIMEOUT_JIFFIES;
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, long_timeouts);
|
2010-05-26 21:43:49 +00:00
|
|
|
goto do_mod_timer;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* If the state machine asks for a short delay, then shorten
|
|
|
|
* the timer timeout.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
if (smi_result == SI_SM_CALL_WITH_DELAY) {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, short_timeouts);
|
2010-05-26 21:43:49 +00:00
|
|
|
timeout = jiffies + 1;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, long_timeouts);
|
2010-05-26 21:43:49 +00:00
|
|
|
timeout = jiffies + SI_TIMEOUT_JIFFIES;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-04-27 03:40:15 +00:00
|
|
|
do_mod_timer:
|
2010-05-26 21:43:49 +00:00
|
|
|
if (smi_result != SI_SM_IDLE)
|
2014-04-14 14:46:51 +00:00
|
|
|
smi_mod_timer(smi_info, timeout);
|
|
|
|
else
|
|
|
|
smi_info->timer_running = false;
|
|
|
|
spin_unlock_irqrestore(&(smi_info->si_lock), flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
irqreturn_t ipmi_si_irq_handler(int irq, void *data)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct smi_info *smi_info = data;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
if (smi_info->io.si_type == SI_BT)
|
|
|
|
/* We need to clear the IRQ flag for the BT interface. */
|
|
|
|
smi_info->io.outputb(&smi_info->io, IPMI_BT_INTMASK_REG,
|
|
|
|
IPMI_BT_INTMASK_CLEAR_IRQ_BIT
|
|
|
|
| IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_lock_irqsave(&(smi_info->si_lock), flags);
|
|
|
|
|
2008-04-29 08:01:07 +00:00
|
|
|
smi_inc_stat(smi_info, interrupts);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-01-07 22:24:28 +00:00
|
|
|
debug_timestamp("Interrupt");
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_event_handler(smi_info, 0);
|
|
|
|
spin_unlock_irqrestore(&(smi_info->si_lock), flags);
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
}
|
|
|
|
|
2018-04-06 01:54:04 +00:00
|
|
|
static int smi_start_processing(void *send_info,
|
|
|
|
struct ipmi_smi *intf)
|
2006-03-31 10:30:39 +00:00
|
|
|
{
|
|
|
|
struct smi_info *new_smi = send_info;
|
2006-10-03 08:13:59 +00:00
|
|
|
int enable = 0;
|
2006-03-31 10:30:39 +00:00
|
|
|
|
|
|
|
new_smi->intf = intf;
|
|
|
|
|
|
|
|
/* Set up the timer that drives the interface. */
|
treewide: setup_timer() -> timer_setup()
This converts all remaining cases of the old setup_timer() API into using
timer_setup(), where the callback argument is the structure already
holding the struct timer_list. These should have no behavioral changes,
since they just change which pointer is passed into the callback with
the same available pointers after conversion. It handles the following
examples, in addition to some other variations.
Casting from unsigned long:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
setup_timer(&ptr->my_timer, my_callback, ptr);
and forced object casts:
void my_callback(struct something *ptr)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, (unsigned long)ptr);
become:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
Direct function assignments:
void my_callback(unsigned long data)
{
struct something *ptr = (struct something *)data;
...
}
...
ptr->my_timer.function = my_callback;
have a temporary cast added, along with converting the args:
void my_callback(struct timer_list *t)
{
struct something *ptr = from_timer(ptr, t, my_timer);
...
}
...
ptr->my_timer.function = (TIMER_FUNC_TYPE)my_callback;
And finally, callbacks without a data assignment:
void my_callback(unsigned long data)
{
...
}
...
setup_timer(&ptr->my_timer, my_callback, 0);
have their argument renamed to verify they're unused during conversion:
void my_callback(struct timer_list *unused)
{
...
}
...
timer_setup(&ptr->my_timer, my_callback, 0);
The conversion is done with the following Coccinelle script:
spatch --very-quiet --all-includes --include-headers \
-I ./arch/x86/include -I ./arch/x86/include/generated \
-I ./include -I ./arch/x86/include/uapi \
-I ./arch/x86/include/generated/uapi -I ./include/uapi \
-I ./include/generated/uapi --include ./include/linux/kconfig.h \
--dir . \
--cocci-file ~/src/data/timer_setup.cocci
@fix_address_of@
expression e;
@@
setup_timer(
-&(e)
+&e
, ...)
// Update any raw setup_timer() usages that have a NULL callback, but
// would otherwise match change_timer_function_usage, since the latter
// will update all function assignments done in the face of a NULL
// function initialization in setup_timer().
@change_timer_function_usage_NULL@
expression _E;
identifier _timer;
type _cast_data;
@@
(
-setup_timer(&_E->_timer, NULL, _E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E->_timer, NULL, (_cast_data)_E);
+timer_setup(&_E->_timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, &_E);
+timer_setup(&_E._timer, NULL, 0);
|
-setup_timer(&_E._timer, NULL, (_cast_data)&_E);
+timer_setup(&_E._timer, NULL, 0);
)
@change_timer_function_usage@
expression _E;
identifier _timer;
struct timer_list _stl;
identifier _callback;
type _cast_func, _cast_data;
@@
(
-setup_timer(&_E->_timer, _callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, &_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, _E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, &_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)_E);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, (_cast_func)&_callback, (_cast_data)&_E);
+timer_setup(&_E._timer, _callback, 0);
|
_E->_timer@_stl.function = _callback;
|
_E->_timer@_stl.function = &_callback;
|
_E->_timer@_stl.function = (_cast_func)_callback;
|
_E->_timer@_stl.function = (_cast_func)&_callback;
|
_E._timer@_stl.function = _callback;
|
_E._timer@_stl.function = &_callback;
|
_E._timer@_stl.function = (_cast_func)_callback;
|
_E._timer@_stl.function = (_cast_func)&_callback;
)
// callback(unsigned long arg)
@change_callback_handle_cast
depends on change_timer_function_usage@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
identifier _handle;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
(
... when != _origarg
_handletype *_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(_handletype *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
|
... when != _origarg
_handletype *_handle;
... when != _handle
_handle =
-(void *)_origarg;
+from_timer(_handle, t, _timer);
... when != _origarg
)
}
// callback(unsigned long arg) without existing variable
@change_callback_handle_cast_no_arg
depends on change_timer_function_usage &&
!change_callback_handle_cast@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _origtype;
identifier _origarg;
type _handletype;
@@
void _callback(
-_origtype _origarg
+struct timer_list *t
)
{
+ _handletype *_origarg = from_timer(_origarg, t, _timer);
+
... when != _origarg
- (_handletype *)_origarg
+ _origarg
... when != _origarg
}
// Avoid already converted callbacks.
@match_callback_converted
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier t;
@@
void _callback(struct timer_list *t)
{ ... }
// callback(struct something *handle)
@change_callback_handle_arg
depends on change_timer_function_usage &&
!match_callback_converted &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
@@
void _callback(
-_handletype *_handle
+struct timer_list *t
)
{
+ _handletype *_handle = from_timer(_handle, t, _timer);
...
}
// If change_callback_handle_arg ran on an empty function, remove
// the added handler.
@unchange_callback_handle_arg
depends on change_timer_function_usage &&
change_callback_handle_arg@
identifier change_timer_function_usage._callback;
identifier change_timer_function_usage._timer;
type _handletype;
identifier _handle;
identifier t;
@@
void _callback(struct timer_list *t)
{
- _handletype *_handle = from_timer(_handle, t, _timer);
}
// We only want to refactor the setup_timer() data argument if we've found
// the matching callback. This undoes changes in change_timer_function_usage.
@unchange_timer_function_usage
depends on change_timer_function_usage &&
!change_callback_handle_cast &&
!change_callback_handle_cast_no_arg &&
!change_callback_handle_arg@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type change_timer_function_usage._cast_data;
@@
(
-timer_setup(&_E->_timer, _callback, 0);
+setup_timer(&_E->_timer, _callback, (_cast_data)_E);
|
-timer_setup(&_E._timer, _callback, 0);
+setup_timer(&_E._timer, _callback, (_cast_data)&_E);
)
// If we fixed a callback from a .function assignment, fix the
// assignment cast now.
@change_timer_function_assignment
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression change_timer_function_usage._E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_func;
typedef TIMER_FUNC_TYPE;
@@
(
_E->_timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E->_timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-&_callback;
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)_callback
+(TIMER_FUNC_TYPE)_callback
;
|
_E._timer.function =
-(_cast_func)&_callback
+(TIMER_FUNC_TYPE)_callback
;
)
// Sometimes timer functions are called directly. Replace matched args.
@change_timer_function_calls
depends on change_timer_function_usage &&
(change_callback_handle_cast ||
change_callback_handle_cast_no_arg ||
change_callback_handle_arg)@
expression _E;
identifier change_timer_function_usage._timer;
identifier change_timer_function_usage._callback;
type _cast_data;
@@
_callback(
(
-(_cast_data)_E
+&_E->_timer
|
-(_cast_data)&_E
+&_E._timer
|
-_E
+&_E->_timer
)
)
// If a timer has been configured without a data argument, it can be
// converted without regard to the callback argument, since it is unused.
@match_timer_function_unused_data@
expression _E;
identifier _timer;
identifier _callback;
@@
(
-setup_timer(&_E->_timer, _callback, 0);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0L);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E->_timer, _callback, 0UL);
+timer_setup(&_E->_timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0L);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_E._timer, _callback, 0UL);
+timer_setup(&_E._timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0L);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(&_timer, _callback, 0UL);
+timer_setup(&_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0L);
+timer_setup(_timer, _callback, 0);
|
-setup_timer(_timer, _callback, 0UL);
+timer_setup(_timer, _callback, 0);
)
@change_callback_unused_data
depends on match_timer_function_unused_data@
identifier match_timer_function_unused_data._callback;
type _origtype;
identifier _origarg;
@@
void _callback(
-_origtype _origarg
+struct timer_list *unused
)
{
... when != _origarg
}
Signed-off-by: Kees Cook <keescook@chromium.org>
2017-10-16 21:43:17 +00:00
|
|
|
timer_setup(&new_smi->si_timer, smi_timeout, 0);
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
new_smi->timer_can_start = true;
|
2014-04-14 14:46:51 +00:00
|
|
|
smi_mod_timer(new_smi, jiffies + SI_TIMEOUT_JIFFIES);
|
2006-03-31 10:30:39 +00:00
|
|
|
|
2015-12-08 18:57:51 +00:00
|
|
|
/* Try to claim any interrupts. */
|
2017-09-12 20:10:22 +00:00
|
|
|
if (new_smi->io.irq_setup) {
|
|
|
|
new_smi->io.irq_handler_data = new_smi;
|
|
|
|
new_smi->io.irq_setup(&new_smi->io);
|
|
|
|
}
|
2015-12-08 18:57:51 +00:00
|
|
|
|
2006-10-03 08:13:59 +00:00
|
|
|
/*
|
|
|
|
* Check if the user forcefully enabled the daemon.
|
|
|
|
*/
|
2018-04-11 18:28:34 +00:00
|
|
|
if (new_smi->si_num < num_force_kipmid)
|
|
|
|
enable = force_kipmid[new_smi->si_num];
|
2006-10-01 06:28:20 +00:00
|
|
|
/*
|
|
|
|
* The BT interface is efficient enough to not need a thread,
|
|
|
|
* and there is no need for a thread if we have interrupts.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
else if ((new_smi->io.si_type != SI_BT) && (!new_smi->io.irq))
|
2006-10-03 08:13:59 +00:00
|
|
|
enable = 1;
|
|
|
|
|
|
|
|
if (enable) {
|
2006-03-31 10:30:39 +00:00
|
|
|
new_smi->thread = kthread_run(ipmi_thread, new_smi,
|
2018-04-11 18:28:34 +00:00
|
|
|
"kipmi%d", new_smi->si_num);
|
2006-03-31 10:30:39 +00:00
|
|
|
if (IS_ERR(new_smi->thread)) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_notice(new_smi->io.dev, "Could not start"
|
2010-05-26 21:43:52 +00:00
|
|
|
" kernel thread due to error %ld, only using"
|
|
|
|
" timers to drive the interface\n",
|
|
|
|
PTR_ERR(new_smi->thread));
|
2006-03-31 10:30:39 +00:00
|
|
|
new_smi->thread = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
2005-05-01 15:59:11 +00:00
|
|
|
|
2010-12-08 02:10:16 +00:00
|
|
|
static int get_smi_info(void *send_info, struct ipmi_smi_info *data)
|
|
|
|
{
|
|
|
|
struct smi_info *smi = send_info;
|
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
data->addr_src = smi->io.addr_source;
|
|
|
|
data->dev = smi->io.dev;
|
2017-09-13 02:37:02 +00:00
|
|
|
data->addr_info = smi->io.addr_info;
|
2017-09-12 19:41:56 +00:00
|
|
|
get_device(smi->io.dev);
|
2010-12-08 02:10:16 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-04-14 14:46:56 +00:00
|
|
|
static void set_maintenance_mode(void *send_info, bool enable)
|
2006-12-07 04:41:02 +00:00
|
|
|
{
|
|
|
|
struct smi_info *smi_info = send_info;
|
|
|
|
|
|
|
|
if (!enable)
|
|
|
|
atomic_set(&smi_info->req_events, 0);
|
|
|
|
}
|
|
|
|
|
2018-04-06 03:03:35 +00:00
|
|
|
static void shutdown_smi(void *send_info);
|
2015-06-13 15:34:25 +00:00
|
|
|
static const struct ipmi_smi_handlers handlers = {
|
2005-04-16 22:20:36 +00:00
|
|
|
.owner = THIS_MODULE,
|
2006-03-31 10:30:39 +00:00
|
|
|
.start_processing = smi_start_processing,
|
2018-04-06 03:03:35 +00:00
|
|
|
.shutdown = shutdown_smi,
|
2010-12-08 02:10:16 +00:00
|
|
|
.get_smi_info = get_smi_info,
|
2005-04-16 22:20:36 +00:00
|
|
|
.sender = sender,
|
|
|
|
.request_events = request_events,
|
2014-04-14 14:46:54 +00:00
|
|
|
.set_need_watch = set_need_watch,
|
2006-12-07 04:41:02 +00:00
|
|
|
.set_maintenance_mode = set_maintenance_mode,
|
2005-04-16 22:20:36 +00:00
|
|
|
.set_run_to_completion = set_run_to_completion,
|
2015-07-27 05:55:16 +00:00
|
|
|
.flush_messages = flush_messages,
|
2005-04-16 22:20:36 +00:00
|
|
|
.poll = poll,
|
|
|
|
};
|
|
|
|
|
2006-03-26 09:37:20 +00:00
|
|
|
static LIST_HEAD(smi_infos);
|
2006-03-31 10:30:41 +00:00
|
|
|
static DEFINE_MUTEX(smi_infos_lock);
|
2006-03-26 09:37:20 +00:00
|
|
|
static int smi_num; /* Used to sequence the SMIs */
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-11-13 12:31:51 +00:00
|
|
|
static const char * const addr_space_to_str[] = { "i/o", "mem" };
|
2006-12-07 04:41:07 +00:00
|
|
|
|
2006-10-03 08:13:59 +00:00
|
|
|
module_param_array(force_kipmid, int, &num_force_kipmid, 0);
|
|
|
|
MODULE_PARM_DESC(force_kipmid, "Force the kipmi daemon to be enabled (1) or"
|
|
|
|
" disabled(0). Normally the IPMI driver auto-detects"
|
|
|
|
" this, but the value may be overridden by this parm.");
|
2014-04-14 14:46:56 +00:00
|
|
|
module_param(unload_when_empty, bool, 0);
|
2006-12-07 04:41:07 +00:00
|
|
|
MODULE_PARM_DESC(unload_when_empty, "Unload the module if no interfaces are"
|
|
|
|
" specified or found, default is 1. Setting to 0"
|
|
|
|
" is useful for hot add of devices using hotmod.");
|
2010-03-10 23:23:06 +00:00
|
|
|
module_param_array(kipmid_max_busy_us, uint, &num_max_busy_us, 0644);
|
|
|
|
MODULE_PARM_DESC(kipmid_max_busy_us,
|
|
|
|
"Max time (in microseconds) to busy-wait for IPMI data before"
|
|
|
|
" sleeping. 0 (default) means to wait forever. Set to 100-500"
|
|
|
|
" if kipmid is using up a lot of CPU time.");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
void ipmi_irq_finish_setup(struct si_sm_io *io)
|
|
|
|
{
|
|
|
|
if (io->si_type == SI_BT)
|
|
|
|
/* Enable the interrupt in the BT interface. */
|
|
|
|
io->outputb(io, IPMI_BT_INTMASK_REG,
|
|
|
|
IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
void ipmi_irq_start_cleanup(struct si_sm_io *io)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2017-09-12 20:10:22 +00:00
|
|
|
if (io->si_type == SI_BT)
|
2006-03-26 09:37:20 +00:00
|
|
|
/* Disable the interrupt in the BT interface. */
|
2017-09-12 20:10:22 +00:00
|
|
|
io->outputb(io, IPMI_BT_INTMASK_REG, 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void std_irq_cleanup(struct si_sm_io *io)
|
|
|
|
{
|
|
|
|
ipmi_irq_start_cleanup(io);
|
|
|
|
free_irq(io->irq, io->irq_handler_data);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
int ipmi_std_irq_setup(struct si_sm_io *io)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int rv;
|
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
if (!io->irq)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
|
2017-09-12 20:10:22 +00:00
|
|
|
rv = request_irq(io->irq,
|
|
|
|
ipmi_si_irq_handler,
|
|
|
|
IRQF_SHARED,
|
|
|
|
DEVICE_NAME,
|
|
|
|
io->irq_handler_data);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (rv) {
|
2017-09-12 20:10:22 +00:00
|
|
|
dev_warn(io->dev, "%s unable to claim interrupt %d,"
|
2010-05-26 21:43:52 +00:00
|
|
|
" running polled\n",
|
2017-09-12 20:10:22 +00:00
|
|
|
DEVICE_NAME, io->irq);
|
|
|
|
io->irq = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
2017-09-12 20:10:22 +00:00
|
|
|
io->irq_cleanup = std_irq_cleanup;
|
|
|
|
ipmi_irq_finish_setup(io);
|
|
|
|
dev_info(io->dev, "Using irq %d\n", io->irq);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2009-04-21 19:24:03 +00:00
|
|
|
static int wait_for_msg_done(struct smi_info *smi_info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-03-26 09:37:21 +00:00
|
|
|
enum si_sm_result smi_result;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
smi_result = smi_info->handlers->event(smi_info->si_sm, 0);
|
2008-04-29 08:01:10 +00:00
|
|
|
for (;;) {
|
2005-11-07 09:00:02 +00:00
|
|
|
if (smi_result == SI_SM_CALL_WITH_DELAY ||
|
|
|
|
smi_result == SI_SM_CALL_WITH_TICK_DELAY) {
|
2005-09-10 07:27:30 +00:00
|
|
|
schedule_timeout_uninterruptible(1);
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_result = smi_info->handlers->event(
|
2014-01-24 20:00:52 +00:00
|
|
|
smi_info->si_sm, jiffies_to_usecs(1));
|
2008-04-29 08:01:10 +00:00
|
|
|
} else if (smi_result == SI_SM_CALL_WITHOUT_DELAY) {
|
2005-04-16 22:20:36 +00:00
|
|
|
smi_result = smi_info->handlers->event(
|
|
|
|
smi_info->si_sm, 0);
|
2008-04-29 08:01:10 +00:00
|
|
|
} else
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
2009-04-21 19:24:03 +00:00
|
|
|
if (smi_result == SI_SM_HOSED)
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* We couldn't get the state machine to run, so whatever's at
|
|
|
|
* the port is probably not an IPMI SMI interface.
|
|
|
|
*/
|
2009-04-21 19:24:03 +00:00
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int try_get_dev_id(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
unsigned char msg[2];
|
|
|
|
unsigned char *resp;
|
|
|
|
unsigned long resp_len;
|
|
|
|
int rv = 0;
|
|
|
|
|
|
|
|
resp = kmalloc(IPMI_MAX_MSG_LENGTH, GFP_KERNEL);
|
|
|
|
if (!resp)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Do a Get Device ID command, since it comes back with some
|
|
|
|
* useful info.
|
|
|
|
*/
|
|
|
|
msg[0] = IPMI_NETFN_APP_REQUEST << 2;
|
|
|
|
msg[1] = IPMI_GET_DEVICE_ID_CMD;
|
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, 2);
|
|
|
|
|
|
|
|
rv = wait_for_msg_done(smi_info);
|
|
|
|
if (rv)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
resp_len = smi_info->handlers->get_result(smi_info->si_sm,
|
|
|
|
resp, IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
2007-10-18 10:07:11 +00:00
|
|
|
/* Check and record info from the get device id, in case we need it. */
|
2017-08-25 07:47:23 +00:00
|
|
|
rv = ipmi_demangle_device_id(resp[0] >> 2, resp[1],
|
|
|
|
resp + 2, resp_len - 2, &smi_info->device_id);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-04-27 03:40:15 +00:00
|
|
|
out:
|
2005-04-16 22:20:36 +00:00
|
|
|
kfree(resp);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2015-08-18 19:29:10 +00:00
|
|
|
static int get_global_enables(struct smi_info *smi_info, u8 *enables)
|
2015-04-03 17:13:48 +00:00
|
|
|
{
|
|
|
|
unsigned char msg[3];
|
|
|
|
unsigned char *resp;
|
|
|
|
unsigned long resp_len;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
resp = kmalloc(IPMI_MAX_MSG_LENGTH, GFP_KERNEL);
|
2015-08-18 19:29:10 +00:00
|
|
|
if (!resp)
|
|
|
|
return -ENOMEM;
|
2015-04-03 17:13:48 +00:00
|
|
|
|
|
|
|
msg[0] = IPMI_NETFN_APP_REQUEST << 2;
|
|
|
|
msg[1] = IPMI_GET_BMC_GLOBAL_ENABLES_CMD;
|
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, 2);
|
|
|
|
|
|
|
|
rv = wait_for_msg_done(smi_info);
|
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Error getting response from get global enables command: %d\n",
|
|
|
|
rv);
|
2015-04-03 17:13:48 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
resp_len = smi_info->handlers->get_result(smi_info->si_sm,
|
|
|
|
resp, IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
|
|
|
if (resp_len < 4 ||
|
|
|
|
resp[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2 ||
|
|
|
|
resp[1] != IPMI_GET_BMC_GLOBAL_ENABLES_CMD ||
|
|
|
|
resp[2] != 0) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Invalid return from get global enables command: %ld %x %x %x\n",
|
|
|
|
resp_len, resp[0], resp[1], resp[2]);
|
2015-04-03 17:13:48 +00:00
|
|
|
rv = -EINVAL;
|
|
|
|
goto out;
|
2015-08-18 19:29:10 +00:00
|
|
|
} else {
|
|
|
|
*enables = resp[3];
|
2015-04-03 17:13:48 +00:00
|
|
|
}
|
|
|
|
|
2015-08-18 19:29:10 +00:00
|
|
|
out:
|
|
|
|
kfree(resp);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Returns 1 if it gets an error from the command.
|
|
|
|
*/
|
|
|
|
static int set_global_enables(struct smi_info *smi_info, u8 enables)
|
|
|
|
{
|
|
|
|
unsigned char msg[3];
|
|
|
|
unsigned char *resp;
|
|
|
|
unsigned long resp_len;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
resp = kmalloc(IPMI_MAX_MSG_LENGTH, GFP_KERNEL);
|
|
|
|
if (!resp)
|
|
|
|
return -ENOMEM;
|
2015-04-03 17:13:48 +00:00
|
|
|
|
|
|
|
msg[0] = IPMI_NETFN_APP_REQUEST << 2;
|
|
|
|
msg[1] = IPMI_SET_BMC_GLOBAL_ENABLES_CMD;
|
2015-08-18 19:29:10 +00:00
|
|
|
msg[2] = enables;
|
2015-04-03 17:13:48 +00:00
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, 3);
|
|
|
|
|
|
|
|
rv = wait_for_msg_done(smi_info);
|
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Error getting response from set global enables command: %d\n",
|
|
|
|
rv);
|
2015-04-03 17:13:48 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
resp_len = smi_info->handlers->get_result(smi_info->si_sm,
|
|
|
|
resp, IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
|
|
|
if (resp_len < 3 ||
|
|
|
|
resp[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2 ||
|
|
|
|
resp[1] != IPMI_SET_BMC_GLOBAL_ENABLES_CMD) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Invalid return from set global enables command: %ld %x %x\n",
|
|
|
|
resp_len, resp[0], resp[1]);
|
2015-04-03 17:13:48 +00:00
|
|
|
rv = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2015-08-18 19:29:10 +00:00
|
|
|
if (resp[2] != 0)
|
|
|
|
rv = 1;
|
|
|
|
|
|
|
|
out:
|
|
|
|
kfree(resp);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Some BMCs do not support clearing the receive irq bit in the global
|
|
|
|
* enables (even if they don't support interrupts on the BMC). Check
|
|
|
|
* for this and handle it properly.
|
|
|
|
*/
|
|
|
|
static void check_clr_rcv_irq(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
u8 enables = 0;
|
|
|
|
int rv;
|
|
|
|
|
|
|
|
rv = get_global_enables(smi_info, &enables);
|
|
|
|
if (!rv) {
|
|
|
|
if ((enables & IPMI_BMC_RCV_MSG_INTR) == 0)
|
|
|
|
/* Already clear, should work ok. */
|
|
|
|
return;
|
|
|
|
|
|
|
|
enables &= ~IPMI_BMC_RCV_MSG_INTR;
|
|
|
|
rv = set_global_enables(smi_info, enables);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rv < 0) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_err(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Cannot check clearing the rcv irq: %d\n", rv);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rv) {
|
2015-04-03 17:13:48 +00:00
|
|
|
/*
|
|
|
|
* An error when setting the event buffer bit means
|
|
|
|
* clearing the bit is not supported.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"The BMC does not support clearing the recv irq bit, compensating, but the BMC needs to be fixed.\n");
|
|
|
|
smi_info->cannot_disable_irq = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Some BMCs do not support setting the interrupt bits in the global
|
|
|
|
* enables even if they support interrupts. Clearly bad, but we can
|
|
|
|
* compensate.
|
|
|
|
*/
|
|
|
|
static void check_set_rcv_irq(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
u8 enables = 0;
|
|
|
|
int rv;
|
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
if (!smi_info->io.irq)
|
2015-08-18 19:29:10 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
rv = get_global_enables(smi_info, &enables);
|
|
|
|
if (!rv) {
|
|
|
|
enables |= IPMI_BMC_RCV_MSG_INTR;
|
|
|
|
rv = set_global_enables(smi_info, enables);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rv < 0) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_err(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"Cannot check setting the rcv irq: %d\n", rv);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rv) {
|
|
|
|
/*
|
|
|
|
* An error when setting the event buffer bit means
|
|
|
|
* setting the bit is not supported.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_warn(smi_info->io.dev,
|
2015-08-18 19:29:10 +00:00
|
|
|
"The BMC does not support setting the recv irq bit, compensating, but the BMC needs to be fixed.\n");
|
|
|
|
smi_info->cannot_disable_irq = true;
|
|
|
|
smi_info->irq_enable_broken = true;
|
2015-04-03 17:13:48 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-04-21 19:24:03 +00:00
|
|
|
static int try_enable_event_buffer(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
unsigned char msg[3];
|
|
|
|
unsigned char *resp;
|
|
|
|
unsigned long resp_len;
|
|
|
|
int rv = 0;
|
|
|
|
|
|
|
|
resp = kmalloc(IPMI_MAX_MSG_LENGTH, GFP_KERNEL);
|
|
|
|
if (!resp)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
msg[0] = IPMI_NETFN_APP_REQUEST << 2;
|
|
|
|
msg[1] = IPMI_GET_BMC_GLOBAL_ENABLES_CMD;
|
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, 2);
|
|
|
|
|
|
|
|
rv = wait_for_msg_done(smi_info);
|
|
|
|
if (rv) {
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_warn("Error getting response from get global enables command, the event buffer is not enabled\n");
|
2009-04-21 19:24:03 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
resp_len = smi_info->handlers->get_result(smi_info->si_sm,
|
|
|
|
resp, IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
|
|
|
if (resp_len < 4 ||
|
|
|
|
resp[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2 ||
|
|
|
|
resp[1] != IPMI_GET_BMC_GLOBAL_ENABLES_CMD ||
|
|
|
|
resp[2] != 0) {
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_warn("Invalid return from get global enables command, cannot enable the event buffer\n");
|
2009-04-21 19:24:03 +00:00
|
|
|
rv = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-11-19 10:03:26 +00:00
|
|
|
if (resp[3] & IPMI_BMC_EVT_MSG_BUFF) {
|
2009-04-21 19:24:03 +00:00
|
|
|
/* buffer is already enabled, nothing to do. */
|
2014-11-19 10:03:26 +00:00
|
|
|
smi_info->supports_event_msg_buff = true;
|
2009-04-21 19:24:03 +00:00
|
|
|
goto out;
|
2014-11-19 10:03:26 +00:00
|
|
|
}
|
2009-04-21 19:24:03 +00:00
|
|
|
|
|
|
|
msg[0] = IPMI_NETFN_APP_REQUEST << 2;
|
|
|
|
msg[1] = IPMI_SET_BMC_GLOBAL_ENABLES_CMD;
|
|
|
|
msg[2] = resp[3] | IPMI_BMC_EVT_MSG_BUFF;
|
|
|
|
smi_info->handlers->start_transaction(smi_info->si_sm, msg, 3);
|
|
|
|
|
|
|
|
rv = wait_for_msg_done(smi_info);
|
|
|
|
if (rv) {
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_warn("Error getting response from set global, enables command, the event buffer is not enabled\n");
|
2009-04-21 19:24:03 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
resp_len = smi_info->handlers->get_result(smi_info->si_sm,
|
|
|
|
resp, IPMI_MAX_MSG_LENGTH);
|
|
|
|
|
|
|
|
if (resp_len < 3 ||
|
|
|
|
resp[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2 ||
|
|
|
|
resp[1] != IPMI_SET_BMC_GLOBAL_ENABLES_CMD) {
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_warn("Invalid return from get global, enables command, not enable the event buffer\n");
|
2009-04-21 19:24:03 +00:00
|
|
|
rv = -EINVAL;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (resp[2] != 0)
|
|
|
|
/*
|
|
|
|
* An error when setting the event buffer bit means
|
|
|
|
* that the event buffer is not supported.
|
|
|
|
*/
|
|
|
|
rv = -ENOENT;
|
2014-11-19 10:03:26 +00:00
|
|
|
else
|
|
|
|
smi_info->supports_event_msg_buff = true;
|
|
|
|
|
2016-04-27 03:40:15 +00:00
|
|
|
out:
|
2009-04-21 19:24:03 +00:00
|
|
|
kfree(resp);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2017-09-16 19:53:12 +00:00
|
|
|
#define IPMI_SI_ATTR(name) \
|
|
|
|
static ssize_t ipmi_##name##_show(struct device *dev, \
|
|
|
|
struct device_attribute *attr, \
|
|
|
|
char *buf) \
|
|
|
|
{ \
|
|
|
|
struct smi_info *smi_info = dev_get_drvdata(dev); \
|
|
|
|
\
|
|
|
|
return snprintf(buf, 10, "%u\n", smi_get_stat(smi_info, name)); \
|
|
|
|
} \
|
|
|
|
static DEVICE_ATTR(name, S_IRUGO, ipmi_##name##_show, NULL)
|
|
|
|
|
|
|
|
static ssize_t ipmi_type_show(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
return snprintf(buf, 10, "%s\n", si_to_str[smi_info->io.si_type]);
|
|
|
|
}
|
|
|
|
static DEVICE_ATTR(type, S_IRUGO, ipmi_type_show, NULL);
|
|
|
|
|
|
|
|
static ssize_t ipmi_interrupts_enabled_show(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = dev_get_drvdata(dev);
|
|
|
|
int enabled = smi_info->io.irq && !smi_info->interrupt_disabled;
|
|
|
|
|
|
|
|
return snprintf(buf, 10, "%d\n", enabled);
|
|
|
|
}
|
|
|
|
static DEVICE_ATTR(interrupts_enabled, S_IRUGO,
|
|
|
|
ipmi_interrupts_enabled_show, NULL);
|
|
|
|
|
|
|
|
IPMI_SI_ATTR(short_timeouts);
|
|
|
|
IPMI_SI_ATTR(long_timeouts);
|
|
|
|
IPMI_SI_ATTR(idles);
|
|
|
|
IPMI_SI_ATTR(interrupts);
|
|
|
|
IPMI_SI_ATTR(attentions);
|
|
|
|
IPMI_SI_ATTR(flag_fetches);
|
|
|
|
IPMI_SI_ATTR(hosed_count);
|
|
|
|
IPMI_SI_ATTR(complete_transactions);
|
|
|
|
IPMI_SI_ATTR(events);
|
|
|
|
IPMI_SI_ATTR(watchdog_pretimeouts);
|
|
|
|
IPMI_SI_ATTR(incoming_messages);
|
|
|
|
|
|
|
|
static ssize_t ipmi_params_show(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = dev_get_drvdata(dev);
|
|
|
|
|
|
|
|
return snprintf(buf, 200,
|
|
|
|
"%s,%s,0x%lx,rsp=%d,rsi=%d,rsh=%d,irq=%d,ipmb=%d\n",
|
|
|
|
si_to_str[smi_info->io.si_type],
|
|
|
|
addr_space_to_str[smi_info->io.addr_type],
|
|
|
|
smi_info->io.addr_data,
|
|
|
|
smi_info->io.regspacing,
|
|
|
|
smi_info->io.regsize,
|
|
|
|
smi_info->io.regshift,
|
|
|
|
smi_info->io.irq,
|
|
|
|
smi_info->io.slave_addr);
|
|
|
|
}
|
|
|
|
static DEVICE_ATTR(params, S_IRUGO, ipmi_params_show, NULL);
|
|
|
|
|
|
|
|
static struct attribute *ipmi_si_dev_attrs[] = {
|
|
|
|
&dev_attr_type.attr,
|
|
|
|
&dev_attr_interrupts_enabled.attr,
|
|
|
|
&dev_attr_short_timeouts.attr,
|
|
|
|
&dev_attr_long_timeouts.attr,
|
|
|
|
&dev_attr_idles.attr,
|
|
|
|
&dev_attr_interrupts.attr,
|
|
|
|
&dev_attr_attentions.attr,
|
|
|
|
&dev_attr_flag_fetches.attr,
|
|
|
|
&dev_attr_hosed_count.attr,
|
|
|
|
&dev_attr_complete_transactions.attr,
|
|
|
|
&dev_attr_events.attr,
|
|
|
|
&dev_attr_watchdog_pretimeouts.attr,
|
|
|
|
&dev_attr_incoming_messages.attr,
|
|
|
|
&dev_attr_params.attr,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group ipmi_si_dev_attr_group = {
|
|
|
|
.attrs = ipmi_si_dev_attrs,
|
|
|
|
};
|
|
|
|
|
2005-09-06 22:18:41 +00:00
|
|
|
/*
|
|
|
|
* oem_data_avail_to_receive_msg_avail
|
|
|
|
* @info - smi_info structure with msg_flags set
|
|
|
|
*
|
|
|
|
* Converts flags from OEM_DATA_AVAIL to RECEIVE_MSG_AVAIL
|
|
|
|
* Returns 1 indicating need to re-run handle_flags().
|
|
|
|
*/
|
|
|
|
static int oem_data_avail_to_receive_msg_avail(struct smi_info *smi_info)
|
|
|
|
{
|
2005-09-06 22:18:45 +00:00
|
|
|
smi_info->msg_flags = ((smi_info->msg_flags & ~OEM_DATA_AVAIL) |
|
2008-04-29 08:01:10 +00:00
|
|
|
RECEIVE_MSG_AVAIL);
|
2005-09-06 22:18:41 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* setup_dell_poweredge_oem_data_handler
|
|
|
|
* @info - smi_info.device_id must be populated
|
|
|
|
*
|
|
|
|
* Systems that match, but have firmware version < 1.40 may assert
|
|
|
|
* OEM0_DATA_AVAIL on their own, without being told via Set Flags that
|
|
|
|
* it's safe to do so. Such systems will de-assert OEM1_DATA_AVAIL
|
|
|
|
* upon receipt of IPMI_GET_MSG_CMD, so we should treat these flags
|
|
|
|
* as RECEIVE_MSG_AVAIL instead.
|
|
|
|
*
|
|
|
|
* As Dell has no plans to release IPMI 1.5 firmware that *ever*
|
|
|
|
* assert the OEM[012] bits, and if it did, the driver would have to
|
|
|
|
* change to handle that properly, we don't actually check for the
|
|
|
|
* firmware version.
|
|
|
|
* Device ID = 0x20 BMC on PowerEdge 8G servers
|
|
|
|
* Device Revision = 0x80
|
|
|
|
* Firmware Revision1 = 0x01 BMC version 1.40
|
|
|
|
* Firmware Revision2 = 0x40 BCD encoded
|
|
|
|
* IPMI Version = 0x51 IPMI 1.5
|
|
|
|
* Manufacturer ID = A2 02 00 Dell IANA
|
|
|
|
*
|
2005-11-07 08:59:58 +00:00
|
|
|
* Additionally, PowerEdge systems with IPMI < 1.5 may also assert
|
|
|
|
* OEM0_DATA_AVAIL and needs to be treated as RECEIVE_MSG_AVAIL.
|
|
|
|
*
|
2005-09-06 22:18:41 +00:00
|
|
|
*/
|
|
|
|
#define DELL_POWEREDGE_8G_BMC_DEVICE_ID 0x20
|
|
|
|
#define DELL_POWEREDGE_8G_BMC_DEVICE_REV 0x80
|
|
|
|
#define DELL_POWEREDGE_8G_BMC_IPMI_VERSION 0x51
|
2006-03-26 09:37:21 +00:00
|
|
|
#define DELL_IANA_MFR_ID 0x0002a2
|
2005-09-06 22:18:41 +00:00
|
|
|
static void setup_dell_poweredge_oem_data_handler(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
struct ipmi_device_id *id = &smi_info->device_id;
|
2006-03-26 09:37:21 +00:00
|
|
|
if (id->manufacturer_id == DELL_IANA_MFR_ID) {
|
2005-11-07 08:59:58 +00:00
|
|
|
if (id->device_id == DELL_POWEREDGE_8G_BMC_DEVICE_ID &&
|
|
|
|
id->device_revision == DELL_POWEREDGE_8G_BMC_DEVICE_REV &&
|
2006-03-26 09:37:21 +00:00
|
|
|
id->ipmi_version == DELL_POWEREDGE_8G_BMC_IPMI_VERSION) {
|
2005-11-07 08:59:58 +00:00
|
|
|
smi_info->oem_data_avail_handler =
|
|
|
|
oem_data_avail_to_receive_msg_avail;
|
2008-04-29 08:01:10 +00:00
|
|
|
} else if (ipmi_version_major(id) < 1 ||
|
|
|
|
(ipmi_version_major(id) == 1 &&
|
|
|
|
ipmi_version_minor(id) < 5)) {
|
2005-11-07 08:59:58 +00:00
|
|
|
smi_info->oem_data_avail_handler =
|
|
|
|
oem_data_avail_to_receive_msg_avail;
|
|
|
|
}
|
2005-09-06 22:18:41 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-11-07 08:59:59 +00:00
|
|
|
#define CANNOT_RETURN_REQUESTED_LENGTH 0xCA
|
|
|
|
static void return_hosed_msg_badsize(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
struct ipmi_smi_msg *msg = smi_info->curr_msg;
|
|
|
|
|
2011-03-31 01:57:33 +00:00
|
|
|
/* Make it a response */
|
2005-11-07 08:59:59 +00:00
|
|
|
msg->rsp[0] = msg->data[0] | 4;
|
|
|
|
msg->rsp[1] = msg->data[1];
|
|
|
|
msg->rsp[2] = CANNOT_RETURN_REQUESTED_LENGTH;
|
|
|
|
msg->rsp_size = 3;
|
|
|
|
smi_info->curr_msg = NULL;
|
|
|
|
deliver_recv_msg(smi_info, msg);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* dell_poweredge_bt_xaction_handler
|
|
|
|
* @info - smi_info.device_id must be populated
|
|
|
|
*
|
|
|
|
* Dell PowerEdge servers with the BT interface (x6xx and 1750) will
|
|
|
|
* not respond to a Get SDR command if the length of the data
|
|
|
|
* requested is exactly 0x3A, which leads to command timeouts and no
|
|
|
|
* data returned. This intercepts such commands, and causes userspace
|
|
|
|
* callers to try again with a different-sized buffer, which succeeds.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define STORAGE_NETFN 0x0A
|
|
|
|
#define STORAGE_CMD_GET_SDR 0x23
|
|
|
|
static int dell_poweredge_bt_xaction_handler(struct notifier_block *self,
|
|
|
|
unsigned long unused,
|
|
|
|
void *in)
|
|
|
|
{
|
|
|
|
struct smi_info *smi_info = in;
|
|
|
|
unsigned char *data = smi_info->curr_msg->data;
|
|
|
|
unsigned int size = smi_info->curr_msg->data_size;
|
|
|
|
if (size >= 8 &&
|
|
|
|
(data[0]>>2) == STORAGE_NETFN &&
|
|
|
|
data[1] == STORAGE_CMD_GET_SDR &&
|
|
|
|
data[7] == 0x3A) {
|
|
|
|
return_hosed_msg_badsize(smi_info);
|
|
|
|
return NOTIFY_STOP;
|
|
|
|
}
|
|
|
|
return NOTIFY_DONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct notifier_block dell_poweredge_bt_xaction_notifier = {
|
|
|
|
.notifier_call = dell_poweredge_bt_xaction_handler,
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* setup_dell_poweredge_bt_xaction_handler
|
|
|
|
* @info - smi_info.device_id must be filled in already
|
|
|
|
*
|
|
|
|
* Fills in smi_info.device_id.start_transaction_pre_hook
|
|
|
|
* when we know what function to use there.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
setup_dell_poweredge_bt_xaction_handler(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
struct ipmi_device_id *id = &smi_info->device_id;
|
2006-03-26 09:37:21 +00:00
|
|
|
if (id->manufacturer_id == DELL_IANA_MFR_ID &&
|
2017-09-12 19:41:56 +00:00
|
|
|
smi_info->io.si_type == SI_BT)
|
2005-11-07 08:59:59 +00:00
|
|
|
register_xaction_notifier(&dell_poweredge_bt_xaction_notifier);
|
|
|
|
}
|
|
|
|
|
2005-09-06 22:18:41 +00:00
|
|
|
/*
|
|
|
|
* setup_oem_data_handler
|
|
|
|
* @info - smi_info.device_id must be filled in already
|
|
|
|
*
|
|
|
|
* Fills in smi_info.device_id.oem_data_available_handler
|
|
|
|
* when we know what function to use there.
|
|
|
|
*/
|
|
|
|
|
|
|
|
static void setup_oem_data_handler(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
setup_dell_poweredge_oem_data_handler(smi_info);
|
|
|
|
}
|
|
|
|
|
2005-11-07 08:59:59 +00:00
|
|
|
static void setup_xaction_handlers(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
setup_dell_poweredge_bt_xaction_handler(smi_info);
|
|
|
|
}
|
|
|
|
|
2015-08-18 19:29:10 +00:00
|
|
|
static void check_for_broken_irqs(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
check_clr_rcv_irq(smi_info);
|
|
|
|
check_set_rcv_irq(smi_info);
|
|
|
|
}
|
|
|
|
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
static inline void stop_timer_and_thread(struct smi_info *smi_info)
|
2005-11-07 09:00:03 +00:00
|
|
|
{
|
2018-01-15 07:58:12 +00:00
|
|
|
if (smi_info->thread != NULL) {
|
2014-11-06 23:01:59 +00:00
|
|
|
kthread_stop(smi_info->thread);
|
2018-01-15 07:58:12 +00:00
|
|
|
smi_info->thread = NULL;
|
|
|
|
}
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
|
|
|
|
smi_info->timer_can_start = false;
|
2014-11-06 23:01:59 +00:00
|
|
|
if (smi_info->timer_running)
|
2006-03-31 10:30:39 +00:00
|
|
|
del_timer_sync(&smi_info->si_timer);
|
2005-11-07 09:00:03 +00:00
|
|
|
}
|
|
|
|
|
2017-09-08 19:05:58 +00:00
|
|
|
static struct smi_info *find_dup_si(struct smi_info *info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-03-26 09:37:20 +00:00
|
|
|
struct smi_info *e;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-03-26 09:37:20 +00:00
|
|
|
list_for_each_entry(e, &smi_infos, link) {
|
|
|
|
if (e->io.addr_type != info->io.addr_type)
|
|
|
|
continue;
|
2016-11-07 18:07:09 +00:00
|
|
|
if (e->io.addr_data == info->io.addr_data) {
|
|
|
|
/*
|
|
|
|
* This is a cheap hack, ACPI doesn't have a defined
|
|
|
|
* slave address but SMBIOS does. Pick it up from
|
|
|
|
* any source that has it available.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
if (info->io.slave_addr && !e->io.slave_addr)
|
|
|
|
e->io.slave_addr = info->io.slave_addr;
|
2017-09-08 19:05:58 +00:00
|
|
|
return e;
|
2016-11-07 18:07:09 +00:00
|
|
|
}
|
2006-03-26 09:37:20 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-08 19:05:58 +00:00
|
|
|
return NULL;
|
2006-03-26 09:37:20 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-13 02:37:02 +00:00
|
|
|
int ipmi_si_add_smi(struct si_sm_io *io)
|
2006-03-26 09:37:20 +00:00
|
|
|
{
|
2010-05-26 21:43:46 +00:00
|
|
|
int rv = 0;
|
2017-09-13 02:37:02 +00:00
|
|
|
struct smi_info *new_smi, *dup;
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2017-09-13 02:37:02 +00:00
|
|
|
if (!io->io_setup) {
|
|
|
|
if (io->addr_type == IPMI_IO_ADDR_SPACE) {
|
2017-09-13 04:24:30 +00:00
|
|
|
io->io_setup = ipmi_si_port_setup;
|
2017-09-13 02:37:02 +00:00
|
|
|
} else if (io->addr_type == IPMI_MEM_ADDR_SPACE) {
|
2017-09-13 04:24:30 +00:00
|
|
|
io->io_setup = ipmi_si_mem_setup;
|
2017-09-12 20:40:53 +00:00
|
|
|
} else {
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-13 04:35:39 +00:00
|
|
|
new_smi = kzalloc(sizeof(*new_smi), GFP_KERNEL);
|
2017-09-13 02:37:02 +00:00
|
|
|
if (!new_smi)
|
|
|
|
return -ENOMEM;
|
2017-09-13 04:35:39 +00:00
|
|
|
spin_lock_init(&new_smi->si_lock);
|
2017-09-13 02:37:02 +00:00
|
|
|
|
|
|
|
new_smi->io = *io;
|
|
|
|
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_lock(&smi_infos_lock);
|
2017-09-08 19:05:58 +00:00
|
|
|
dup = find_dup_si(new_smi);
|
|
|
|
if (dup) {
|
2017-09-12 19:41:56 +00:00
|
|
|
if (new_smi->io.addr_source == SI_ACPI &&
|
|
|
|
dup->io.addr_source == SI_SMBIOS) {
|
2017-09-08 19:05:58 +00:00
|
|
|
/* We prefer ACPI over SMBIOS. */
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_info(dup->io.dev,
|
2017-09-08 19:05:58 +00:00
|
|
|
"Removing SMBIOS-specified %s state machine in favor of ACPI\n",
|
2017-09-12 19:41:56 +00:00
|
|
|
si_to_str[new_smi->io.si_type]);
|
2017-09-08 19:05:58 +00:00
|
|
|
cleanup_one_si(dup);
|
|
|
|
} else {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_info(new_smi->io.dev,
|
2017-09-08 19:05:58 +00:00
|
|
|
"%s-specified %s state machine: duplicate\n",
|
2017-09-12 19:41:56 +00:00
|
|
|
ipmi_addr_src_to_str(new_smi->io.addr_source),
|
|
|
|
si_to_str[new_smi->io.si_type]);
|
2017-09-08 19:05:58 +00:00
|
|
|
rv = -EBUSY;
|
2017-10-17 15:54:52 +00:00
|
|
|
kfree(new_smi);
|
2017-09-08 19:05:58 +00:00
|
|
|
goto out_err;
|
|
|
|
}
|
2006-03-26 09:37:20 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_info("Adding %s-specified %s state machine\n",
|
2017-09-12 19:41:56 +00:00
|
|
|
ipmi_addr_src_to_str(new_smi->io.addr_source),
|
|
|
|
si_to_str[new_smi->io.si_type]);
|
2010-05-26 21:43:46 +00:00
|
|
|
|
|
|
|
list_add_tail(&new_smi->link, &smi_infos);
|
|
|
|
|
2018-04-11 18:53:52 +00:00
|
|
|
if (initialized)
|
2017-09-13 02:37:02 +00:00
|
|
|
rv = try_smi_init(new_smi);
|
2010-05-26 21:43:46 +00:00
|
|
|
out_err:
|
|
|
|
mutex_unlock(&smi_infos_lock);
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2017-04-10 16:22:13 +00:00
|
|
|
/*
|
|
|
|
* Try to start up an interface. Must be called with smi_infos_lock
|
|
|
|
* held, primarily to keep smi_num consistent, we only one to do these
|
|
|
|
* one at a time.
|
|
|
|
*/
|
2010-05-26 21:43:46 +00:00
|
|
|
static int try_smi_init(struct smi_info *new_smi)
|
|
|
|
{
|
|
|
|
int rv = 0;
|
|
|
|
int i;
|
2016-11-07 14:37:06 +00:00
|
|
|
char *init_name = NULL;
|
2010-05-26 21:43:46 +00:00
|
|
|
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_info("Trying %s-specified %s state machine at %s address 0x%lx, slave address 0x%x, irq %d\n",
|
2017-09-12 19:41:56 +00:00
|
|
|
ipmi_addr_src_to_str(new_smi->io.addr_source),
|
|
|
|
si_to_str[new_smi->io.si_type],
|
2016-11-07 17:27:18 +00:00
|
|
|
addr_space_to_str[new_smi->io.addr_type],
|
|
|
|
new_smi->io.addr_data,
|
2017-09-12 19:41:56 +00:00
|
|
|
new_smi->io.slave_addr, new_smi->io.irq);
|
2010-05-26 21:43:46 +00:00
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
switch (new_smi->io.si_type) {
|
2006-03-26 09:37:20 +00:00
|
|
|
case SI_KCS:
|
2005-04-16 22:20:36 +00:00
|
|
|
new_smi->handlers = &kcs_smi_handlers;
|
2006-03-26 09:37:20 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case SI_SMIC:
|
2005-04-16 22:20:36 +00:00
|
|
|
new_smi->handlers = &smic_smi_handlers;
|
2006-03-26 09:37:20 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
case SI_BT:
|
2005-04-16 22:20:36 +00:00
|
|
|
new_smi->handlers = &bt_smi_handlers;
|
2006-03-26 09:37:20 +00:00
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
2005-04-16 22:20:36 +00:00
|
|
|
/* No support for anything else yet. */
|
|
|
|
rv = -EIO;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
|
2018-04-11 18:28:34 +00:00
|
|
|
new_smi->si_num = smi_num;
|
2017-04-10 16:22:13 +00:00
|
|
|
|
2016-11-07 14:37:06 +00:00
|
|
|
/* Do this early so it's available for logs. */
|
2017-09-12 19:41:56 +00:00
|
|
|
if (!new_smi->io.dev) {
|
2017-04-10 16:22:13 +00:00
|
|
|
init_name = kasprintf(GFP_KERNEL, "ipmi_si.%d",
|
2018-04-11 18:28:34 +00:00
|
|
|
new_smi->si_num);
|
2016-11-07 14:37:06 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we don't already have a device from something
|
|
|
|
* else (like PCI), then register a new one.
|
|
|
|
*/
|
|
|
|
new_smi->pdev = platform_device_alloc("ipmi_si",
|
2018-04-11 18:28:34 +00:00
|
|
|
new_smi->si_num);
|
2016-11-07 14:37:06 +00:00
|
|
|
if (!new_smi->pdev) {
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_err("Unable to allocate platform device\n");
|
2018-03-06 09:58:03 +00:00
|
|
|
rv = -ENOMEM;
|
2016-11-07 14:37:06 +00:00
|
|
|
goto out_err;
|
|
|
|
}
|
2017-09-12 19:41:56 +00:00
|
|
|
new_smi->io.dev = &new_smi->pdev->dev;
|
2017-09-13 03:55:57 +00:00
|
|
|
new_smi->io.dev->driver = &ipmi_platform_driver.driver;
|
2016-11-07 14:37:06 +00:00
|
|
|
/* Nulled by device_add() */
|
2017-09-12 19:41:56 +00:00
|
|
|
new_smi->io.dev->init_name = init_name;
|
2016-11-07 14:37:06 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Allocate the state machine's data and initialize it. */
|
|
|
|
new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL);
|
2006-03-26 09:37:20 +00:00
|
|
|
if (!new_smi->si_sm) {
|
2005-04-16 22:20:36 +00:00
|
|
|
rv = -ENOMEM;
|
|
|
|
goto out_err;
|
|
|
|
}
|
2017-09-12 20:40:53 +00:00
|
|
|
new_smi->io.io_size = new_smi->handlers->init_data(new_smi->si_sm,
|
|
|
|
&new_smi->io);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* Now that we know the I/O size, we can set up the I/O. */
|
2017-09-12 20:40:53 +00:00
|
|
|
rv = new_smi->io.io_setup(&new_smi->io);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_err(new_smi->io.dev, "Could not set up I/O space\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Do low-level detection first. */
|
|
|
|
if (new_smi->handlers->detect(new_smi->si_sm)) {
|
2017-09-12 19:41:56 +00:00
|
|
|
if (new_smi->io.addr_source)
|
|
|
|
dev_err(new_smi->io.dev,
|
|
|
|
"Interface detection failed\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
rv = -ENODEV;
|
|
|
|
goto out_err;
|
|
|
|
}
|
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Attempt a get device id command. If it fails, we probably
|
|
|
|
* don't have a BMC here.
|
|
|
|
*/
|
2005-04-16 22:20:36 +00:00
|
|
|
rv = try_get_dev_id(new_smi);
|
2006-03-26 09:37:20 +00:00
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
if (new_smi->io.addr_source)
|
|
|
|
dev_err(new_smi->io.dev,
|
|
|
|
"There appears to be no BMC at this location\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out_err;
|
2006-03-26 09:37:20 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2005-09-06 22:18:41 +00:00
|
|
|
setup_oem_data_handler(new_smi);
|
2005-11-07 08:59:59 +00:00
|
|
|
setup_xaction_handlers(new_smi);
|
2015-08-18 19:29:10 +00:00
|
|
|
check_for_broken_irqs(new_smi);
|
2005-09-06 22:18:41 +00:00
|
|
|
|
2014-11-06 23:01:59 +00:00
|
|
|
new_smi->waiting_msg = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
new_smi->curr_msg = NULL;
|
|
|
|
atomic_set(&new_smi->req_events, 0);
|
2014-04-14 14:46:56 +00:00
|
|
|
new_smi->run_to_completion = false;
|
2008-04-29 08:01:07 +00:00
|
|
|
for (i = 0; i < SI_NUM_STATS; i++)
|
|
|
|
atomic_set(&new_smi->stats[i], 0);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2014-04-14 14:46:56 +00:00
|
|
|
new_smi->interrupt_disabled = true;
|
2014-04-14 14:46:54 +00:00
|
|
|
atomic_set(&new_smi->need_watch, 0);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-04-21 19:24:03 +00:00
|
|
|
rv = try_enable_event_buffer(new_smi);
|
|
|
|
if (rv == 0)
|
2014-04-14 14:46:56 +00:00
|
|
|
new_smi->has_event_buffer = true;
|
2009-04-21 19:24:03 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Start clearing the flags before we enable interrupts or the
|
|
|
|
* timer to avoid racing with the timer.
|
|
|
|
*/
|
ipmi: Stop timers before cleaning up the module
System may crash after unloading ipmi_si.ko module
because a timer may remain and fire after the module cleaned up resources.
cleanup_one_si() contains the following processing.
/*
* Make sure that interrupts, the timer and the thread are
* stopped and will not run again.
*/
if (to_clean->irq_cleanup)
to_clean->irq_cleanup(to_clean);
wait_for_timer_and_thread(to_clean);
/*
* Timeouts are stopped, now make sure the interrupts are off
* in the BMC. Note that timers and CPU interrupts are off,
* so no need for locks.
*/
while (to_clean->curr_msg || (to_clean->si_state != SI_NORMAL)) {
poll(to_clean);
schedule_timeout_uninterruptible(1);
}
si_state changes as following in the while loop calling poll(to_clean).
SI_GETTING_MESSAGES
=> SI_CHECKING_ENABLES
=> SI_SETTING_ENABLES
=> SI_GETTING_EVENTS
=> SI_NORMAL
As written in the code comments above,
timers are expected to stop before the polling loop and not to run again.
But the timer is set again in the following process
when si_state becomes SI_SETTING_ENABLES.
=> poll
=> smi_event_handler
=> handle_transaction_done
// smi_info->si_state == SI_SETTING_ENABLES
=> start_getting_events
=> start_new_msg
=> smi_mod_timer
=> mod_timer
As a result, before the timer set in start_new_msg() expires,
the polling loop may see si_state becoming SI_NORMAL
and the module clean-up finishes.
For example, hard LOCKUP and panic occurred as following.
smi_timeout was called after smi_event_handler,
kcs_event and hangs at port_inb()
trying to access I/O port after release.
[exception RIP: port_inb+19]
RIP: ffffffffc0473053 RSP: ffff88069fdc3d80 RFLAGS: 00000006
RAX: ffff8806800f8e00 RBX: ffff880682bd9400 RCX: 0000000000000000
RDX: 0000000000000ca3 RSI: 0000000000000ca3 RDI: ffff8806800f8e40
RBP: ffff88069fdc3d80 R8: ffffffff81d86dfc R9: ffffffff81e36426
R10: 00000000000509f0 R11: 0000000000100000 R12: 0000000000]:000000
R13: 0000000000000000 R14: 0000000000000246 R15: ffff8806800f8e00
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0000
--- <NMI exception stack> ---
To fix the problem I defined a flag, timer_can_start,
as member of struct smi_info.
The flag is enabled immediately after initializing the timer
and disabled immediately before waiting for timer deletion.
Fixes: 0cfec916e86d ("ipmi: Start the timer and thread on internal msgs")
Signed-off-by: Yamazaki Masamitsu <m-yamazaki@ah.jp.nec.com>
[Adjusted for recent changes in the driver.]
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2017-11-15 07:33:14 +00:00
|
|
|
start_clear_flags(new_smi);
|
2014-11-19 10:03:26 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* IRQ is defined to be set when non-zero. req_events will
|
|
|
|
* cause a global flags check that will enable interrupts.
|
|
|
|
*/
|
2017-09-12 19:41:56 +00:00
|
|
|
if (new_smi->io.irq) {
|
2014-11-19 10:03:26 +00:00
|
|
|
new_smi->interrupt_disabled = false;
|
|
|
|
atomic_set(&new_smi->req_events, 1);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
if (new_smi->pdev && !new_smi->pdev_registered) {
|
2006-11-16 09:19:08 +00:00
|
|
|
rv = platform_device_add(new_smi->pdev);
|
2006-03-26 09:37:21 +00:00
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_err(new_smi->io.dev,
|
2016-11-07 17:27:18 +00:00
|
|
|
"Unable to register system interface device: %d\n",
|
|
|
|
rv);
|
2006-03-31 10:30:39 +00:00
|
|
|
goto out_err;
|
2006-03-26 09:37:21 +00:00
|
|
|
}
|
2018-02-28 17:40:16 +00:00
|
|
|
new_smi->pdev_registered = true;
|
2006-03-26 09:37:21 +00:00
|
|
|
}
|
|
|
|
|
2017-09-16 19:53:12 +00:00
|
|
|
dev_set_drvdata(new_smi->io.dev, new_smi);
|
|
|
|
rv = device_add_group(new_smi->io.dev, &ipmi_si_dev_attr_group);
|
|
|
|
if (rv) {
|
|
|
|
dev_err(new_smi->io.dev,
|
|
|
|
"Unable to add device attributes: error %d\n",
|
|
|
|
rv);
|
2018-02-28 17:40:16 +00:00
|
|
|
goto out_err;
|
2017-09-16 19:53:12 +00:00
|
|
|
}
|
2018-02-28 14:09:49 +00:00
|
|
|
new_smi->dev_group_added = true;
|
2017-09-16 19:53:12 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
rv = ipmi_register_smi(&handlers,
|
|
|
|
new_smi,
|
2017-09-12 19:41:56 +00:00
|
|
|
new_smi->io.dev,
|
|
|
|
new_smi->io.slave_addr);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (rv) {
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_err(new_smi->io.dev,
|
|
|
|
"Unable to register device: error %d\n",
|
2010-05-26 21:43:52 +00:00
|
|
|
rv);
|
2018-02-28 17:40:16 +00:00
|
|
|
goto out_err;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-04-10 16:22:13 +00:00
|
|
|
/* Don't increment till we know we have succeeded. */
|
|
|
|
smi_num++;
|
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
dev_info(new_smi->io.dev, "IPMI %s interface initialized\n",
|
|
|
|
si_to_str[new_smi->io.si_type]);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-09-12 19:41:56 +00:00
|
|
|
WARN_ON(new_smi->io.dev->init_name != NULL);
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2018-08-22 17:08:13 +00:00
|
|
|
out_err:
|
ipmi_si: fix use-after-free of resource->name
When we excute the following commands, we got oops
rmmod ipmi_si
cat /proc/ioports
[ 1623.482380] Unable to handle kernel paging request at virtual address ffff00000901d478
[ 1623.482382] Mem abort info:
[ 1623.482383] ESR = 0x96000007
[ 1623.482385] Exception class = DABT (current EL), IL = 32 bits
[ 1623.482386] SET = 0, FnV = 0
[ 1623.482387] EA = 0, S1PTW = 0
[ 1623.482388] Data abort info:
[ 1623.482389] ISV = 0, ISS = 0x00000007
[ 1623.482390] CM = 0, WnR = 0
[ 1623.482393] swapper pgtable: 4k pages, 48-bit VAs, pgdp = 00000000d7d94a66
[ 1623.482395] [ffff00000901d478] pgd=000000dffbfff003, pud=000000dffbffe003, pmd=0000003f5d06e003, pte=0000000000000000
[ 1623.482399] Internal error: Oops: 96000007 [#1] SMP
[ 1623.487407] Modules linked in: ipmi_si(E) nls_utf8 isofs rpcrdma ib_iser ib_srpt target_core_mod ib_srp scsi_transport_srp ib_ipoib rdma_ucm ib_umad rdma_cm ib_cm dm_mirror dm_region_hash dm_log iw_cm dm_mod aes_ce_blk crypto_simd cryptd aes_ce_cipher ses ghash_ce sha2_ce enclosure sha256_arm64 sg sha1_ce hisi_sas_v2_hw hibmc_drm sbsa_gwdt hisi_sas_main ip_tables mlx5_ib ib_uverbs marvell ib_core mlx5_core ixgbe mdio hns_dsaf ipmi_devintf hns_enet_drv ipmi_msghandler hns_mdio [last unloaded: ipmi_si]
[ 1623.532410] CPU: 30 PID: 11438 Comm: cat Kdump: loaded Tainted: G E 5.0.0-rc3+ #168
[ 1623.541498] Hardware name: Huawei TaiShan 2280 /BC11SPCD, BIOS 1.37 11/21/2017
[ 1623.548822] pstate: a0000005 (NzCv daif -PAN -UAO)
[ 1623.553684] pc : string+0x28/0x98
[ 1623.557040] lr : vsnprintf+0x368/0x5e8
[ 1623.560837] sp : ffff000013213a80
[ 1623.564191] x29: ffff000013213a80 x28: ffff00001138abb5
[ 1623.569577] x27: ffff000013213c18 x26: ffff805f67d06049
[ 1623.574963] x25: 0000000000000000 x24: ffff00001138abb5
[ 1623.580349] x23: 0000000000000fb7 x22: ffff0000117ed000
[ 1623.585734] x21: ffff000011188fd8 x20: ffff805f67d07000
[ 1623.591119] x19: ffff805f67d06061 x18: ffffffffffffffff
[ 1623.596505] x17: 0000000000000200 x16: 0000000000000000
[ 1623.601890] x15: ffff0000117ed748 x14: ffff805f67d07000
[ 1623.607276] x13: ffff805f67d0605e x12: 0000000000000000
[ 1623.612661] x11: 0000000000000000 x10: 0000000000000000
[ 1623.618046] x9 : 0000000000000000 x8 : 000000000000000f
[ 1623.623432] x7 : ffff805f67d06061 x6 : fffffffffffffffe
[ 1623.628817] x5 : 0000000000000012 x4 : ffff00000901d478
[ 1623.634203] x3 : ffff0a00ffffff04 x2 : ffff805f67d07000
[ 1623.639588] x1 : ffff805f67d07000 x0 : ffffffffffffffff
[ 1623.644974] Process cat (pid: 11438, stack limit = 0x000000008d4cbc10)
[ 1623.651592] Call trace:
[ 1623.654068] string+0x28/0x98
[ 1623.657071] vsnprintf+0x368/0x5e8
[ 1623.660517] seq_vprintf+0x70/0x98
[ 1623.668009] seq_printf+0x7c/0xa0
[ 1623.675530] r_show+0xc8/0xf8
[ 1623.682558] seq_read+0x330/0x440
[ 1623.689877] proc_reg_read+0x78/0xd0
[ 1623.697346] __vfs_read+0x60/0x1a0
[ 1623.704564] vfs_read+0x94/0x150
[ 1623.711339] ksys_read+0x6c/0xd8
[ 1623.717939] __arm64_sys_read+0x24/0x30
[ 1623.725077] el0_svc_common+0x120/0x148
[ 1623.732035] el0_svc_handler+0x30/0x40
[ 1623.738757] el0_svc+0x8/0xc
[ 1623.744520] Code: d1000406 aa0103e2 54000149 b4000080 (39400085)
[ 1623.753441] ---[ end trace f91b6a4937de9835 ]---
[ 1623.760871] Kernel panic - not syncing: Fatal exception
[ 1623.768935] SMP: stopping secondary CPUs
[ 1623.775718] Kernel Offset: disabled
[ 1623.781998] CPU features: 0x002,21006008
[ 1623.788777] Memory Limit: none
[ 1623.798329] Starting crashdump kernel...
[ 1623.805202] Bye!
If io_setup is called successful in try_smi_init() but try_smi_init()
goes out_err before calling ipmi_register_smi(), so ipmi_unregister_smi()
will not be called while removing module. It leads to the resource that
allocated in io_setup() can not be freed, but the name(DEVICE_NAME) of
resource is freed while removing the module. It causes use-after-free
when cat /proc/ioports.
Fix this by calling io_cleanup() while try_smi_init() goes to out_err.
and don't call io_cleanup() until io_setup() returns successful to avoid
warning prints.
Fixes: 93c303d2045b ("ipmi_si: Clean up shutdown a bit")
Cc: stable@vger.kernel.org
Reported-by: NuoHan Qiao <qiaonuohan@huawei.com>
Suggested-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
2019-01-28 03:08:54 +00:00
|
|
|
if (rv && new_smi->io.io_cleanup) {
|
|
|
|
new_smi->io.io_cleanup(&new_smi->io);
|
|
|
|
new_smi->io.io_cleanup = NULL;
|
|
|
|
}
|
|
|
|
|
2016-11-07 14:37:06 +00:00
|
|
|
kfree(init_name);
|
2005-04-16 22:20:36 +00:00
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2012-11-19 18:22:51 +00:00
|
|
|
static int init_ipmi_si(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-05-26 21:43:46 +00:00
|
|
|
struct smi_info *e;
|
2010-05-26 21:43:49 +00:00
|
|
|
enum ipmi_addr_src type = SI_INVALID;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (initialized)
|
|
|
|
return 0;
|
|
|
|
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_info("IPMI System Interface driver\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-05-26 21:43:46 +00:00
|
|
|
/* If the user gave us a device, they presumably want us to use it */
|
2017-09-13 03:46:29 +00:00
|
|
|
if (!ipmi_si_hardcode_find_bmc())
|
|
|
|
goto do_scan;
|
2010-05-26 21:43:46 +00:00
|
|
|
|
2017-09-13 03:55:57 +00:00
|
|
|
ipmi_si_platform_init();
|
|
|
|
|
2017-09-13 04:04:35 +00:00
|
|
|
ipmi_si_pci_init();
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2017-09-13 04:10:18 +00:00
|
|
|
ipmi_si_parisc_init();
|
2013-09-05 11:36:36 +00:00
|
|
|
|
2010-05-26 21:43:49 +00:00
|
|
|
/* We prefer devices with interrupts, but in the case of a machine
|
|
|
|
with multiple BMCs we assume that there will be several instances
|
|
|
|
of a given type so if we succeed in registering a type then also
|
|
|
|
try to register everything else of the same type */
|
2017-09-13 03:46:29 +00:00
|
|
|
do_scan:
|
2010-05-26 21:43:46 +00:00
|
|
|
mutex_lock(&smi_infos_lock);
|
|
|
|
list_for_each_entry(e, &smi_infos, link) {
|
2010-05-26 21:43:49 +00:00
|
|
|
/* Try to register a device if it has an IRQ and we either
|
|
|
|
haven't successfully registered a device yet or this
|
|
|
|
device has the same type as one we successfully registered */
|
2017-09-12 19:41:56 +00:00
|
|
|
if (e->io.irq && (!type || e->io.addr_source == type)) {
|
2010-05-26 21:43:46 +00:00
|
|
|
if (!try_smi_init(e)) {
|
2017-09-12 19:41:56 +00:00
|
|
|
type = e->io.addr_source;
|
2010-05-26 21:43:46 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-26 21:43:49 +00:00
|
|
|
/* type will only have been set if we successfully registered an si */
|
2017-09-13 02:37:02 +00:00
|
|
|
if (type)
|
|
|
|
goto skip_fallback_noirq;
|
2010-05-26 21:43:49 +00:00
|
|
|
|
2010-05-26 21:43:46 +00:00
|
|
|
/* Fall back to the preferred device */
|
|
|
|
|
|
|
|
list_for_each_entry(e, &smi_infos, link) {
|
2017-09-12 19:41:56 +00:00
|
|
|
if (!e->io.irq && (!type || e->io.addr_source == type)) {
|
2010-05-26 21:43:46 +00:00
|
|
|
if (!try_smi_init(e)) {
|
2017-09-12 19:41:56 +00:00
|
|
|
type = e->io.addr_source;
|
2010-05-26 21:43:46 +00:00
|
|
|
}
|
|
|
|
}
|
2010-05-26 21:43:46 +00:00
|
|
|
}
|
2017-09-13 02:37:02 +00:00
|
|
|
|
|
|
|
skip_fallback_noirq:
|
|
|
|
initialized = 1;
|
2010-05-26 21:43:46 +00:00
|
|
|
mutex_unlock(&smi_infos_lock);
|
|
|
|
|
2010-05-26 21:43:49 +00:00
|
|
|
if (type)
|
|
|
|
return 0;
|
|
|
|
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_lock(&smi_infos_lock);
|
2006-12-07 04:41:07 +00:00
|
|
|
if (unload_when_empty && list_empty(&smi_infos)) {
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_unlock(&smi_infos_lock);
|
2011-02-10 22:08:38 +00:00
|
|
|
cleanup_ipmi_si();
|
2018-05-09 15:15:48 +00:00
|
|
|
pr_warn("Unable to find any System Interface(s)\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
return -ENODEV;
|
2006-03-26 09:37:20 +00:00
|
|
|
} else {
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_unlock(&smi_infos_lock);
|
2006-03-26 09:37:20 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
module_init(init_ipmi_si);
|
|
|
|
|
2018-04-06 03:03:35 +00:00
|
|
|
static void shutdown_smi(void *send_info)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-04-06 03:03:35 +00:00
|
|
|
struct smi_info *smi_info = send_info;
|
2014-11-06 23:01:59 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
if (smi_info->dev_group_added) {
|
|
|
|
device_remove_group(smi_info->io.dev, &ipmi_si_dev_attr_group);
|
|
|
|
smi_info->dev_group_added = false;
|
|
|
|
}
|
|
|
|
if (smi_info->io.dev)
|
|
|
|
dev_set_drvdata(smi_info->io.dev, NULL);
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
2014-11-06 23:01:59 +00:00
|
|
|
* Make sure that interrupts, the timer and the thread are
|
|
|
|
* stopped and will not run again.
|
2008-04-29 08:01:10 +00:00
|
|
|
*/
|
2018-02-28 17:40:16 +00:00
|
|
|
smi_info->interrupt_disabled = true;
|
|
|
|
if (smi_info->io.irq_cleanup) {
|
|
|
|
smi_info->io.irq_cleanup(&smi_info->io);
|
|
|
|
smi_info->io.irq_cleanup = NULL;
|
|
|
|
}
|
|
|
|
stop_timer_and_thread(smi_info);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Wait until we know that we are out of any interrupt
|
|
|
|
* handlers might have been running before we freed the
|
|
|
|
* interrupt.
|
|
|
|
*/
|
2018-11-06 01:00:58 +00:00
|
|
|
synchronize_rcu();
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-04-29 08:01:10 +00:00
|
|
|
/*
|
|
|
|
* Timeouts are stopped, now make sure the interrupts are off
|
2014-11-06 23:01:59 +00:00
|
|
|
* in the BMC. Note that timers and CPU interrupts are off,
|
|
|
|
* so no need for locks.
|
2008-04-29 08:01:10 +00:00
|
|
|
*/
|
2018-02-28 17:40:16 +00:00
|
|
|
while (smi_info->curr_msg || (smi_info->si_state != SI_NORMAL)) {
|
|
|
|
poll(smi_info);
|
2007-05-08 07:23:54 +00:00
|
|
|
schedule_timeout_uninterruptible(1);
|
|
|
|
}
|
2018-02-28 17:40:16 +00:00
|
|
|
if (smi_info->handlers)
|
|
|
|
disable_si_irq(smi_info);
|
|
|
|
while (smi_info->curr_msg || (smi_info->si_state != SI_NORMAL)) {
|
|
|
|
poll(smi_info);
|
2005-09-10 07:27:30 +00:00
|
|
|
schedule_timeout_uninterruptible(1);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2018-02-28 17:40:16 +00:00
|
|
|
if (smi_info->handlers)
|
|
|
|
smi_info->handlers->cleanup(smi_info->si_sm);
|
|
|
|
|
|
|
|
if (smi_info->io.addr_source_cleanup) {
|
|
|
|
smi_info->io.addr_source_cleanup(&smi_info->io);
|
|
|
|
smi_info->io.addr_source_cleanup = NULL;
|
|
|
|
}
|
|
|
|
if (smi_info->io.io_cleanup) {
|
|
|
|
smi_info->io.io_cleanup(&smi_info->io);
|
|
|
|
smi_info->io.io_cleanup = NULL;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
kfree(smi_info->si_sm);
|
|
|
|
smi_info->si_sm = NULL;
|
2018-08-22 17:08:13 +00:00
|
|
|
|
|
|
|
smi_info->intf = NULL;
|
2018-02-28 17:40:16 +00:00
|
|
|
}
|
|
|
|
|
2018-04-11 18:53:52 +00:00
|
|
|
/*
|
|
|
|
* Must be called with smi_infos_lock held, to serialize the
|
|
|
|
* smi_info->intf check.
|
|
|
|
*/
|
2018-02-28 17:40:16 +00:00
|
|
|
static void cleanup_one_si(struct smi_info *smi_info)
|
|
|
|
{
|
|
|
|
if (!smi_info)
|
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
list_del(&smi_info->link);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-08-22 17:08:13 +00:00
|
|
|
if (smi_info->intf)
|
2018-04-11 18:53:52 +00:00
|
|
|
ipmi_unregister_smi(smi_info->intf);
|
2006-03-26 09:37:21 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
if (smi_info->pdev) {
|
|
|
|
if (smi_info->pdev_registered)
|
|
|
|
platform_device_unregister(smi_info->pdev);
|
|
|
|
else
|
|
|
|
platform_device_put(smi_info->pdev);
|
|
|
|
}
|
2006-03-26 09:37:21 +00:00
|
|
|
|
2018-02-28 17:40:16 +00:00
|
|
|
kfree(smi_info);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-09-13 02:37:02 +00:00
|
|
|
int ipmi_si_remove_by_dev(struct device *dev)
|
|
|
|
{
|
|
|
|
struct smi_info *e;
|
|
|
|
int rv = -ENOENT;
|
|
|
|
|
|
|
|
mutex_lock(&smi_infos_lock);
|
|
|
|
list_for_each_entry(e, &smi_infos, link) {
|
|
|
|
if (e->io.dev == dev) {
|
|
|
|
cleanup_one_si(e);
|
|
|
|
rv = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
mutex_unlock(&smi_infos_lock);
|
|
|
|
|
|
|
|
return rv;
|
|
|
|
}
|
|
|
|
|
2017-09-13 03:28:49 +00:00
|
|
|
void ipmi_si_remove_by_data(int addr_space, enum si_type si_type,
|
|
|
|
unsigned long addr)
|
|
|
|
{
|
|
|
|
/* remove */
|
|
|
|
struct smi_info *e, *tmp_e;
|
|
|
|
|
|
|
|
mutex_lock(&smi_infos_lock);
|
|
|
|
list_for_each_entry_safe(e, tmp_e, &smi_infos, link) {
|
|
|
|
if (e->io.addr_type != addr_space)
|
|
|
|
continue;
|
|
|
|
if (e->io.si_type != si_type)
|
|
|
|
continue;
|
|
|
|
if (e->io.addr_data == addr)
|
|
|
|
cleanup_one_si(e);
|
|
|
|
}
|
|
|
|
mutex_unlock(&smi_infos_lock);
|
|
|
|
}
|
|
|
|
|
2011-03-23 23:42:54 +00:00
|
|
|
static void cleanup_ipmi_si(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2006-03-26 09:37:20 +00:00
|
|
|
struct smi_info *e, *tmp_e;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-03-26 09:37:20 +00:00
|
|
|
if (!initialized)
|
2005-04-16 22:20:36 +00:00
|
|
|
return;
|
|
|
|
|
2017-09-13 04:04:35 +00:00
|
|
|
ipmi_si_pci_shutdown();
|
2017-09-13 04:10:18 +00:00
|
|
|
|
|
|
|
ipmi_si_parisc_shutdown();
|
2006-03-26 09:37:20 +00:00
|
|
|
|
2017-09-13 03:55:57 +00:00
|
|
|
ipmi_si_platform_shutdown();
|
2007-05-08 07:23:51 +00:00
|
|
|
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_lock(&smi_infos_lock);
|
2006-03-26 09:37:20 +00:00
|
|
|
list_for_each_entry_safe(e, tmp_e, &smi_infos, link)
|
|
|
|
cleanup_one_si(e);
|
2006-03-31 10:30:41 +00:00
|
|
|
mutex_unlock(&smi_infos_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
module_exit(cleanup_ipmi_si);
|
|
|
|
|
2016-02-03 16:45:28 +00:00
|
|
|
MODULE_ALIAS("platform:dmi-ipmi-si");
|
2005-04-16 22:20:36 +00:00
|
|
|
MODULE_LICENSE("GPL");
|
2005-09-06 22:18:42 +00:00
|
|
|
MODULE_AUTHOR("Corey Minyard <minyard@mvista.com>");
|
2008-04-29 08:01:10 +00:00
|
|
|
MODULE_DESCRIPTION("Interface to the IPMI driver for the KCS, SMIC, and BT"
|
|
|
|
" system interfaces.");
|