2008-07-28 16:44:22 +00:00
|
|
|
/*
|
|
|
|
* AMD CPU Microcode Update Driver for Linux
|
2011-12-02 17:09:23 +00:00
|
|
|
* Copyright (C) 2008-2011 Advanced Micro Devices Inc.
|
2008-07-28 16:44:22 +00:00
|
|
|
*
|
|
|
|
* Author: Peter Oruba <peter.oruba@amd.com>
|
|
|
|
*
|
|
|
|
* Based on work by:
|
|
|
|
* Tigran Aivazian <tigran@aivazian.fsnet.co.uk>
|
|
|
|
*
|
2011-12-02 17:09:23 +00:00
|
|
|
* Maintainers:
|
|
|
|
* Andreas Herrmann <andreas.herrmann3@amd.com>
|
|
|
|
* Borislav Petkov <borislav.petkov@amd.com>
|
|
|
|
*
|
|
|
|
* This driver allows to upgrade microcode on F10h AMD
|
|
|
|
* CPUs and later.
|
2008-07-28 16:44:22 +00:00
|
|
|
*
|
2008-12-16 18:08:53 +00:00
|
|
|
* Licensed under the terms of the GNU General Public
|
2008-07-28 16:44:22 +00:00
|
|
|
* License version 2. See file COPYING for details.
|
2009-03-11 10:19:46 +00:00
|
|
|
*/
|
2009-12-09 06:30:50 +00:00
|
|
|
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
2009-03-11 10:19:46 +00:00
|
|
|
#include <linux/firmware.h>
|
|
|
|
#include <linux/pci_ids.h>
|
|
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/vmalloc.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
2008-07-28 16:44:22 +00:00
|
|
|
#include <linux/pci.h>
|
|
|
|
|
|
|
|
#include <asm/microcode.h>
|
2009-03-11 10:19:46 +00:00
|
|
|
#include <asm/processor.h>
|
|
|
|
#include <asm/msr.h>
|
2008-07-28 16:44:22 +00:00
|
|
|
|
|
|
|
MODULE_DESCRIPTION("AMD Microcode Update Driver");
|
2008-10-17 13:30:38 +00:00
|
|
|
MODULE_AUTHOR("Peter Oruba");
|
2008-07-29 08:07:36 +00:00
|
|
|
MODULE_LICENSE("GPL v2");
|
2008-07-28 16:44:22 +00:00
|
|
|
|
|
|
|
#define UCODE_MAGIC 0x00414d44
|
|
|
|
#define UCODE_EQUIV_CPU_TABLE_TYPE 0x00000000
|
|
|
|
#define UCODE_UCODE_TYPE 0x00000001
|
|
|
|
|
2008-09-23 10:08:44 +00:00
|
|
|
struct equiv_cpu_entry {
|
2008-12-16 18:21:30 +00:00
|
|
|
u32 installed_cpu;
|
|
|
|
u32 fixed_errata_mask;
|
|
|
|
u32 fixed_errata_compare;
|
|
|
|
u16 equiv_cpu;
|
|
|
|
u16 res;
|
|
|
|
} __attribute__((packed));
|
2008-09-23 10:08:44 +00:00
|
|
|
|
|
|
|
struct microcode_header_amd {
|
2008-12-16 18:21:30 +00:00
|
|
|
u32 data_code;
|
|
|
|
u32 patch_id;
|
|
|
|
u16 mc_patch_data_id;
|
|
|
|
u8 mc_patch_data_len;
|
|
|
|
u8 init_flag;
|
|
|
|
u32 mc_patch_data_checksum;
|
|
|
|
u32 nb_dev_id;
|
|
|
|
u32 sb_dev_id;
|
|
|
|
u16 processor_rev_id;
|
|
|
|
u8 nb_rev_id;
|
|
|
|
u8 sb_rev_id;
|
|
|
|
u8 bios_api_rev;
|
|
|
|
u8 reserved1[3];
|
|
|
|
u32 match_reg[8];
|
|
|
|
} __attribute__((packed));
|
2008-09-23 10:08:44 +00:00
|
|
|
|
|
|
|
struct microcode_amd {
|
2009-03-11 10:19:46 +00:00
|
|
|
struct microcode_header_amd hdr;
|
|
|
|
unsigned int mpb[0];
|
2008-09-23 10:08:44 +00:00
|
|
|
};
|
|
|
|
|
2011-06-15 13:34:57 +00:00
|
|
|
#define SECTION_HDR_SIZE 8
|
|
|
|
#define CONTAINER_HDR_SZ 12
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2008-09-11 21:27:52 +00:00
|
|
|
static struct equiv_cpu_entry *equiv_cpu_table;
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 13:38:18 +00:00
|
|
|
struct ucode_patch {
|
|
|
|
struct list_head plist;
|
|
|
|
void *data;
|
|
|
|
u32 patch_id;
|
|
|
|
u16 equiv_cpu;
|
|
|
|
};
|
|
|
|
|
|
|
|
static LIST_HEAD(pcache);
|
|
|
|
|
2012-08-01 12:55:01 +00:00
|
|
|
static u16 find_equiv_id(unsigned int cpu)
|
|
|
|
{
|
|
|
|
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
|
|
|
|
int i = 0;
|
|
|
|
|
2012-08-01 13:38:18 +00:00
|
|
|
if (!equiv_cpu_table)
|
|
|
|
return 0;
|
2012-08-01 12:55:01 +00:00
|
|
|
|
|
|
|
while (equiv_cpu_table[i].installed_cpu != 0) {
|
|
|
|
if (uci->cpu_sig.sig == equiv_cpu_table[i].installed_cpu)
|
|
|
|
return equiv_cpu_table[i].equiv_cpu;
|
|
|
|
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static u32 find_cpu_family_by_equiv_cpu(u16 equiv_cpu)
|
|
|
|
{
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
BUG_ON(!equiv_cpu_table);
|
|
|
|
|
|
|
|
while (equiv_cpu_table[i].equiv_cpu != 0) {
|
|
|
|
if (equiv_cpu == equiv_cpu_table[i].equiv_cpu)
|
|
|
|
return equiv_cpu_table[i].installed_cpu;
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-08-01 13:38:18 +00:00
|
|
|
/*
|
|
|
|
* a small, trivial cache of per-family ucode patches
|
|
|
|
*/
|
|
|
|
static struct ucode_patch *cache_find_patch(u16 equiv_cpu)
|
|
|
|
{
|
|
|
|
struct ucode_patch *p;
|
|
|
|
|
|
|
|
list_for_each_entry(p, &pcache, plist)
|
|
|
|
if (p->equiv_cpu == equiv_cpu)
|
|
|
|
return p;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void update_cache(struct ucode_patch *new_patch)
|
|
|
|
{
|
|
|
|
struct ucode_patch *p;
|
|
|
|
|
|
|
|
list_for_each_entry(p, &pcache, plist) {
|
|
|
|
if (p->equiv_cpu == new_patch->equiv_cpu) {
|
|
|
|
if (p->patch_id >= new_patch->patch_id)
|
|
|
|
/* we already have the latest patch */
|
|
|
|
return;
|
|
|
|
|
|
|
|
list_replace(&p->plist, &new_patch->plist);
|
|
|
|
kfree(p->data);
|
|
|
|
kfree(p);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/* no patch found, add it */
|
|
|
|
list_add_tail(&new_patch->plist, &pcache);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void free_cache(void)
|
|
|
|
{
|
2012-09-05 12:30:42 +00:00
|
|
|
struct ucode_patch *p, *tmp;
|
2012-08-01 13:38:18 +00:00
|
|
|
|
2012-09-05 12:30:42 +00:00
|
|
|
list_for_each_entry_safe(p, tmp, &pcache, plist) {
|
2012-08-01 13:38:18 +00:00
|
|
|
__list_del(p->plist.prev, p->plist.next);
|
|
|
|
kfree(p->data);
|
|
|
|
kfree(p);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct ucode_patch *find_patch(unsigned int cpu)
|
|
|
|
{
|
|
|
|
u16 equiv_id;
|
|
|
|
|
|
|
|
equiv_id = find_equiv_id(cpu);
|
|
|
|
if (!equiv_id)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return cache_find_patch(equiv_id);
|
|
|
|
}
|
|
|
|
|
2008-08-19 22:22:26 +00:00
|
|
|
static int collect_cpu_info_amd(int cpu, struct cpu_signature *csig)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
2010-01-22 20:34:56 +00:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-07-25 18:06:54 +00:00
|
|
|
csig->sig = cpuid_eax(0x00000001);
|
2011-10-17 14:34:36 +00:00
|
|
|
csig->rev = c->microcode;
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_info("CPU%d: patch_level=0x%08x\n", cpu, csig->rev);
|
|
|
|
|
2008-08-19 22:22:26 +00:00
|
|
|
return 0;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
static unsigned int verify_patch_size(int cpu, u32 patch_size,
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 17:02:17 +00:00
|
|
|
unsigned int size)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 17:02:17 +00:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
|
|
|
u32 max_size;
|
|
|
|
|
|
|
|
#define F1XH_MPB_MAX_SIZE 2048
|
|
|
|
#define F14H_MPB_MAX_SIZE 1824
|
|
|
|
#define F15H_MPB_MAX_SIZE 4096
|
|
|
|
|
|
|
|
switch (c->x86) {
|
|
|
|
case 0x14:
|
|
|
|
max_size = F14H_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
case 0x15:
|
|
|
|
max_size = F15H_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
max_size = F1XH_MPB_MAX_SIZE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (patch_size > min_t(u32, size, max_size)) {
|
|
|
|
pr_err("patch size mismatch\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return patch_size;
|
|
|
|
}
|
|
|
|
|
2009-05-11 21:48:27 +00:00
|
|
|
static int apply_microcode_amd(int cpu)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
2011-10-17 14:34:36 +00:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
2012-08-01 14:16:13 +00:00
|
|
|
struct microcode_amd *mc_amd;
|
|
|
|
struct ucode_cpu_info *uci;
|
|
|
|
struct ucode_patch *p;
|
|
|
|
u32 rev, dummy;
|
|
|
|
|
|
|
|
BUG_ON(raw_smp_processor_id() != cpu);
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
uci = ucode_cpu_info + cpu;
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
p = find_patch(cpu);
|
|
|
|
if (!p)
|
2009-05-11 21:48:27 +00:00
|
|
|
return 0;
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
mc_amd = p->data;
|
|
|
|
uci->mc = p->data;
|
|
|
|
|
2008-12-16 18:16:34 +00:00
|
|
|
rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-06-20 14:17:51 +00:00
|
|
|
/* need to apply patch? */
|
|
|
|
if (rev >= mc_amd->hdr.patch_id) {
|
|
|
|
c->microcode = rev;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
wrmsrl(MSR_AMD64_PATCH_LOADER, (u64)(long)&mc_amd->hdr.data_code);
|
|
|
|
|
|
|
|
/* verify patch application was successful */
|
|
|
|
rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
|
2008-09-23 10:08:44 +00:00
|
|
|
if (rev != mc_amd->hdr.patch_id) {
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_err("CPU%d: update failed for patch_level=0x%08x\n",
|
2009-12-09 06:30:50 +00:00
|
|
|
cpu, mc_amd->hdr.patch_id);
|
2009-05-11 21:48:27 +00:00
|
|
|
return -1;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_info("CPU%d: new patch_level=0x%08x\n", cpu, rev);
|
2008-08-19 22:22:26 +00:00
|
|
|
uci->cpu_sig.rev = rev;
|
2011-10-17 14:34:36 +00:00
|
|
|
c->microcode = rev;
|
2009-05-11 21:48:27 +00:00
|
|
|
|
|
|
|
return 0;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2008-12-16 18:14:05 +00:00
|
|
|
static int install_equiv_cpu_table(const u8 *buf)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
2010-12-30 21:10:12 +00:00
|
|
|
unsigned int *ibuf = (unsigned int *)buf;
|
|
|
|
unsigned int type = ibuf[1];
|
|
|
|
unsigned int size = ibuf[2];
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2010-12-30 21:10:12 +00:00
|
|
|
if (type != UCODE_EQUIV_CPU_TABLE_TYPE || !size) {
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_err("empty section/"
|
|
|
|
"invalid type field in container file section header\n");
|
2010-12-30 21:10:12 +00:00
|
|
|
return -EINVAL;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2010-11-08 23:08:11 +00:00
|
|
|
equiv_cpu_table = vmalloc(size);
|
2008-07-28 16:44:22 +00:00
|
|
|
if (!equiv_cpu_table) {
|
2009-12-09 06:30:50 +00:00
|
|
|
pr_err("failed to allocate equivalent CPU table\n");
|
2010-12-30 21:10:12 +00:00
|
|
|
return -ENOMEM;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2012-07-20 12:12:21 +00:00
|
|
|
memcpy(equiv_cpu_table, buf + CONTAINER_HDR_SZ, size);
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2011-06-15 13:34:57 +00:00
|
|
|
/* add header length */
|
|
|
|
return size + CONTAINER_HDR_SZ;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
2008-09-11 21:27:52 +00:00
|
|
|
static void free_equiv_cpu_table(void)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
2009-06-07 14:30:36 +00:00
|
|
|
vfree(equiv_cpu_table);
|
|
|
|
equiv_cpu_table = NULL;
|
2008-09-11 21:27:52 +00:00
|
|
|
}
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
static void cleanup(void)
|
2008-09-11 21:27:52 +00:00
|
|
|
{
|
2012-08-01 14:16:13 +00:00
|
|
|
free_equiv_cpu_table();
|
|
|
|
free_cache();
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We return the current size even if some of the checks failed so that
|
|
|
|
* we can skip over the next patch. If we return a negative value, we
|
|
|
|
* signal a grave error like a memory allocation has failed and the
|
|
|
|
* driver cannot continue functioning normally. In such cases, we tear
|
|
|
|
* down everything we've used up so far and exit.
|
|
|
|
*/
|
|
|
|
static int verify_and_add_patch(unsigned int cpu, u8 *fw, unsigned int leftover)
|
|
|
|
{
|
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
|
|
|
struct microcode_header_amd *mc_hdr;
|
|
|
|
struct ucode_patch *patch;
|
|
|
|
unsigned int patch_size, crnt_size, ret;
|
|
|
|
u32 proc_fam;
|
|
|
|
u16 proc_id;
|
|
|
|
|
|
|
|
patch_size = *(u32 *)(fw + 4);
|
|
|
|
crnt_size = patch_size + SECTION_HDR_SIZE;
|
|
|
|
mc_hdr = (struct microcode_header_amd *)(fw + SECTION_HDR_SIZE);
|
|
|
|
proc_id = mc_hdr->processor_rev_id;
|
|
|
|
|
|
|
|
proc_fam = find_cpu_family_by_equiv_cpu(proc_id);
|
|
|
|
if (!proc_fam) {
|
|
|
|
pr_err("No patch family for equiv ID: 0x%04x\n", proc_id);
|
|
|
|
return crnt_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* check if patch is for the current family */
|
|
|
|
proc_fam = ((proc_fam >> 8) & 0xf) + ((proc_fam >> 20) & 0xff);
|
|
|
|
if (proc_fam != c->x86)
|
|
|
|
return crnt_size;
|
|
|
|
|
|
|
|
if (mc_hdr->nb_dev_id || mc_hdr->sb_dev_id) {
|
|
|
|
pr_err("Patch-ID 0x%08x: chipset-specific code unsupported.\n",
|
|
|
|
mc_hdr->patch_id);
|
|
|
|
return crnt_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = verify_patch_size(cpu, patch_size, leftover);
|
|
|
|
if (!ret) {
|
|
|
|
pr_err("Patch-ID 0x%08x: size mismatch.\n", mc_hdr->patch_id);
|
|
|
|
return crnt_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
patch = kzalloc(sizeof(*patch), GFP_KERNEL);
|
|
|
|
if (!patch) {
|
|
|
|
pr_err("Patch allocation failure.\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
patch->data = kzalloc(patch_size, GFP_KERNEL);
|
|
|
|
if (!patch->data) {
|
|
|
|
pr_err("Patch data allocation failure.\n");
|
|
|
|
kfree(patch);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* All looks ok, copy patch... */
|
|
|
|
memcpy(patch->data, fw + SECTION_HDR_SIZE, patch_size);
|
|
|
|
INIT_LIST_HEAD(&patch->plist);
|
|
|
|
patch->patch_id = mc_hdr->patch_id;
|
|
|
|
patch->equiv_cpu = proc_id;
|
|
|
|
|
|
|
|
/* ... and add to cache. */
|
|
|
|
update_cache(patch);
|
|
|
|
|
|
|
|
return crnt_size;
|
|
|
|
}
|
|
|
|
|
|
|
|
static enum ucode_state load_microcode_amd(int cpu, const u8 *data, size_t size)
|
|
|
|
{
|
|
|
|
enum ucode_state ret = UCODE_ERROR;
|
|
|
|
unsigned int leftover;
|
|
|
|
u8 *fw = (u8 *)data;
|
|
|
|
int crnt_size = 0;
|
2011-02-18 09:17:16 +00:00
|
|
|
int offset;
|
2008-07-28 16:44:22 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
offset = install_equiv_cpu_table(data);
|
2010-12-30 21:10:12 +00:00
|
|
|
if (offset < 0) {
|
2009-12-09 06:30:50 +00:00
|
|
|
pr_err("failed to create equivalent cpu table\n");
|
2012-08-01 14:16:13 +00:00
|
|
|
return ret;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
2012-08-01 14:16:13 +00:00
|
|
|
fw += offset;
|
2008-09-11 21:27:52 +00:00
|
|
|
leftover = size - offset;
|
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
if (*(u32 *)fw != UCODE_UCODE_TYPE) {
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 17:02:17 +00:00
|
|
|
pr_err("invalid type field in container file section header\n");
|
2012-08-01 14:16:13 +00:00
|
|
|
free_equiv_cpu_table();
|
|
|
|
return ret;
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 17:02:17 +00:00
|
|
|
}
|
2008-09-11 21:27:52 +00:00
|
|
|
|
x86, microcode, AMD: Simplify ucode verification
Basically, what we did until now is take out a chunk of the firmware
image, vmalloc space for it and inspect it before application. And
repeat.
This patch changes all that so that we look at each ucode patch from
the firmware image, check it for sanity and copy it to local buffer for
application only once and if it passes all checks. Thus, vmalloc-ing for
each piece is gone, we can do proper size checking only of the patch
which is destined for the CPU of the current machine instead of each
single patch, which is clearly wrong.
Oh yeah, simplify and cleanup the code while at it, along with adding
comments as to what actually happens.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
2011-12-02 17:02:17 +00:00
|
|
|
while (leftover) {
|
2012-08-01 14:16:13 +00:00
|
|
|
crnt_size = verify_and_add_patch(cpu, fw, leftover);
|
|
|
|
if (crnt_size < 0)
|
|
|
|
return ret;
|
2011-12-07 16:26:56 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
fw += crnt_size;
|
|
|
|
leftover -= crnt_size;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
2008-09-11 21:27:52 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
return UCODE_OK;
|
2008-09-11 21:27:52 +00:00
|
|
|
}
|
|
|
|
|
2012-01-20 16:44:12 +00:00
|
|
|
/*
|
|
|
|
* AMD microcode firmware naming convention, up to family 15h they are in
|
|
|
|
* the legacy file:
|
|
|
|
*
|
|
|
|
* amd-ucode/microcode_amd.bin
|
|
|
|
*
|
|
|
|
* This legacy file is always smaller than 2K in size.
|
|
|
|
*
|
2012-08-01 14:16:13 +00:00
|
|
|
* Beginning with family 15h, they are in family-specific firmware files:
|
2012-01-20 16:44:12 +00:00
|
|
|
*
|
|
|
|
* amd-ucode/microcode_amd_fam15h.bin
|
|
|
|
* amd-ucode/microcode_amd_fam16h.bin
|
|
|
|
* ...
|
|
|
|
*
|
|
|
|
* These might be larger than 2K.
|
|
|
|
*/
|
2012-07-26 13:51:00 +00:00
|
|
|
static enum ucode_state request_microcode_amd(int cpu, struct device *device,
|
|
|
|
bool refresh_fw)
|
2008-09-11 21:27:52 +00:00
|
|
|
{
|
2012-01-20 16:44:12 +00:00
|
|
|
char fw_name[36] = "amd-ucode/microcode_amd.bin";
|
|
|
|
struct cpuinfo_x86 *c = &cpu_data(cpu);
|
2012-08-01 14:16:13 +00:00
|
|
|
enum ucode_state ret = UCODE_NFOUND;
|
|
|
|
const struct firmware *fw;
|
|
|
|
|
|
|
|
/* reload ucode container only on the boot cpu */
|
|
|
|
if (!refresh_fw || c->cpu_index != boot_cpu_data.cpu_index)
|
|
|
|
return UCODE_OK;
|
2012-01-20 16:44:12 +00:00
|
|
|
|
|
|
|
if (c->x86 >= 0x15)
|
|
|
|
snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
|
2008-09-11 21:27:52 +00:00
|
|
|
|
2012-01-20 16:44:12 +00:00
|
|
|
if (request_firmware(&fw, (const char *)fw_name, device)) {
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_err("failed to load file %s\n", fw_name);
|
2010-12-30 20:06:01 +00:00
|
|
|
goto out;
|
2010-01-22 20:34:56 +00:00
|
|
|
}
|
2008-09-11 21:27:52 +00:00
|
|
|
|
2010-12-30 20:06:01 +00:00
|
|
|
ret = UCODE_ERROR;
|
|
|
|
if (*(u32 *)fw->data != UCODE_MAGIC) {
|
2011-01-05 17:13:19 +00:00
|
|
|
pr_err("invalid magic value (0x%08x)\n", *(u32 *)fw->data);
|
2010-12-30 20:06:01 +00:00
|
|
|
goto fw_release;
|
2009-10-29 13:45:52 +00:00
|
|
|
}
|
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
/* free old equiv table */
|
|
|
|
free_equiv_cpu_table();
|
|
|
|
|
|
|
|
ret = load_microcode_amd(cpu, fw->data, fw->size);
|
|
|
|
if (ret != UCODE_OK)
|
|
|
|
cleanup();
|
2008-09-11 21:27:52 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
fw_release:
|
2010-12-30 20:06:01 +00:00
|
|
|
release_firmware(fw);
|
2010-01-22 20:34:56 +00:00
|
|
|
|
2012-08-01 14:16:13 +00:00
|
|
|
out:
|
2008-09-11 21:27:52 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2009-05-11 21:48:27 +00:00
|
|
|
static enum ucode_state
|
|
|
|
request_microcode_user(int cpu, const void __user *buf, size_t size)
|
2008-09-11 21:27:52 +00:00
|
|
|
{
|
2009-05-11 21:48:27 +00:00
|
|
|
return UCODE_ERROR;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void microcode_fini_cpu_amd(int cpu)
|
|
|
|
{
|
|
|
|
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
|
|
|
|
|
2008-09-23 10:08:44 +00:00
|
|
|
uci->mc = NULL;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static struct microcode_ops microcode_amd_ops = {
|
2008-09-11 21:27:52 +00:00
|
|
|
.request_microcode_user = request_microcode_user,
|
2010-12-30 20:06:01 +00:00
|
|
|
.request_microcode_fw = request_microcode_amd,
|
2008-07-28 16:44:22 +00:00
|
|
|
.collect_cpu_info = collect_cpu_info_amd,
|
|
|
|
.apply_microcode = apply_microcode_amd,
|
|
|
|
.microcode_fini_cpu = microcode_fini_cpu_amd,
|
|
|
|
};
|
|
|
|
|
2008-09-23 10:08:44 +00:00
|
|
|
struct microcode_ops * __init init_amd_microcode(void)
|
2008-07-28 16:44:22 +00:00
|
|
|
{
|
2012-04-12 14:51:57 +00:00
|
|
|
struct cpuinfo_x86 *c = &cpu_data(0);
|
|
|
|
|
|
|
|
if (c->x86_vendor != X86_VENDOR_AMD || c->x86 < 0x10) {
|
|
|
|
pr_warning("AMD CPU family 0x%x not supported\n", c->x86);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2008-09-23 10:08:44 +00:00
|
|
|
return µcode_amd_ops;
|
2008-07-28 16:44:22 +00:00
|
|
|
}
|
2011-12-02 15:50:04 +00:00
|
|
|
|
|
|
|
void __exit exit_amd_microcode(void)
|
|
|
|
{
|
2012-08-01 14:16:13 +00:00
|
|
|
cleanup();
|
2011-12-02 15:50:04 +00:00
|
|
|
}
|