2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* net/sched/act_api.c Packet action API.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version
|
|
|
|
* 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* Author: Jamal Hadi Salim
|
|
|
|
*
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/types.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/errno.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <linux/skbuff.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/kmod.h>
|
2008-01-24 04:33:13 +00:00
|
|
|
#include <linux/err.h>
|
2011-05-27 13:12:25 +00:00
|
|
|
#include <linux/module.h>
|
2007-11-30 13:21:31 +00:00
|
|
|
#include <net/net_namespace.h>
|
|
|
|
#include <net/sock.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <net/sch_generic.h>
|
2017-01-24 12:02:41 +00:00
|
|
|
#include <net/pkt_cls.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include <net/act_api.h>
|
2007-03-26 06:06:12 +00:00
|
|
|
#include <net/netlink.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-05-17 09:08:03 +00:00
|
|
|
static void tcf_action_goto_chain_exec(const struct tc_action *a,
|
|
|
|
struct tcf_result *res)
|
|
|
|
{
|
|
|
|
const struct tcf_chain *chain = a->goto_chain;
|
|
|
|
|
|
|
|
res->goto_tp = rcu_dereference_bh(chain->filter_chain);
|
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:23 +00:00
|
|
|
static void tcf_free_cookie_rcu(struct rcu_head *p)
|
|
|
|
{
|
|
|
|
struct tc_cookie *cookie = container_of(p, struct tc_cookie, rcu);
|
|
|
|
|
|
|
|
kfree(cookie->data);
|
|
|
|
kfree(cookie);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void tcf_set_action_cookie(struct tc_cookie __rcu **old_cookie,
|
|
|
|
struct tc_cookie *new_cookie)
|
|
|
|
{
|
|
|
|
struct tc_cookie *old;
|
|
|
|
|
2018-07-08 08:02:59 +00:00
|
|
|
old = xchg((__force struct tc_cookie **)old_cookie, new_cookie);
|
2018-07-05 14:24:23 +00:00
|
|
|
if (old)
|
|
|
|
call_rcu(&old->rcu, tcf_free_cookie_rcu);
|
|
|
|
}
|
|
|
|
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
int tcf_action_check_ctrlact(int action, struct tcf_proto *tp,
|
|
|
|
struct tcf_chain **newchain,
|
|
|
|
struct netlink_ext_ack *extack)
|
|
|
|
{
|
|
|
|
int opcode = TC_ACT_EXT_OPCODE(action), ret = -EINVAL;
|
|
|
|
u32 chain_index;
|
|
|
|
|
|
|
|
if (!opcode)
|
|
|
|
ret = action > TC_ACT_VALUE_MAX ? -EINVAL : 0;
|
|
|
|
else if (opcode <= TC_ACT_EXT_OPCODE_MAX || action == TC_ACT_UNSPEC)
|
|
|
|
ret = 0;
|
|
|
|
if (ret) {
|
|
|
|
NL_SET_ERR_MSG(extack, "invalid control action");
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (TC_ACT_EXT_CMP(action, TC_ACT_GOTO_CHAIN)) {
|
|
|
|
chain_index = action & TC_ACT_EXT_VAL_MASK;
|
|
|
|
if (!tp || !newchain) {
|
|
|
|
ret = -EINVAL;
|
|
|
|
NL_SET_ERR_MSG(extack,
|
|
|
|
"can't goto NULL proto/chain");
|
|
|
|
goto end;
|
|
|
|
}
|
|
|
|
*newchain = tcf_chain_get_by_act(tp->chain->block, chain_index);
|
|
|
|
if (!*newchain) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
NL_SET_ERR_MSG(extack,
|
|
|
|
"can't allocate goto_chain");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
end:
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tcf_action_check_ctrlact);
|
|
|
|
|
|
|
|
struct tcf_chain *tcf_action_set_ctrlact(struct tc_action *a, int action,
|
|
|
|
struct tcf_chain *newchain)
|
|
|
|
{
|
|
|
|
struct tcf_chain *oldchain = a->goto_chain;
|
|
|
|
|
|
|
|
a->tcfa_action = action;
|
|
|
|
a->goto_chain = newchain;
|
|
|
|
return oldchain;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tcf_action_set_ctrlact);
|
|
|
|
|
2017-09-11 23:33:30 +00:00
|
|
|
/* XXX: For standalone actions, we don't need a RCU grace period either, because
|
|
|
|
* actions are always connected to filters and filters are already destroyed in
|
|
|
|
* RCU callbacks, so after a RCU grace period actions are already disconnected
|
|
|
|
* from filters. Readers later can not find us.
|
|
|
|
*/
|
|
|
|
static void free_tcf(struct tc_action *p)
|
2015-07-06 12:18:04 +00:00
|
|
|
{
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
struct tcf_chain *chain = p->goto_chain;
|
|
|
|
|
2015-07-06 12:18:04 +00:00
|
|
|
free_percpu(p->cpu_bstats);
|
2018-09-21 11:14:02 +00:00
|
|
|
free_percpu(p->cpu_bstats_hw);
|
2015-07-06 12:18:04 +00:00
|
|
|
free_percpu(p->cpu_qstats);
|
2017-01-24 12:02:41 +00:00
|
|
|
|
2018-07-05 14:24:23 +00:00
|
|
|
tcf_set_action_cookie(&p->act_cookie, NULL);
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
if (chain)
|
|
|
|
tcf_chain_put_by_act(chain);
|
2017-01-24 12:02:41 +00:00
|
|
|
|
2015-07-06 12:18:04 +00:00
|
|
|
kfree(p);
|
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
static void tcf_action_cleanup(struct tc_action *p)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2018-07-05 14:24:29 +00:00
|
|
|
if (p->ops->cleanup)
|
|
|
|
p->ops->cleanup(p);
|
|
|
|
|
2016-12-04 17:48:16 +00:00
|
|
|
gen_kill_estimator(&p->tcfa_rate_est);
|
2017-09-11 23:33:30 +00:00
|
|
|
free_tcf(p);
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
static int __tcf_action_put(struct tc_action *p, bool bind)
|
|
|
|
{
|
|
|
|
struct tcf_idrinfo *idrinfo = p->idrinfo;
|
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
if (refcount_dec_and_mutex_lock(&p->tcfa_refcnt, &idrinfo->lock)) {
|
2018-07-05 14:24:29 +00:00
|
|
|
if (bind)
|
|
|
|
atomic_dec(&p->tcfa_bindcnt);
|
|
|
|
idr_remove(&idrinfo->action_idr, p->tcfa_index);
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:29 +00:00
|
|
|
|
|
|
|
tcf_action_cleanup(p);
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bind)
|
|
|
|
atomic_dec(&p->tcfa_bindcnt);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
int __tcf_idr_release(struct tc_action *p, bool bind, bool strict)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
|
2018-07-05 14:24:24 +00:00
|
|
|
/* Release with strict==1 and bind==0 is only called through act API
|
|
|
|
* interface (classifiers always bind). Only case when action with
|
|
|
|
* positive reference count and zero bind count can exist is when it was
|
|
|
|
* also created with act API (unbinding last classifier will destroy the
|
|
|
|
* action if it was created by classifier). So only case when bind count
|
|
|
|
* can be changed after initial check is when unbound action is
|
|
|
|
* destroyed by act API while classifier binds to action with same id
|
|
|
|
* concurrently. This result either creation of new action(same behavior
|
|
|
|
* as before), or reusing existing action if concurrent process
|
|
|
|
* increments reference count before action is deleted. Both scenarios
|
|
|
|
* are acceptable.
|
|
|
|
*/
|
2006-08-22 06:54:55 +00:00
|
|
|
if (p) {
|
2018-07-05 14:24:29 +00:00
|
|
|
if (!bind && strict && atomic_read(&p->tcfa_bindcnt) > 0)
|
2014-02-12 01:07:34 +00:00
|
|
|
return -EPERM;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
if (__tcf_action_put(p, bind))
|
2016-02-22 23:57:52 +00:00
|
|
|
ret = ACT_P_DELETED;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
net: sched: fix refcount imbalance in actions
Since commit 55334a5db5cd ("net_sched: act: refuse to remove bound action
outside"), we end up with a wrong reference count for a tc action.
Test case 1:
FOO="1,6 0 0 4294967295,"
BAR="1,6 0 0 4294967294,"
tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 \
action bpf bytecode "$FOO"
tc actions show action bpf
action order 0: bpf bytecode '1,6 0 0 4294967295' default-action pipe
index 1 ref 1 bind 1
tc actions replace action bpf bytecode "$BAR" index 1
tc actions show action bpf
action order 0: bpf bytecode '1,6 0 0 4294967294' default-action pipe
index 1 ref 2 bind 1
tc actions replace action bpf bytecode "$FOO" index 1
tc actions show action bpf
action order 0: bpf bytecode '1,6 0 0 4294967295' default-action pipe
index 1 ref 3 bind 1
Test case 2:
FOO="1,6 0 0 4294967295,"
tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok
tc actions show action gact
action order 0: gact action pass
random type none pass val 0
index 1 ref 1 bind 1
tc actions add action drop index 1
RTNETLINK answers: File exists [...]
tc actions show action gact
action order 0: gact action pass
random type none pass val 0
index 1 ref 2 bind 1
tc actions add action drop index 1
RTNETLINK answers: File exists [...]
tc actions show action gact
action order 0: gact action pass
random type none pass val 0
index 1 ref 3 bind 1
What happens is that in tcf_hash_check(), we check tcf_common for a given
index and increase tcfc_refcnt and conditionally tcfc_bindcnt when we've
found an existing action. Now there are the following cases:
1) We do a late binding of an action. In that case, we leave the
tcfc_refcnt/tcfc_bindcnt increased and are done with the ->init()
handler. This is correctly handeled.
2) We replace the given action, or we try to add one without replacing
and find out that the action at a specific index already exists
(thus, we go out with error in that case).
In case of 2), we have to undo the reference count increase from
tcf_hash_check() in the tcf_hash_check() function. Currently, we fail to
do so because of the 'tcfc_bindcnt > 0' check which bails out early with
an -EPERM error.
Now, while commit 55334a5db5cd prevents 'tc actions del action ...' on an
already classifier-bound action to drop the reference count (which could
then become negative, wrap around etc), this restriction only accounts for
invocations outside a specific action's ->init() handler.
One possible solution would be to add a flag thus we possibly trigger
the -EPERM ony in situations where it is indeed relevant.
After the patch, above test cases have correct reference count again.
Fixes: 55334a5db5cd ("net_sched: act: refuse to remove bound action outside")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-07-29 21:35:25 +00:00
|
|
|
|
2006-08-22 06:54:55 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
EXPORT_SYMBOL(__tcf_idr_release);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-03-08 21:59:19 +00:00
|
|
|
static size_t tcf_action_shared_attrs_size(const struct tc_action *act)
|
|
|
|
{
|
2018-07-09 17:26:47 +00:00
|
|
|
struct tc_cookie *act_cookie;
|
2018-03-08 21:59:19 +00:00
|
|
|
u32 cookie_len = 0;
|
|
|
|
|
2018-07-09 17:26:47 +00:00
|
|
|
rcu_read_lock();
|
|
|
|
act_cookie = rcu_dereference(act->act_cookie);
|
|
|
|
|
|
|
|
if (act_cookie)
|
|
|
|
cookie_len = nla_total_size(act_cookie->len);
|
|
|
|
rcu_read_unlock();
|
2018-03-08 21:59:19 +00:00
|
|
|
|
|
|
|
return nla_total_size(0) /* action number nested */
|
|
|
|
+ nla_total_size(IFNAMSIZ) /* TCA_ACT_KIND */
|
|
|
|
+ cookie_len /* TCA_ACT_COOKIE */
|
|
|
|
+ nla_total_size(0) /* TCA_ACT_STATS nested */
|
|
|
|
/* TCA_STATS_BASIC */
|
|
|
|
+ nla_total_size_64bit(sizeof(struct gnet_stats_basic))
|
|
|
|
/* TCA_STATS_QUEUE */
|
|
|
|
+ nla_total_size_64bit(sizeof(struct gnet_stats_queue))
|
|
|
|
+ nla_total_size(0) /* TCA_OPTIONS nested */
|
|
|
|
+ nla_total_size(sizeof(struct tcf_t)); /* TCA_GACT_TM */
|
|
|
|
}
|
|
|
|
|
|
|
|
static size_t tcf_action_full_attrs_size(size_t sz)
|
|
|
|
{
|
|
|
|
return NLMSG_HDRLEN /* struct nlmsghdr */
|
|
|
|
+ sizeof(struct tcamsg)
|
|
|
|
+ nla_total_size(0) /* TCA_ACT_TAB nested */
|
|
|
|
+ sz;
|
|
|
|
}
|
|
|
|
|
|
|
|
static size_t tcf_action_fill_size(const struct tc_action *act)
|
|
|
|
{
|
|
|
|
size_t sz = tcf_action_shared_attrs_size(act);
|
|
|
|
|
|
|
|
if (act->ops->get_fill_size)
|
|
|
|
return act->ops->get_fill_size(act) + sz;
|
|
|
|
return sz;
|
|
|
|
}
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
static int tcf_dump_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb,
|
2016-07-25 23:09:41 +00:00
|
|
|
struct netlink_callback *cb)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2017-08-30 06:31:59 +00:00
|
|
|
int err = 0, index = -1, s_i = 0, n_i = 0;
|
2017-07-30 17:24:51 +00:00
|
|
|
u32 act_flags = cb->args[2];
|
2017-07-30 17:24:52 +00:00
|
|
|
unsigned long jiffy_since = cb->args[3];
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2017-08-30 06:31:59 +00:00
|
|
|
struct idr *idr = &idrinfo->action_idr;
|
|
|
|
struct tc_action *p;
|
|
|
|
unsigned long id = 1;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
|
|
|
s_i = cb->args[0];
|
|
|
|
|
2017-11-28 20:39:51 +00:00
|
|
|
idr_for_each_entry_ul(idr, p, id) {
|
2017-08-30 06:31:59 +00:00
|
|
|
index++;
|
|
|
|
if (index < s_i)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (jiffy_since &&
|
|
|
|
time_after(jiffy_since,
|
|
|
|
(unsigned long)p->tcfa_tm.lastuse))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
nest = nla_nest_start(skb, n_i);
|
2018-03-26 18:58:32 +00:00
|
|
|
if (!nest) {
|
|
|
|
index--;
|
2017-08-30 06:31:59 +00:00
|
|
|
goto nla_put_failure;
|
2018-03-26 18:58:32 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
err = tcf_action_dump_1(skb, p, 0, 0);
|
|
|
|
if (err < 0) {
|
|
|
|
index--;
|
|
|
|
nlmsg_trim(skb, nest);
|
|
|
|
goto done;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
nla_nest_end(skb, nest);
|
|
|
|
n_i++;
|
|
|
|
if (!(act_flags & TCA_FLAG_LARGE_DUMP_ON) &&
|
|
|
|
n_i >= TCA_ACT_MAX_PRIO)
|
|
|
|
goto done;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
|
|
|
done:
|
2017-07-30 17:24:52 +00:00
|
|
|
if (index >= 0)
|
|
|
|
cb->args[0] = index + 1;
|
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2017-07-30 17:24:51 +00:00
|
|
|
if (n_i) {
|
|
|
|
if (act_flags & TCA_FLAG_LARGE_DUMP_ON)
|
|
|
|
cb->args[1] = n_i;
|
|
|
|
}
|
2006-08-22 06:54:55 +00:00
|
|
|
return n_i;
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
nla_put_failure:
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_cancel(skb, nest);
|
2006-08-22 06:54:55 +00:00
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
|
2018-09-19 23:37:29 +00:00
|
|
|
static int tcf_idr_release_unsafe(struct tc_action *p)
|
|
|
|
{
|
|
|
|
if (atomic_read(&p->tcfa_bindcnt) > 0)
|
|
|
|
return -EPERM;
|
|
|
|
|
|
|
|
if (refcount_dec_and_test(&p->tcfa_refcnt)) {
|
|
|
|
idr_remove(&p->idrinfo->action_idr, p->tcfa_index);
|
|
|
|
tcf_action_cleanup(p);
|
|
|
|
return ACT_P_DELETED;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
static int tcf_del_walker(struct tcf_idrinfo *idrinfo, struct sk_buff *skb,
|
2016-07-25 23:09:41 +00:00
|
|
|
const struct tc_action_ops *ops)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2017-08-30 06:31:59 +00:00
|
|
|
int n_i = 0;
|
2014-02-12 01:07:34 +00:00
|
|
|
int ret = -EINVAL;
|
2017-08-30 06:31:59 +00:00
|
|
|
struct idr *idr = &idrinfo->action_idr;
|
|
|
|
struct tc_action *p;
|
|
|
|
unsigned long id = 1;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2016-07-25 23:09:41 +00:00
|
|
|
nest = nla_nest_start(skb, 0);
|
2008-01-24 04:34:11 +00:00
|
|
|
if (nest == NULL)
|
|
|
|
goto nla_put_failure;
|
2016-07-25 23:09:41 +00:00
|
|
|
if (nla_put_string(skb, TCA_KIND, ops->kind))
|
2012-03-29 09:11:39 +00:00
|
|
|
goto nla_put_failure;
|
2017-08-30 06:31:59 +00:00
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2017-11-28 20:39:51 +00:00
|
|
|
idr_for_each_entry_ul(idr, p, id) {
|
2018-09-19 23:37:29 +00:00
|
|
|
ret = tcf_idr_release_unsafe(p);
|
2017-08-30 06:31:59 +00:00
|
|
|
if (ret == ACT_P_DELETED) {
|
2017-09-13 15:32:37 +00:00
|
|
|
module_put(ops->owner);
|
2017-08-30 06:31:59 +00:00
|
|
|
n_i++;
|
|
|
|
} else if (ret < 0) {
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2017-08-30 06:31:59 +00:00
|
|
|
goto nla_put_failure;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
|
|
|
}
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-09-19 23:37:29 +00:00
|
|
|
|
2012-03-29 09:11:39 +00:00
|
|
|
if (nla_put_u32(skb, TCA_FCNT, n_i))
|
|
|
|
goto nla_put_failure;
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
|
|
|
return n_i;
|
2008-01-23 06:11:50 +00:00
|
|
|
nla_put_failure:
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_cancel(skb, nest);
|
2014-02-12 01:07:34 +00:00
|
|
|
return ret;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
|
|
|
|
2016-02-22 23:57:53 +00:00
|
|
|
int tcf_generic_walker(struct tc_action_net *tn, struct sk_buff *skb,
|
|
|
|
struct netlink_callback *cb, int type,
|
2018-02-15 15:54:59 +00:00
|
|
|
const struct tc_action_ops *ops,
|
|
|
|
struct netlink_ext_ack *extack)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2017-08-30 06:31:59 +00:00
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
2016-02-22 23:57:53 +00:00
|
|
|
|
2006-08-22 06:54:55 +00:00
|
|
|
if (type == RTM_DELACTION) {
|
2017-08-30 06:31:59 +00:00
|
|
|
return tcf_del_walker(idrinfo, skb, ops);
|
2006-08-22 06:54:55 +00:00
|
|
|
} else if (type == RTM_GETACTION) {
|
2017-08-30 06:31:59 +00:00
|
|
|
return tcf_dump_walker(idrinfo, skb, cb);
|
2006-08-22 06:54:55 +00:00
|
|
|
} else {
|
2018-02-15 15:54:59 +00:00
|
|
|
WARN(1, "tcf_generic_walker: unknown command %d\n", type);
|
|
|
|
NL_SET_ERR_MSG(extack, "tcf_generic_walker: unknown command");
|
2006-08-22 06:54:55 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
}
|
2016-02-22 23:57:53 +00:00
|
|
|
EXPORT_SYMBOL(tcf_generic_walker);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-08-19 19:22:08 +00:00
|
|
|
int tcf_idr_search(struct tc_action_net *tn, struct tc_action **a, u32 index)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2018-07-05 14:24:26 +00:00
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
|
|
|
struct tc_action *p;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2017-11-28 15:01:24 +00:00
|
|
|
p = idr_find(&idrinfo->action_idr, index);
|
2018-08-19 19:22:08 +00:00
|
|
|
if (IS_ERR(p))
|
2018-07-05 14:24:32 +00:00
|
|
|
p = NULL;
|
2018-08-19 19:22:08 +00:00
|
|
|
else if (p)
|
2018-07-05 14:24:26 +00:00
|
|
|
refcount_inc(&p->tcfa_refcnt);
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-07-05 14:24:26 +00:00
|
|
|
if (p) {
|
|
|
|
*a = p;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
EXPORT_SYMBOL(tcf_idr_search);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-08-19 19:22:06 +00:00
|
|
|
static int tcf_idr_delete_index(struct tcf_idrinfo *idrinfo, u32 index)
|
2018-07-05 14:24:27 +00:00
|
|
|
{
|
|
|
|
struct tc_action *p;
|
|
|
|
int ret = 0;
|
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2018-07-05 14:24:27 +00:00
|
|
|
p = idr_find(&idrinfo->action_idr, index);
|
|
|
|
if (!p) {
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:27 +00:00
|
|
|
return -ENOENT;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!atomic_read(&p->tcfa_bindcnt)) {
|
|
|
|
if (refcount_dec_and_test(&p->tcfa_refcnt)) {
|
|
|
|
struct module *owner = p->ops->owner;
|
|
|
|
|
|
|
|
WARN_ON(p != idr_remove(&idrinfo->action_idr,
|
|
|
|
p->tcfa_index));
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:27 +00:00
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
tcf_action_cleanup(p);
|
2018-07-05 14:24:27 +00:00
|
|
|
module_put(owner);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
} else {
|
|
|
|
ret = -EPERM;
|
|
|
|
}
|
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:27 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,
|
|
|
|
struct tc_action **a, const struct tc_action_ops *ops,
|
|
|
|
int bind, bool cpustats)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2016-07-25 23:09:42 +00:00
|
|
|
struct tc_action *p = kzalloc(ops->size, GFP_KERNEL);
|
2017-08-30 06:31:59 +00:00
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
2015-07-06 12:18:04 +00:00
|
|
|
int err = -ENOMEM;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
|
|
|
if (unlikely(!p))
|
2014-02-12 01:07:31 +00:00
|
|
|
return -ENOMEM;
|
2018-07-05 14:24:24 +00:00
|
|
|
refcount_set(&p->tcfa_refcnt, 1);
|
2006-08-22 06:54:55 +00:00
|
|
|
if (bind)
|
2018-07-05 14:24:24 +00:00
|
|
|
atomic_set(&p->tcfa_bindcnt, 1);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2015-07-06 12:18:04 +00:00
|
|
|
if (cpustats) {
|
|
|
|
p->cpu_bstats = netdev_alloc_pcpu_stats(struct gnet_stats_basic_cpu);
|
2017-11-28 15:28:15 +00:00
|
|
|
if (!p->cpu_bstats)
|
2015-07-06 12:18:04 +00:00
|
|
|
goto err1;
|
2018-09-21 11:14:02 +00:00
|
|
|
p->cpu_bstats_hw = netdev_alloc_pcpu_stats(struct gnet_stats_basic_cpu);
|
|
|
|
if (!p->cpu_bstats_hw)
|
|
|
|
goto err2;
|
2017-11-28 15:28:15 +00:00
|
|
|
p->cpu_qstats = alloc_percpu(struct gnet_stats_queue);
|
|
|
|
if (!p->cpu_qstats)
|
2018-09-21 11:14:02 +00:00
|
|
|
goto err3;
|
2015-07-06 12:18:04 +00:00
|
|
|
}
|
2016-07-25 23:09:42 +00:00
|
|
|
spin_lock_init(&p->tcfa_lock);
|
2017-11-28 15:28:15 +00:00
|
|
|
p->tcfa_index = index;
|
2016-07-25 23:09:42 +00:00
|
|
|
p->tcfa_tm.install = jiffies;
|
|
|
|
p->tcfa_tm.lastuse = jiffies;
|
|
|
|
p->tcfa_tm.firstuse = 0;
|
2008-11-26 05:12:32 +00:00
|
|
|
if (est) {
|
2016-07-25 23:09:42 +00:00
|
|
|
err = gen_new_estimator(&p->tcfa_bstats, p->cpu_bstats,
|
|
|
|
&p->tcfa_rate_est,
|
|
|
|
&p->tcfa_lock, NULL, est);
|
2017-11-28 15:28:15 +00:00
|
|
|
if (err)
|
2018-09-21 11:14:02 +00:00
|
|
|
goto err4;
|
2008-11-26 05:12:32 +00:00
|
|
|
}
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
p->idrinfo = idrinfo;
|
2016-07-25 23:09:42 +00:00
|
|
|
p->ops = ops;
|
|
|
|
*a = p;
|
2014-02-12 01:07:31 +00:00
|
|
|
return 0;
|
2018-09-21 11:14:02 +00:00
|
|
|
err4:
|
2017-11-28 15:28:15 +00:00
|
|
|
free_percpu(p->cpu_qstats);
|
2018-09-21 11:14:02 +00:00
|
|
|
err3:
|
|
|
|
free_percpu(p->cpu_bstats_hw);
|
2017-11-28 15:28:15 +00:00
|
|
|
err2:
|
|
|
|
free_percpu(p->cpu_bstats);
|
|
|
|
err1:
|
|
|
|
kfree(p);
|
|
|
|
return err;
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
EXPORT_SYMBOL(tcf_idr_create);
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
void tcf_idr_insert(struct tc_action_net *tn, struct tc_action *a)
|
2006-08-22 06:54:55 +00:00
|
|
|
{
|
2017-08-30 06:31:59 +00:00
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
2006-08-22 06:54:55 +00:00
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
/* Replace ERR_PTR(-EBUSY) allocated by tcf_idr_check_alloc */
|
|
|
|
WARN_ON(!IS_ERR(idr_replace(&idrinfo->action_idr, a, a->tcfa_index)));
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2006-08-22 06:54:55 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
EXPORT_SYMBOL(tcf_idr_insert);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:32 +00:00
|
|
|
/* Cleanup idr index that was allocated but not initialized. */
|
|
|
|
|
|
|
|
void tcf_idr_cleanup(struct tc_action_net *tn, u32 index)
|
|
|
|
{
|
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
|
|
|
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
/* Remove ERR_PTR(-EBUSY) allocated by tcf_idr_check_alloc */
|
|
|
|
WARN_ON(!IS_ERR(idr_remove(&idrinfo->action_idr, index)));
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tcf_idr_cleanup);
|
|
|
|
|
|
|
|
/* Check if action with specified index exists. If actions is found, increments
|
|
|
|
* its reference and bind counters, and return 1. Otherwise insert temporary
|
|
|
|
* error pointer (to prevent concurrent users from inserting actions with same
|
|
|
|
* index) and return 0.
|
|
|
|
*/
|
|
|
|
|
|
|
|
int tcf_idr_check_alloc(struct tc_action_net *tn, u32 *index,
|
|
|
|
struct tc_action **a, int bind)
|
|
|
|
{
|
|
|
|
struct tcf_idrinfo *idrinfo = tn->idrinfo;
|
|
|
|
struct tc_action *p;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
again:
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_lock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
if (*index) {
|
|
|
|
p = idr_find(&idrinfo->action_idr, *index);
|
|
|
|
if (IS_ERR(p)) {
|
|
|
|
/* This means that another process allocated
|
|
|
|
* index but did not assign the pointer yet.
|
|
|
|
*/
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
goto again;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (p) {
|
|
|
|
refcount_inc(&p->tcfa_refcnt);
|
|
|
|
if (bind)
|
|
|
|
atomic_inc(&p->tcfa_bindcnt);
|
|
|
|
*a = p;
|
|
|
|
ret = 1;
|
|
|
|
} else {
|
|
|
|
*a = NULL;
|
|
|
|
ret = idr_alloc_u32(&idrinfo->action_idr, NULL, index,
|
2018-10-02 19:50:19 +00:00
|
|
|
*index, GFP_KERNEL);
|
2018-07-05 14:24:32 +00:00
|
|
|
if (!ret)
|
|
|
|
idr_replace(&idrinfo->action_idr,
|
|
|
|
ERR_PTR(-EBUSY), *index);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
*index = 1;
|
|
|
|
*a = NULL;
|
|
|
|
ret = idr_alloc_u32(&idrinfo->action_idr, NULL, index,
|
2018-10-02 19:50:19 +00:00
|
|
|
UINT_MAX, GFP_KERNEL);
|
2018-07-05 14:24:32 +00:00
|
|
|
if (!ret)
|
|
|
|
idr_replace(&idrinfo->action_idr, ERR_PTR(-EBUSY),
|
|
|
|
*index);
|
|
|
|
}
|
2018-10-02 19:50:19 +00:00
|
|
|
mutex_unlock(&idrinfo->lock);
|
2018-07-05 14:24:32 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tcf_idr_check_alloc);
|
|
|
|
|
2017-08-30 06:31:59 +00:00
|
|
|
void tcf_idrinfo_destroy(const struct tc_action_ops *ops,
|
|
|
|
struct tcf_idrinfo *idrinfo)
|
2016-02-22 23:57:52 +00:00
|
|
|
{
|
2017-08-30 06:31:59 +00:00
|
|
|
struct idr *idr = &idrinfo->action_idr;
|
|
|
|
struct tc_action *p;
|
|
|
|
int ret;
|
|
|
|
unsigned long id = 1;
|
2016-02-22 23:57:52 +00:00
|
|
|
|
2017-11-28 20:39:51 +00:00
|
|
|
idr_for_each_entry_ul(idr, p, id) {
|
2017-08-30 06:31:59 +00:00
|
|
|
ret = __tcf_idr_release(p, false, true);
|
|
|
|
if (ret == ACT_P_DELETED)
|
|
|
|
module_put(ops->owner);
|
|
|
|
else if (ret < 0)
|
|
|
|
return;
|
2016-02-22 23:57:52 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
idr_destroy(&idrinfo->action_idr);
|
2016-02-22 23:57:52 +00:00
|
|
|
}
|
2017-08-30 06:31:59 +00:00
|
|
|
EXPORT_SYMBOL(tcf_idrinfo_destroy);
|
2016-02-22 23:57:52 +00:00
|
|
|
|
2013-12-16 04:15:10 +00:00
|
|
|
static LIST_HEAD(act_base);
|
2005-04-16 22:20:36 +00:00
|
|
|
static DEFINE_RWLOCK(act_mod_lock);
|
|
|
|
|
2016-02-22 23:57:53 +00:00
|
|
|
int tcf_register_action(struct tc_action_ops *act,
|
|
|
|
struct pernet_operations *ops)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2013-12-16 04:15:10 +00:00
|
|
|
struct tc_action_ops *a;
|
2016-02-22 23:57:53 +00:00
|
|
|
int ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-02-22 23:57:53 +00:00
|
|
|
if (!act->act || !act->dump || !act->init || !act->walk || !act->lookup)
|
2013-12-04 14:26:52 +00:00
|
|
|
return -EINVAL;
|
|
|
|
|
2016-10-11 17:56:45 +00:00
|
|
|
/* We have to register pernet ops before making the action ops visible,
|
|
|
|
* otherwise tcf_action_init_1() could get a partially initialized
|
|
|
|
* netns.
|
|
|
|
*/
|
|
|
|
ret = register_pernet_subsys(ops);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
write_lock(&act_mod_lock);
|
2013-12-16 04:15:10 +00:00
|
|
|
list_for_each_entry(a, &act_base, head) {
|
2019-02-10 12:25:00 +00:00
|
|
|
if (act->id == a->id || (strcmp(act->kind, a->kind) == 0)) {
|
2005-04-16 22:20:36 +00:00
|
|
|
write_unlock(&act_mod_lock);
|
2016-10-11 17:56:45 +00:00
|
|
|
unregister_pernet_subsys(ops);
|
2005-04-16 22:20:36 +00:00
|
|
|
return -EEXIST;
|
|
|
|
}
|
|
|
|
}
|
2013-12-16 04:15:10 +00:00
|
|
|
list_add_tail(&act->head, &act_base);
|
2005-04-16 22:20:36 +00:00
|
|
|
write_unlock(&act_mod_lock);
|
2016-02-22 23:57:53 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2008-01-23 06:10:23 +00:00
|
|
|
EXPORT_SYMBOL(tcf_register_action);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-02-22 23:57:53 +00:00
|
|
|
int tcf_unregister_action(struct tc_action_ops *act,
|
|
|
|
struct pernet_operations *ops)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2013-12-16 04:15:10 +00:00
|
|
|
struct tc_action_ops *a;
|
2005-04-16 22:20:36 +00:00
|
|
|
int err = -ENOENT;
|
|
|
|
|
|
|
|
write_lock(&act_mod_lock);
|
2013-12-20 20:32:32 +00:00
|
|
|
list_for_each_entry(a, &act_base, head) {
|
|
|
|
if (a == act) {
|
|
|
|
list_del(&act->head);
|
|
|
|
err = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2013-12-20 20:32:32 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
write_unlock(&act_mod_lock);
|
2016-10-11 17:56:45 +00:00
|
|
|
if (!err)
|
|
|
|
unregister_pernet_subsys(ops);
|
2005-04-16 22:20:36 +00:00
|
|
|
return err;
|
|
|
|
}
|
2008-01-23 06:10:23 +00:00
|
|
|
EXPORT_SYMBOL(tcf_unregister_action);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/* lookup by name */
|
|
|
|
static struct tc_action_ops *tc_lookup_action_n(char *kind)
|
|
|
|
{
|
2013-12-20 20:32:32 +00:00
|
|
|
struct tc_action_ops *a, *res = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (kind) {
|
|
|
|
read_lock(&act_mod_lock);
|
2013-12-16 04:15:10 +00:00
|
|
|
list_for_each_entry(a, &act_base, head) {
|
2005-04-16 22:20:36 +00:00
|
|
|
if (strcmp(kind, a->kind) == 0) {
|
2013-12-20 20:32:32 +00:00
|
|
|
if (try_module_get(a->owner))
|
|
|
|
res = a;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_unlock(&act_mod_lock);
|
|
|
|
}
|
2013-12-20 20:32:32 +00:00
|
|
|
return res;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
/* lookup by nlattr */
|
|
|
|
static struct tc_action_ops *tc_lookup_action(struct nlattr *kind)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2013-12-20 20:32:32 +00:00
|
|
|
struct tc_action_ops *a, *res = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (kind) {
|
|
|
|
read_lock(&act_mod_lock);
|
2013-12-16 04:15:10 +00:00
|
|
|
list_for_each_entry(a, &act_base, head) {
|
2008-01-23 06:11:50 +00:00
|
|
|
if (nla_strcmp(kind, a->kind) == 0) {
|
2013-12-20 20:32:32 +00:00
|
|
|
if (try_module_get(a->owner))
|
|
|
|
res = a;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_unlock(&act_mod_lock);
|
|
|
|
}
|
2013-12-20 20:32:32 +00:00
|
|
|
return res;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-04-23 17:17:28 +00:00
|
|
|
/*TCA_ACT_MAX_PRIO is 32, there count upto 32 */
|
|
|
|
#define TCA_ACT_MAX_PRIO_MASK 0x1FF
|
2016-08-14 05:35:00 +00:00
|
|
|
int tcf_action_exec(struct sk_buff *skb, struct tc_action **actions,
|
|
|
|
int nr_actions, struct tcf_result *res)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2017-04-23 17:17:28 +00:00
|
|
|
u32 jmp_prgcnt = 0;
|
|
|
|
u32 jmp_ttl = TCA_ACT_MAX_PRIO; /*matches actions per filter */
|
2017-08-04 12:29:02 +00:00
|
|
|
int i;
|
|
|
|
int ret = TC_ACT_OK;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-01-07 22:06:35 +00:00
|
|
|
if (skb_skip_tc_classify(skb))
|
|
|
|
return TC_ACT_OK;
|
|
|
|
|
2017-04-23 17:17:28 +00:00
|
|
|
restart_act_graph:
|
2016-08-14 05:35:00 +00:00
|
|
|
for (i = 0; i < nr_actions; i++) {
|
|
|
|
const struct tc_action *a = actions[i];
|
|
|
|
|
2017-04-23 17:17:28 +00:00
|
|
|
if (jmp_prgcnt > 0) {
|
|
|
|
jmp_prgcnt -= 1;
|
|
|
|
continue;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
repeat:
|
2013-12-23 13:02:12 +00:00
|
|
|
ret = a->ops->act(skb, a, res);
|
|
|
|
if (ret == TC_ACT_REPEAT)
|
|
|
|
goto repeat; /* we need a ttl - JHS */
|
2017-04-23 17:17:28 +00:00
|
|
|
|
2017-05-02 08:12:00 +00:00
|
|
|
if (TC_ACT_EXT_CMP(ret, TC_ACT_JUMP)) {
|
2017-04-23 17:17:28 +00:00
|
|
|
jmp_prgcnt = ret & TCA_ACT_MAX_PRIO_MASK;
|
|
|
|
if (!jmp_prgcnt || (jmp_prgcnt > nr_actions)) {
|
|
|
|
/* faulty opcode, stop pipeline */
|
|
|
|
return TC_ACT_OK;
|
|
|
|
} else {
|
|
|
|
jmp_ttl -= 1;
|
|
|
|
if (jmp_ttl > 0)
|
|
|
|
goto restart_act_graph;
|
|
|
|
else /* faulty graph, stop pipeline */
|
|
|
|
return TC_ACT_OK;
|
|
|
|
}
|
2017-05-17 09:08:03 +00:00
|
|
|
} else if (TC_ACT_EXT_CMP(ret, TC_ACT_GOTO_CHAIN)) {
|
|
|
|
tcf_action_goto_chain_exec(a, res);
|
2017-04-23 17:17:28 +00:00
|
|
|
}
|
|
|
|
|
2013-12-23 13:02:12 +00:00
|
|
|
if (ret != TC_ACT_PIPE)
|
2017-01-07 22:06:35 +00:00
|
|
|
break;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2017-04-23 17:17:28 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
2008-01-23 06:10:23 +00:00
|
|
|
EXPORT_SYMBOL(tcf_action_exec);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
int tcf_action_destroy(struct tc_action *actions[], int bind)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2017-09-13 15:32:37 +00:00
|
|
|
const struct tc_action_ops *ops;
|
2018-07-05 14:24:33 +00:00
|
|
|
struct tc_action *a;
|
|
|
|
int ret = 0, i;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
for (i = 0; i < TCA_ACT_MAX_PRIO && actions[i]; i++) {
|
|
|
|
a = actions[i];
|
|
|
|
actions[i] = NULL;
|
2017-09-13 15:32:37 +00:00
|
|
|
ops = a->ops;
|
2017-08-30 06:31:59 +00:00
|
|
|
ret = __tcf_idr_release(a, bind, true);
|
2014-02-12 01:07:34 +00:00
|
|
|
if (ret == ACT_P_DELETED)
|
2017-09-13 15:32:37 +00:00
|
|
|
module_put(ops->owner);
|
2014-02-12 01:07:34 +00:00
|
|
|
else if (ret < 0)
|
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2014-02-12 01:07:34 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2018-08-29 08:22:33 +00:00
|
|
|
static int tcf_action_destroy_1(struct tc_action *a, int bind)
|
|
|
|
{
|
|
|
|
struct tc_action *actions[] = { a, NULL };
|
|
|
|
|
|
|
|
return tcf_action_destroy(actions, bind);
|
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
static int tcf_action_put(struct tc_action *p)
|
|
|
|
{
|
|
|
|
return __tcf_action_put(p, false);
|
|
|
|
}
|
|
|
|
|
2018-08-19 19:22:05 +00:00
|
|
|
/* Put all actions in this array, skip those NULL's. */
|
2018-07-05 14:24:33 +00:00
|
|
|
static void tcf_action_put_many(struct tc_action *actions[])
|
2018-07-05 14:24:31 +00:00
|
|
|
{
|
2018-07-05 14:24:33 +00:00
|
|
|
int i;
|
2018-07-05 14:24:31 +00:00
|
|
|
|
2018-08-19 19:22:05 +00:00
|
|
|
for (i = 0; i < TCA_ACT_MAX_PRIO; i++) {
|
2018-07-05 14:24:33 +00:00
|
|
|
struct tc_action *a = actions[i];
|
2018-08-19 19:22:05 +00:00
|
|
|
const struct tc_action_ops *ops;
|
2018-07-05 14:24:31 +00:00
|
|
|
|
2018-08-19 19:22:05 +00:00
|
|
|
if (!a)
|
|
|
|
continue;
|
|
|
|
ops = a->ops;
|
2018-07-05 14:24:31 +00:00
|
|
|
if (tcf_action_put(a))
|
|
|
|
module_put(ops->owner);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
int
|
|
|
|
tcf_action_dump_old(struct sk_buff *skb, struct tc_action *a, int bind, int ref)
|
|
|
|
{
|
|
|
|
return a->ops->dump(skb, a, bind, ref);
|
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
tcf_action_dump_1(struct sk_buff *skb, struct tc_action *a, int bind, int ref)
|
|
|
|
{
|
|
|
|
int err = -EINVAL;
|
2007-04-20 03:29:13 +00:00
|
|
|
unsigned char *b = skb_tail_pointer(skb);
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2018-07-05 14:24:23 +00:00
|
|
|
struct tc_cookie *cookie;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-29 09:11:39 +00:00
|
|
|
if (nla_put_string(skb, TCA_KIND, a->ops->kind))
|
|
|
|
goto nla_put_failure;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (tcf_action_copy_stats(skb, a, 0))
|
2008-01-23 06:11:50 +00:00
|
|
|
goto nla_put_failure;
|
2018-07-05 14:24:23 +00:00
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
cookie = rcu_dereference(a->act_cookie);
|
|
|
|
if (cookie) {
|
|
|
|
if (nla_put(skb, TCA_ACT_COOKIE, cookie->len, cookie->data)) {
|
|
|
|
rcu_read_unlock();
|
2017-01-24 12:02:41 +00:00
|
|
|
goto nla_put_failure;
|
2018-07-05 14:24:23 +00:00
|
|
|
}
|
2017-01-24 12:02:41 +00:00
|
|
|
}
|
2018-07-05 14:24:23 +00:00
|
|
|
rcu_read_unlock();
|
2017-01-24 12:02:41 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nest = nla_nest_start(skb, TCA_OPTIONS);
|
|
|
|
if (nest == NULL)
|
|
|
|
goto nla_put_failure;
|
2011-01-19 19:26:56 +00:00
|
|
|
err = tcf_action_dump_old(skb, a, bind, ref);
|
|
|
|
if (err > 0) {
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2005-04-16 22:20:36 +00:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
nla_put_failure:
|
2007-03-26 06:06:12 +00:00
|
|
|
nlmsg_trim(skb, b);
|
2005-04-16 22:20:36 +00:00
|
|
|
return -1;
|
|
|
|
}
|
2008-01-23 06:10:23 +00:00
|
|
|
EXPORT_SYMBOL(tcf_action_dump_1);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
int tcf_action_dump(struct sk_buff *skb, struct tc_action *actions[],
|
2016-06-05 14:41:32 +00:00
|
|
|
int bind, int ref)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct tc_action *a;
|
2018-07-05 14:24:33 +00:00
|
|
|
int err = -EINVAL, i;
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
for (i = 0; i < TCA_ACT_MAX_PRIO && actions[i]; i++) {
|
|
|
|
a = actions[i];
|
2008-01-24 04:34:11 +00:00
|
|
|
nest = nla_nest_start(skb, a->order);
|
|
|
|
if (nest == NULL)
|
|
|
|
goto nla_put_failure;
|
2005-04-16 22:20:36 +00:00
|
|
|
err = tcf_action_dump_1(skb, a, bind, ref);
|
|
|
|
if (err < 0)
|
2006-07-06 03:47:28 +00:00
|
|
|
goto errout;
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
nla_put_failure:
|
2006-07-06 03:47:28 +00:00
|
|
|
err = -EINVAL;
|
|
|
|
errout:
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_cancel(skb, nest);
|
2006-07-06 03:47:28 +00:00
|
|
|
return err;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-04-20 12:08:26 +00:00
|
|
|
static struct tc_cookie *nla_memdup_cookie(struct nlattr **tb)
|
2017-01-24 12:02:41 +00:00
|
|
|
{
|
2017-04-20 12:08:26 +00:00
|
|
|
struct tc_cookie *c = kzalloc(sizeof(*c), GFP_KERNEL);
|
|
|
|
if (!c)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
c->data = nla_memdup(tb[TCA_ACT_COOKIE], GFP_KERNEL);
|
|
|
|
if (!c->data) {
|
|
|
|
kfree(c);
|
|
|
|
return NULL;
|
2017-01-24 12:02:41 +00:00
|
|
|
}
|
2017-04-20 12:08:26 +00:00
|
|
|
c->len = nla_len(tb[TCA_ACT_COOKIE]);
|
2017-01-24 12:02:41 +00:00
|
|
|
|
2017-04-20 12:08:26 +00:00
|
|
|
return c;
|
2017-01-24 12:02:41 +00:00
|
|
|
}
|
|
|
|
|
2017-05-17 09:08:02 +00:00
|
|
|
struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
|
|
|
|
struct nlattr *nla, struct nlattr *est,
|
2018-02-15 15:54:54 +00:00
|
|
|
char *name, int ovr, int bind,
|
2018-07-05 14:24:25 +00:00
|
|
|
bool rtnl_held,
|
2018-02-15 15:54:54 +00:00
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct tc_action *a;
|
|
|
|
struct tc_action_ops *a_o;
|
2017-04-20 12:08:26 +00:00
|
|
|
struct tc_cookie *cookie = NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
char act_name[IFNAMSIZ];
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX + 1];
|
2008-01-23 06:11:50 +00:00
|
|
|
struct nlattr *kind;
|
2008-01-24 04:33:13 +00:00
|
|
|
int err;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (name == NULL) {
|
2018-02-15 15:54:55 +00:00
|
|
|
err = nla_parse_nested(tb, TCA_ACT_MAX, nla, NULL, extack);
|
2008-01-24 04:33:32 +00:00
|
|
|
if (err < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
2008-01-24 04:33:32 +00:00
|
|
|
err = -EINVAL;
|
2008-01-23 06:11:50 +00:00
|
|
|
kind = tb[TCA_ACT_KIND];
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!kind) {
|
|
|
|
NL_SET_ERR_MSG(extack, "TC action kind must be specified");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
|
|
|
if (nla_strlcpy(act_name, kind, IFNAMSIZ) >= IFNAMSIZ) {
|
|
|
|
NL_SET_ERR_MSG(extack, "TC action name too long");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2017-04-20 12:08:26 +00:00
|
|
|
if (tb[TCA_ACT_COOKIE]) {
|
|
|
|
int cklen = nla_len(tb[TCA_ACT_COOKIE]);
|
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
if (cklen > TC_COOKIE_MAX_SIZE) {
|
|
|
|
NL_SET_ERR_MSG(extack, "TC cookie size above the maximum");
|
2017-04-20 12:08:26 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2017-04-20 12:08:26 +00:00
|
|
|
|
|
|
|
cookie = nla_memdup_cookie(tb);
|
|
|
|
if (!cookie) {
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "No memory to generate TC cookie");
|
2017-04-20 12:08:26 +00:00
|
|
|
err = -ENOMEM;
|
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
} else {
|
2018-02-15 15:54:55 +00:00
|
|
|
if (strlcpy(act_name, name, IFNAMSIZ) >= IFNAMSIZ) {
|
|
|
|
NL_SET_ERR_MSG(extack, "TC action name too long");
|
|
|
|
err = -EINVAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
a_o = tc_lookup_action_n(act_name);
|
|
|
|
if (a_o == NULL) {
|
2008-10-16 22:24:51 +00:00
|
|
|
#ifdef CONFIG_MODULES
|
2018-07-05 14:24:25 +00:00
|
|
|
if (rtnl_held)
|
|
|
|
rtnl_unlock();
|
2006-01-09 06:22:14 +00:00
|
|
|
request_module("act_%s", act_name);
|
2018-07-05 14:24:25 +00:00
|
|
|
if (rtnl_held)
|
|
|
|
rtnl_lock();
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
a_o = tc_lookup_action_n(act_name);
|
|
|
|
|
|
|
|
/* We dropped the RTNL semaphore in order to
|
|
|
|
* perform the module load. So, even if we
|
|
|
|
* succeeded in loading the module we have to
|
|
|
|
* tell the caller to replay the request. We
|
|
|
|
* indicate this using -EAGAIN.
|
|
|
|
*/
|
|
|
|
if (a_o != NULL) {
|
2008-01-24 04:33:13 +00:00
|
|
|
err = -EAGAIN;
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_mod;
|
|
|
|
}
|
|
|
|
#endif
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Failed to load TC action module");
|
2008-01-24 04:33:13 +00:00
|
|
|
err = -ENOENT;
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* backward compatibility for policer */
|
|
|
|
if (name == NULL)
|
2018-02-15 15:54:56 +00:00
|
|
|
err = a_o->init(net, tb[TCA_ACT_OPTIONS], est, &a, ovr, bind,
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
rtnl_held, tp, extack);
|
2005-04-16 22:20:36 +00:00
|
|
|
else
|
2018-07-05 14:24:25 +00:00
|
|
|
err = a_o->init(net, nla, est, &a, ovr, bind, rtnl_held,
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
tp, extack);
|
2008-01-24 04:33:13 +00:00
|
|
|
if (err < 0)
|
2016-07-25 23:09:41 +00:00
|
|
|
goto err_mod;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:23 +00:00
|
|
|
if (!name && tb[TCA_ACT_COOKIE])
|
|
|
|
tcf_set_action_cookie(&a->act_cookie, cookie);
|
2017-01-24 12:02:41 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* module count goes up only when brand new policy is created
|
2011-01-19 19:26:56 +00:00
|
|
|
* if it exists and is only bound to in a_o->init() then
|
|
|
|
* ACT_P_CREATED is not returned (a zero is).
|
|
|
|
*/
|
2008-01-24 04:33:13 +00:00
|
|
|
if (err != ACT_P_CREATED)
|
2005-04-16 22:20:36 +00:00
|
|
|
module_put(a_o->owner);
|
|
|
|
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
if (TC_ACT_EXT_CMP(a->tcfa_action, TC_ACT_GOTO_CHAIN) &&
|
|
|
|
!a->goto_chain) {
|
2018-08-29 08:22:33 +00:00
|
|
|
tcf_action_destroy_1(a, bind);
|
net/sched: prepare TC actions to properly validate the control action
- pass a pointer to struct tcf_proto in each actions's init() handler,
to allow validating the control action, checking whether the chain
exists and (eventually) refcounting it.
- remove code that validates the control action after a successful call
to the action's init() handler, and replace it with a test that forbids
addition of actions having 'goto_chain' and NULL goto_chain pointer at
the same time.
- add tcf_action_check_ctrlact(), that will validate the control action
and eventually allocate the action 'goto_chain' within the init()
handler.
- add tcf_action_set_ctrlact(), that will assign the control action and
swap the current 'goto_chain' pointer with the new given one.
This disallows 'goto_chain' on actions that don't initialize it properly
in their init() handler, i.e. calling tcf_action_check_ctrlact() after
successful IDR reservation and then calling tcf_action_set_ctrlact()
to assign 'goto_chain' and 'tcf_action' consistently.
By doing this, the kernel does not leak anymore refcounts when a valid
'goto chain' handle is replaced in TC actions, causing kmemleak splats
like the following one:
# tc chain add dev dd0 chain 42 ingress protocol ip flower \
> ip_proto tcp action drop
# tc chain add dev dd0 chain 43 ingress protocol ip flower \
> ip_proto udp action drop
# tc filter add dev dd0 ingress matchall \
> action gact goto chain 42 index 66
# tc filter replace dev dd0 ingress matchall \
> action gact goto chain 43 index 66
# echo scan >/sys/kernel/debug/kmemleak
<...>
unreferenced object 0xffff93c0ee09f000 (size 1024):
comm "tc", pid 2565, jiffies 4295339808 (age 65.426s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 08 00 06 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<000000009b63f92d>] tc_ctl_chain+0x3d2/0x4c0
[<00000000683a8d72>] rtnetlink_rcv_msg+0x263/0x2d0
[<00000000ddd88f8e>] netlink_rcv_skb+0x4a/0x110
[<000000006126a348>] netlink_unicast+0x1a0/0x250
[<00000000b3340877>] netlink_sendmsg+0x2c1/0x3c0
[<00000000a25a2171>] sock_sendmsg+0x36/0x40
[<00000000f19ee1ec>] ___sys_sendmsg+0x280/0x2f0
[<00000000d0422042>] __sys_sendmsg+0x5e/0xa0
[<000000007a6c61f9>] do_syscall_64+0x5b/0x180
[<00000000ccd07542>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[<0000000013eaa334>] 0xffffffffffffffff
Fixes: db50514f9a9c ("net: sched: add termination action to allow goto chain")
Fixes: 97763dc0f401 ("net_sched: reject unknown tcfa_action values")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-20 13:59:59 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "can't use goto chain with NULL chain");
|
2018-08-29 08:22:33 +00:00
|
|
|
return ERR_PTR(-EINVAL);
|
2018-07-30 12:30:42 +00:00
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return a;
|
|
|
|
|
|
|
|
err_mod:
|
|
|
|
module_put(a_o->owner);
|
|
|
|
err_out:
|
2017-04-20 12:08:26 +00:00
|
|
|
if (cookie) {
|
|
|
|
kfree(cookie->data);
|
|
|
|
kfree(cookie);
|
|
|
|
}
|
2008-01-24 04:33:13 +00:00
|
|
|
return ERR_PTR(err);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
/* Returns numbers of initialized actions or negative error. */
|
|
|
|
|
2017-05-17 09:08:02 +00:00
|
|
|
int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla,
|
|
|
|
struct nlattr *est, char *name, int ovr, int bind,
|
2018-07-05 14:24:33 +00:00
|
|
|
struct tc_action *actions[], size_t *attr_size,
|
2018-07-05 14:24:25 +00:00
|
|
|
bool rtnl_held, struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX_PRIO + 1];
|
2013-12-16 04:15:05 +00:00
|
|
|
struct tc_action *act;
|
2018-03-08 21:59:19 +00:00
|
|
|
size_t sz = 0;
|
2008-01-24 04:33:32 +00:00
|
|
|
int err;
|
2005-04-16 22:20:36 +00:00
|
|
|
int i;
|
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
err = nla_parse_nested(tb, TCA_ACT_MAX_PRIO, nla, NULL, extack);
|
2008-01-24 04:33:32 +00:00
|
|
|
if (err < 0)
|
2013-12-16 04:15:05 +00:00
|
|
|
return err;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
for (i = 1; i <= TCA_ACT_MAX_PRIO && tb[i]; i++) {
|
2018-02-15 15:54:54 +00:00
|
|
|
act = tcf_action_init_1(net, tp, tb[i], est, name, ovr, bind,
|
2018-07-05 14:24:25 +00:00
|
|
|
rtnl_held, extack);
|
2013-12-16 04:15:05 +00:00
|
|
|
if (IS_ERR(act)) {
|
|
|
|
err = PTR_ERR(act);
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err;
|
2013-12-16 04:15:05 +00:00
|
|
|
}
|
2008-01-23 06:11:50 +00:00
|
|
|
act->order = i;
|
2018-03-08 21:59:19 +00:00
|
|
|
sz += tcf_action_fill_size(act);
|
2018-07-05 14:24:33 +00:00
|
|
|
/* Start from index 0 */
|
|
|
|
actions[i - 1] = act;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2016-09-19 23:02:51 +00:00
|
|
|
|
2018-03-08 21:59:19 +00:00
|
|
|
*attr_size = tcf_action_full_attrs_size(sz);
|
2018-07-05 14:24:33 +00:00
|
|
|
return i - 1;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
err:
|
2013-12-16 04:15:05 +00:00
|
|
|
tcf_action_destroy(actions, bind);
|
|
|
|
return err;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-07-25 23:09:42 +00:00
|
|
|
int tcf_action_copy_stats(struct sk_buff *skb, struct tc_action *p,
|
2005-04-16 22:20:36 +00:00
|
|
|
int compat_mode)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
struct gnet_dump d;
|
2007-02-09 14:25:16 +00:00
|
|
|
|
2014-01-10 00:14:05 +00:00
|
|
|
if (p == NULL)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto errout;
|
|
|
|
|
|
|
|
/* compat_mode being true specifies a call that is supposed
|
2009-09-29 01:43:57 +00:00
|
|
|
* to add additional backward compatibility statistic TLVs.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
if (compat_mode) {
|
2016-07-25 23:09:42 +00:00
|
|
|
if (p->type == TCA_OLD_COMPAT)
|
2005-04-16 22:20:36 +00:00
|
|
|
err = gnet_stats_start_copy_compat(skb, 0,
|
2016-04-26 08:06:18 +00:00
|
|
|
TCA_STATS,
|
|
|
|
TCA_XSTATS,
|
2016-07-25 23:09:42 +00:00
|
|
|
&p->tcfa_lock, &d,
|
2016-04-26 08:06:18 +00:00
|
|
|
TCA_PAD);
|
2005-04-16 22:20:36 +00:00
|
|
|
else
|
|
|
|
return 0;
|
|
|
|
} else
|
|
|
|
err = gnet_stats_start_copy(skb, TCA_ACT_STATS,
|
2016-07-25 23:09:42 +00:00
|
|
|
&p->tcfa_lock, &d, TCA_ACT_PAD);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (err < 0)
|
|
|
|
goto errout;
|
|
|
|
|
2016-07-25 23:09:42 +00:00
|
|
|
if (gnet_stats_copy_basic(NULL, &d, p->cpu_bstats, &p->tcfa_bstats) < 0 ||
|
2018-09-21 11:14:02 +00:00
|
|
|
gnet_stats_copy_basic_hw(NULL, &d, p->cpu_bstats_hw,
|
|
|
|
&p->tcfa_bstats_hw) < 0 ||
|
2016-12-04 17:48:16 +00:00
|
|
|
gnet_stats_copy_rate_est(&d, &p->tcfa_rate_est) < 0 ||
|
2015-07-06 12:18:04 +00:00
|
|
|
gnet_stats_copy_queue(&d, p->cpu_qstats,
|
2016-07-25 23:09:42 +00:00
|
|
|
&p->tcfa_qstats,
|
|
|
|
p->tcfa_qstats.qlen) < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto errout;
|
|
|
|
|
|
|
|
if (gnet_stats_finish_copy(&d) < 0)
|
|
|
|
goto errout;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
errout:
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
static int tca_get_fill(struct sk_buff *skb, struct tc_action *actions[],
|
2016-06-05 14:41:32 +00:00
|
|
|
u32 portid, u32 seq, u16 flags, int event, int bind,
|
|
|
|
int ref)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct tcamsg *t;
|
|
|
|
struct nlmsghdr *nlh;
|
2007-04-20 03:29:13 +00:00
|
|
|
unsigned char *b = skb_tail_pointer(skb);
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-09-07 20:12:54 +00:00
|
|
|
nlh = nlmsg_put(skb, portid, seq, event, sizeof(*t), flags);
|
2012-06-27 04:39:32 +00:00
|
|
|
if (!nlh)
|
|
|
|
goto out_nlmsg_trim;
|
|
|
|
t = nlmsg_data(nlh);
|
2005-04-16 22:20:36 +00:00
|
|
|
t->tca_family = AF_UNSPEC;
|
2005-06-28 19:55:30 +00:00
|
|
|
t->tca__pad1 = 0;
|
|
|
|
t->tca__pad2 = 0;
|
2007-02-09 14:25:16 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nest = nla_nest_start(skb, TCA_ACT_TAB);
|
2018-02-15 15:54:53 +00:00
|
|
|
if (!nest)
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_nlmsg_trim;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-12-16 04:15:05 +00:00
|
|
|
if (tcf_action_dump(skb, actions, bind, ref) < 0)
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_nlmsg_trim;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2007-02-09 14:25:16 +00:00
|
|
|
|
2007-04-20 03:29:13 +00:00
|
|
|
nlh->nlmsg_len = skb_tail_pointer(skb) - b;
|
2005-04-16 22:20:36 +00:00
|
|
|
return skb->len;
|
|
|
|
|
2012-06-27 04:39:32 +00:00
|
|
|
out_nlmsg_trim:
|
2007-03-26 06:06:12 +00:00
|
|
|
nlmsg_trim(skb, b);
|
2005-04-16 22:20:36 +00:00
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2017-07-13 17:12:18 +00:00
|
|
|
tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
|
2018-07-05 14:24:33 +00:00
|
|
|
struct tc_action *actions[], int event,
|
2018-02-15 15:54:55 +00:00
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
|
|
|
skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
|
|
|
|
if (!skb)
|
|
|
|
return -ENOBUFS;
|
2016-06-05 14:41:32 +00:00
|
|
|
if (tca_get_fill(skb, actions, portid, n->nlmsg_seq, 0, event,
|
2018-07-05 14:24:26 +00:00
|
|
|
0, 1) <= 0) {
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Failed to fill netlink attributes while adding TC action");
|
2005-04-16 22:20:36 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2006-08-15 07:30:25 +00:00
|
|
|
|
2012-09-07 20:12:54 +00:00
|
|
|
return rtnl_unicast(skb, net, portid);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-02-22 23:57:53 +00:00
|
|
|
static struct tc_action *tcf_action_get_1(struct net *net, struct nlattr *nla,
|
2018-02-15 15:54:55 +00:00
|
|
|
struct nlmsghdr *n, u32 portid,
|
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX + 1];
|
2016-07-25 23:09:41 +00:00
|
|
|
const struct tc_action_ops *ops;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct tc_action *a;
|
|
|
|
int index;
|
2008-01-24 04:33:13 +00:00
|
|
|
int err;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
err = nla_parse_nested(tb, TCA_ACT_MAX, nla, NULL, extack);
|
2008-01-24 04:33:32 +00:00
|
|
|
if (err < 0)
|
2008-01-24 04:33:13 +00:00
|
|
|
goto err_out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:33:32 +00:00
|
|
|
err = -EINVAL;
|
2008-01-23 06:11:50 +00:00
|
|
|
if (tb[TCA_ACT_INDEX] == NULL ||
|
2018-02-15 15:54:55 +00:00
|
|
|
nla_len(tb[TCA_ACT_INDEX]) < sizeof(index)) {
|
|
|
|
NL_SET_ERR_MSG(extack, "Invalid TC action index value");
|
2008-01-24 04:33:13 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2008-01-24 04:35:03 +00:00
|
|
|
index = nla_get_u32(tb[TCA_ACT_INDEX]);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:33:13 +00:00
|
|
|
err = -EINVAL;
|
2016-07-25 23:09:41 +00:00
|
|
|
ops = tc_lookup_action(tb[TCA_ACT_KIND]);
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!ops) { /* could happen in batch of actions */
|
2018-08-29 17:15:35 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Specified TC action kind not found");
|
2016-07-25 23:09:41 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2008-01-24 04:33:13 +00:00
|
|
|
err = -ENOENT;
|
2018-08-29 17:15:35 +00:00
|
|
|
if (ops->lookup(net, &a, index) == 0) {
|
|
|
|
NL_SET_ERR_MSG(extack, "TC action with specified index not found");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_mod;
|
2018-08-29 17:15:35 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-07-25 23:09:41 +00:00
|
|
|
module_put(ops->owner);
|
2005-04-16 22:20:36 +00:00
|
|
|
return a;
|
2008-01-24 04:33:13 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
err_mod:
|
2016-07-25 23:09:41 +00:00
|
|
|
module_put(ops->owner);
|
2008-01-24 04:33:13 +00:00
|
|
|
err_out:
|
|
|
|
return ERR_PTR(err);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-03-19 15:40:13 +00:00
|
|
|
static int tca_action_flush(struct net *net, struct nlattr *nla,
|
2018-02-15 15:54:55 +00:00
|
|
|
struct nlmsghdr *n, u32 portid,
|
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
|
|
|
unsigned char *b;
|
|
|
|
struct nlmsghdr *nlh;
|
|
|
|
struct tcamsg *t;
|
|
|
|
struct netlink_callback dcb;
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX + 1];
|
2016-07-25 23:09:41 +00:00
|
|
|
const struct tc_action_ops *ops;
|
2008-01-23 06:11:50 +00:00
|
|
|
struct nlattr *kind;
|
2008-08-13 09:41:45 +00:00
|
|
|
int err = -ENOMEM;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!skb)
|
2008-08-13 09:41:45 +00:00
|
|
|
return err;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-04-20 03:29:13 +00:00
|
|
|
b = skb_tail_pointer(skb);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
err = nla_parse_nested(tb, TCA_ACT_MAX, nla, NULL, extack);
|
2008-01-24 04:33:32 +00:00
|
|
|
if (err < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
|
|
|
|
2008-01-24 04:33:32 +00:00
|
|
|
err = -EINVAL;
|
2008-01-23 06:11:50 +00:00
|
|
|
kind = tb[TCA_ACT_KIND];
|
2016-07-25 23:09:41 +00:00
|
|
|
ops = tc_lookup_action(kind);
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!ops) { /*some idjot trying to flush unknown action */
|
|
|
|
NL_SET_ERR_MSG(extack, "Cannot flush unknown TC action");
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err_out;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2016-06-05 14:41:32 +00:00
|
|
|
nlh = nlmsg_put(skb, portid, n->nlmsg_seq, RTM_DELACTION,
|
|
|
|
sizeof(*t), 0);
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!nlh) {
|
|
|
|
NL_SET_ERR_MSG(extack, "Failed to create TC action flush notification");
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_module_put;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2012-06-27 04:39:32 +00:00
|
|
|
t = nlmsg_data(nlh);
|
2005-04-16 22:20:36 +00:00
|
|
|
t->tca_family = AF_UNSPEC;
|
2005-06-28 19:55:30 +00:00
|
|
|
t->tca__pad1 = 0;
|
|
|
|
t->tca__pad2 = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nest = nla_nest_start(skb, TCA_ACT_TAB);
|
2018-02-15 15:54:55 +00:00
|
|
|
if (!nest) {
|
|
|
|
NL_SET_ERR_MSG(extack, "Failed to add new netlink message");
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_module_put;
|
2018-02-15 15:54:55 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-15 15:54:58 +00:00
|
|
|
err = ops->walk(net, skb, &dcb, RTM_DELACTION, ops, extack);
|
2018-02-15 14:50:57 +00:00
|
|
|
if (err <= 0) {
|
|
|
|
nla_nest_cancel(skb, nest);
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_module_put;
|
2018-02-15 14:50:57 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-04-20 03:29:13 +00:00
|
|
|
nlh->nlmsg_len = skb_tail_pointer(skb) - b;
|
2005-04-16 22:20:36 +00:00
|
|
|
nlh->nlmsg_flags |= NLM_F_ROOT;
|
2016-07-25 23:09:41 +00:00
|
|
|
module_put(ops->owner);
|
2012-09-07 20:12:54 +00:00
|
|
|
err = rtnetlink_send(skb, net, portid, RTNLGRP_TC,
|
2011-01-19 19:26:56 +00:00
|
|
|
n->nlmsg_flags & NLM_F_ECHO);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (err > 0)
|
|
|
|
return 0;
|
2018-02-15 15:54:55 +00:00
|
|
|
if (err < 0)
|
|
|
|
NL_SET_ERR_MSG(extack, "Failed to send TC action flush notification");
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return err;
|
|
|
|
|
2012-06-27 04:39:32 +00:00
|
|
|
out_module_put:
|
2016-07-25 23:09:41 +00:00
|
|
|
module_put(ops->owner);
|
2005-04-16 22:20:36 +00:00
|
|
|
err_out:
|
|
|
|
kfree_skb(skb);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2018-08-19 19:22:07 +00:00
|
|
|
static int tcf_action_delete(struct net *net, struct tc_action *actions[])
|
2018-07-05 14:24:29 +00:00
|
|
|
{
|
2018-08-19 19:22:06 +00:00
|
|
|
int i;
|
2018-07-05 14:24:29 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
for (i = 0; i < TCA_ACT_MAX_PRIO && actions[i]; i++) {
|
|
|
|
struct tc_action *a = actions[i];
|
2018-07-05 14:24:29 +00:00
|
|
|
const struct tc_action_ops *ops = a->ops;
|
|
|
|
/* Actions can be deleted concurrently so we must save their
|
|
|
|
* type and id to search again after reference is released.
|
|
|
|
*/
|
2018-08-19 19:22:06 +00:00
|
|
|
struct tcf_idrinfo *idrinfo = a->idrinfo;
|
|
|
|
u32 act_index = a->tcfa_index;
|
2018-07-05 14:24:29 +00:00
|
|
|
|
2018-09-03 07:04:55 +00:00
|
|
|
actions[i] = NULL;
|
2018-07-05 14:24:29 +00:00
|
|
|
if (tcf_action_put(a)) {
|
|
|
|
/* last reference, action was deleted concurrently */
|
|
|
|
module_put(ops->owner);
|
|
|
|
} else {
|
2018-08-19 19:22:06 +00:00
|
|
|
int ret;
|
|
|
|
|
2018-07-05 14:24:29 +00:00
|
|
|
/* now do the delete */
|
2018-08-19 19:22:06 +00:00
|
|
|
ret = tcf_idr_delete_index(idrinfo, act_index);
|
2018-08-19 19:22:05 +00:00
|
|
|
if (ret < 0)
|
2018-07-05 14:24:29 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-01-10 00:14:00 +00:00
|
|
|
static int
|
2018-07-05 14:24:33 +00:00
|
|
|
tcf_del_notify(struct net *net, struct nlmsghdr *n, struct tc_action *actions[],
|
2018-08-19 19:22:05 +00:00
|
|
|
u32 portid, size_t attr_size, struct netlink_ext_ack *extack)
|
2014-01-10 00:14:00 +00:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
struct sk_buff *skb;
|
|
|
|
|
2018-03-08 21:59:17 +00:00
|
|
|
skb = alloc_skb(attr_size <= NLMSG_GOODSIZE ? NLMSG_GOODSIZE : attr_size,
|
|
|
|
GFP_KERNEL);
|
2014-01-10 00:14:00 +00:00
|
|
|
if (!skb)
|
|
|
|
return -ENOBUFS;
|
|
|
|
|
|
|
|
if (tca_get_fill(skb, actions, portid, n->nlmsg_seq, 0, RTM_DELACTION,
|
2018-07-05 14:24:26 +00:00
|
|
|
0, 2) <= 0) {
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Failed to fill netlink TC action attributes");
|
2014-01-10 00:14:00 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* now do the delete */
|
2018-08-19 19:22:07 +00:00
|
|
|
ret = tcf_action_delete(net, actions);
|
2014-02-12 01:07:34 +00:00
|
|
|
if (ret < 0) {
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Failed to delete TC action");
|
2014-02-12 01:07:34 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
return ret;
|
|
|
|
}
|
2014-01-10 00:14:00 +00:00
|
|
|
|
|
|
|
ret = rtnetlink_send(skb, net, portid, RTNLGRP_TC,
|
|
|
|
n->nlmsg_flags & NLM_F_ECHO);
|
|
|
|
if (ret > 0)
|
|
|
|
return 0;
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static int
|
2010-03-19 15:40:13 +00:00
|
|
|
tca_action_gd(struct net *net, struct nlattr *nla, struct nlmsghdr *n,
|
2018-02-15 15:54:55 +00:00
|
|
|
u32 portid, int event, struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-01-24 04:33:32 +00:00
|
|
|
int i, ret;
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX_PRIO + 1];
|
2013-12-16 04:15:05 +00:00
|
|
|
struct tc_action *act;
|
2018-03-08 21:59:17 +00:00
|
|
|
size_t attr_size = 0;
|
2018-08-19 19:22:05 +00:00
|
|
|
struct tc_action *actions[TCA_ACT_MAX_PRIO] = {};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
ret = nla_parse_nested(tb, TCA_ACT_MAX_PRIO, nla, NULL, extack);
|
2008-01-24 04:33:32 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2011-01-19 19:26:56 +00:00
|
|
|
if (event == RTM_DELACTION && n->nlmsg_flags & NLM_F_ROOT) {
|
2018-02-15 15:54:53 +00:00
|
|
|
if (tb[1])
|
2018-02-15 15:54:55 +00:00
|
|
|
return tca_action_flush(net, tb[1], n, portid, extack);
|
2018-02-15 15:54:53 +00:00
|
|
|
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Invalid netlink attributes while flushing TC action");
|
2018-02-15 15:54:53 +00:00
|
|
|
return -EINVAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
for (i = 1; i <= TCA_ACT_MAX_PRIO && tb[i]; i++) {
|
2018-02-15 15:54:55 +00:00
|
|
|
act = tcf_action_get_1(net, tb[i], n, portid, extack);
|
2008-01-24 04:33:13 +00:00
|
|
|
if (IS_ERR(act)) {
|
|
|
|
ret = PTR_ERR(act);
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err;
|
2008-01-24 04:33:13 +00:00
|
|
|
}
|
2008-01-23 06:11:50 +00:00
|
|
|
act->order = i;
|
2018-03-08 21:59:19 +00:00
|
|
|
attr_size += tcf_action_fill_size(act);
|
2018-07-05 14:24:33 +00:00
|
|
|
actions[i - 1] = act;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2018-03-08 21:59:19 +00:00
|
|
|
|
|
|
|
attr_size = tcf_action_full_attrs_size(attr_size);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (event == RTM_GETACTION)
|
2018-07-05 14:24:33 +00:00
|
|
|
ret = tcf_get_notify(net, portid, n, actions, event, extack);
|
2005-04-16 22:20:36 +00:00
|
|
|
else { /* delete */
|
2018-08-19 19:22:05 +00:00
|
|
|
ret = tcf_del_notify(net, n, actions, portid, attr_size, extack);
|
2014-01-10 00:14:00 +00:00
|
|
|
if (ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto err;
|
2018-08-19 19:22:05 +00:00
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
err:
|
2018-08-19 19:22:05 +00:00
|
|
|
tcf_action_put_many(actions);
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-01-10 00:14:00 +00:00
|
|
|
static int
|
2018-07-05 14:24:33 +00:00
|
|
|
tcf_add_notify(struct net *net, struct nlmsghdr *n, struct tc_action *actions[],
|
2018-03-08 21:59:17 +00:00
|
|
|
u32 portid, size_t attr_size, struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct sk_buff *skb;
|
|
|
|
int err = 0;
|
|
|
|
|
2018-03-08 21:59:17 +00:00
|
|
|
skb = alloc_skb(attr_size <= NLMSG_GOODSIZE ? NLMSG_GOODSIZE : attr_size,
|
|
|
|
GFP_KERNEL);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (!skb)
|
|
|
|
return -ENOBUFS;
|
|
|
|
|
2014-01-10 00:14:00 +00:00
|
|
|
if (tca_get_fill(skb, actions, portid, n->nlmsg_seq, n->nlmsg_flags,
|
|
|
|
RTM_NEWACTION, 0, 0) <= 0) {
|
2018-03-03 01:52:01 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Failed to fill netlink attributes while adding TC action");
|
2014-01-10 00:14:00 +00:00
|
|
|
kfree_skb(skb);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2007-02-09 14:25:16 +00:00
|
|
|
|
2014-01-10 00:14:00 +00:00
|
|
|
err = rtnetlink_send(skb, net, portid, RTNLGRP_TC,
|
|
|
|
n->nlmsg_flags & NLM_F_ECHO);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (err > 0)
|
|
|
|
err = 0;
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2016-09-18 12:45:33 +00:00
|
|
|
static int tcf_action_add(struct net *net, struct nlattr *nla,
|
2018-02-15 15:54:54 +00:00
|
|
|
struct nlmsghdr *n, u32 portid, int ovr,
|
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2018-03-08 21:59:17 +00:00
|
|
|
size_t attr_size = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
int ret = 0;
|
2018-07-05 14:24:33 +00:00
|
|
|
struct tc_action *actions[TCA_ACT_MAX_PRIO] = {};
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:33 +00:00
|
|
|
ret = tcf_action_init(net, NULL, nla, NULL, NULL, ovr, 0, actions,
|
2018-07-05 14:24:25 +00:00
|
|
|
&attr_size, true, extack);
|
2018-07-05 14:24:33 +00:00
|
|
|
if (ret < 0)
|
2016-08-14 05:34:56 +00:00
|
|
|
return ret;
|
2018-07-05 14:24:33 +00:00
|
|
|
ret = tcf_add_notify(net, n, actions, portid, attr_size, extack);
|
2018-07-05 14:24:31 +00:00
|
|
|
if (ovr)
|
2018-07-05 14:24:33 +00:00
|
|
|
tcf_action_put_many(actions);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-07-05 14:24:31 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-07-30 17:24:51 +00:00
|
|
|
static u32 tcaa_root_flags_allowed = TCA_FLAG_LARGE_DUMP_ON;
|
|
|
|
static const struct nla_policy tcaa_policy[TCA_ROOT_MAX + 1] = {
|
|
|
|
[TCA_ROOT_FLAGS] = { .type = NLA_BITFIELD32,
|
|
|
|
.validation_data = &tcaa_root_flags_allowed },
|
2017-07-30 17:24:52 +00:00
|
|
|
[TCA_ROOT_TIME_DELTA] = { .type = NLA_U32 },
|
2017-07-30 17:24:51 +00:00
|
|
|
};
|
|
|
|
|
2017-04-16 16:48:24 +00:00
|
|
|
static int tc_ctl_action(struct sk_buff *skb, struct nlmsghdr *n,
|
|
|
|
struct netlink_ext_ack *extack)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-03-25 17:26:21 +00:00
|
|
|
struct net *net = sock_net(skb->sk);
|
2017-07-30 17:24:51 +00:00
|
|
|
struct nlattr *tca[TCA_ROOT_MAX + 1];
|
2012-09-07 20:12:54 +00:00
|
|
|
u32 portid = skb ? NETLINK_CB(skb).portid : 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
int ret = 0, ovr = 0;
|
|
|
|
|
2016-06-05 14:41:32 +00:00
|
|
|
if ((n->nlmsg_type != RTM_GETACTION) &&
|
|
|
|
!netlink_capable(skb, CAP_NET_ADMIN))
|
2012-11-16 03:03:00 +00:00
|
|
|
return -EPERM;
|
|
|
|
|
2017-07-30 17:24:51 +00:00
|
|
|
ret = nlmsg_parse(n, sizeof(struct tcamsg), tca, TCA_ROOT_MAX, NULL,
|
2017-04-16 16:48:24 +00:00
|
|
|
extack);
|
2008-01-23 06:11:50 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (tca[TCA_ACT_TAB] == NULL) {
|
2018-02-15 15:54:55 +00:00
|
|
|
NL_SET_ERR_MSG(extack, "Netlink action attributes missing");
|
2005-04-16 22:20:36 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2011-01-19 19:26:56 +00:00
|
|
|
/* n->nlmsg_flags & NLM_F_CREATE */
|
2005-04-16 22:20:36 +00:00
|
|
|
switch (n->nlmsg_type) {
|
|
|
|
case RTM_NEWACTION:
|
|
|
|
/* we are going to assume all other flags
|
2011-03-31 01:57:33 +00:00
|
|
|
* imply create only if it doesn't exist
|
2005-04-16 22:20:36 +00:00
|
|
|
* Note that CREATE | EXCL implies that
|
|
|
|
* but since we want avoid ambiguity (eg when flags
|
|
|
|
* is zero) then just set this
|
|
|
|
*/
|
2011-01-19 19:26:56 +00:00
|
|
|
if (n->nlmsg_flags & NLM_F_REPLACE)
|
2005-04-16 22:20:36 +00:00
|
|
|
ovr = 1;
|
|
|
|
replay:
|
2018-02-15 15:54:54 +00:00
|
|
|
ret = tcf_action_add(net, tca[TCA_ACT_TAB], n, portid, ovr,
|
|
|
|
extack);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (ret == -EAGAIN)
|
|
|
|
goto replay;
|
|
|
|
break;
|
|
|
|
case RTM_DELACTION:
|
2010-03-19 15:40:13 +00:00
|
|
|
ret = tca_action_gd(net, tca[TCA_ACT_TAB], n,
|
2018-02-15 15:54:55 +00:00
|
|
|
portid, RTM_DELACTION, extack);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case RTM_GETACTION:
|
2010-03-19 15:40:13 +00:00
|
|
|
ret = tca_action_gd(net, tca[TCA_ACT_TAB], n,
|
2018-02-15 15:54:55 +00:00
|
|
|
portid, RTM_GETACTION, extack);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
BUG();
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-07-30 17:24:51 +00:00
|
|
|
static struct nlattr *find_dump_kind(struct nlattr **nla)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2011-01-19 19:26:56 +00:00
|
|
|
struct nlattr *tb1, *tb2[TCA_ACT_MAX + 1];
|
2008-01-23 06:11:50 +00:00
|
|
|
struct nlattr *tb[TCA_ACT_MAX_PRIO + 1];
|
|
|
|
struct nlattr *kind;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
tb1 = nla[TCA_ACT_TAB];
|
2005-04-16 22:20:36 +00:00
|
|
|
if (tb1 == NULL)
|
|
|
|
return NULL;
|
|
|
|
|
2008-01-23 06:11:50 +00:00
|
|
|
if (nla_parse(tb, TCA_ACT_MAX_PRIO, nla_data(tb1),
|
2017-04-12 12:34:07 +00:00
|
|
|
NLMSG_ALIGN(nla_len(tb1)), NULL, NULL) < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
return NULL;
|
|
|
|
|
2008-01-24 04:32:42 +00:00
|
|
|
if (tb[1] == NULL)
|
|
|
|
return NULL;
|
2017-04-12 12:34:07 +00:00
|
|
|
if (nla_parse_nested(tb2, TCA_ACT_MAX, tb[1], NULL, NULL) < 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
return NULL;
|
2008-01-23 06:11:50 +00:00
|
|
|
kind = tb2[TCA_ACT_KIND];
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-07-06 03:45:06 +00:00
|
|
|
return kind;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2016-09-18 12:45:33 +00:00
|
|
|
static int tc_dump_action(struct sk_buff *skb, struct netlink_callback *cb)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2016-02-22 23:57:53 +00:00
|
|
|
struct net *net = sock_net(skb->sk);
|
2005-04-16 22:20:36 +00:00
|
|
|
struct nlmsghdr *nlh;
|
2007-04-20 03:29:13 +00:00
|
|
|
unsigned char *b = skb_tail_pointer(skb);
|
2008-01-24 04:34:11 +00:00
|
|
|
struct nlattr *nest;
|
2005-04-16 22:20:36 +00:00
|
|
|
struct tc_action_ops *a_o;
|
|
|
|
int ret = 0;
|
2012-06-27 04:39:32 +00:00
|
|
|
struct tcamsg *t = (struct tcamsg *) nlmsg_data(cb->nlh);
|
2017-07-30 17:24:51 +00:00
|
|
|
struct nlattr *tb[TCA_ROOT_MAX + 1];
|
|
|
|
struct nlattr *count_attr = NULL;
|
2017-07-30 17:24:52 +00:00
|
|
|
unsigned long jiffy_since = 0;
|
2017-07-30 17:24:51 +00:00
|
|
|
struct nlattr *kind = NULL;
|
|
|
|
struct nla_bitfield32 bf;
|
2017-07-30 17:24:52 +00:00
|
|
|
u32 msecs_since = 0;
|
2017-07-30 17:24:51 +00:00
|
|
|
u32 act_count = 0;
|
|
|
|
|
|
|
|
ret = nlmsg_parse(cb->nlh, sizeof(struct tcamsg), tb, TCA_ROOT_MAX,
|
2018-10-08 03:16:24 +00:00
|
|
|
tcaa_policy, cb->extack);
|
2017-07-30 17:24:51 +00:00
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2017-07-30 17:24:51 +00:00
|
|
|
kind = find_dump_kind(tb);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (kind == NULL) {
|
2010-05-12 06:37:05 +00:00
|
|
|
pr_info("tc_dump_action: action bad kind\n");
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-07-06 03:45:06 +00:00
|
|
|
a_o = tc_lookup_action(kind);
|
2011-01-19 19:26:56 +00:00
|
|
|
if (a_o == NULL)
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
|
2017-07-30 17:24:51 +00:00
|
|
|
cb->args[2] = 0;
|
|
|
|
if (tb[TCA_ROOT_FLAGS]) {
|
|
|
|
bf = nla_get_bitfield32(tb[TCA_ROOT_FLAGS]);
|
|
|
|
cb->args[2] = bf.value;
|
|
|
|
}
|
|
|
|
|
2017-07-30 17:24:52 +00:00
|
|
|
if (tb[TCA_ROOT_TIME_DELTA]) {
|
|
|
|
msecs_since = nla_get_u32(tb[TCA_ROOT_TIME_DELTA]);
|
|
|
|
}
|
|
|
|
|
2012-09-07 20:12:54 +00:00
|
|
|
nlh = nlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,
|
2012-06-27 04:39:32 +00:00
|
|
|
cb->nlh->nlmsg_type, sizeof(*t), 0);
|
|
|
|
if (!nlh)
|
|
|
|
goto out_module_put;
|
2017-07-30 17:24:51 +00:00
|
|
|
|
2017-07-30 17:24:52 +00:00
|
|
|
if (msecs_since)
|
|
|
|
jiffy_since = jiffies - msecs_to_jiffies(msecs_since);
|
|
|
|
|
2012-06-27 04:39:32 +00:00
|
|
|
t = nlmsg_data(nlh);
|
2005-04-16 22:20:36 +00:00
|
|
|
t->tca_family = AF_UNSPEC;
|
2005-06-28 19:55:30 +00:00
|
|
|
t->tca__pad1 = 0;
|
|
|
|
t->tca__pad2 = 0;
|
2017-07-30 17:24:52 +00:00
|
|
|
cb->args[3] = jiffy_since;
|
2017-07-30 17:24:51 +00:00
|
|
|
count_attr = nla_reserve(skb, TCA_ROOT_COUNT, sizeof(u32));
|
|
|
|
if (!count_attr)
|
|
|
|
goto out_module_put;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-01-24 04:34:11 +00:00
|
|
|
nest = nla_nest_start(skb, TCA_ACT_TAB);
|
|
|
|
if (nest == NULL)
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_module_put;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2018-02-15 15:54:58 +00:00
|
|
|
ret = a_o->walk(net, skb, cb, RTM_GETACTION, a_o, NULL);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (ret < 0)
|
2012-06-27 04:39:32 +00:00
|
|
|
goto out_module_put;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (ret > 0) {
|
2008-01-24 04:34:11 +00:00
|
|
|
nla_nest_end(skb, nest);
|
2005-04-16 22:20:36 +00:00
|
|
|
ret = skb->len;
|
2017-07-30 17:24:51 +00:00
|
|
|
act_count = cb->args[1];
|
|
|
|
memcpy(nla_data(count_attr), &act_count, sizeof(u32));
|
|
|
|
cb->args[1] = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
} else
|
2016-06-13 22:08:42 +00:00
|
|
|
nlmsg_trim(skb, b);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-04-20 03:29:13 +00:00
|
|
|
nlh->nlmsg_len = skb_tail_pointer(skb) - b;
|
2012-09-07 20:12:54 +00:00
|
|
|
if (NETLINK_CB(cb->skb).portid && ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
nlh->nlmsg_flags |= NLM_F_MULTI;
|
|
|
|
module_put(a_o->owner);
|
|
|
|
return skb->len;
|
|
|
|
|
2012-06-27 04:39:32 +00:00
|
|
|
out_module_put:
|
2005-04-16 22:20:36 +00:00
|
|
|
module_put(a_o->owner);
|
2007-03-26 06:06:12 +00:00
|
|
|
nlmsg_trim(skb, b);
|
2005-04-16 22:20:36 +00:00
|
|
|
return skb->len;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __init tc_action_init(void)
|
|
|
|
{
|
2017-08-09 18:41:48 +00:00
|
|
|
rtnl_register(PF_UNSPEC, RTM_NEWACTION, tc_ctl_action, NULL, 0);
|
|
|
|
rtnl_register(PF_UNSPEC, RTM_DELACTION, tc_ctl_action, NULL, 0);
|
2011-06-10 01:27:09 +00:00
|
|
|
rtnl_register(PF_UNSPEC, RTM_GETACTION, tc_ctl_action, tc_dump_action,
|
2017-08-09 18:41:48 +00:00
|
|
|
0);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
subsys_initcall(tc_action_init);
|