2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Driver for AMBA serial ports
|
|
|
|
*
|
|
|
|
* Based on drivers/char/serial.c, by Linus Torvalds, Theodore Ts'o.
|
|
|
|
*
|
|
|
|
* Copyright 1999 ARM Limited
|
|
|
|
* Copyright (C) 2000 Deep Blue Solutions Ltd.
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
* Copyright (C) 2010 ST-Ericsson SA
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
*
|
|
|
|
* This is a generic driver for ARM AMBA-type serial ports. They
|
|
|
|
* have a lot of 16550-like features, but are not register compatible.
|
|
|
|
* Note that although they do have CTS, DCD and DSR inputs, they do
|
|
|
|
* not have an RI input, nor do they have DTR or RTS outputs. If
|
|
|
|
* required, these have to be supplied via some other means (eg, GPIO)
|
|
|
|
* and hooked into this driver.
|
|
|
|
*/
|
|
|
|
|
2013-03-27 09:38:11 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#if defined(CONFIG_SERIAL_AMBA_PL011_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
|
|
|
|
#define SUPPORT_SYSRQ
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/ioport.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/console.h>
|
|
|
|
#include <linux/sysrq.h>
|
|
|
|
#include <linux/device.h>
|
|
|
|
#include <linux/tty.h>
|
|
|
|
#include <linux/tty_flip.h>
|
|
|
|
#include <linux/serial_core.h>
|
|
|
|
#include <linux/serial.h>
|
2006-01-07 13:52:45 +00:00
|
|
|
#include <linux/amba/bus.h>
|
|
|
|
#include <linux/amba/serial.h>
|
2006-01-07 16:15:52 +00:00
|
|
|
#include <linux/clk.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
#include <linux/dmaengine.h>
|
|
|
|
#include <linux/dma-mapping.h>
|
|
|
|
#include <linux/scatterlist.h>
|
2011-06-13 08:11:33 +00:00
|
|
|
#include <linux/delay.h>
|
2012-02-01 10:42:19 +00:00
|
|
|
#include <linux/types.h>
|
2012-08-28 15:41:28 +00:00
|
|
|
#include <linux/of.h>
|
|
|
|
#include <linux/of_device.h>
|
2012-05-06 14:53:35 +00:00
|
|
|
#include <linux/pinctrl/consumer.h>
|
2012-06-24 11:46:37 +00:00
|
|
|
#include <linux/sizes.h>
|
2012-10-15 11:36:01 +00:00
|
|
|
#include <linux/io.h>
|
2015-05-21 16:26:24 +00:00
|
|
|
#include <linux/acpi.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
#include "amba-pl011.h"
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#define UART_NR 14
|
|
|
|
|
|
|
|
#define SERIAL_AMBA_MAJOR 204
|
|
|
|
#define SERIAL_AMBA_MINOR 64
|
|
|
|
#define SERIAL_AMBA_NR UART_NR
|
|
|
|
|
|
|
|
#define AMBA_ISR_PASS_LIMIT 256
|
|
|
|
|
2005-11-19 11:10:35 +00:00
|
|
|
#define UART_DR_ERROR (UART011_DR_OE|UART011_DR_BE|UART011_DR_PE|UART011_DR_FE)
|
|
|
|
#define UART_DUMMY_DR_RX (1 << 16)
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-11-16 17:40:26 +00:00
|
|
|
static u16 pl011_std_offsets[REG_ARRAY_SIZE] = {
|
|
|
|
[REG_DR] = UART01x_DR,
|
|
|
|
[REG_FR] = UART01x_FR,
|
2015-11-16 17:40:41 +00:00
|
|
|
[REG_LCRH_RX] = UART011_LCRH,
|
|
|
|
[REG_LCRH_TX] = UART011_LCRH,
|
2015-11-16 17:40:26 +00:00
|
|
|
[REG_IBRD] = UART011_IBRD,
|
|
|
|
[REG_FBRD] = UART011_FBRD,
|
|
|
|
[REG_CR] = UART011_CR,
|
|
|
|
[REG_IFLS] = UART011_IFLS,
|
|
|
|
[REG_IMSC] = UART011_IMSC,
|
|
|
|
[REG_RIS] = UART011_RIS,
|
|
|
|
[REG_MIS] = UART011_MIS,
|
|
|
|
[REG_ICR] = UART011_ICR,
|
|
|
|
[REG_DMACR] = UART011_DMACR,
|
|
|
|
};
|
|
|
|
|
2009-06-04 16:43:04 +00:00
|
|
|
/* There is by now at least one vendor with differing details, so handle it */
|
|
|
|
struct vendor_data {
|
2015-11-16 17:40:31 +00:00
|
|
|
const u16 *reg_offset;
|
2009-06-04 16:43:04 +00:00
|
|
|
unsigned int ifls;
|
2016-07-08 09:00:39 +00:00
|
|
|
unsigned int fr_busy;
|
|
|
|
unsigned int fr_dsr;
|
|
|
|
unsigned int fr_cts;
|
|
|
|
unsigned int fr_ri;
|
2017-02-15 21:39:43 +00:00
|
|
|
unsigned int inv_fr;
|
2015-11-16 17:40:52 +00:00
|
|
|
bool access_32b;
|
2010-06-02 19:40:22 +00:00
|
|
|
bool oversampling;
|
2010-12-22 17:59:16 +00:00
|
|
|
bool dma_threshold;
|
2012-03-26 09:17:02 +00:00
|
|
|
bool cts_event_workaround;
|
2015-05-21 16:26:21 +00:00
|
|
|
bool always_enabled;
|
2015-05-21 16:26:22 +00:00
|
|
|
bool fixed_options;
|
2013-04-15 05:45:25 +00:00
|
|
|
|
2013-05-10 09:05:35 +00:00
|
|
|
unsigned int (*get_fifosize)(struct amba_device *dev);
|
2009-06-04 16:43:04 +00:00
|
|
|
};
|
|
|
|
|
2013-05-10 09:05:35 +00:00
|
|
|
static unsigned int get_fifosize_arm(struct amba_device *dev)
|
2013-04-15 05:45:25 +00:00
|
|
|
{
|
2013-05-10 09:05:35 +00:00
|
|
|
return amba_rev(dev) < 3 ? 16 : 32;
|
2013-04-15 05:45:25 +00:00
|
|
|
}
|
|
|
|
|
2009-06-04 16:43:04 +00:00
|
|
|
static struct vendor_data vendor_arm = {
|
2015-11-16 17:40:31 +00:00
|
|
|
.reg_offset = pl011_std_offsets,
|
2009-06-04 16:43:04 +00:00
|
|
|
.ifls = UART011_IFLS_RX4_8|UART011_IFLS_TX4_8,
|
2016-07-08 09:00:39 +00:00
|
|
|
.fr_busy = UART01x_FR_BUSY,
|
|
|
|
.fr_dsr = UART01x_FR_DSR,
|
|
|
|
.fr_cts = UART01x_FR_CTS,
|
|
|
|
.fr_ri = UART011_FR_RI,
|
2010-06-02 19:40:22 +00:00
|
|
|
.oversampling = false,
|
2010-12-22 17:59:16 +00:00
|
|
|
.dma_threshold = false,
|
2012-03-26 09:17:02 +00:00
|
|
|
.cts_event_workaround = false,
|
2015-05-21 16:26:21 +00:00
|
|
|
.always_enabled = false,
|
2015-05-21 16:26:22 +00:00
|
|
|
.fixed_options = false,
|
2013-04-15 05:45:25 +00:00
|
|
|
.get_fifosize = get_fifosize_arm,
|
2009-06-04 16:43:04 +00:00
|
|
|
};
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static struct vendor_data vendor_sbsa = {
|
2015-11-16 17:40:31 +00:00
|
|
|
.reg_offset = pl011_std_offsets,
|
2016-07-08 09:00:39 +00:00
|
|
|
.fr_busy = UART01x_FR_BUSY,
|
|
|
|
.fr_dsr = UART01x_FR_DSR,
|
|
|
|
.fr_cts = UART01x_FR_CTS,
|
|
|
|
.fr_ri = UART011_FR_RI,
|
2016-04-01 21:23:58 +00:00
|
|
|
.access_32b = true,
|
2015-05-21 16:26:23 +00:00
|
|
|
.oversampling = false,
|
|
|
|
.dma_threshold = false,
|
|
|
|
.cts_event_workaround = false,
|
|
|
|
.always_enabled = true,
|
|
|
|
.fixed_options = true,
|
|
|
|
};
|
|
|
|
|
2017-02-15 21:39:43 +00:00
|
|
|
/*
|
|
|
|
* Erratum 44 for QDF2432v1 and QDF2400v1 SoCs describes the BUSY bit as
|
|
|
|
* occasionally getting stuck as 1. To avoid the potential for a hang, check
|
|
|
|
* TXFE == 0 instead of BUSY == 1. This may not be suitable for all UART
|
|
|
|
* implementations, so only do so if an affected platform is detected in
|
|
|
|
* parse_spcr().
|
|
|
|
*/
|
|
|
|
static bool qdf2400_e44_present = false;
|
|
|
|
|
|
|
|
static struct vendor_data vendor_qdt_qdf2400_e44 = {
|
|
|
|
.reg_offset = pl011_std_offsets,
|
|
|
|
.fr_busy = UART011_FR_TXFE,
|
|
|
|
.fr_dsr = UART01x_FR_DSR,
|
|
|
|
.fr_cts = UART01x_FR_CTS,
|
|
|
|
.fr_ri = UART011_FR_RI,
|
|
|
|
.inv_fr = UART011_FR_TXFE,
|
|
|
|
.access_32b = true,
|
|
|
|
.oversampling = false,
|
|
|
|
.dma_threshold = false,
|
|
|
|
.cts_event_workaround = false,
|
|
|
|
.always_enabled = true,
|
|
|
|
.fixed_options = true,
|
|
|
|
};
|
|
|
|
|
2015-11-16 17:40:36 +00:00
|
|
|
static u16 pl011_st_offsets[REG_ARRAY_SIZE] = {
|
|
|
|
[REG_DR] = UART01x_DR,
|
|
|
|
[REG_ST_DMAWM] = ST_UART011_DMAWM,
|
|
|
|
[REG_ST_TIMEOUT] = ST_UART011_TIMEOUT,
|
|
|
|
[REG_FR] = UART01x_FR,
|
2015-11-16 17:40:41 +00:00
|
|
|
[REG_LCRH_RX] = ST_UART011_LCRH_RX,
|
|
|
|
[REG_LCRH_TX] = ST_UART011_LCRH_TX,
|
2015-11-16 17:40:36 +00:00
|
|
|
[REG_IBRD] = UART011_IBRD,
|
|
|
|
[REG_FBRD] = UART011_FBRD,
|
|
|
|
[REG_CR] = UART011_CR,
|
|
|
|
[REG_IFLS] = UART011_IFLS,
|
|
|
|
[REG_IMSC] = UART011_IMSC,
|
|
|
|
[REG_RIS] = UART011_RIS,
|
|
|
|
[REG_MIS] = UART011_MIS,
|
|
|
|
[REG_ICR] = UART011_ICR,
|
|
|
|
[REG_DMACR] = UART011_DMACR,
|
|
|
|
[REG_ST_XFCR] = ST_UART011_XFCR,
|
|
|
|
[REG_ST_XON1] = ST_UART011_XON1,
|
|
|
|
[REG_ST_XON2] = ST_UART011_XON2,
|
|
|
|
[REG_ST_XOFF1] = ST_UART011_XOFF1,
|
|
|
|
[REG_ST_XOFF2] = ST_UART011_XOFF2,
|
|
|
|
[REG_ST_ITCR] = ST_UART011_ITCR,
|
|
|
|
[REG_ST_ITIP] = ST_UART011_ITIP,
|
|
|
|
[REG_ST_ABCR] = ST_UART011_ABCR,
|
|
|
|
[REG_ST_ABIMSC] = ST_UART011_ABIMSC,
|
|
|
|
};
|
|
|
|
|
2013-05-10 09:05:35 +00:00
|
|
|
static unsigned int get_fifosize_st(struct amba_device *dev)
|
2013-04-15 05:45:25 +00:00
|
|
|
{
|
|
|
|
return 64;
|
|
|
|
}
|
|
|
|
|
2009-06-04 16:43:04 +00:00
|
|
|
static struct vendor_data vendor_st = {
|
2015-11-16 17:40:36 +00:00
|
|
|
.reg_offset = pl011_st_offsets,
|
2009-06-04 16:43:04 +00:00
|
|
|
.ifls = UART011_IFLS_RX_HALF|UART011_IFLS_TX_HALF,
|
2016-07-08 09:00:39 +00:00
|
|
|
.fr_busy = UART01x_FR_BUSY,
|
|
|
|
.fr_dsr = UART01x_FR_DSR,
|
|
|
|
.fr_cts = UART01x_FR_CTS,
|
|
|
|
.fr_ri = UART011_FR_RI,
|
2010-06-02 19:40:22 +00:00
|
|
|
.oversampling = true,
|
2010-12-22 17:59:16 +00:00
|
|
|
.dma_threshold = true,
|
2012-03-26 09:17:02 +00:00
|
|
|
.cts_event_workaround = true,
|
2015-05-21 16:26:21 +00:00
|
|
|
.always_enabled = false,
|
2015-05-21 16:26:22 +00:00
|
|
|
.fixed_options = false,
|
2013-04-15 05:45:25 +00:00
|
|
|
.get_fifosize = get_fifosize_st,
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2015-11-16 17:40:57 +00:00
|
|
|
static const u16 pl011_zte_offsets[REG_ARRAY_SIZE] = {
|
|
|
|
[REG_DR] = ZX_UART011_DR,
|
|
|
|
[REG_FR] = ZX_UART011_FR,
|
|
|
|
[REG_LCRH_RX] = ZX_UART011_LCRH,
|
|
|
|
[REG_LCRH_TX] = ZX_UART011_LCRH,
|
|
|
|
[REG_IBRD] = ZX_UART011_IBRD,
|
|
|
|
[REG_FBRD] = ZX_UART011_FBRD,
|
|
|
|
[REG_CR] = ZX_UART011_CR,
|
|
|
|
[REG_IFLS] = ZX_UART011_IFLS,
|
|
|
|
[REG_IMSC] = ZX_UART011_IMSC,
|
|
|
|
[REG_RIS] = ZX_UART011_RIS,
|
|
|
|
[REG_MIS] = ZX_UART011_MIS,
|
|
|
|
[REG_ICR] = ZX_UART011_ICR,
|
|
|
|
[REG_DMACR] = ZX_UART011_DMACR,
|
|
|
|
};
|
|
|
|
|
2016-07-08 09:00:40 +00:00
|
|
|
static unsigned int get_fifosize_zte(struct amba_device *dev)
|
|
|
|
{
|
|
|
|
return 16;
|
|
|
|
}
|
|
|
|
|
tty: amba-pl011: probe ZTE device from AMBA bus with a pseudo-ID
There is no Peripheral Identification Registers on ZTE PL011 device, so
although the driver amba-pl011 is ready to work for ZTE device, the
device cannot be probed by the driver at all.
With arm,primecell-periphid DT bindings (bindings/arm/primecell.txt) in
place, it should be the cleanest the way to use a pseudo-ID to probe the
device from AMBA bus. We create an unofficial vendor number
AMBA_VENDOR_LINUX, which will practically never become an official
vendor ID, and takes Configuration, Revision number, and Part number as
input to compose a pseudo-ID for ZTE device.
Also, since we start using vendor_zte to probe ZTE device, the
__maybe_unused for vendor_zte is removed.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-07-08 09:00:41 +00:00
|
|
|
static struct vendor_data vendor_zte = {
|
2015-11-16 17:40:57 +00:00
|
|
|
.reg_offset = pl011_zte_offsets,
|
|
|
|
.access_32b = true,
|
|
|
|
.ifls = UART011_IFLS_RX4_8|UART011_IFLS_TX4_8,
|
2016-07-08 09:00:39 +00:00
|
|
|
.fr_busy = ZX_UART01x_FR_BUSY,
|
|
|
|
.fr_dsr = ZX_UART01x_FR_DSR,
|
|
|
|
.fr_cts = ZX_UART01x_FR_CTS,
|
|
|
|
.fr_ri = ZX_UART011_FR_RI,
|
2016-07-08 09:00:40 +00:00
|
|
|
.get_fifosize = get_fifosize_zte,
|
2015-11-16 17:40:57 +00:00
|
|
|
};
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/* Deals with DMA transactions */
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
struct pl011_sgbuf {
|
|
|
|
struct scatterlist sg;
|
|
|
|
char *buf;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct pl011_dmarx_data {
|
|
|
|
struct dma_chan *chan;
|
|
|
|
struct completion complete;
|
|
|
|
bool use_buf_b;
|
|
|
|
struct pl011_sgbuf sgbuf_a;
|
|
|
|
struct pl011_sgbuf sgbuf_b;
|
|
|
|
dma_cookie_t cookie;
|
|
|
|
bool running;
|
2013-03-27 09:38:11 +00:00
|
|
|
struct timer_list timer;
|
|
|
|
unsigned int last_residue;
|
|
|
|
unsigned long last_jiffies;
|
|
|
|
bool auto_poll_rate;
|
|
|
|
unsigned int poll_rate;
|
|
|
|
unsigned int poll_timeout;
|
2011-02-24 12:21:08 +00:00
|
|
|
};
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
struct pl011_dmatx_data {
|
|
|
|
struct dma_chan *chan;
|
|
|
|
struct scatterlist sg;
|
|
|
|
char *buf;
|
|
|
|
bool queued;
|
|
|
|
};
|
|
|
|
|
2010-12-22 17:48:26 +00:00
|
|
|
/*
|
|
|
|
* We wrap our port structure around the generic uart_port.
|
|
|
|
*/
|
|
|
|
struct uart_amba_port {
|
|
|
|
struct uart_port port;
|
2015-11-16 17:40:26 +00:00
|
|
|
const u16 *reg_offset;
|
2010-12-22 17:48:26 +00:00
|
|
|
struct clk *clk;
|
|
|
|
const struct vendor_data *vendor;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
unsigned int dmacr; /* dma control reg */
|
2010-12-22 17:48:26 +00:00
|
|
|
unsigned int im; /* interrupt mask */
|
|
|
|
unsigned int old_status;
|
2010-12-22 17:13:05 +00:00
|
|
|
unsigned int fifosize; /* vendor-specific */
|
2012-01-18 10:23:59 +00:00
|
|
|
unsigned int old_cr; /* state during shutdown */
|
2010-12-22 17:48:26 +00:00
|
|
|
bool autorts;
|
2015-05-21 16:26:22 +00:00
|
|
|
unsigned int fixed_baud; /* vendor-set fixed baud rate */
|
2010-12-22 17:48:26 +00:00
|
|
|
char type[12];
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
#ifdef CONFIG_DMA_ENGINE
|
|
|
|
/* DMA stuff */
|
2011-02-24 12:21:08 +00:00
|
|
|
bool using_tx_dma;
|
|
|
|
bool using_rx_dma;
|
|
|
|
struct pl011_dmarx_data dmarx;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
struct pl011_dmatx_data dmatx;
|
2015-03-06 18:05:40 +00:00
|
|
|
bool dma_probed;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
#endif
|
|
|
|
};
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
static unsigned int pl011_reg_to_offset(const struct uart_amba_port *uap,
|
|
|
|
unsigned int reg)
|
|
|
|
{
|
2015-11-16 17:40:26 +00:00
|
|
|
return uap->reg_offset[reg];
|
2015-11-03 14:51:13 +00:00
|
|
|
}
|
|
|
|
|
2015-11-03 14:51:03 +00:00
|
|
|
static unsigned int pl011_read(const struct uart_amba_port *uap,
|
|
|
|
unsigned int reg)
|
2015-11-03 14:50:58 +00:00
|
|
|
{
|
2015-11-16 17:40:52 +00:00
|
|
|
void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
|
|
|
|
|
2016-01-04 21:37:42 +00:00
|
|
|
return (uap->port.iotype == UPIO_MEM32) ?
|
|
|
|
readl_relaxed(addr) : readw_relaxed(addr);
|
2015-11-03 14:50:58 +00:00
|
|
|
}
|
|
|
|
|
2015-11-03 14:51:03 +00:00
|
|
|
static void pl011_write(unsigned int val, const struct uart_amba_port *uap,
|
|
|
|
unsigned int reg)
|
2015-11-03 14:50:58 +00:00
|
|
|
{
|
2015-11-16 17:40:52 +00:00
|
|
|
void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
|
|
|
|
|
2016-01-04 21:37:42 +00:00
|
|
|
if (uap->port.iotype == UPIO_MEM32)
|
2015-11-16 17:41:02 +00:00
|
|
|
writel_relaxed(val, addr);
|
2015-11-16 17:40:52 +00:00
|
|
|
else
|
2015-11-16 17:41:02 +00:00
|
|
|
writew_relaxed(val, addr);
|
2015-11-03 14:50:58 +00:00
|
|
|
}
|
|
|
|
|
2011-02-24 12:21:36 +00:00
|
|
|
/*
|
|
|
|
* Reads up to 256 characters from the FIFO or until it's empty and
|
|
|
|
* inserts them into the TTY layer. Returns the number of characters
|
|
|
|
* read from the FIFO.
|
|
|
|
*/
|
|
|
|
static int pl011_fifo_to_tty(struct uart_amba_port *uap)
|
|
|
|
{
|
2015-10-07 20:27:16 +00:00
|
|
|
u16 status;
|
|
|
|
unsigned int ch, flag, max_count = 256;
|
2011-02-24 12:21:36 +00:00
|
|
|
int fifotaken = 0;
|
|
|
|
|
|
|
|
while (max_count--) {
|
2015-11-03 14:51:13 +00:00
|
|
|
status = pl011_read(uap, REG_FR);
|
2011-02-24 12:21:36 +00:00
|
|
|
if (status & UART01x_FR_RXFE)
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Take chars from the FIFO and update status */
|
2015-11-03 14:51:13 +00:00
|
|
|
ch = pl011_read(uap, REG_DR) | UART_DUMMY_DR_RX;
|
2011-02-24 12:21:36 +00:00
|
|
|
flag = TTY_NORMAL;
|
|
|
|
uap->port.icount.rx++;
|
|
|
|
fifotaken++;
|
|
|
|
|
|
|
|
if (unlikely(ch & UART_DR_ERROR)) {
|
|
|
|
if (ch & UART011_DR_BE) {
|
|
|
|
ch &= ~(UART011_DR_FE | UART011_DR_PE);
|
|
|
|
uap->port.icount.brk++;
|
|
|
|
if (uart_handle_break(&uap->port))
|
|
|
|
continue;
|
|
|
|
} else if (ch & UART011_DR_PE)
|
|
|
|
uap->port.icount.parity++;
|
|
|
|
else if (ch & UART011_DR_FE)
|
|
|
|
uap->port.icount.frame++;
|
|
|
|
if (ch & UART011_DR_OE)
|
|
|
|
uap->port.icount.overrun++;
|
|
|
|
|
|
|
|
ch &= uap->port.read_status_mask;
|
|
|
|
|
|
|
|
if (ch & UART011_DR_BE)
|
|
|
|
flag = TTY_BREAK;
|
|
|
|
else if (ch & UART011_DR_PE)
|
|
|
|
flag = TTY_PARITY;
|
|
|
|
else if (ch & UART011_DR_FE)
|
|
|
|
flag = TTY_FRAME;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (uart_handle_sysrq_char(&uap->port, ch & 255))
|
|
|
|
continue;
|
|
|
|
|
|
|
|
uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag);
|
|
|
|
}
|
|
|
|
|
|
|
|
return fifotaken;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/*
|
|
|
|
* All the DMA operation mode stuff goes inside this ifdef.
|
|
|
|
* This assumes that you have a generic DMA device interface,
|
|
|
|
* no custom DMA interfaces are supported.
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_DMA_ENGINE
|
|
|
|
|
|
|
|
#define PL011_DMA_BUFFER_SIZE PAGE_SIZE
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
static int pl011_sgbuf_init(struct dma_chan *chan, struct pl011_sgbuf *sg,
|
|
|
|
enum dma_data_direction dir)
|
|
|
|
{
|
2013-03-27 09:38:11 +00:00
|
|
|
dma_addr_t dma_addr;
|
|
|
|
|
|
|
|
sg->buf = dma_alloc_coherent(chan->device->dev,
|
|
|
|
PL011_DMA_BUFFER_SIZE, &dma_addr, GFP_KERNEL);
|
2011-02-24 12:21:08 +00:00
|
|
|
if (!sg->buf)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2013-03-27 09:38:11 +00:00
|
|
|
sg_init_table(&sg->sg, 1);
|
|
|
|
sg_set_page(&sg->sg, phys_to_page(dma_addr),
|
|
|
|
PL011_DMA_BUFFER_SIZE, offset_in_page(dma_addr));
|
|
|
|
sg_dma_address(&sg->sg) = dma_addr;
|
2014-11-07 14:14:43 +00:00
|
|
|
sg_dma_len(&sg->sg) = PL011_DMA_BUFFER_SIZE;
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_sgbuf_free(struct dma_chan *chan, struct pl011_sgbuf *sg,
|
|
|
|
enum dma_data_direction dir)
|
|
|
|
{
|
|
|
|
if (sg->buf) {
|
2013-03-27 09:38:11 +00:00
|
|
|
dma_free_coherent(chan->device->dev,
|
|
|
|
PL011_DMA_BUFFER_SIZE, sg->buf,
|
|
|
|
sg_dma_address(&sg->sg));
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-06 18:05:40 +00:00
|
|
|
static void pl011_dma_probe(struct uart_amba_port *uap)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
{
|
|
|
|
/* DMA is the sole user of the platform data right now */
|
2013-07-30 08:06:57 +00:00
|
|
|
struct amba_pl011_data *plat = dev_get_platdata(uap->port.dev);
|
2015-03-06 18:05:40 +00:00
|
|
|
struct device *dev = uap->port.dev;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
struct dma_slave_config tx_conf = {
|
2015-11-03 14:51:13 +00:00
|
|
|
.dst_addr = uap->port.mapbase +
|
|
|
|
pl011_reg_to_offset(uap, REG_DR),
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE,
|
2011-10-14 05:17:38 +00:00
|
|
|
.direction = DMA_MEM_TO_DEV,
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
.dst_maxburst = uap->fifosize >> 1,
|
2012-02-01 10:42:19 +00:00
|
|
|
.device_fc = false,
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
};
|
|
|
|
struct dma_chan *chan;
|
|
|
|
dma_cap_mask_t mask;
|
|
|
|
|
2015-03-06 18:05:40 +00:00
|
|
|
uap->dma_probed = true;
|
|
|
|
chan = dma_request_slave_channel_reason(dev, "tx");
|
|
|
|
if (IS_ERR(chan)) {
|
|
|
|
if (PTR_ERR(chan) == -EPROBE_DEFER) {
|
|
|
|
uap->dma_probed = false;
|
|
|
|
return;
|
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2013-01-28 16:24:37 +00:00
|
|
|
/* We need platform data */
|
|
|
|
if (!plat || !plat->dma_filter) {
|
|
|
|
dev_info(uap->port.dev, "no DMA platform data\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Try to acquire a generic DMA engine slave TX channel */
|
|
|
|
dma_cap_zero(mask);
|
|
|
|
dma_cap_set(DMA_SLAVE, mask);
|
|
|
|
|
|
|
|
chan = dma_request_channel(mask, plat->dma_filter,
|
|
|
|
plat->dma_tx_param);
|
|
|
|
if (!chan) {
|
|
|
|
dev_err(uap->port.dev, "no TX DMA channel!\n");
|
|
|
|
return;
|
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
dmaengine_slave_config(chan, &tx_conf);
|
|
|
|
uap->dmatx.chan = chan;
|
|
|
|
|
|
|
|
dev_info(uap->port.dev, "DMA channel TX %s\n",
|
|
|
|
dma_chan_name(uap->dmatx.chan));
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
/* Optionally make use of an RX channel as well */
|
2013-01-28 16:24:37 +00:00
|
|
|
chan = dma_request_slave_channel(dev, "rx");
|
2014-04-18 22:19:57 +00:00
|
|
|
|
2016-03-03 16:35:35 +00:00
|
|
|
if (!chan && plat && plat->dma_rx_param) {
|
2013-01-28 16:24:37 +00:00
|
|
|
chan = dma_request_channel(mask, plat->dma_filter, plat->dma_rx_param);
|
|
|
|
|
|
|
|
if (!chan) {
|
|
|
|
dev_err(uap->port.dev, "no RX DMA channel!\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (chan) {
|
2011-02-24 12:21:08 +00:00
|
|
|
struct dma_slave_config rx_conf = {
|
2015-11-03 14:51:13 +00:00
|
|
|
.src_addr = uap->port.mapbase +
|
|
|
|
pl011_reg_to_offset(uap, REG_DR),
|
2011-02-24 12:21:08 +00:00
|
|
|
.src_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE,
|
2011-10-14 05:17:38 +00:00
|
|
|
.direction = DMA_DEV_TO_MEM,
|
2014-04-12 17:47:17 +00:00
|
|
|
.src_maxburst = uap->fifosize >> 2,
|
2012-02-01 10:42:19 +00:00
|
|
|
.device_fc = false,
|
2011-02-24 12:21:08 +00:00
|
|
|
};
|
2014-11-07 14:14:47 +00:00
|
|
|
struct dma_slave_caps caps;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Some DMA controllers provide information on their capabilities.
|
|
|
|
* If the controller does, check for suitable residue processing
|
|
|
|
* otherwise assime all is well.
|
|
|
|
*/
|
|
|
|
if (0 == dma_get_slave_caps(chan, &caps)) {
|
|
|
|
if (caps.residue_granularity ==
|
|
|
|
DMA_RESIDUE_GRANULARITY_DESCRIPTOR) {
|
|
|
|
dma_release_channel(chan);
|
|
|
|
dev_info(uap->port.dev,
|
|
|
|
"RX DMA disabled - no residue processing\n");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
2011-02-24 12:21:08 +00:00
|
|
|
dmaengine_slave_config(chan, &rx_conf);
|
|
|
|
uap->dmarx.chan = chan;
|
|
|
|
|
2014-11-07 14:14:23 +00:00
|
|
|
uap->dmarx.auto_poll_rate = false;
|
2013-12-17 17:33:18 +00:00
|
|
|
if (plat && plat->dma_rx_poll_enable) {
|
2013-03-27 09:38:11 +00:00
|
|
|
/* Set poll rate if specified. */
|
|
|
|
if (plat->dma_rx_poll_rate) {
|
|
|
|
uap->dmarx.auto_poll_rate = false;
|
|
|
|
uap->dmarx.poll_rate = plat->dma_rx_poll_rate;
|
|
|
|
} else {
|
|
|
|
/*
|
|
|
|
* 100 ms defaults to poll rate if not
|
|
|
|
* specified. This will be adjusted with
|
|
|
|
* the baud rate at set_termios.
|
|
|
|
*/
|
|
|
|
uap->dmarx.auto_poll_rate = true;
|
|
|
|
uap->dmarx.poll_rate = 100;
|
|
|
|
}
|
|
|
|
/* 3 secs defaults poll_timeout if not specified. */
|
|
|
|
if (plat->dma_rx_poll_timeout)
|
|
|
|
uap->dmarx.poll_timeout =
|
|
|
|
plat->dma_rx_poll_timeout;
|
|
|
|
else
|
|
|
|
uap->dmarx.poll_timeout = 3000;
|
2014-11-07 14:14:23 +00:00
|
|
|
} else if (!plat && dev->of_node) {
|
|
|
|
uap->dmarx.auto_poll_rate = of_property_read_bool(
|
|
|
|
dev->of_node, "auto-poll");
|
|
|
|
if (uap->dmarx.auto_poll_rate) {
|
|
|
|
u32 x;
|
|
|
|
|
|
|
|
if (0 == of_property_read_u32(dev->of_node,
|
|
|
|
"poll-rate-ms", &x))
|
|
|
|
uap->dmarx.poll_rate = x;
|
|
|
|
else
|
|
|
|
uap->dmarx.poll_rate = 100;
|
|
|
|
if (0 == of_property_read_u32(dev->of_node,
|
|
|
|
"poll-timeout-ms", &x))
|
|
|
|
uap->dmarx.poll_timeout = x;
|
|
|
|
else
|
|
|
|
uap->dmarx.poll_timeout = 3000;
|
|
|
|
}
|
|
|
|
}
|
2011-02-24 12:21:08 +00:00
|
|
|
dev_info(uap->port.dev, "DMA channel RX %s\n",
|
|
|
|
dma_chan_name(uap->dmarx.chan));
|
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_dma_remove(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
if (uap->dmatx.chan)
|
|
|
|
dma_release_channel(uap->dmatx.chan);
|
2011-02-24 12:21:08 +00:00
|
|
|
if (uap->dmarx.chan)
|
|
|
|
dma_release_channel(uap->dmarx.chan);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
2015-03-04 12:27:33 +00:00
|
|
|
/* Forward declare these for the refill routine */
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
static int pl011_dma_tx_refill(struct uart_amba_port *uap);
|
2015-03-04 12:27:33 +00:00
|
|
|
static void pl011_start_tx_pio(struct uart_amba_port *uap);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The current DMA TX buffer has been sent.
|
|
|
|
* Try to queue up another DMA buffer.
|
|
|
|
*/
|
|
|
|
static void pl011_dma_tx_callback(void *data)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = data;
|
|
|
|
struct pl011_dmatx_data *dmatx = &uap->dmatx;
|
|
|
|
unsigned long flags;
|
|
|
|
u16 dmacr;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&uap->port.lock, flags);
|
|
|
|
if (uap->dmatx.queued)
|
|
|
|
dma_unmap_sg(dmatx->chan->device->dev, &dmatx->sg, 1,
|
|
|
|
DMA_TO_DEVICE);
|
|
|
|
|
|
|
|
dmacr = uap->dmacr;
|
|
|
|
uap->dmacr = dmacr & ~UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If TX DMA was disabled, it means that we've stopped the DMA for
|
|
|
|
* some reason (eg, XOFF received, or we want to send an X-char.)
|
|
|
|
*
|
|
|
|
* Note: we need to be careful here of a potential race between DMA
|
|
|
|
* and the rest of the driver - if the driver disables TX DMA while
|
|
|
|
* a TX buffer completing, we must update the tx queued status to
|
|
|
|
* get further refills (hence we check dmacr).
|
|
|
|
*/
|
|
|
|
if (!(dmacr & UART011_TXDMAE) || uart_tx_stopped(&uap->port) ||
|
|
|
|
uart_circ_empty(&uap->port.state->xmit)) {
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
spin_unlock_irqrestore(&uap->port.lock, flags);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2015-03-04 12:27:33 +00:00
|
|
|
if (pl011_dma_tx_refill(uap) <= 0)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/*
|
|
|
|
* We didn't queue a DMA buffer for some reason, but we
|
|
|
|
* have data pending to be sent. Re-enable the TX IRQ.
|
|
|
|
*/
|
2015-03-04 12:27:33 +00:00
|
|
|
pl011_start_tx_pio(uap);
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
spin_unlock_irqrestore(&uap->port.lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to refill the TX DMA buffer.
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
* Returns:
|
|
|
|
* 1 if we queued up a TX DMA buffer.
|
|
|
|
* 0 if we didn't want to handle this by DMA
|
|
|
|
* <0 on error
|
|
|
|
*/
|
|
|
|
static int pl011_dma_tx_refill(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
struct pl011_dmatx_data *dmatx = &uap->dmatx;
|
|
|
|
struct dma_chan *chan = dmatx->chan;
|
|
|
|
struct dma_device *dma_dev = chan->device;
|
|
|
|
struct dma_async_tx_descriptor *desc;
|
|
|
|
struct circ_buf *xmit = &uap->port.state->xmit;
|
|
|
|
unsigned int count;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to avoid the overhead involved in using DMA if the
|
|
|
|
* transaction fits in the first half of the FIFO, by using
|
|
|
|
* the standard interrupt handling. This ensures that we
|
|
|
|
* issue a uart_write_wakeup() at the appropriate time.
|
|
|
|
*/
|
|
|
|
count = uart_circ_chars_pending(xmit);
|
|
|
|
if (count < (uap->fifosize >> 1)) {
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Bodge: don't send the last character by DMA, as this
|
|
|
|
* will prevent XON from notifying us to restart DMA.
|
|
|
|
*/
|
|
|
|
count -= 1;
|
|
|
|
|
|
|
|
/* Else proceed to copy the TX chars to the DMA buffer and fire DMA */
|
|
|
|
if (count > PL011_DMA_BUFFER_SIZE)
|
|
|
|
count = PL011_DMA_BUFFER_SIZE;
|
|
|
|
|
|
|
|
if (xmit->tail < xmit->head)
|
|
|
|
memcpy(&dmatx->buf[0], &xmit->buf[xmit->tail], count);
|
|
|
|
else {
|
|
|
|
size_t first = UART_XMIT_SIZE - xmit->tail;
|
2014-11-07 14:14:39 +00:00
|
|
|
size_t second;
|
|
|
|
|
|
|
|
if (first > count)
|
|
|
|
first = count;
|
|
|
|
second = count - first;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
|
|
|
memcpy(&dmatx->buf[0], &xmit->buf[xmit->tail], first);
|
|
|
|
if (second)
|
|
|
|
memcpy(&dmatx->buf[first], &xmit->buf[0], second);
|
|
|
|
}
|
|
|
|
|
|
|
|
dmatx->sg.length = count;
|
|
|
|
|
|
|
|
if (dma_map_sg(dma_dev->dev, &dmatx->sg, 1, DMA_TO_DEVICE) != 1) {
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
dev_dbg(uap->port.dev, "unable to map TX DMA\n");
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
2012-03-08 21:11:18 +00:00
|
|
|
desc = dmaengine_prep_slave_sg(chan, &dmatx->sg, 1, DMA_MEM_TO_DEV,
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
|
|
|
|
if (!desc) {
|
|
|
|
dma_unmap_sg(dma_dev->dev, &dmatx->sg, 1, DMA_TO_DEVICE);
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
/*
|
|
|
|
* If DMA cannot be used right now, we complete this
|
|
|
|
* transaction via IRQ and let the TTY layer retry.
|
|
|
|
*/
|
|
|
|
dev_dbg(uap->port.dev, "TX DMA busy\n");
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Some data to go along to the callback */
|
|
|
|
desc->callback = pl011_dma_tx_callback;
|
|
|
|
desc->callback_param = uap;
|
|
|
|
|
|
|
|
/* All errors should happen at prepare time */
|
|
|
|
dmaengine_submit(desc);
|
|
|
|
|
|
|
|
/* Fire the DMA transaction */
|
|
|
|
dma_dev->device_issue_pending(chan);
|
|
|
|
|
|
|
|
uap->dmacr |= UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
uap->dmatx.queued = true;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now we know that DMA will fire, so advance the ring buffer
|
|
|
|
* with the stuff we just dispatched.
|
|
|
|
*/
|
|
|
|
xmit->tail = (xmit->tail + count) & (UART_XMIT_SIZE - 1);
|
|
|
|
uap->port.icount.tx += count;
|
|
|
|
|
|
|
|
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
|
|
|
|
uart_write_wakeup(&uap->port);
|
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We received a transmit interrupt without a pending X-char but with
|
|
|
|
* pending characters.
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
* Returns:
|
|
|
|
* false if we want to use PIO to transmit
|
|
|
|
* true if we queued a DMA buffer
|
|
|
|
*/
|
|
|
|
static bool pl011_dma_tx_irq(struct uart_amba_port *uap)
|
|
|
|
{
|
2011-02-24 12:21:08 +00:00
|
|
|
if (!uap->using_tx_dma)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we already have a TX buffer queued, but received a
|
|
|
|
* TX interrupt, it will be because we've just sent an X-char.
|
|
|
|
* Ensure the TX DMA is enabled and the TX IRQ is disabled.
|
|
|
|
*/
|
|
|
|
if (uap->dmatx.queued) {
|
|
|
|
uap->dmacr |= UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
uap->im &= ~UART011_TXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We don't have a TX buffer queued, so try to queue one.
|
2011-03-31 01:57:33 +00:00
|
|
|
* If we successfully queued a buffer, mask the TX IRQ.
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
*/
|
|
|
|
if (pl011_dma_tx_refill(uap) > 0) {
|
|
|
|
uap->im &= ~UART011_TXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Stop the DMA transmit (eg, due to received XOFF).
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
*/
|
|
|
|
static inline void pl011_dma_tx_stop(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
if (uap->dmatx.queued) {
|
|
|
|
uap->dmacr &= ~UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to start a DMA transmit, or in the case of an XON/OFF
|
|
|
|
* character queued for send, try to get that character out ASAP.
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
* Returns:
|
|
|
|
* false if we want the TX IRQ to be enabled
|
|
|
|
* true if we have a buffer queued
|
|
|
|
*/
|
|
|
|
static inline bool pl011_dma_tx_start(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
u16 dmacr;
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
if (!uap->using_tx_dma)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
if (!uap->port.x_char) {
|
|
|
|
/* no X-char, try to push chars out in DMA mode */
|
|
|
|
bool ret = true;
|
|
|
|
|
|
|
|
if (!uap->dmatx.queued) {
|
|
|
|
if (pl011_dma_tx_refill(uap) > 0) {
|
|
|
|
uap->im &= ~UART011_TXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2015-03-04 12:27:33 +00:00
|
|
|
} else
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
ret = false;
|
|
|
|
} else if (!(uap->dmacr & UART011_TXDMAE)) {
|
|
|
|
uap->dmacr |= UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We have an X-char to send. Disable DMA to prevent it loading
|
|
|
|
* the TX fifo, and then see if we can stuff it into the FIFO.
|
|
|
|
*/
|
|
|
|
dmacr = uap->dmacr;
|
|
|
|
uap->dmacr &= ~UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
if (pl011_read(uap, REG_FR) & UART01x_FR_TXFF) {
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/*
|
|
|
|
* No space in the FIFO, so enable the transmit interrupt
|
|
|
|
* so we know when there is space. Note that once we've
|
|
|
|
* loaded the character, we should just re-enable DMA.
|
|
|
|
*/
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->port.x_char, uap, REG_DR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
uap->port.icount.tx++;
|
|
|
|
uap->port.x_char = 0;
|
|
|
|
|
|
|
|
/* Success - restore the DMA state */
|
|
|
|
uap->dmacr = dmacr;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Flush the transmit buffer.
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
*/
|
|
|
|
static void pl011_dma_flush_buffer(struct uart_port *port)
|
2013-08-09 20:58:51 +00:00
|
|
|
__releases(&uap->port.lock)
|
|
|
|
__acquires(&uap->port.lock)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
if (!uap->using_tx_dma)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
/* Avoid deadlock with the DMA engine callback */
|
|
|
|
spin_unlock(&uap->port.lock);
|
|
|
|
dmaengine_terminate_all(uap->dmatx.chan);
|
|
|
|
spin_lock(&uap->port.lock);
|
|
|
|
if (uap->dmatx.queued) {
|
|
|
|
dma_unmap_sg(uap->dmatx.chan->device->dev, &uap->dmatx.sg, 1,
|
|
|
|
DMA_TO_DEVICE);
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
uap->dmacr &= ~UART011_TXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
static void pl011_dma_rx_callback(void *data);
|
|
|
|
|
|
|
|
static int pl011_dma_rx_trigger_dma(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
struct dma_chan *rxchan = uap->dmarx.chan;
|
|
|
|
struct pl011_dmarx_data *dmarx = &uap->dmarx;
|
|
|
|
struct dma_async_tx_descriptor *desc;
|
|
|
|
struct pl011_sgbuf *sgbuf;
|
|
|
|
|
|
|
|
if (!rxchan)
|
|
|
|
return -EIO;
|
|
|
|
|
|
|
|
/* Start the RX DMA job */
|
|
|
|
sgbuf = uap->dmarx.use_buf_b ?
|
|
|
|
&uap->dmarx.sgbuf_b : &uap->dmarx.sgbuf_a;
|
2012-03-08 21:11:18 +00:00
|
|
|
desc = dmaengine_prep_slave_sg(rxchan, &sgbuf->sg, 1,
|
2011-10-14 05:17:38 +00:00
|
|
|
DMA_DEV_TO_MEM,
|
2011-02-24 12:21:08 +00:00
|
|
|
DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
|
|
|
|
/*
|
|
|
|
* If the DMA engine is busy and cannot prepare a
|
|
|
|
* channel, no big deal, the driver will fall back
|
|
|
|
* to interrupt mode as a result of this error code.
|
|
|
|
*/
|
|
|
|
if (!desc) {
|
|
|
|
uap->dmarx.running = false;
|
|
|
|
dmaengine_terminate_all(rxchan);
|
|
|
|
return -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Some data to go along to the callback */
|
|
|
|
desc->callback = pl011_dma_rx_callback;
|
|
|
|
desc->callback_param = uap;
|
|
|
|
dmarx->cookie = dmaengine_submit(desc);
|
|
|
|
dma_async_issue_pending(rxchan);
|
|
|
|
|
|
|
|
uap->dmacr |= UART011_RXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
2011-02-24 12:21:08 +00:00
|
|
|
uap->dmarx.running = true;
|
|
|
|
|
|
|
|
uap->im &= ~UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is called when either the DMA job is complete, or
|
|
|
|
* the FIFO timeout interrupt occurred. This must be called
|
|
|
|
* with the port spinlock uap->port.lock held.
|
|
|
|
*/
|
|
|
|
static void pl011_dma_rx_chars(struct uart_amba_port *uap,
|
|
|
|
u32 pending, bool use_buf_b,
|
|
|
|
bool readfifo)
|
|
|
|
{
|
2013-01-03 14:53:04 +00:00
|
|
|
struct tty_port *port = &uap->port.state->port;
|
2011-02-24 12:21:08 +00:00
|
|
|
struct pl011_sgbuf *sgbuf = use_buf_b ?
|
|
|
|
&uap->dmarx.sgbuf_b : &uap->dmarx.sgbuf_a;
|
|
|
|
int dma_count = 0;
|
|
|
|
u32 fifotaken = 0; /* only used for vdbg() */
|
|
|
|
|
2013-03-27 09:38:11 +00:00
|
|
|
struct pl011_dmarx_data *dmarx = &uap->dmarx;
|
|
|
|
int dmataken = 0;
|
|
|
|
|
|
|
|
if (uap->dmarx.poll_rate) {
|
|
|
|
/* The data can be taken by polling */
|
|
|
|
dmataken = sgbuf->sg.length - dmarx->last_residue;
|
|
|
|
/* Recalculate the pending size */
|
|
|
|
if (pending >= dmataken)
|
|
|
|
pending -= dmataken;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Pick the remain data from the DMA */
|
2011-02-24 12:21:08 +00:00
|
|
|
if (pending) {
|
|
|
|
|
|
|
|
/*
|
|
|
|
* First take all chars in the DMA pipe, then look in the FIFO.
|
|
|
|
* Note that tty_insert_flip_buf() tries to take as many chars
|
|
|
|
* as it can.
|
|
|
|
*/
|
2013-03-27 09:38:11 +00:00
|
|
|
dma_count = tty_insert_flip_string(port, sgbuf->buf + dmataken,
|
|
|
|
pending);
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
uap->port.icount.rx += dma_count;
|
|
|
|
if (dma_count < pending)
|
|
|
|
dev_warn(uap->port.dev,
|
|
|
|
"couldn't insert all characters (TTY is full?)\n");
|
|
|
|
}
|
|
|
|
|
2013-03-27 09:38:11 +00:00
|
|
|
/* Reset the last_residue for Rx DMA poll */
|
|
|
|
if (uap->dmarx.poll_rate)
|
|
|
|
dmarx->last_residue = sgbuf->sg.length;
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
/*
|
|
|
|
* Only continue with trying to read the FIFO if all DMA chars have
|
|
|
|
* been taken first.
|
|
|
|
*/
|
|
|
|
if (dma_count == pending && readfifo) {
|
|
|
|
/* Clear any error flags */
|
2015-11-03 14:50:58 +00:00
|
|
|
pl011_write(UART011_OEIS | UART011_BEIS | UART011_PEIS |
|
2015-11-03 14:51:13 +00:00
|
|
|
UART011_FEIS, uap, REG_ICR);
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we read all the DMA'd characters, and we had an
|
2011-02-24 12:21:36 +00:00
|
|
|
* incomplete buffer, that could be due to an rx error, or
|
|
|
|
* maybe we just timed out. Read any pending chars and check
|
|
|
|
* the error status.
|
|
|
|
*
|
|
|
|
* Error conditions will only occur in the FIFO, these will
|
|
|
|
* trigger an immediate interrupt and stop the DMA job, so we
|
|
|
|
* will always find the error in the FIFO, never in the DMA
|
|
|
|
* buffer.
|
2011-02-24 12:21:08 +00:00
|
|
|
*/
|
2011-02-24 12:21:36 +00:00
|
|
|
fifotaken = pl011_fifo_to_tty(uap);
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock(&uap->port.lock);
|
|
|
|
dev_vdbg(uap->port.dev,
|
|
|
|
"Took %d chars from DMA buffer and %d chars from the FIFO\n",
|
|
|
|
dma_count, fifotaken);
|
2013-01-03 14:53:06 +00:00
|
|
|
tty_flip_buffer_push(port);
|
2011-02-24 12:21:08 +00:00
|
|
|
spin_lock(&uap->port.lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_dma_rx_irq(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
struct pl011_dmarx_data *dmarx = &uap->dmarx;
|
|
|
|
struct dma_chan *rxchan = dmarx->chan;
|
|
|
|
struct pl011_sgbuf *sgbuf = dmarx->use_buf_b ?
|
|
|
|
&dmarx->sgbuf_b : &dmarx->sgbuf_a;
|
|
|
|
size_t pending;
|
|
|
|
struct dma_tx_state state;
|
|
|
|
enum dma_status dmastat;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Pause the transfer so we can trust the current counter,
|
|
|
|
* do this before we pause the PL011 block, else we may
|
|
|
|
* overflow the FIFO.
|
|
|
|
*/
|
|
|
|
if (dmaengine_pause(rxchan))
|
|
|
|
dev_err(uap->port.dev, "unable to pause DMA transfer\n");
|
|
|
|
dmastat = rxchan->device->device_tx_status(rxchan,
|
|
|
|
dmarx->cookie, &state);
|
|
|
|
if (dmastat != DMA_PAUSED)
|
|
|
|
dev_err(uap->port.dev, "unable to pause DMA transfer\n");
|
|
|
|
|
|
|
|
/* Disable RX DMA - incoming data will wait in the FIFO */
|
|
|
|
uap->dmacr &= ~UART011_RXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
2011-02-24 12:21:08 +00:00
|
|
|
uap->dmarx.running = false;
|
|
|
|
|
|
|
|
pending = sgbuf->sg.length - state.residue;
|
|
|
|
BUG_ON(pending > PL011_DMA_BUFFER_SIZE);
|
|
|
|
/* Then we terminate the transfer - we now know our residue */
|
|
|
|
dmaengine_terminate_all(rxchan);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This will take the chars we have so far and insert
|
|
|
|
* into the framework.
|
|
|
|
*/
|
|
|
|
pl011_dma_rx_chars(uap, pending, dmarx->use_buf_b, true);
|
|
|
|
|
|
|
|
/* Switch buffer & re-trigger DMA job */
|
|
|
|
dmarx->use_buf_b = !dmarx->use_buf_b;
|
|
|
|
if (pl011_dma_rx_trigger_dma(uap)) {
|
|
|
|
dev_dbg(uap->port.dev, "could not retrigger RX DMA job "
|
|
|
|
"fall back to interrupt mode\n");
|
|
|
|
uap->im |= UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_dma_rx_callback(void *data)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = data;
|
|
|
|
struct pl011_dmarx_data *dmarx = &uap->dmarx;
|
2012-02-20 01:24:40 +00:00
|
|
|
struct dma_chan *rxchan = dmarx->chan;
|
2011-02-24 12:21:08 +00:00
|
|
|
bool lastbuf = dmarx->use_buf_b;
|
2012-02-20 01:24:40 +00:00
|
|
|
struct pl011_sgbuf *sgbuf = dmarx->use_buf_b ?
|
|
|
|
&dmarx->sgbuf_b : &dmarx->sgbuf_a;
|
|
|
|
size_t pending;
|
|
|
|
struct dma_tx_state state;
|
2011-02-24 12:21:08 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This completion interrupt occurs typically when the
|
|
|
|
* RX buffer is totally stuffed but no timeout has yet
|
|
|
|
* occurred. When that happens, we just want the RX
|
|
|
|
* routine to flush out the secondary DMA buffer while
|
|
|
|
* we immediately trigger the next DMA job.
|
|
|
|
*/
|
|
|
|
spin_lock_irq(&uap->port.lock);
|
2012-02-20 01:24:40 +00:00
|
|
|
/*
|
|
|
|
* Rx data can be taken by the UART interrupts during
|
|
|
|
* the DMA irq handler. So we check the residue here.
|
|
|
|
*/
|
|
|
|
rxchan->device->device_tx_status(rxchan, dmarx->cookie, &state);
|
|
|
|
pending = sgbuf->sg.length - state.residue;
|
|
|
|
BUG_ON(pending > PL011_DMA_BUFFER_SIZE);
|
|
|
|
/* Then we terminate the transfer - we now know our residue */
|
|
|
|
dmaengine_terminate_all(rxchan);
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
uap->dmarx.running = false;
|
|
|
|
dmarx->use_buf_b = !lastbuf;
|
|
|
|
ret = pl011_dma_rx_trigger_dma(uap);
|
|
|
|
|
2012-02-20 01:24:40 +00:00
|
|
|
pl011_dma_rx_chars(uap, pending, lastbuf, false);
|
2011-02-24 12:21:08 +00:00
|
|
|
spin_unlock_irq(&uap->port.lock);
|
|
|
|
/*
|
|
|
|
* Do this check after we picked the DMA chars so we don't
|
|
|
|
* get some IRQ immediately from RX.
|
|
|
|
*/
|
|
|
|
if (ret) {
|
|
|
|
dev_dbg(uap->port.dev, "could not retrigger RX DMA job "
|
|
|
|
"fall back to interrupt mode\n");
|
|
|
|
uap->im |= UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Stop accepting received characters, when we're shutting down or
|
|
|
|
* suspending this port.
|
|
|
|
* Locking: called with port lock held and IRQs disabled.
|
|
|
|
*/
|
|
|
|
static inline void pl011_dma_rx_stop(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
/* FIXME. Just disable the DMA enable */
|
|
|
|
uap->dmacr &= ~UART011_RXDMAE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2013-03-27 09:38:11 +00:00
|
|
|
/*
|
|
|
|
* Timer handler for Rx DMA polling.
|
|
|
|
* Every polling, It checks the residue in the dma buffer and transfer
|
|
|
|
* data to the tty. Also, last_residue is updated for the next polling.
|
|
|
|
*/
|
|
|
|
static void pl011_dma_rx_poll(unsigned long args)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = (struct uart_amba_port *)args;
|
|
|
|
struct tty_port *port = &uap->port.state->port;
|
|
|
|
struct pl011_dmarx_data *dmarx = &uap->dmarx;
|
|
|
|
struct dma_chan *rxchan = uap->dmarx.chan;
|
|
|
|
unsigned long flags = 0;
|
|
|
|
unsigned int dmataken = 0;
|
|
|
|
unsigned int size = 0;
|
|
|
|
struct pl011_sgbuf *sgbuf;
|
|
|
|
int dma_count;
|
|
|
|
struct dma_tx_state state;
|
|
|
|
|
|
|
|
sgbuf = dmarx->use_buf_b ? &uap->dmarx.sgbuf_b : &uap->dmarx.sgbuf_a;
|
|
|
|
rxchan->device->device_tx_status(rxchan, dmarx->cookie, &state);
|
|
|
|
if (likely(state.residue < dmarx->last_residue)) {
|
|
|
|
dmataken = sgbuf->sg.length - dmarx->last_residue;
|
|
|
|
size = dmarx->last_residue - state.residue;
|
|
|
|
dma_count = tty_insert_flip_string(port, sgbuf->buf + dmataken,
|
|
|
|
size);
|
|
|
|
if (dma_count == size)
|
|
|
|
dmarx->last_residue = state.residue;
|
|
|
|
dmarx->last_jiffies = jiffies;
|
|
|
|
}
|
|
|
|
tty_flip_buffer_push(port);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If no data is received in poll_timeout, the driver will fall back
|
|
|
|
* to interrupt mode. We will retrigger DMA at the first interrupt.
|
|
|
|
*/
|
|
|
|
if (jiffies_to_msecs(jiffies - dmarx->last_jiffies)
|
|
|
|
> uap->dmarx.poll_timeout) {
|
|
|
|
|
|
|
|
spin_lock_irqsave(&uap->port.lock, flags);
|
|
|
|
pl011_dma_rx_stop(uap);
|
2013-12-10 13:54:47 +00:00
|
|
|
uap->im |= UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2013-03-27 09:38:11 +00:00
|
|
|
spin_unlock_irqrestore(&uap->port.lock, flags);
|
|
|
|
|
|
|
|
uap->dmarx.running = false;
|
|
|
|
dmaengine_terminate_all(rxchan);
|
|
|
|
del_timer(&uap->dmarx.timer);
|
|
|
|
} else {
|
|
|
|
mod_timer(&uap->dmarx.timer,
|
|
|
|
jiffies + msecs_to_jiffies(uap->dmarx.poll_rate));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
static void pl011_dma_startup(struct uart_amba_port *uap)
|
|
|
|
{
|
2011-02-24 12:21:08 +00:00
|
|
|
int ret;
|
|
|
|
|
2015-03-06 18:05:40 +00:00
|
|
|
if (!uap->dma_probed)
|
|
|
|
pl011_dma_probe(uap);
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
if (!uap->dmatx.chan)
|
|
|
|
return;
|
|
|
|
|
2014-11-07 14:14:35 +00:00
|
|
|
uap->dmatx.buf = kmalloc(PL011_DMA_BUFFER_SIZE, GFP_KERNEL | __GFP_DMA);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
if (!uap->dmatx.buf) {
|
|
|
|
dev_err(uap->port.dev, "no memory for DMA TX buffer\n");
|
|
|
|
uap->port.fifosize = uap->fifosize;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
sg_init_one(&uap->dmatx.sg, uap->dmatx.buf, PL011_DMA_BUFFER_SIZE);
|
|
|
|
|
|
|
|
/* The DMA buffer is now the FIFO the TTY subsystem can use */
|
|
|
|
uap->port.fifosize = PL011_DMA_BUFFER_SIZE;
|
2011-02-24 12:21:08 +00:00
|
|
|
uap->using_tx_dma = true;
|
|
|
|
|
|
|
|
if (!uap->dmarx.chan)
|
|
|
|
goto skip_rx;
|
|
|
|
|
|
|
|
/* Allocate and map DMA RX buffers */
|
|
|
|
ret = pl011_sgbuf_init(uap->dmarx.chan, &uap->dmarx.sgbuf_a,
|
|
|
|
DMA_FROM_DEVICE);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(uap->port.dev, "failed to init DMA %s: %d\n",
|
|
|
|
"RX buffer A", ret);
|
|
|
|
goto skip_rx;
|
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
ret = pl011_sgbuf_init(uap->dmarx.chan, &uap->dmarx.sgbuf_b,
|
|
|
|
DMA_FROM_DEVICE);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(uap->port.dev, "failed to init DMA %s: %d\n",
|
|
|
|
"RX buffer B", ret);
|
|
|
|
pl011_sgbuf_free(uap->dmarx.chan, &uap->dmarx.sgbuf_a,
|
|
|
|
DMA_FROM_DEVICE);
|
|
|
|
goto skip_rx;
|
|
|
|
}
|
|
|
|
|
|
|
|
uap->using_rx_dma = true;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
skip_rx:
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/* Turn on DMA error (RX/TX will be enabled on demand) */
|
|
|
|
uap->dmacr |= UART011_DMAONERR;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
2010-12-22 17:59:16 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* ST Micro variants has some specific dma burst threshold
|
|
|
|
* compensation. Set this to 16 bytes, so burst will only
|
|
|
|
* be issued above/below 16 bytes.
|
|
|
|
*/
|
|
|
|
if (uap->vendor->dma_threshold)
|
2015-11-03 14:50:58 +00:00
|
|
|
pl011_write(ST_UART011_DMAWM_RX_16 | ST_UART011_DMAWM_TX_16,
|
2015-11-03 14:51:13 +00:00
|
|
|
uap, REG_ST_DMAWM);
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
if (uap->using_rx_dma) {
|
|
|
|
if (pl011_dma_rx_trigger_dma(uap))
|
|
|
|
dev_dbg(uap->port.dev, "could not trigger initial "
|
|
|
|
"RX DMA job, fall back to interrupt mode\n");
|
2013-03-27 09:38:11 +00:00
|
|
|
if (uap->dmarx.poll_rate) {
|
|
|
|
init_timer(&(uap->dmarx.timer));
|
|
|
|
uap->dmarx.timer.function = pl011_dma_rx_poll;
|
|
|
|
uap->dmarx.timer.data = (unsigned long)uap;
|
|
|
|
mod_timer(&uap->dmarx.timer,
|
|
|
|
jiffies +
|
|
|
|
msecs_to_jiffies(uap->dmarx.poll_rate));
|
|
|
|
uap->dmarx.last_residue = PL011_DMA_BUFFER_SIZE;
|
|
|
|
uap->dmarx.last_jiffies = jiffies;
|
|
|
|
}
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_dma_shutdown(struct uart_amba_port *uap)
|
|
|
|
{
|
2011-02-24 12:21:08 +00:00
|
|
|
if (!(uap->using_tx_dma || uap->using_rx_dma))
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
/* Disable RX and TX DMA */
|
2016-07-08 09:00:39 +00:00
|
|
|
while (pl011_read(uap, REG_FR) & uap->vendor->fr_busy)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
|
|
|
spin_lock_irq(&uap->port.lock);
|
|
|
|
uap->dmacr &= ~(UART011_DMAONERR | UART011_RXDMAE | UART011_TXDMAE);
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->dmacr, uap, REG_DMACR);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
spin_unlock_irq(&uap->port.lock);
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
if (uap->using_tx_dma) {
|
|
|
|
/* In theory, this should already be done by pl011_dma_flush_buffer */
|
|
|
|
dmaengine_terminate_all(uap->dmatx.chan);
|
|
|
|
if (uap->dmatx.queued) {
|
|
|
|
dma_unmap_sg(uap->dmatx.chan->device->dev, &uap->dmatx.sg, 1,
|
|
|
|
DMA_TO_DEVICE);
|
|
|
|
uap->dmatx.queued = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
kfree(uap->dmatx.buf);
|
|
|
|
uap->using_tx_dma = false;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
if (uap->using_rx_dma) {
|
|
|
|
dmaengine_terminate_all(uap->dmarx.chan);
|
|
|
|
/* Clean up the RX DMA */
|
|
|
|
pl011_sgbuf_free(uap->dmarx.chan, &uap->dmarx.sgbuf_a, DMA_FROM_DEVICE);
|
|
|
|
pl011_sgbuf_free(uap->dmarx.chan, &uap->dmarx.sgbuf_b, DMA_FROM_DEVICE);
|
2013-03-27 09:38:11 +00:00
|
|
|
if (uap->dmarx.poll_rate)
|
|
|
|
del_timer_sync(&uap->dmarx.timer);
|
2011-02-24 12:21:08 +00:00
|
|
|
uap->using_rx_dma = false;
|
|
|
|
}
|
|
|
|
}
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
static inline bool pl011_dma_rx_available(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return uap->using_rx_dma;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
}
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
static inline bool pl011_dma_rx_running(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return uap->using_rx_dma && uap->dmarx.running;
|
|
|
|
}
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
#else
|
|
|
|
/* Blank functions if the DMA engine is not available */
|
2015-03-06 18:05:40 +00:00
|
|
|
static inline void pl011_dma_probe(struct uart_amba_port *uap)
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void pl011_dma_remove(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void pl011_dma_startup(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void pl011_dma_shutdown(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool pl011_dma_tx_irq(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void pl011_dma_tx_stop(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool pl011_dma_tx_start(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
static inline void pl011_dma_rx_irq(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void pl011_dma_rx_stop(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int pl011_dma_rx_trigger_dma(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool pl011_dma_rx_available(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool pl011_dma_rx_running(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
#define pl011_dma_flush_buffer NULL
|
|
|
|
#endif
|
|
|
|
|
2005-08-31 09:12:14 +00:00
|
|
|
static void pl011_stop_tx(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
uap->im &= ~UART011_TXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
pl011_dma_tx_stop(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2017-04-01 19:42:09 +00:00
|
|
|
static bool pl011_tx_chars(struct uart_amba_port *uap, bool from_irq);
|
2015-03-04 12:27:33 +00:00
|
|
|
|
|
|
|
/* Start TX with programmed I/O only (no DMA) */
|
|
|
|
static void pl011_start_tx_pio(struct uart_amba_port *uap)
|
|
|
|
{
|
2017-04-01 19:42:09 +00:00
|
|
|
if (pl011_tx_chars(uap, false)) {
|
|
|
|
uap->im |= UART011_TXIM;
|
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
|
|
|
}
|
2015-03-04 12:27:33 +00:00
|
|
|
}
|
|
|
|
|
2005-08-31 09:12:14 +00:00
|
|
|
static void pl011_start_tx(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-03-04 12:27:33 +00:00
|
|
|
if (!pl011_dma_tx_start(uap))
|
|
|
|
pl011_start_tx_pio(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_stop_rx(struct uart_port *port)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
uap->im &= ~(UART011_RXIM|UART011_RTIM|UART011_FEIM|
|
|
|
|
UART011_PEIM|UART011_BEIM|UART011_OEIM);
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2011-02-24 12:21:08 +00:00
|
|
|
|
|
|
|
pl011_dma_rx_stop(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_enable_ms(struct uart_port *port)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
uap->im |= UART011_RIMIM|UART011_CTSMIM|UART011_DCDMIM|UART011_DSRMIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.
The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).
Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.
Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.
I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.
This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);
I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().
Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.
(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.
(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.
Signed-Off-By: David Howells <dhowells@redhat.com>
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
2006-10-05 13:55:46 +00:00
|
|
|
static void pl011_rx_chars(struct uart_amba_port *uap)
|
2013-08-09 20:58:51 +00:00
|
|
|
__releases(&uap->port.lock)
|
|
|
|
__acquires(&uap->port.lock)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2011-02-24 12:21:36 +00:00
|
|
|
pl011_fifo_to_tty(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-05-29 20:53:50 +00:00
|
|
|
spin_unlock(&uap->port.lock);
|
2013-01-03 14:53:06 +00:00
|
|
|
tty_flip_buffer_push(&uap->port.state->port);
|
2011-02-24 12:21:08 +00:00
|
|
|
/*
|
|
|
|
* If we were temporarily out of DMA mode for a while,
|
|
|
|
* attempt to switch back to DMA mode again.
|
|
|
|
*/
|
|
|
|
if (pl011_dma_rx_available(uap)) {
|
|
|
|
if (pl011_dma_rx_trigger_dma(uap)) {
|
|
|
|
dev_dbg(uap->port.dev, "could not trigger RX DMA job "
|
|
|
|
"fall back to interrupt mode again\n");
|
|
|
|
uap->im |= UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2013-03-27 09:38:11 +00:00
|
|
|
} else {
|
2013-04-03 02:10:37 +00:00
|
|
|
#ifdef CONFIG_DMA_ENGINE
|
2013-03-27 09:38:11 +00:00
|
|
|
/* Start Rx DMA poll */
|
|
|
|
if (uap->dmarx.poll_rate) {
|
|
|
|
uap->dmarx.last_jiffies = jiffies;
|
|
|
|
uap->dmarx.last_residue = PL011_DMA_BUFFER_SIZE;
|
|
|
|
mod_timer(&uap->dmarx.timer,
|
|
|
|
jiffies +
|
|
|
|
msecs_to_jiffies(uap->dmarx.poll_rate));
|
|
|
|
}
|
2013-04-03 02:10:37 +00:00
|
|
|
#endif
|
2013-03-27 09:38:11 +00:00
|
|
|
}
|
2011-02-24 12:21:08 +00:00
|
|
|
}
|
2007-05-29 20:53:50 +00:00
|
|
|
spin_lock(&uap->port.lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2015-04-27 15:49:05 +00:00
|
|
|
static bool pl011_tx_char(struct uart_amba_port *uap, unsigned char c,
|
|
|
|
bool from_irq)
|
2015-03-04 12:27:33 +00:00
|
|
|
{
|
2015-04-27 15:49:05 +00:00
|
|
|
if (unlikely(!from_irq) &&
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_read(uap, REG_FR) & UART01x_FR_TXFF)
|
2015-04-27 15:49:05 +00:00
|
|
|
return false; /* unable to transmit character */
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(c, uap, REG_DR);
|
2015-03-04 12:27:33 +00:00
|
|
|
uap->port.icount.tx++;
|
|
|
|
|
2015-04-27 15:49:05 +00:00
|
|
|
return true;
|
2015-03-04 12:27:33 +00:00
|
|
|
}
|
|
|
|
|
2017-04-01 19:42:09 +00:00
|
|
|
/* Returns true if tx interrupts have to be (kept) enabled */
|
|
|
|
static bool pl011_tx_chars(struct uart_amba_port *uap, bool from_irq)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-09-19 20:13:28 +00:00
|
|
|
struct circ_buf *xmit = &uap->port.state->xmit;
|
2015-04-27 15:49:05 +00:00
|
|
|
int count = uap->fifosize >> 1;
|
2015-03-04 12:27:33 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
if (uap->port.x_char) {
|
2015-04-27 15:49:05 +00:00
|
|
|
if (!pl011_tx_char(uap, uap->port.x_char, from_irq))
|
2017-04-01 19:42:09 +00:00
|
|
|
return true;
|
2005-04-16 22:20:36 +00:00
|
|
|
uap->port.x_char = 0;
|
2015-03-04 12:27:33 +00:00
|
|
|
--count;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
if (uart_circ_empty(xmit) || uart_tx_stopped(&uap->port)) {
|
2005-08-31 09:12:14 +00:00
|
|
|
pl011_stop_tx(&uap->port);
|
2017-04-01 19:42:09 +00:00
|
|
|
return false;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/* If we are using DMA mode, try to send some characters. */
|
|
|
|
if (pl011_dma_tx_irq(uap))
|
2017-04-01 19:42:09 +00:00
|
|
|
return true;
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
|
2015-04-27 15:49:05 +00:00
|
|
|
do {
|
|
|
|
if (likely(from_irq) && count-- == 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2015-04-27 15:49:05 +00:00
|
|
|
|
|
|
|
if (!pl011_tx_char(uap, xmit->buf[xmit->tail], from_irq))
|
|
|
|
break;
|
|
|
|
|
|
|
|
xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
|
|
|
|
} while (!uart_circ_empty(xmit));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
|
|
|
|
uart_write_wakeup(&uap->port);
|
|
|
|
|
2017-04-01 19:42:09 +00:00
|
|
|
if (uart_circ_empty(xmit)) {
|
2005-08-31 09:12:14 +00:00
|
|
|
pl011_stop_tx(&uap->port);
|
2017-04-01 19:42:09 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return true;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_modem_status(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
unsigned int status, delta;
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
status = pl011_read(uap, REG_FR) & UART01x_FR_MODEM_ANY;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
delta = status ^ uap->old_status;
|
|
|
|
uap->old_status = status;
|
|
|
|
|
|
|
|
if (!delta)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (delta & UART01x_FR_DCD)
|
|
|
|
uart_handle_dcd_change(&uap->port, status & UART01x_FR_DCD);
|
|
|
|
|
2016-07-08 09:00:39 +00:00
|
|
|
if (delta & uap->vendor->fr_dsr)
|
2005-04-16 22:20:36 +00:00
|
|
|
uap->port.icount.dsr++;
|
|
|
|
|
2016-07-08 09:00:39 +00:00
|
|
|
if (delta & uap->vendor->fr_cts)
|
|
|
|
uart_handle_cts_change(&uap->port,
|
|
|
|
status & uap->vendor->fr_cts);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-09-19 20:13:31 +00:00
|
|
|
wake_up_interruptible(&uap->port.state->port.delta_msr_wait);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:20 +00:00
|
|
|
static void check_apply_cts_event_workaround(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
unsigned int dummy_read;
|
|
|
|
|
|
|
|
if (!uap->vendor->cts_event_workaround)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* workaround to make sure that all bits are unlocked.. */
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(0x00, uap, REG_ICR);
|
2015-05-21 16:26:20 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* WA: introduce 26ns(1 uart clk) delay before W1C;
|
|
|
|
* single apb access will incur 2 pclk(133.12Mhz) delay,
|
|
|
|
* so add 2 dummy reads
|
|
|
|
*/
|
2015-11-03 14:51:13 +00:00
|
|
|
dummy_read = pl011_read(uap, REG_ICR);
|
|
|
|
dummy_read = pl011_read(uap, REG_ICR);
|
2015-05-21 16:26:20 +00:00
|
|
|
}
|
|
|
|
|
IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.
The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).
Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.
Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.
I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.
This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);
I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().
Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.
(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.
(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.
Signed-Off-By: David Howells <dhowells@redhat.com>
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
2006-10-05 13:55:46 +00:00
|
|
|
static irqreturn_t pl011_int(int irq, void *dev_id)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = dev_id;
|
2010-12-22 17:16:09 +00:00
|
|
|
unsigned long flags;
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int status, pass_counter = AMBA_ISR_PASS_LIMIT;
|
2015-05-21 16:26:19 +00:00
|
|
|
u16 imsc;
|
2005-04-16 22:20:36 +00:00
|
|
|
int handled = 0;
|
|
|
|
|
2010-12-22 17:16:09 +00:00
|
|
|
spin_lock_irqsave(&uap->port.lock, flags);
|
2015-11-03 14:51:13 +00:00
|
|
|
imsc = pl011_read(uap, REG_IMSC);
|
|
|
|
status = pl011_read(uap, REG_RIS) & imsc;
|
2005-04-16 22:20:36 +00:00
|
|
|
if (status) {
|
|
|
|
do {
|
2015-05-21 16:26:20 +00:00
|
|
|
check_apply_cts_event_workaround(uap);
|
2015-09-04 16:13:39 +00:00
|
|
|
|
2015-11-03 14:50:58 +00:00
|
|
|
pl011_write(status & ~(UART011_TXIS|UART011_RTIS|
|
|
|
|
UART011_RXIS),
|
2015-11-03 14:51:13 +00:00
|
|
|
uap, REG_ICR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2011-02-24 12:21:08 +00:00
|
|
|
if (status & (UART011_RTIS|UART011_RXIS)) {
|
|
|
|
if (pl011_dma_rx_running(uap))
|
|
|
|
pl011_dma_rx_irq(uap);
|
|
|
|
else
|
|
|
|
pl011_rx_chars(uap);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
if (status & (UART011_DSRMIS|UART011_DCDMIS|
|
|
|
|
UART011_CTSMIS|UART011_RIMIS))
|
|
|
|
pl011_modem_status(uap);
|
2015-04-27 15:49:05 +00:00
|
|
|
if (status & UART011_TXIS)
|
|
|
|
pl011_tx_chars(uap, true);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-03-26 09:17:02 +00:00
|
|
|
if (pass_counter-- == 0)
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
status = pl011_read(uap, REG_RIS) & imsc;
|
2005-04-16 22:20:36 +00:00
|
|
|
} while (status != 0);
|
|
|
|
handled = 1;
|
|
|
|
}
|
|
|
|
|
2010-12-22 17:16:09 +00:00
|
|
|
spin_unlock_irqrestore(&uap->port.lock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return IRQ_RETVAL(handled);
|
|
|
|
}
|
|
|
|
|
2012-06-17 13:44:19 +00:00
|
|
|
static unsigned int pl011_tx_empty(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2017-02-15 21:39:43 +00:00
|
|
|
|
|
|
|
/* Allow feature register bits to be inverted to work around errata */
|
|
|
|
unsigned int status = pl011_read(uap, REG_FR) ^ uap->vendor->inv_fr;
|
|
|
|
|
2016-07-08 09:00:39 +00:00
|
|
|
return status & (uap->vendor->fr_busy | UART01x_FR_TXFF) ?
|
|
|
|
0 : TIOCSER_TEMT;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2012-06-17 13:44:19 +00:00
|
|
|
static unsigned int pl011_get_mctrl(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int result = 0;
|
2015-11-03 14:51:13 +00:00
|
|
|
unsigned int status = pl011_read(uap, REG_FR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-10-19 06:40:31 +00:00
|
|
|
#define TIOCMBIT(uartbit, tiocmbit) \
|
2005-04-16 22:20:36 +00:00
|
|
|
if (status & uartbit) \
|
|
|
|
result |= tiocmbit
|
|
|
|
|
2007-10-19 06:40:31 +00:00
|
|
|
TIOCMBIT(UART01x_FR_DCD, TIOCM_CAR);
|
2016-07-08 09:00:39 +00:00
|
|
|
TIOCMBIT(uap->vendor->fr_dsr, TIOCM_DSR);
|
|
|
|
TIOCMBIT(uap->vendor->fr_cts, TIOCM_CTS);
|
|
|
|
TIOCMBIT(uap->vendor->fr_ri, TIOCM_RNG);
|
2007-10-19 06:40:31 +00:00
|
|
|
#undef TIOCMBIT
|
2005-04-16 22:20:36 +00:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_set_mctrl(struct uart_port *port, unsigned int mctrl)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int cr;
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
cr = pl011_read(uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2007-10-19 06:40:31 +00:00
|
|
|
#define TIOCMBIT(tiocmbit, uartbit) \
|
2005-04-16 22:20:36 +00:00
|
|
|
if (mctrl & tiocmbit) \
|
|
|
|
cr |= uartbit; \
|
|
|
|
else \
|
|
|
|
cr &= ~uartbit
|
|
|
|
|
2007-10-19 06:40:31 +00:00
|
|
|
TIOCMBIT(TIOCM_RTS, UART011_CR_RTS);
|
|
|
|
TIOCMBIT(TIOCM_DTR, UART011_CR_DTR);
|
|
|
|
TIOCMBIT(TIOCM_OUT1, UART011_CR_OUT1);
|
|
|
|
TIOCMBIT(TIOCM_OUT2, UART011_CR_OUT2);
|
|
|
|
TIOCMBIT(TIOCM_LOOP, UART011_CR_LBE);
|
2010-02-12 05:43:11 +00:00
|
|
|
|
|
|
|
if (uap->autorts) {
|
|
|
|
/* We need to disable auto-RTS if we want to turn RTS off */
|
|
|
|
TIOCMBIT(TIOCM_RTS, UART011_CR_RTSEN);
|
|
|
|
}
|
2007-10-19 06:40:31 +00:00
|
|
|
#undef TIOCMBIT
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(cr, uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_break_ctl(struct uart_port *port, int break_state)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned long flags;
|
|
|
|
unsigned int lcr_h;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&uap->port.lock, flags);
|
2015-11-16 17:40:41 +00:00
|
|
|
lcr_h = pl011_read(uap, REG_LCRH_TX);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (break_state == -1)
|
|
|
|
lcr_h |= UART01x_LCRH_BRK;
|
|
|
|
else
|
|
|
|
lcr_h &= ~UART01x_LCRH_BRK;
|
2015-11-16 17:40:41 +00:00
|
|
|
pl011_write(lcr_h, uap, REG_LCRH_TX);
|
2005-04-16 22:20:36 +00:00
|
|
|
spin_unlock_irqrestore(&uap->port.lock, flags);
|
|
|
|
}
|
|
|
|
|
2008-02-20 19:33:39 +00:00
|
|
|
#ifdef CONFIG_CONSOLE_POLL
|
2012-09-24 21:27:55 +00:00
|
|
|
|
|
|
|
static void pl011_quiesce_irqs(struct uart_port *port)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2012-09-24 21:27:55 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(pl011_read(uap, REG_MIS), uap, REG_ICR);
|
2012-09-24 21:27:55 +00:00
|
|
|
/*
|
|
|
|
* There is no way to clear TXIM as this is "ready to transmit IRQ", so
|
|
|
|
* we simply mask it. start_tx() will unmask it.
|
|
|
|
*
|
|
|
|
* Note we can race with start_tx(), and if the race happens, the
|
|
|
|
* polling user might get another interrupt just after we clear it.
|
|
|
|
* But it should be OK and can happen even w/o the race, e.g.
|
|
|
|
* controller immediately got some new data and raised the IRQ.
|
|
|
|
*
|
|
|
|
* And whoever uses polling routines assumes that it manages the device
|
|
|
|
* (including tx queue), so we're also fine with start_tx()'s caller
|
|
|
|
* side.
|
|
|
|
*/
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(pl011_read(uap, REG_IMSC) & ~UART011_TXIM, uap,
|
|
|
|
REG_IMSC);
|
2012-09-24 21:27:55 +00:00
|
|
|
}
|
|
|
|
|
2012-06-17 13:44:19 +00:00
|
|
|
static int pl011_get_poll_char(struct uart_port *port)
|
2008-02-20 19:33:39 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2008-02-20 19:33:39 +00:00
|
|
|
unsigned int status;
|
|
|
|
|
2012-09-24 21:27:55 +00:00
|
|
|
/*
|
|
|
|
* The caller might need IRQs lowered, e.g. if used with KDB NMI
|
|
|
|
* debugger.
|
|
|
|
*/
|
|
|
|
pl011_quiesce_irqs(port);
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
status = pl011_read(uap, REG_FR);
|
2010-05-21 02:04:22 +00:00
|
|
|
if (status & UART01x_FR_RXFE)
|
|
|
|
return NO_POLL_CHAR;
|
2008-02-20 19:33:39 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
return pl011_read(uap, REG_DR);
|
2008-02-20 19:33:39 +00:00
|
|
|
}
|
|
|
|
|
2012-06-17 13:44:19 +00:00
|
|
|
static void pl011_put_poll_char(struct uart_port *port,
|
2008-02-20 19:33:39 +00:00
|
|
|
unsigned char ch)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2008-02-20 19:33:39 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
while (pl011_read(uap, REG_FR) & UART01x_FR_TXFF)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
2008-02-20 19:33:39 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(ch, uap, REG_DR);
|
2008-02-20 19:33:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_CONSOLE_POLL */
|
|
|
|
|
2012-09-24 21:27:54 +00:00
|
|
|
static int pl011_hwinit(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
int retval;
|
|
|
|
|
2012-05-23 19:18:46 +00:00
|
|
|
/* Optionaly enable pins to be muxed in and configured */
|
2013-06-05 13:36:42 +00:00
|
|
|
pinctrl_pm_select_default_state(port->dev);
|
2012-05-23 19:18:46 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* Try to enable the clock producer.
|
|
|
|
*/
|
2012-08-26 16:01:01 +00:00
|
|
|
retval = clk_prepare_enable(uap->clk);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval)
|
2014-06-26 10:05:35 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
uap->port.uartclk = clk_get_rate(uap->clk);
|
|
|
|
|
2012-03-13 12:27:23 +00:00
|
|
|
/* Clear pending error and receive interrupts */
|
2015-11-03 14:50:58 +00:00
|
|
|
pl011_write(UART011_OEIS | UART011_BEIS | UART011_PEIS |
|
|
|
|
UART011_FEIS | UART011_RTIS | UART011_RXIS,
|
2015-11-03 14:51:13 +00:00
|
|
|
uap, REG_ICR);
|
2012-03-13 12:27:23 +00:00
|
|
|
|
2012-09-24 21:27:54 +00:00
|
|
|
/*
|
|
|
|
* Save interrupts enable mask, and enable RX interrupts in case if
|
|
|
|
* the interrupt is used for NMI entry.
|
|
|
|
*/
|
2015-11-03 14:51:13 +00:00
|
|
|
uap->im = pl011_read(uap, REG_IMSC);
|
|
|
|
pl011_write(UART011_RTIM | UART011_RXIM, uap, REG_IMSC);
|
2012-09-24 21:27:54 +00:00
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
if (dev_get_platdata(uap->port.dev)) {
|
2012-09-24 21:27:54 +00:00
|
|
|
struct amba_pl011_data *plat;
|
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
plat = dev_get_platdata(uap->port.dev);
|
2012-09-24 21:27:54 +00:00
|
|
|
if (plat->init)
|
|
|
|
plat->init();
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-11-03 14:51:08 +00:00
|
|
|
static bool pl011_split_lcrh(const struct uart_amba_port *uap)
|
|
|
|
{
|
2015-11-16 17:40:41 +00:00
|
|
|
return pl011_reg_to_offset(uap, REG_LCRH_RX) !=
|
|
|
|
pl011_reg_to_offset(uap, REG_LCRH_TX);
|
2015-11-03 14:51:08 +00:00
|
|
|
}
|
|
|
|
|
2013-12-10 10:18:59 +00:00
|
|
|
static void pl011_write_lcr_h(struct uart_amba_port *uap, unsigned int lcr_h)
|
|
|
|
{
|
2015-11-16 17:40:41 +00:00
|
|
|
pl011_write(lcr_h, uap, REG_LCRH_RX);
|
2015-11-03 14:51:08 +00:00
|
|
|
if (pl011_split_lcrh(uap)) {
|
2013-12-10 10:18:59 +00:00
|
|
|
int i;
|
|
|
|
/*
|
|
|
|
* Wait 10 PCLKs before writing LCRH_TX register,
|
|
|
|
* to get this delay write read only register 10 times
|
|
|
|
*/
|
|
|
|
for (i = 0; i < 10; ++i)
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(0xff, uap, REG_MIS);
|
2015-11-16 17:40:41 +00:00
|
|
|
pl011_write(lcr_h, uap, REG_LCRH_TX);
|
2013-12-10 10:18:59 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:15 +00:00
|
|
|
static int pl011_allocate_irq(struct uart_amba_port *uap)
|
|
|
|
{
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2015-05-21 16:26:15 +00:00
|
|
|
|
|
|
|
return request_irq(uap->port.irq, pl011_int, 0, "uart-pl011", uap);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Enable interrupts, only timeouts when using DMA
|
|
|
|
* if initial RX DMA job failed, start in interrupt mode
|
|
|
|
* as well.
|
|
|
|
*/
|
|
|
|
static void pl011_enable_interrupts(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
spin_lock_irq(&uap->port.lock);
|
|
|
|
|
|
|
|
/* Clear out any spuriously appearing RX interrupts */
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(UART011_RTIS | UART011_RXIS, uap, REG_ICR);
|
2015-05-21 16:26:15 +00:00
|
|
|
uap->im = UART011_RTIM;
|
|
|
|
if (!pl011_dma_rx_running(uap))
|
|
|
|
uap->im |= UART011_RXIM;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
2015-05-21 16:26:15 +00:00
|
|
|
spin_unlock_irq(&uap->port.lock);
|
|
|
|
}
|
|
|
|
|
2012-09-24 21:27:54 +00:00
|
|
|
static int pl011_startup(struct uart_port *port)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2015-03-04 12:27:33 +00:00
|
|
|
unsigned int cr;
|
2012-09-24 21:27:54 +00:00
|
|
|
int retval;
|
|
|
|
|
|
|
|
retval = pl011_hwinit(port);
|
|
|
|
if (retval)
|
|
|
|
goto clk_dis;
|
|
|
|
|
2015-05-21 16:26:15 +00:00
|
|
|
retval = pl011_allocate_irq(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval)
|
|
|
|
goto clk_dis;
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->vendor->ifls, uap, REG_IFLS);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-03-04 12:27:33 +00:00
|
|
|
spin_lock_irq(&uap->port.lock);
|
2013-12-10 10:19:00 +00:00
|
|
|
|
2012-01-18 10:23:59 +00:00
|
|
|
/* restore RTS and DTR */
|
|
|
|
cr = uap->old_cr & (UART011_CR_RTS | UART011_CR_DTR);
|
|
|
|
cr |= UART01x_CR_UARTEN | UART011_CR_RXE | UART011_CR_TXE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(cr, uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2013-12-10 10:18:58 +00:00
|
|
|
spin_unlock_irq(&uap->port.lock);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* initialise the old status of the modem signals
|
|
|
|
*/
|
2015-11-03 14:51:13 +00:00
|
|
|
uap->old_status = pl011_read(uap, REG_FR) & UART01x_FR_MODEM_ANY;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
/* Startup DMA */
|
|
|
|
pl011_dma_startup(uap);
|
|
|
|
|
2015-05-21 16:26:15 +00:00
|
|
|
pl011_enable_interrupts(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
clk_dis:
|
2012-08-26 16:01:01 +00:00
|
|
|
clk_disable_unprepare(uap->clk);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static int sbsa_uart_startup(struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
retval = pl011_hwinit(port);
|
|
|
|
if (retval)
|
|
|
|
return retval;
|
|
|
|
|
|
|
|
retval = pl011_allocate_irq(uap);
|
|
|
|
if (retval)
|
|
|
|
return retval;
|
|
|
|
|
|
|
|
/* The SBSA UART does not support any modem status lines. */
|
|
|
|
uap->old_status = 0;
|
|
|
|
|
|
|
|
pl011_enable_interrupts(uap);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-06-02 07:13:52 +00:00
|
|
|
static void pl011_shutdown_channel(struct uart_amba_port *uap,
|
|
|
|
unsigned int lcrh)
|
|
|
|
{
|
2015-09-04 16:13:39 +00:00
|
|
|
unsigned long val;
|
2010-06-02 07:13:52 +00:00
|
|
|
|
2015-11-03 14:51:03 +00:00
|
|
|
val = pl011_read(uap, lcrh);
|
2015-09-04 16:13:39 +00:00
|
|
|
val &= ~(UART01x_LCRH_BRK | UART01x_LCRH_FEN);
|
2015-11-03 14:51:03 +00:00
|
|
|
pl011_write(val, uap, lcrh);
|
2010-06-02 07:13:52 +00:00
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:16 +00:00
|
|
|
/*
|
|
|
|
* disable the port. It should not disable RTS and DTR.
|
|
|
|
* Also RTS and DTR state should be preserved to restore
|
|
|
|
* it during startup().
|
|
|
|
*/
|
|
|
|
static void pl011_disable_uart(struct uart_amba_port *uap)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2012-01-18 10:23:59 +00:00
|
|
|
unsigned int cr;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-02-12 05:43:11 +00:00
|
|
|
uap->autorts = false;
|
2013-12-10 10:18:58 +00:00
|
|
|
spin_lock_irq(&uap->port.lock);
|
2015-11-03 14:51:13 +00:00
|
|
|
cr = pl011_read(uap, REG_CR);
|
2012-01-18 10:23:59 +00:00
|
|
|
uap->old_cr = cr;
|
|
|
|
cr &= UART011_CR_RTS | UART011_CR_DTR;
|
|
|
|
cr |= UART01x_CR_UARTEN | UART011_CR_TXE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(cr, uap, REG_CR);
|
2013-12-10 10:18:58 +00:00
|
|
|
spin_unlock_irq(&uap->port.lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* disable break condition and fifos
|
|
|
|
*/
|
2015-11-16 17:40:41 +00:00
|
|
|
pl011_shutdown_channel(uap, REG_LCRH_RX);
|
2015-11-03 14:51:08 +00:00
|
|
|
if (pl011_split_lcrh(uap))
|
2015-11-16 17:40:41 +00:00
|
|
|
pl011_shutdown_channel(uap, REG_LCRH_TX);
|
2015-05-21 16:26:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_disable_interrupts(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
spin_lock_irq(&uap->port.lock);
|
|
|
|
|
|
|
|
/* mask all interrupts and clear all pending ones */
|
|
|
|
uap->im = 0;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(uap->im, uap, REG_IMSC);
|
|
|
|
pl011_write(0xffff, uap, REG_ICR);
|
2015-05-21 16:26:16 +00:00
|
|
|
|
|
|
|
spin_unlock_irq(&uap->port.lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_shutdown(struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
|
|
|
|
|
|
|
pl011_disable_interrupts(uap);
|
|
|
|
|
|
|
|
pl011_dma_shutdown(uap);
|
|
|
|
|
|
|
|
free_irq(uap->port.irq, uap);
|
|
|
|
|
|
|
|
pl011_disable_uart(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Shut down the clock producer
|
|
|
|
*/
|
2012-08-26 16:01:01 +00:00
|
|
|
clk_disable_unprepare(uap->clk);
|
2012-05-23 19:18:46 +00:00
|
|
|
/* Optionally let pins go into sleep states */
|
2013-06-05 13:36:42 +00:00
|
|
|
pinctrl_pm_select_sleep_state(port->dev);
|
2011-06-13 08:11:33 +00:00
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
if (dev_get_platdata(uap->port.dev)) {
|
2011-06-13 08:11:33 +00:00
|
|
|
struct amba_pl011_data *plat;
|
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
plat = dev_get_platdata(uap->port.dev);
|
2011-06-13 08:11:33 +00:00
|
|
|
if (plat->exit)
|
|
|
|
plat->exit();
|
|
|
|
}
|
|
|
|
|
2014-11-06 14:06:12 +00:00
|
|
|
if (uap->port.ops->flush_buffer)
|
|
|
|
uap->port.ops->flush_buffer(port);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static void sbsa_uart_shutdown(struct uart_port *port)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
|
|
|
|
|
|
|
pl011_disable_interrupts(uap);
|
|
|
|
|
|
|
|
free_irq(uap->port.irq, uap);
|
|
|
|
|
|
|
|
if (uap->port.ops->flush_buffer)
|
|
|
|
uap->port.ops->flush_buffer(port);
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:17 +00:00
|
|
|
static void
|
|
|
|
pl011_setup_status_masks(struct uart_port *port, struct ktermios *termios)
|
|
|
|
{
|
|
|
|
port->read_status_mask = UART011_DR_OE | 255;
|
|
|
|
if (termios->c_iflag & INPCK)
|
|
|
|
port->read_status_mask |= UART011_DR_FE | UART011_DR_PE;
|
|
|
|
if (termios->c_iflag & (IGNBRK | BRKINT | PARMRK))
|
|
|
|
port->read_status_mask |= UART011_DR_BE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Characters to ignore
|
|
|
|
*/
|
|
|
|
port->ignore_status_mask = 0;
|
|
|
|
if (termios->c_iflag & IGNPAR)
|
|
|
|
port->ignore_status_mask |= UART011_DR_FE | UART011_DR_PE;
|
|
|
|
if (termios->c_iflag & IGNBRK) {
|
|
|
|
port->ignore_status_mask |= UART011_DR_BE;
|
|
|
|
/*
|
|
|
|
* If we're ignoring parity and break indicators,
|
|
|
|
* ignore overruns too (for real raw support).
|
|
|
|
*/
|
|
|
|
if (termios->c_iflag & IGNPAR)
|
|
|
|
port->ignore_status_mask |= UART011_DR_OE;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Ignore all characters if CREAD is not set.
|
|
|
|
*/
|
|
|
|
if ((termios->c_cflag & CREAD) == 0)
|
|
|
|
port->ignore_status_mask |= UART_DUMMY_DR_RX;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static void
|
2006-12-08 10:38:45 +00:00
|
|
|
pl011_set_termios(struct uart_port *port, struct ktermios *termios,
|
|
|
|
struct ktermios *old)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int lcr_h, old_cr;
|
|
|
|
unsigned long flags;
|
2010-12-22 17:48:26 +00:00
|
|
|
unsigned int baud, quot, clkdiv;
|
|
|
|
|
|
|
|
if (uap->vendor->oversampling)
|
|
|
|
clkdiv = 8;
|
|
|
|
else
|
|
|
|
clkdiv = 16;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Ask the core to calculate the divisor for us.
|
|
|
|
*/
|
2010-06-02 19:40:22 +00:00
|
|
|
baud = uart_get_baud_rate(port, termios, old, 0,
|
2010-12-22 17:48:26 +00:00
|
|
|
port->uartclk / clkdiv);
|
2013-04-03 02:10:37 +00:00
|
|
|
#ifdef CONFIG_DMA_ENGINE
|
2013-03-27 09:38:11 +00:00
|
|
|
/*
|
|
|
|
* Adjust RX DMA polling rate with baud rate if not specified.
|
|
|
|
*/
|
|
|
|
if (uap->dmarx.auto_poll_rate)
|
|
|
|
uap->dmarx.poll_rate = DIV_ROUND_UP(10000000, baud);
|
2013-04-03 02:10:37 +00:00
|
|
|
#endif
|
2010-06-02 19:40:22 +00:00
|
|
|
|
|
|
|
if (baud > port->uartclk/16)
|
|
|
|
quot = DIV_ROUND_CLOSEST(port->uartclk * 8, baud);
|
|
|
|
else
|
|
|
|
quot = DIV_ROUND_CLOSEST(port->uartclk * 4, baud);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (termios->c_cflag & CSIZE) {
|
|
|
|
case CS5:
|
|
|
|
lcr_h = UART01x_LCRH_WLEN_5;
|
|
|
|
break;
|
|
|
|
case CS6:
|
|
|
|
lcr_h = UART01x_LCRH_WLEN_6;
|
|
|
|
break;
|
|
|
|
case CS7:
|
|
|
|
lcr_h = UART01x_LCRH_WLEN_7;
|
|
|
|
break;
|
|
|
|
default: // CS8
|
|
|
|
lcr_h = UART01x_LCRH_WLEN_8;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (termios->c_cflag & CSTOPB)
|
|
|
|
lcr_h |= UART01x_LCRH_STP2;
|
|
|
|
if (termios->c_cflag & PARENB) {
|
|
|
|
lcr_h |= UART01x_LCRH_PEN;
|
|
|
|
if (!(termios->c_cflag & PARODD))
|
|
|
|
lcr_h |= UART01x_LCRH_EPS;
|
2016-03-04 05:11:53 +00:00
|
|
|
if (termios->c_cflag & CMSPAR)
|
|
|
|
lcr_h |= UART011_LCRH_SPS;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2010-12-22 17:13:05 +00:00
|
|
|
if (uap->fifosize > 1)
|
2005-04-16 22:20:36 +00:00
|
|
|
lcr_h |= UART01x_LCRH_FEN;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&port->lock, flags);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Update the per-port timeout.
|
|
|
|
*/
|
|
|
|
uart_update_timeout(port, termios->c_cflag, baud);
|
|
|
|
|
2015-05-21 16:26:17 +00:00
|
|
|
pl011_setup_status_masks(port, termios);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
if (UART_ENABLE_MS(port, termios->c_cflag))
|
|
|
|
pl011_enable_ms(port);
|
|
|
|
|
|
|
|
/* first, disable everything */
|
2015-11-03 14:51:13 +00:00
|
|
|
old_cr = pl011_read(uap, REG_CR);
|
|
|
|
pl011_write(0, uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-02-12 05:43:11 +00:00
|
|
|
if (termios->c_cflag & CRTSCTS) {
|
|
|
|
if (old_cr & UART011_CR_RTS)
|
|
|
|
old_cr |= UART011_CR_RTSEN;
|
|
|
|
|
|
|
|
old_cr |= UART011_CR_CTSEN;
|
|
|
|
uap->autorts = true;
|
|
|
|
} else {
|
|
|
|
old_cr &= ~(UART011_CR_CTSEN | UART011_CR_RTSEN);
|
|
|
|
uap->autorts = false;
|
|
|
|
}
|
|
|
|
|
2010-12-22 17:48:26 +00:00
|
|
|
if (uap->vendor->oversampling) {
|
|
|
|
if (baud > port->uartclk / 16)
|
2010-06-02 19:40:22 +00:00
|
|
|
old_cr |= ST_UART011_CR_OVSFACT;
|
|
|
|
else
|
|
|
|
old_cr &= ~ST_UART011_CR_OVSFACT;
|
|
|
|
}
|
|
|
|
|
2012-09-26 15:21:36 +00:00
|
|
|
/*
|
|
|
|
* Workaround for the ST Micro oversampling variants to
|
|
|
|
* increase the bitrate slightly, by lowering the divisor,
|
|
|
|
* to avoid delayed sampling of start bit at high speeds,
|
|
|
|
* else we see data corruption.
|
|
|
|
*/
|
|
|
|
if (uap->vendor->oversampling) {
|
|
|
|
if ((baud >= 3000000) && (baud < 3250000) && (quot > 1))
|
|
|
|
quot -= 1;
|
|
|
|
else if ((baud > 3250000) && (quot > 2))
|
|
|
|
quot -= 2;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
/* Set baud rate */
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(quot & 0x3f, uap, REG_FBRD);
|
|
|
|
pl011_write(quot >> 6, uap, REG_IBRD);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* ----------v----------v----------v----------v-----
|
2015-11-16 17:40:41 +00:00
|
|
|
* NOTE: REG_LCRH_TX and REG_LCRH_RX MUST BE WRITTEN AFTER
|
2015-11-03 14:51:13 +00:00
|
|
|
* REG_FBRD & REG_IBRD.
|
2005-04-16 22:20:36 +00:00
|
|
|
* ----------^----------^----------^----------^-----
|
|
|
|
*/
|
2013-12-10 10:18:59 +00:00
|
|
|
pl011_write_lcr_h(uap, lcr_h);
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(old_cr, uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
spin_unlock_irqrestore(&port->lock, flags);
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static void
|
|
|
|
sbsa_uart_set_termios(struct uart_port *port, struct ktermios *termios,
|
|
|
|
struct ktermios *old)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
tty_termios_encode_baud_rate(termios, uap->fixed_baud, uap->fixed_baud);
|
|
|
|
|
|
|
|
/* The SBSA UART only supports 8n1 without hardware flow control. */
|
|
|
|
termios->c_cflag &= ~(CSIZE | CSTOPB | PARENB | PARODD);
|
|
|
|
termios->c_cflag &= ~(CMSPAR | CRTSCTS);
|
|
|
|
termios->c_cflag |= CS8 | CLOCAL;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&port->lock, flags);
|
|
|
|
uart_update_timeout(port, CS8, uap->fixed_baud);
|
|
|
|
pl011_setup_status_masks(port, termios);
|
|
|
|
spin_unlock_irqrestore(&port->lock, flags);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static const char *pl011_type(struct uart_port *port)
|
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2010-12-28 09:16:54 +00:00
|
|
|
return uap->port.type == PORT_AMBA ? uap->type : NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Release the memory region(s) being used by 'port'
|
|
|
|
*/
|
2012-06-17 13:44:19 +00:00
|
|
|
static void pl011_release_port(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
release_mem_region(port->mapbase, SZ_4K);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Request the memory region(s) being used by 'port'
|
|
|
|
*/
|
2012-06-17 13:44:19 +00:00
|
|
|
static int pl011_request_port(struct uart_port *port)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
return request_mem_region(port->mapbase, SZ_4K, "uart-pl011")
|
|
|
|
!= NULL ? 0 : -EBUSY;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Configure/autoconfigure the port.
|
|
|
|
*/
|
2012-06-17 13:44:19 +00:00
|
|
|
static void pl011_config_port(struct uart_port *port, int flags)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
if (flags & UART_CONFIG_TYPE) {
|
|
|
|
port->type = PORT_AMBA;
|
2012-06-17 13:44:19 +00:00
|
|
|
pl011_request_port(port);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* verify the new serial_struct (for TIOCSSERIAL).
|
|
|
|
*/
|
2012-06-17 13:44:19 +00:00
|
|
|
static int pl011_verify_port(struct uart_port *port, struct serial_struct *ser)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
if (ser->type != PORT_UNKNOWN && ser->type != PORT_AMBA)
|
|
|
|
ret = -EINVAL;
|
2008-08-20 03:49:55 +00:00
|
|
|
if (ser->irq < 0 || ser->irq >= nr_irqs)
|
2005-04-16 22:20:36 +00:00
|
|
|
ret = -EINVAL;
|
|
|
|
if (ser->baud_base < 9600)
|
|
|
|
ret = -EINVAL;
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2017-01-25 17:48:52 +00:00
|
|
|
static const struct uart_ops amba_pl011_pops = {
|
2012-06-17 13:44:19 +00:00
|
|
|
.tx_empty = pl011_tx_empty,
|
2005-04-16 22:20:36 +00:00
|
|
|
.set_mctrl = pl011_set_mctrl,
|
2012-06-17 13:44:19 +00:00
|
|
|
.get_mctrl = pl011_get_mctrl,
|
2005-04-16 22:20:36 +00:00
|
|
|
.stop_tx = pl011_stop_tx,
|
|
|
|
.start_tx = pl011_start_tx,
|
|
|
|
.stop_rx = pl011_stop_rx,
|
|
|
|
.enable_ms = pl011_enable_ms,
|
|
|
|
.break_ctl = pl011_break_ctl,
|
|
|
|
.startup = pl011_startup,
|
|
|
|
.shutdown = pl011_shutdown,
|
ARM: PL011: Add support for transmit DMA
Add DMA engine support for transmit to the PL011 driver. Based on a
patch from Linus Walliej, with the following changes:
- remove RX DMA support. As PL011 doesn't give us receive timeout
interrupts, we only get notified of received data when the RX DMA
has completed. This rather sucks for interactive use of the TTY.
- remove abuse of completions. Completions are supposed to be for
events, not to tell what condition buffers are in. Replace it with
a simple 'queued' bool.
- fix locking - it is only safe to access the circular buffer with the
port lock held.
- only map the DMA buffer when required - if we're ever behind an IOMMU
this helps keep IOMMU usage down, and also ensures that we're legal
when we change the scatterlist entry length.
- fix XON/XOFF sending - we must send XON/XOFF characters out as soon
as possible - waiting for up to 4095 characters in the DMA buffer
to be sent first is not acceptable.
- fix XON/XOFF receive handling - we need to stop DMA when instructed
to by the TTY layer, and restart it again when instructed to. There
is a subtle problem here: we must not completely empty the circular
buffer with DMA, otherwise we will not be notified of XON.
- change the 'enable_dma' flag into a 'using DMA' flag, and track
whether we can use TX DMA by whether the channel pointer is non-NULL.
This gives us more control over whether we use DMA in the driver.
- we don't need to have the TX DMA buffer continually allocated for
each port - instead, allocate it when the port starts up, and free
it when it's shut down. Update the 'using DMA' flag if we get
the buffer, and adjust the TTY FIFO size appropriately.
- if we're going to use PIO to send characters, use the existing IRQ
based functionality rather than reimplementing it. This also ensures
we call uart_write_wakeup() at the appropriate time, otherwise we'll
stall.
- use DMA engine helper functions for type safety.
- fix init when built as a module - we can't have to initcall functions,
so we must settle on one. This means we can eliminate the deferred
DMA initialization.
- there is no need to terminate transfers on a failed prep_slave_sg()
call - nothing has been setup, so nothing needs to be terminated.
This avoids a potential deadlock in the DMA engine code
(tasklet->callback->failed prepare->terminate->tasklet_disable
which then ends up waiting for the tasklet to finish running.)
- Dan says that the submission callback should not return an error:
| dma_submit_error() is something I should have removed after commit
| a0587bcf "ioat1: move descriptor allocation from submit to prep" all
| errors should be notified by prep failing to return a descriptor
| handle. Negative dma_cookie_t values are only returned by the
| dma_async_memcpy* calls which translate a prep failure into -ENOMEM.
So remove the error handling at that point. This also solves the
potential deadlock mentioned in the previous comment.
Acked-by: Linus Walleij <linus.walleij@stericsson.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2010-12-22 17:24:39 +00:00
|
|
|
.flush_buffer = pl011_dma_flush_buffer,
|
2005-04-16 22:20:36 +00:00
|
|
|
.set_termios = pl011_set_termios,
|
|
|
|
.type = pl011_type,
|
2012-06-17 13:44:19 +00:00
|
|
|
.release_port = pl011_release_port,
|
|
|
|
.request_port = pl011_request_port,
|
|
|
|
.config_port = pl011_config_port,
|
|
|
|
.verify_port = pl011_verify_port,
|
2008-02-20 19:33:39 +00:00
|
|
|
#ifdef CONFIG_CONSOLE_POLL
|
2012-09-24 21:27:54 +00:00
|
|
|
.poll_init = pl011_hwinit,
|
2012-06-17 13:44:19 +00:00
|
|
|
.poll_get_char = pl011_get_poll_char,
|
|
|
|
.poll_put_char = pl011_put_poll_char,
|
2008-02-20 19:33:39 +00:00
|
|
|
#endif
|
2005-04-16 22:20:36 +00:00
|
|
|
};
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static void sbsa_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static unsigned int sbsa_uart_get_mctrl(struct uart_port *port)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct uart_ops sbsa_uart_pops = {
|
|
|
|
.tx_empty = pl011_tx_empty,
|
|
|
|
.set_mctrl = sbsa_uart_set_mctrl,
|
|
|
|
.get_mctrl = sbsa_uart_get_mctrl,
|
|
|
|
.stop_tx = pl011_stop_tx,
|
|
|
|
.start_tx = pl011_start_tx,
|
|
|
|
.stop_rx = pl011_stop_rx,
|
|
|
|
.startup = sbsa_uart_startup,
|
|
|
|
.shutdown = sbsa_uart_shutdown,
|
|
|
|
.set_termios = sbsa_uart_set_termios,
|
|
|
|
.type = pl011_type,
|
|
|
|
.release_port = pl011_release_port,
|
|
|
|
.request_port = pl011_request_port,
|
|
|
|
.config_port = pl011_config_port,
|
|
|
|
.verify_port = pl011_verify_port,
|
|
|
|
#ifdef CONFIG_CONSOLE_POLL
|
|
|
|
.poll_init = pl011_hwinit,
|
|
|
|
.poll_get_char = pl011_get_poll_char,
|
|
|
|
.poll_put_char = pl011_put_poll_char,
|
|
|
|
#endif
|
|
|
|
};
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static struct uart_amba_port *amba_ports[UART_NR];
|
|
|
|
|
|
|
|
#ifdef CONFIG_SERIAL_AMBA_PL011_CONSOLE
|
|
|
|
|
2006-03-20 20:00:09 +00:00
|
|
|
static void pl011_console_putchar(struct uart_port *port, int ch)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2014-09-03 11:51:55 +00:00
|
|
|
struct uart_amba_port *uap =
|
|
|
|
container_of(port, struct uart_amba_port, port);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
while (pl011_read(uap, REG_FR) & UART01x_FR_TXFF)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(ch, uap, REG_DR);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
pl011_console_write(struct console *co, const char *s, unsigned int count)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = amba_ports[co->index];
|
2016-01-15 20:32:20 +00:00
|
|
|
unsigned int old_cr = 0, new_cr;
|
2012-01-17 10:52:28 +00:00
|
|
|
unsigned long flags;
|
|
|
|
int locked = 1;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
clk_enable(uap->clk);
|
|
|
|
|
2012-01-17 10:52:28 +00:00
|
|
|
local_irq_save(flags);
|
|
|
|
if (uap->port.sysrq)
|
|
|
|
locked = 0;
|
|
|
|
else if (oops_in_progress)
|
|
|
|
locked = spin_trylock(&uap->port.lock);
|
|
|
|
else
|
|
|
|
spin_lock(&uap->port.lock);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/*
|
|
|
|
* First save the CR then disable the interrupts
|
|
|
|
*/
|
2015-05-21 16:26:21 +00:00
|
|
|
if (!uap->vendor->always_enabled) {
|
2015-11-03 14:51:13 +00:00
|
|
|
old_cr = pl011_read(uap, REG_CR);
|
2015-05-21 16:26:21 +00:00
|
|
|
new_cr = old_cr & ~UART011_CR_CTSEN;
|
|
|
|
new_cr |= UART01x_CR_UARTEN | UART011_CR_TXE;
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(new_cr, uap, REG_CR);
|
2015-05-21 16:26:21 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2006-03-20 20:00:09 +00:00
|
|
|
uart_console_write(&uap->port, s, count, pl011_console_putchar);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
2017-02-15 21:39:43 +00:00
|
|
|
* Finally, wait for transmitter to become empty and restore the
|
|
|
|
* TCR. Allow feature register bits to be inverted to work around
|
|
|
|
* errata.
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2017-02-15 21:39:43 +00:00
|
|
|
while ((pl011_read(uap, REG_FR) ^ uap->vendor->inv_fr)
|
|
|
|
& uap->vendor->fr_busy)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
2015-05-21 16:26:21 +00:00
|
|
|
if (!uap->vendor->always_enabled)
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(old_cr, uap, REG_CR);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-01-17 10:52:28 +00:00
|
|
|
if (locked)
|
|
|
|
spin_unlock(&uap->port.lock);
|
|
|
|
local_irq_restore(flags);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
clk_disable(uap->clk);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __init
|
|
|
|
pl011_console_get_options(struct uart_amba_port *uap, int *baud,
|
|
|
|
int *parity, int *bits)
|
|
|
|
{
|
2015-11-03 14:51:13 +00:00
|
|
|
if (pl011_read(uap, REG_CR) & UART01x_CR_UARTEN) {
|
2005-04-16 22:20:36 +00:00
|
|
|
unsigned int lcr_h, ibrd, fbrd;
|
|
|
|
|
2015-11-16 17:40:41 +00:00
|
|
|
lcr_h = pl011_read(uap, REG_LCRH_TX);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
*parity = 'n';
|
|
|
|
if (lcr_h & UART01x_LCRH_PEN) {
|
|
|
|
if (lcr_h & UART01x_LCRH_EPS)
|
|
|
|
*parity = 'e';
|
|
|
|
else
|
|
|
|
*parity = 'o';
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((lcr_h & 0x60) == UART01x_LCRH_WLEN_7)
|
|
|
|
*bits = 7;
|
|
|
|
else
|
|
|
|
*bits = 8;
|
|
|
|
|
2015-11-03 14:51:13 +00:00
|
|
|
ibrd = pl011_read(uap, REG_IBRD);
|
|
|
|
fbrd = pl011_read(uap, REG_FBRD);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
*baud = uap->port.uartclk * 4 / (64 * ibrd + fbrd);
|
2010-06-02 19:40:22 +00:00
|
|
|
|
2010-12-22 17:48:26 +00:00
|
|
|
if (uap->vendor->oversampling) {
|
2015-11-03 14:51:13 +00:00
|
|
|
if (pl011_read(uap, REG_CR)
|
2010-06-02 19:40:22 +00:00
|
|
|
& ST_UART011_CR_OVSFACT)
|
|
|
|
*baud *= 2;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __init pl011_console_setup(struct console *co, char *options)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap;
|
|
|
|
int baud = 38400;
|
|
|
|
int bits = 8;
|
|
|
|
int parity = 'n';
|
|
|
|
int flow = 'n';
|
2011-09-22 10:35:30 +00:00
|
|
|
int ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Check whether an invalid uart number has been specified, and
|
|
|
|
* if so, search for the first available port that does have
|
|
|
|
* console support.
|
|
|
|
*/
|
|
|
|
if (co->index >= UART_NR)
|
|
|
|
co->index = 0;
|
|
|
|
uap = amba_ports[co->index];
|
2007-01-22 18:59:42 +00:00
|
|
|
if (!uap)
|
|
|
|
return -ENODEV;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-05-23 19:18:46 +00:00
|
|
|
/* Allow pins to be muxed in and configured */
|
2013-06-05 13:36:42 +00:00
|
|
|
pinctrl_pm_select_default_state(uap->port.dev);
|
2012-05-23 19:18:46 +00:00
|
|
|
|
2011-09-22 10:35:30 +00:00
|
|
|
ret = clk_prepare(uap->clk);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
if (dev_get_platdata(uap->port.dev)) {
|
2011-06-13 08:11:33 +00:00
|
|
|
struct amba_pl011_data *plat;
|
|
|
|
|
2013-07-30 08:06:57 +00:00
|
|
|
plat = dev_get_platdata(uap->port.dev);
|
2011-06-13 08:11:33 +00:00
|
|
|
if (plat->init)
|
|
|
|
plat->init();
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
uap->port.uartclk = clk_get_rate(uap->clk);
|
|
|
|
|
2015-05-21 16:26:22 +00:00
|
|
|
if (uap->vendor->fixed_options) {
|
|
|
|
baud = uap->fixed_baud;
|
|
|
|
} else {
|
|
|
|
if (options)
|
|
|
|
uart_parse_options(options,
|
|
|
|
&baud, &parity, &bits, &flow);
|
|
|
|
else
|
|
|
|
pl011_console_get_options(uap, &baud, &parity, &bits);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return uart_set_options(&uap->port, co, baud, parity, bits, flow);
|
|
|
|
}
|
|
|
|
|
2016-10-04 07:15:32 +00:00
|
|
|
/**
|
|
|
|
* pl011_console_match - non-standard console matching
|
|
|
|
* @co: registering console
|
|
|
|
* @name: name from console command line
|
|
|
|
* @idx: index from console command line
|
|
|
|
* @options: ptr to option string from console command line
|
|
|
|
*
|
|
|
|
* Only attempts to match console command lines of the form:
|
|
|
|
* console=pl011,mmio|mmio32,<addr>[,<options>]
|
|
|
|
* console=pl011,0x<addr>[,<options>]
|
|
|
|
* This form is used to register an initial earlycon boot console and
|
|
|
|
* replace it with the amba_console at pl011 driver init.
|
|
|
|
*
|
|
|
|
* Performs console setup for a match (as required by interface)
|
|
|
|
* If no <options> are specified, then assume the h/w is already setup.
|
|
|
|
*
|
|
|
|
* Returns 0 if console matches; otherwise non-zero to use default matching
|
|
|
|
*/
|
|
|
|
static int __init pl011_console_match(struct console *co, char *name, int idx,
|
|
|
|
char *options)
|
|
|
|
{
|
|
|
|
unsigned char iotype;
|
|
|
|
resource_size_t addr;
|
|
|
|
int i;
|
|
|
|
|
2017-02-15 21:39:43 +00:00
|
|
|
if (strcmp(name, "qdf2400_e44") == 0) {
|
|
|
|
pr_info_once("UART: Working around QDF2400 SoC erratum 44");
|
|
|
|
qdf2400_e44_present = true;
|
2017-03-01 15:23:02 +00:00
|
|
|
} else if (strcmp(name, "pl011") != 0) {
|
2016-10-04 07:15:32 +00:00
|
|
|
return -ENODEV;
|
2017-02-15 21:39:43 +00:00
|
|
|
}
|
2016-10-04 07:15:32 +00:00
|
|
|
|
|
|
|
if (uart_parse_earlycon(options, &iotype, &addr, &options))
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
if (iotype != UPIO_MEM && iotype != UPIO_MEM32)
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
/* try to match the port specified on the command line */
|
|
|
|
for (i = 0; i < ARRAY_SIZE(amba_ports); i++) {
|
|
|
|
struct uart_port *port;
|
|
|
|
|
|
|
|
if (!amba_ports[i])
|
|
|
|
continue;
|
|
|
|
|
|
|
|
port = &amba_ports[i]->port;
|
|
|
|
|
|
|
|
if (port->mapbase != addr)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
co->index = i;
|
|
|
|
port->cons = co;
|
|
|
|
return pl011_console_setup(co, options);
|
|
|
|
}
|
|
|
|
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
|
2005-09-14 21:36:03 +00:00
|
|
|
static struct uart_driver amba_reg;
|
2005-04-16 22:20:36 +00:00
|
|
|
static struct console amba_console = {
|
|
|
|
.name = "ttyAMA",
|
|
|
|
.write = pl011_console_write,
|
|
|
|
.device = uart_console_device,
|
|
|
|
.setup = pl011_console_setup,
|
2016-10-04 07:15:32 +00:00
|
|
|
.match = pl011_console_match,
|
2017-01-18 09:47:33 +00:00
|
|
|
.flags = CON_PRINTBUFFER | CON_ANYTIME,
|
2005-04-16 22:20:36 +00:00
|
|
|
.index = -1,
|
|
|
|
.data = &amba_reg,
|
|
|
|
};
|
|
|
|
|
|
|
|
#define AMBA_CONSOLE (&amba_console)
|
2014-04-18 22:19:57 +00:00
|
|
|
|
2017-02-15 21:39:43 +00:00
|
|
|
static void qdf2400_e44_putc(struct uart_port *port, int c)
|
|
|
|
{
|
|
|
|
while (readl(port->membase + UART01x_FR) & UART01x_FR_TXFF)
|
|
|
|
cpu_relax();
|
|
|
|
writel(c, port->membase + UART01x_DR);
|
|
|
|
while (!(readl(port->membase + UART01x_FR) & UART011_FR_TXFE))
|
|
|
|
cpu_relax();
|
|
|
|
}
|
|
|
|
|
|
|
|
static void qdf2400_e44_early_write(struct console *con, const char *s, unsigned n)
|
|
|
|
{
|
|
|
|
struct earlycon_device *dev = con->data;
|
|
|
|
|
|
|
|
uart_console_write(&dev->port, s, n, qdf2400_e44_putc);
|
|
|
|
}
|
|
|
|
|
2014-04-18 22:19:57 +00:00
|
|
|
static void pl011_putc(struct uart_port *port, int c)
|
|
|
|
{
|
2016-01-04 21:37:41 +00:00
|
|
|
while (readl(port->membase + UART01x_FR) & UART01x_FR_TXFF)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
2016-01-04 21:37:42 +00:00
|
|
|
if (port->iotype == UPIO_MEM32)
|
|
|
|
writel(c, port->membase + UART01x_DR);
|
|
|
|
else
|
|
|
|
writeb(c, port->membase + UART01x_DR);
|
2016-09-17 06:14:38 +00:00
|
|
|
while (readl(port->membase + UART01x_FR) & UART01x_FR_BUSY)
|
2016-01-15 20:32:20 +00:00
|
|
|
cpu_relax();
|
2014-04-18 22:19:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl011_early_write(struct console *con, const char *s, unsigned n)
|
|
|
|
{
|
|
|
|
struct earlycon_device *dev = con->data;
|
|
|
|
|
|
|
|
uart_console_write(&dev->port, s, n, pl011_putc);
|
|
|
|
}
|
|
|
|
|
2017-03-31 22:05:02 +00:00
|
|
|
/*
|
|
|
|
* On non-ACPI systems, earlycon is enabled by specifying
|
|
|
|
* "earlycon=pl011,<address>" on the kernel command line.
|
|
|
|
*
|
|
|
|
* On ACPI ARM64 systems, an "early" console is enabled via the SPCR table,
|
|
|
|
* by specifying only "earlycon" on the command line. Because it requires
|
|
|
|
* SPCR, the console starts after ACPI is parsed, which is later than a
|
|
|
|
* traditional early console.
|
|
|
|
*
|
|
|
|
* To get the traditional early console that starts before ACPI is parsed,
|
|
|
|
* specify the full "earlycon=pl011,<address>" option.
|
|
|
|
*/
|
2014-04-18 22:19:57 +00:00
|
|
|
static int __init pl011_early_console_setup(struct earlycon_device *device,
|
|
|
|
const char *opt)
|
|
|
|
{
|
|
|
|
if (!device->port.membase)
|
|
|
|
return -ENODEV;
|
|
|
|
|
2017-04-13 13:55:08 +00:00
|
|
|
device->con->write = pl011_early_write;
|
2017-03-31 22:05:02 +00:00
|
|
|
|
2014-04-18 22:19:57 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2014-03-27 13:08:03 +00:00
|
|
|
OF_EARLYCON_DECLARE(pl011, "arm,pl011", pl011_early_console_setup);
|
2016-10-31 02:04:19 +00:00
|
|
|
OF_EARLYCON_DECLARE(pl011, "arm,sbsa-uart", pl011_early_console_setup);
|
2017-04-13 13:55:08 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* On Qualcomm Datacenter Technologies QDF2400 SOCs affected by
|
|
|
|
* Erratum 44, traditional earlycon can be enabled by specifying
|
|
|
|
* "earlycon=qdf2400_e44,<address>". Any options are ignored.
|
|
|
|
*
|
|
|
|
* Alternatively, you can just specify "earlycon", and the early console
|
|
|
|
* will be enabled with the information from the SPCR table. In this
|
|
|
|
* case, the SPCR code will detect the need for the E44 work-around,
|
|
|
|
* and set the console name to "qdf2400_e44".
|
|
|
|
*/
|
|
|
|
static int __init
|
|
|
|
qdf2400_e44_early_console_setup(struct earlycon_device *device,
|
|
|
|
const char *opt)
|
|
|
|
{
|
|
|
|
if (!device->port.membase)
|
|
|
|
return -ENODEV;
|
|
|
|
|
|
|
|
device->con->write = qdf2400_e44_early_write;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
EARLYCON_DECLARE(qdf2400_e44, qdf2400_e44_early_console_setup);
|
2014-04-18 22:19:57 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#else
|
|
|
|
#define AMBA_CONSOLE NULL
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static struct uart_driver amba_reg = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.driver_name = "ttyAMA",
|
|
|
|
.dev_name = "ttyAMA",
|
|
|
|
.major = SERIAL_AMBA_MAJOR,
|
|
|
|
.minor = SERIAL_AMBA_MINOR,
|
|
|
|
.nr = UART_NR,
|
|
|
|
.cons = AMBA_CONSOLE,
|
|
|
|
};
|
|
|
|
|
2012-08-28 15:41:28 +00:00
|
|
|
static int pl011_probe_dt_alias(int index, struct device *dev)
|
|
|
|
{
|
|
|
|
struct device_node *np;
|
|
|
|
static bool seen_dev_with_alias = false;
|
|
|
|
static bool seen_dev_without_alias = false;
|
|
|
|
int ret = index;
|
|
|
|
|
|
|
|
if (!IS_ENABLED(CONFIG_OF))
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
np = dev->of_node;
|
|
|
|
if (!np)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
ret = of_alias_get_id(np, "serial");
|
remove lots of IS_ERR_VALUE abuses
Most users of IS_ERR_VALUE() in the kernel are wrong, as they
pass an 'int' into a function that takes an 'unsigned long'
argument. This happens to work because the type is sign-extended
on 64-bit architectures before it gets converted into an
unsigned type.
However, anything that passes an 'unsigned short' or 'unsigned int'
argument into IS_ERR_VALUE() is guaranteed to be broken, as are
8-bit integers and types that are wider than 'unsigned long'.
Andrzej Hajda has already fixed a lot of the worst abusers that
were causing actual bugs, but it would be nice to prevent any
users that are not passing 'unsigned long' arguments.
This patch changes all users of IS_ERR_VALUE() that I could find
on 32-bit ARM randconfig builds and x86 allmodconfig. For the
moment, this doesn't change the definition of IS_ERR_VALUE()
because there are probably still architecture specific users
elsewhere.
Almost all the warnings I got are for files that are better off
using 'if (err)' or 'if (err < 0)'.
The only legitimate user I could find that we get a warning for
is the (32-bit only) freescale fman driver, so I did not remove
the IS_ERR_VALUE() there but changed the type to 'unsigned long'.
For 9pfs, I just worked around one user whose calling conventions
are so obscure that I did not dare change the behavior.
I was using this definition for testing:
#define IS_ERR_VALUE(x) ((unsigned long*)NULL == (typeof (x)*)NULL && \
unlikely((unsigned long long)(x) >= (unsigned long long)(typeof(x))-MAX_ERRNO))
which ends up making all 16-bit or wider types work correctly with
the most plausible interpretation of what IS_ERR_VALUE() was supposed
to return according to its users, but also causes a compile-time
warning for any users that do not pass an 'unsigned long' argument.
I suggested this approach earlier this year, but back then we ended
up deciding to just fix the users that are obviously broken. After
the initial warning that caused me to get involved in the discussion
(fs/gfs2/dir.c) showed up again in the mainline kernel, Linus
asked me to send the whole thing again.
[ Updated the 9p parts as per Al Viro - Linus ]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://lkml.org/lkml/2016/1/7/363
Link: https://lkml.org/lkml/2016/5/27/486
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> # For nvmem part
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-05-27 21:23:25 +00:00
|
|
|
if (ret < 0) {
|
2012-08-28 15:41:28 +00:00
|
|
|
seen_dev_without_alias = true;
|
|
|
|
ret = index;
|
|
|
|
} else {
|
|
|
|
seen_dev_with_alias = true;
|
|
|
|
if (ret >= ARRAY_SIZE(amba_ports) || amba_ports[ret] != NULL) {
|
|
|
|
dev_warn(dev, "requested serial port %d not available.\n", ret);
|
|
|
|
ret = index;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (seen_dev_with_alias && seen_dev_without_alias)
|
|
|
|
dev_warn(dev, "aliased and non-aliased serial devices found in device tree. Serial port enumeration may be unpredictable.\n");
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:14 +00:00
|
|
|
/* unregisters the driver also if no more ports are left */
|
|
|
|
static void pl011_unregister_port(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
bool busy = false;
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(amba_ports); i++) {
|
|
|
|
if (amba_ports[i] == uap)
|
|
|
|
amba_ports[i] = NULL;
|
|
|
|
else if (amba_ports[i])
|
|
|
|
busy = true;
|
|
|
|
}
|
|
|
|
pl011_dma_remove(uap);
|
|
|
|
if (!busy)
|
|
|
|
uart_unregister_driver(&amba_reg);
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
static int pl011_find_free_port(void)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2015-05-21 16:26:18 +00:00
|
|
|
int i;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(amba_ports); i++)
|
|
|
|
if (amba_ports[i] == NULL)
|
2015-05-21 16:26:18 +00:00
|
|
|
return i;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
return -EBUSY;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
static int pl011_setup_port(struct device *dev, struct uart_amba_port *uap,
|
|
|
|
struct resource *mmiobase, int index)
|
|
|
|
{
|
|
|
|
void __iomem *base;
|
2012-08-28 15:41:28 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
base = devm_ioremap_resource(dev, mmiobase);
|
2015-07-09 13:21:41 +00:00
|
|
|
if (IS_ERR(base))
|
|
|
|
return PTR_ERR(base);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
index = pl011_probe_dt_alias(index, dev);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2012-01-18 10:23:59 +00:00
|
|
|
uap->old_cr = 0;
|
2015-05-21 16:26:18 +00:00
|
|
|
uap->port.dev = dev;
|
|
|
|
uap->port.mapbase = mmiobase->start;
|
2005-04-16 22:20:36 +00:00
|
|
|
uap->port.membase = base;
|
2010-12-22 17:13:05 +00:00
|
|
|
uap->port.fifosize = uap->fifosize;
|
2005-04-16 22:20:36 +00:00
|
|
|
uap->port.flags = UPF_BOOT_AUTOCONF;
|
2015-05-21 16:26:18 +00:00
|
|
|
uap->port.line = index;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
amba_ports[index] = uap;
|
2012-03-21 19:15:18 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
return 0;
|
|
|
|
}
|
2010-12-28 09:16:54 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
static int pl011_register_port(struct uart_amba_port *uap)
|
|
|
|
{
|
|
|
|
int ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
/* Ensure interrupts from this UART are masked and cleared */
|
2015-11-03 14:51:13 +00:00
|
|
|
pl011_write(0, uap, REG_IMSC);
|
|
|
|
pl011_write(0xffff, uap, REG_ICR);
|
2014-01-20 09:02:35 +00:00
|
|
|
|
|
|
|
if (!amba_reg.state) {
|
|
|
|
ret = uart_register_driver(&amba_reg);
|
|
|
|
if (ret < 0) {
|
2015-05-21 16:26:18 +00:00
|
|
|
dev_err(uap->port.dev,
|
2015-03-06 18:05:40 +00:00
|
|
|
"Failed to register AMBA-PL011 driver\n");
|
2014-01-20 09:02:35 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
ret = uart_add_one_port(&amba_reg, &uap->port);
|
2015-05-21 16:26:14 +00:00
|
|
|
if (ret)
|
|
|
|
pl011_unregister_port(uap);
|
2014-06-26 10:05:35 +00:00
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2015-05-21 16:26:18 +00:00
|
|
|
static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap;
|
|
|
|
struct vendor_data *vendor = id->data;
|
|
|
|
int portnr, ret;
|
|
|
|
|
|
|
|
portnr = pl011_find_free_port();
|
|
|
|
if (portnr < 0)
|
|
|
|
return portnr;
|
|
|
|
|
|
|
|
uap = devm_kzalloc(&dev->dev, sizeof(struct uart_amba_port),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!uap)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
uap->clk = devm_clk_get(&dev->dev, NULL);
|
|
|
|
if (IS_ERR(uap->clk))
|
|
|
|
return PTR_ERR(uap->clk);
|
|
|
|
|
2015-11-16 17:40:31 +00:00
|
|
|
uap->reg_offset = vendor->reg_offset;
|
2015-05-21 16:26:18 +00:00
|
|
|
uap->vendor = vendor;
|
|
|
|
uap->fifosize = vendor->get_fifosize(dev);
|
2016-01-04 21:37:42 +00:00
|
|
|
uap->port.iotype = vendor->access_32b ? UPIO_MEM32 : UPIO_MEM;
|
2015-05-21 16:26:18 +00:00
|
|
|
uap->port.irq = dev->irq[0];
|
|
|
|
uap->port.ops = &amba_pl011_pops;
|
|
|
|
|
|
|
|
snprintf(uap->type, sizeof(uap->type), "PL011 rev%u", amba_rev(dev));
|
|
|
|
|
|
|
|
ret = pl011_setup_port(&dev->dev, uap, &dev->res, portnr);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
amba_set_drvdata(dev, uap);
|
|
|
|
|
|
|
|
return pl011_register_port(uap);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static int pl011_remove(struct amba_device *dev)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = amba_get_drvdata(dev);
|
|
|
|
|
|
|
|
uart_remove_one_port(&amba_reg, &uap->port);
|
2015-05-21 16:26:14 +00:00
|
|
|
pl011_unregister_port(uap);
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-12-03 10:04:28 +00:00
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
|
|
static int pl011_suspend(struct device *dev)
|
2009-07-28 22:43:33 +00:00
|
|
|
{
|
2013-12-03 10:04:28 +00:00
|
|
|
struct uart_amba_port *uap = dev_get_drvdata(dev);
|
2009-07-28 22:43:33 +00:00
|
|
|
|
|
|
|
if (!uap)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
return uart_suspend_port(&amba_reg, &uap->port);
|
|
|
|
}
|
|
|
|
|
2013-12-03 10:04:28 +00:00
|
|
|
static int pl011_resume(struct device *dev)
|
2009-07-28 22:43:33 +00:00
|
|
|
{
|
2013-12-03 10:04:28 +00:00
|
|
|
struct uart_amba_port *uap = dev_get_drvdata(dev);
|
2009-07-28 22:43:33 +00:00
|
|
|
|
|
|
|
if (!uap)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
return uart_resume_port(&amba_reg, &uap->port);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2013-12-03 10:04:28 +00:00
|
|
|
static SIMPLE_DEV_PM_OPS(pl011_dev_pm_ops, pl011_suspend, pl011_resume);
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static int sbsa_uart_probe(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap;
|
|
|
|
struct resource *r;
|
|
|
|
int portnr, ret;
|
|
|
|
int baudrate;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check the mandatory baud rate parameter in the DT node early
|
|
|
|
* so that we can easily exit with the error.
|
|
|
|
*/
|
|
|
|
if (pdev->dev.of_node) {
|
|
|
|
struct device_node *np = pdev->dev.of_node;
|
|
|
|
|
|
|
|
ret = of_property_read_u32(np, "current-speed", &baudrate);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
} else {
|
|
|
|
baudrate = 115200;
|
|
|
|
}
|
|
|
|
|
|
|
|
portnr = pl011_find_free_port();
|
|
|
|
if (portnr < 0)
|
|
|
|
return portnr;
|
|
|
|
|
|
|
|
uap = devm_kzalloc(&pdev->dev, sizeof(struct uart_amba_port),
|
|
|
|
GFP_KERNEL);
|
|
|
|
if (!uap)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2016-05-09 07:23:35 +00:00
|
|
|
ret = platform_get_irq(pdev, 0);
|
|
|
|
if (ret < 0) {
|
2016-09-24 09:14:24 +00:00
|
|
|
if (ret != -EPROBE_DEFER)
|
|
|
|
dev_err(&pdev->dev, "cannot obtain irq\n");
|
2016-05-09 07:23:35 +00:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
uap->port.irq = ret;
|
|
|
|
|
2015-11-16 17:40:31 +00:00
|
|
|
uap->reg_offset = vendor_sbsa.reg_offset;
|
2017-02-15 21:39:43 +00:00
|
|
|
uap->vendor = qdf2400_e44_present ?
|
|
|
|
&vendor_qdt_qdf2400_e44 : &vendor_sbsa;
|
2015-05-21 16:26:23 +00:00
|
|
|
uap->fifosize = 32;
|
2016-01-04 21:37:42 +00:00
|
|
|
uap->port.iotype = vendor_sbsa.access_32b ? UPIO_MEM32 : UPIO_MEM;
|
2015-05-21 16:26:23 +00:00
|
|
|
uap->port.ops = &sbsa_uart_pops;
|
|
|
|
uap->fixed_baud = baudrate;
|
|
|
|
|
|
|
|
snprintf(uap->type, sizeof(uap->type), "SBSA");
|
|
|
|
|
|
|
|
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
|
|
|
|
|
|
ret = pl011_setup_port(&pdev->dev, uap, r, portnr);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
platform_set_drvdata(pdev, uap);
|
|
|
|
|
|
|
|
return pl011_register_port(uap);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int sbsa_uart_remove(struct platform_device *pdev)
|
|
|
|
{
|
|
|
|
struct uart_amba_port *uap = platform_get_drvdata(pdev);
|
|
|
|
|
|
|
|
uart_remove_one_port(&amba_reg, &uap->port);
|
|
|
|
pl011_unregister_port(uap);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct of_device_id sbsa_uart_of_match[] = {
|
|
|
|
{ .compatible = "arm,sbsa-uart", },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, sbsa_uart_of_match);
|
|
|
|
|
2015-05-21 16:26:24 +00:00
|
|
|
static const struct acpi_device_id sbsa_uart_acpi_match[] = {
|
|
|
|
{ "ARMH0011", 0 },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(acpi, sbsa_uart_acpi_match);
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
static struct platform_driver arm_sbsa_uart_platform_driver = {
|
|
|
|
.probe = sbsa_uart_probe,
|
|
|
|
.remove = sbsa_uart_remove,
|
|
|
|
.driver = {
|
|
|
|
.name = "sbsa-uart",
|
|
|
|
.of_match_table = of_match_ptr(sbsa_uart_of_match),
|
2015-05-21 16:26:24 +00:00
|
|
|
.acpi_match_table = ACPI_PTR(sbsa_uart_acpi_match),
|
2015-05-21 16:26:23 +00:00
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2010-07-27 07:50:16 +00:00
|
|
|
static struct amba_id pl011_ids[] = {
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
|
|
|
.id = 0x00041011,
|
|
|
|
.mask = 0x000fffff,
|
2009-06-04 16:43:04 +00:00
|
|
|
.data = &vendor_arm,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.id = 0x00380802,
|
|
|
|
.mask = 0x00ffffff,
|
|
|
|
.data = &vendor_st,
|
2005-04-16 22:20:36 +00:00
|
|
|
},
|
tty: amba-pl011: probe ZTE device from AMBA bus with a pseudo-ID
There is no Peripheral Identification Registers on ZTE PL011 device, so
although the driver amba-pl011 is ready to work for ZTE device, the
device cannot be probed by the driver at all.
With arm,primecell-periphid DT bindings (bindings/arm/primecell.txt) in
place, it should be the cleanest the way to use a pseudo-ID to probe the
device from AMBA bus. We create an unofficial vendor number
AMBA_VENDOR_LINUX, which will practically never become an official
vendor ID, and takes Configuration, Revision number, and Part number as
input to compose a pseudo-ID for ZTE device.
Also, since we start using vendor_zte to probe ZTE device, the
__maybe_unused for vendor_zte is removed.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-07-08 09:00:41 +00:00
|
|
|
{
|
|
|
|
.id = AMBA_LINUX_ID(0x00, 0x1, 0xffe),
|
|
|
|
.mask = 0x00ffffff,
|
|
|
|
.data = &vendor_zte,
|
|
|
|
},
|
2005-04-16 22:20:36 +00:00
|
|
|
{ 0, 0 },
|
|
|
|
};
|
|
|
|
|
2011-10-05 14:15:22 +00:00
|
|
|
MODULE_DEVICE_TABLE(amba, pl011_ids);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
static struct amba_driver pl011_driver = {
|
|
|
|
.drv = {
|
|
|
|
.name = "uart-pl011",
|
2013-12-03 10:04:28 +00:00
|
|
|
.pm = &pl011_dev_pm_ops,
|
2005-04-16 22:20:36 +00:00
|
|
|
},
|
|
|
|
.id_table = pl011_ids,
|
|
|
|
.probe = pl011_probe,
|
|
|
|
.remove = pl011_remove,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init pl011_init(void)
|
|
|
|
{
|
|
|
|
printk(KERN_INFO "Serial: AMBA PL011 UART driver\n");
|
|
|
|
|
2015-05-21 16:26:23 +00:00
|
|
|
if (platform_driver_register(&arm_sbsa_uart_platform_driver))
|
|
|
|
pr_warn("could not register SBSA UART platform driver\n");
|
2015-09-04 16:11:24 +00:00
|
|
|
return amba_driver_register(&pl011_driver);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit pl011_exit(void)
|
|
|
|
{
|
2015-05-21 16:26:23 +00:00
|
|
|
platform_driver_unregister(&arm_sbsa_uart_platform_driver);
|
2005-04-16 22:20:36 +00:00
|
|
|
amba_driver_unregister(&pl011_driver);
|
|
|
|
}
|
|
|
|
|
2009-05-05 04:54:13 +00:00
|
|
|
/*
|
|
|
|
* While this can be a module, if builtin it's most likely the console
|
|
|
|
* So let's leave module_exit but move module_init to an earlier place
|
|
|
|
*/
|
|
|
|
arch_initcall(pl011_init);
|
2005-04-16 22:20:36 +00:00
|
|
|
module_exit(pl011_exit);
|
|
|
|
|
|
|
|
MODULE_AUTHOR("ARM Ltd/Deep Blue Solutions Ltd");
|
|
|
|
MODULE_DESCRIPTION("ARM AMBA serial port driver");
|
|
|
|
MODULE_LICENSE("GPL");
|