License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2012-11-10 00:46:41 +00:00
|
|
|
#include <linux/compiler.h>
|
|
|
|
#include <linux/rbtree.h>
|
2017-04-17 18:23:08 +00:00
|
|
|
#include <inttypes.h>
|
2012-11-10 00:46:41 +00:00
|
|
|
#include <string.h>
|
2019-07-04 14:21:24 +00:00
|
|
|
#include <stdlib.h>
|
2019-08-30 14:11:01 +00:00
|
|
|
#include "dso.h"
|
2012-11-10 00:46:41 +00:00
|
|
|
#include "map.h"
|
|
|
|
#include "symbol.h"
|
2019-08-06 13:25:25 +00:00
|
|
|
#include <internal/lib.h> // page_size
|
2012-11-10 00:46:41 +00:00
|
|
|
#include "tests.h"
|
|
|
|
#include "debug.h"
|
|
|
|
#include "machine.h"
|
|
|
|
|
2013-08-07 11:38:52 +00:00
|
|
|
#define UM(x) kallsyms_map->unmap_ip(kallsyms_map, (x))
|
|
|
|
|
2017-08-03 18:16:31 +00:00
|
|
|
int test__vmlinux_matches_kallsyms(struct test *test __maybe_unused, int subtest __maybe_unused)
|
2012-11-10 00:46:41 +00:00
|
|
|
{
|
|
|
|
int err = -1;
|
|
|
|
struct rb_node *nd;
|
|
|
|
struct symbol *sym;
|
2015-05-22 14:52:22 +00:00
|
|
|
struct map *kallsyms_map, *vmlinux_map, *map;
|
2012-11-10 00:46:41 +00:00
|
|
|
struct machine kallsyms, vmlinux;
|
2018-04-24 20:06:25 +00:00
|
|
|
struct maps *maps = machine__kernel_maps(&vmlinux);
|
2013-08-07 11:38:48 +00:00
|
|
|
u64 mem_start, mem_end;
|
2016-09-01 13:40:57 +00:00
|
|
|
bool header_printed;
|
2012-11-10 00:46:41 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 1:
|
|
|
|
*
|
|
|
|
* Init the machines that will hold kernel, modules obtained from
|
|
|
|
* both vmlinux + .ko files and from /proc/kallsyms split by modules.
|
|
|
|
*/
|
|
|
|
machine__init(&kallsyms, "", HOST_KERNEL_ID);
|
|
|
|
machine__init(&vmlinux, "", HOST_KERNEL_ID);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 2:
|
|
|
|
*
|
|
|
|
* Create the kernel maps for kallsyms and the DSO where we will then
|
|
|
|
* load /proc/kallsyms. Also create the modules maps from /proc/modules
|
|
|
|
* and find the .ko files that match them in /lib/modules/`uname -r`/.
|
|
|
|
*/
|
|
|
|
if (machine__create_kernel_maps(&kallsyms) < 0) {
|
|
|
|
pr_debug("machine__create_kernel_maps ");
|
2013-01-25 02:01:50 +00:00
|
|
|
goto out;
|
2012-11-10 00:46:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 3:
|
|
|
|
*
|
|
|
|
* Load and split /proc/kallsyms into multiple maps, one per module.
|
2016-04-19 15:16:55 +00:00
|
|
|
* Do not use kcore, as this test was designed before kcore support
|
|
|
|
* and has parts that only make sense if using the non-kcore code.
|
|
|
|
* XXX: extend it to stress the kcorre code as well, hint: the list
|
|
|
|
* of modules extracted from /proc/kcore, in its current form, can't
|
|
|
|
* be compacted against the list of modules found in the "vmlinux"
|
|
|
|
* code and with the one got from /proc/modules from the "kallsyms" code.
|
2012-11-10 00:46:41 +00:00
|
|
|
*/
|
2018-04-25 14:40:32 +00:00
|
|
|
if (machine__load_kallsyms(&kallsyms, "/proc/kallsyms") <= 0) {
|
2012-11-10 00:46:41 +00:00
|
|
|
pr_debug("dso__load_kallsyms ");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 4:
|
|
|
|
*
|
|
|
|
* kallsyms will be internally on demand sorted by name so that we can
|
|
|
|
* find the reference relocation * symbol, i.e. the symbol we will use
|
|
|
|
* to see if the running kernel was relocated by checking if it has the
|
|
|
|
* same value in the vmlinux file we load.
|
|
|
|
*/
|
2015-09-30 14:54:04 +00:00
|
|
|
kallsyms_map = machine__kernel_map(&kallsyms);
|
2012-11-10 00:46:41 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 5:
|
|
|
|
*
|
|
|
|
* Now repeat step 2, this time for the vmlinux file we'll auto-locate.
|
|
|
|
*/
|
|
|
|
if (machine__create_kernel_maps(&vmlinux) < 0) {
|
|
|
|
pr_debug("machine__create_kernel_maps ");
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2015-09-30 14:54:04 +00:00
|
|
|
vmlinux_map = machine__kernel_map(&vmlinux);
|
2012-11-10 00:46:41 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Step 6:
|
|
|
|
*
|
|
|
|
* Locate a vmlinux file in the vmlinux path that has a buildid that
|
|
|
|
* matches the one of the running kernel.
|
|
|
|
*
|
|
|
|
* While doing that look if we find the ref reloc symbol, if we find it
|
|
|
|
* we'll have its ref_reloc_symbol.unrelocated_addr and then
|
|
|
|
* maps__reloc_vmlinux will notice and set proper ->[un]map_ip routines
|
|
|
|
* to fixup the symbols.
|
|
|
|
*/
|
2018-04-25 15:18:11 +00:00
|
|
|
if (machine__load_vmlinux_path(&vmlinux) <= 0) {
|
2012-12-19 14:11:59 +00:00
|
|
|
pr_debug("Couldn't find a vmlinux that matches the kernel running on this machine, skipping test\n");
|
|
|
|
err = TEST_SKIP;
|
2012-11-10 00:46:41 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = 0;
|
|
|
|
/*
|
|
|
|
* Step 7:
|
|
|
|
*
|
|
|
|
* Now look at the symbols in the vmlinux DSO and check if we find all of them
|
|
|
|
* in the kallsyms dso. For the ones that are in both, check its names and
|
|
|
|
* end addresses too.
|
|
|
|
*/
|
2018-04-25 15:32:25 +00:00
|
|
|
map__for_each_symbol(vmlinux_map, sym, nd) {
|
2012-11-10 00:46:41 +00:00
|
|
|
struct symbol *pair, *first_pair;
|
|
|
|
|
|
|
|
sym = rb_entry(nd, struct symbol, rb_node);
|
|
|
|
|
|
|
|
if (sym->start == sym->end)
|
|
|
|
continue;
|
|
|
|
|
2013-08-07 11:38:48 +00:00
|
|
|
mem_start = vmlinux_map->unmap_ip(vmlinux_map, sym->start);
|
|
|
|
mem_end = vmlinux_map->unmap_ip(vmlinux_map, sym->end);
|
|
|
|
|
2018-04-30 15:20:54 +00:00
|
|
|
first_pair = machine__find_kernel_symbol(&kallsyms, mem_start, NULL);
|
2012-11-10 00:46:41 +00:00
|
|
|
pair = first_pair;
|
|
|
|
|
2013-08-07 11:38:52 +00:00
|
|
|
if (pair && UM(pair->start) == mem_start) {
|
2012-11-10 00:46:41 +00:00
|
|
|
next_pair:
|
2018-02-15 12:26:35 +00:00
|
|
|
if (arch__compare_symbol_names(sym->name, pair->name) == 0) {
|
2012-11-10 00:46:41 +00:00
|
|
|
/*
|
|
|
|
* kallsyms don't have the symbol end, so we
|
|
|
|
* set that by using the next symbol start - 1,
|
|
|
|
* in some cases we get this up to a page
|
|
|
|
* wrong, trace_kmalloc when I was developing
|
|
|
|
* this code was one such example, 2106 bytes
|
|
|
|
* off the real size. More than that and we
|
|
|
|
* _really_ have a problem.
|
|
|
|
*/
|
2013-08-07 11:38:52 +00:00
|
|
|
s64 skew = mem_end - UM(pair->end);
|
2013-06-07 13:37:02 +00:00
|
|
|
if (llabs(skew) >= page_size)
|
2016-09-01 13:26:49 +00:00
|
|
|
pr_debug("WARN: %#" PRIx64 ": diff end addr for %s v: %#" PRIx64 " k: %#" PRIx64 "\n",
|
2013-08-07 11:38:48 +00:00
|
|
|
mem_start, sym->name, mem_end,
|
2013-08-07 11:38:52 +00:00
|
|
|
UM(pair->end));
|
2013-06-07 13:37:02 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Do not count this as a failure, because we
|
|
|
|
* could really find a case where it's not
|
|
|
|
* possible to get proper function end from
|
|
|
|
* kallsyms.
|
|
|
|
*/
|
|
|
|
continue;
|
2012-11-10 00:46:41 +00:00
|
|
|
} else {
|
2018-04-30 15:20:54 +00:00
|
|
|
pair = machine__find_kernel_symbol_by_name(&kallsyms, sym->name, NULL);
|
2016-01-25 21:04:47 +00:00
|
|
|
if (pair) {
|
|
|
|
if (UM(pair->start) == mem_start)
|
2012-11-10 00:46:41 +00:00
|
|
|
goto next_pair;
|
|
|
|
|
2016-09-01 13:40:57 +00:00
|
|
|
pr_debug("WARN: %#" PRIx64 ": diff name v: %s k: %s\n",
|
2016-01-25 21:04:47 +00:00
|
|
|
mem_start, sym->name, pair->name);
|
2016-04-19 15:22:25 +00:00
|
|
|
} else {
|
2016-09-01 13:40:57 +00:00
|
|
|
pr_debug("WARN: %#" PRIx64 ": diff name v: %s k: %s\n",
|
2016-04-19 15:22:25 +00:00
|
|
|
mem_start, sym->name, first_pair->name);
|
2012-11-10 00:46:41 +00:00
|
|
|
}
|
2016-09-01 13:40:57 +00:00
|
|
|
|
|
|
|
continue;
|
2012-11-10 00:46:41 +00:00
|
|
|
}
|
2019-05-24 18:39:00 +00:00
|
|
|
} else if (mem_start == kallsyms.vmlinux_map->end) {
|
|
|
|
/*
|
|
|
|
* Ignore aliases to _etext, i.e. to the end of the kernel text area,
|
|
|
|
* such as __indirect_thunk_end.
|
|
|
|
*/
|
|
|
|
continue;
|
|
|
|
} else {
|
2016-09-01 13:26:49 +00:00
|
|
|
pr_debug("ERR : %#" PRIx64 ": %s not on kallsyms\n",
|
2013-08-07 11:38:48 +00:00
|
|
|
mem_start, sym->name);
|
2019-05-24 18:39:00 +00:00
|
|
|
}
|
2012-11-10 00:46:41 +00:00
|
|
|
|
|
|
|
err = -1;
|
|
|
|
}
|
|
|
|
|
2017-02-17 08:17:38 +00:00
|
|
|
if (verbose <= 0)
|
2012-11-10 00:46:41 +00:00
|
|
|
goto out;
|
|
|
|
|
2016-09-01 13:40:57 +00:00
|
|
|
header_printed = false;
|
2012-11-10 00:46:41 +00:00
|
|
|
|
2019-10-28 14:31:38 +00:00
|
|
|
maps__for_each_entry(maps, map) {
|
2015-05-22 14:52:22 +00:00
|
|
|
struct map *
|
2012-11-10 00:46:41 +00:00
|
|
|
/*
|
|
|
|
* If it is the kernel, kallsyms is always "[kernel.kallsyms]", while
|
|
|
|
* the kernel will have the path for the vmlinux file being used,
|
|
|
|
* so use the short name, less descriptive but the same ("[kernel]" in
|
|
|
|
* both cases.
|
|
|
|
*/
|
2019-11-26 00:58:33 +00:00
|
|
|
pair = maps__find_by_name(&kallsyms.kmaps, (map->dso->kernel ?
|
|
|
|
map->dso->short_name :
|
|
|
|
map->dso->name));
|
2016-09-01 13:40:57 +00:00
|
|
|
if (pair) {
|
2012-11-10 00:46:41 +00:00
|
|
|
pair->priv = 1;
|
2016-09-01 13:40:57 +00:00
|
|
|
} else {
|
|
|
|
if (!header_printed) {
|
|
|
|
pr_info("WARN: Maps only in vmlinux:\n");
|
|
|
|
header_printed = true;
|
|
|
|
}
|
2015-05-22 14:52:22 +00:00
|
|
|
map__fprintf(map, stderr);
|
2016-09-01 13:40:57 +00:00
|
|
|
}
|
2012-11-10 00:46:41 +00:00
|
|
|
}
|
|
|
|
|
2016-09-01 13:40:57 +00:00
|
|
|
header_printed = false;
|
2012-11-10 00:46:41 +00:00
|
|
|
|
2019-10-28 14:31:38 +00:00
|
|
|
maps__for_each_entry(maps, map) {
|
2015-05-22 14:52:22 +00:00
|
|
|
struct map *pair;
|
2012-11-10 00:46:41 +00:00
|
|
|
|
2015-05-22 14:52:22 +00:00
|
|
|
mem_start = vmlinux_map->unmap_ip(vmlinux_map, map->start);
|
|
|
|
mem_end = vmlinux_map->unmap_ip(vmlinux_map, map->end);
|
2013-08-07 11:38:48 +00:00
|
|
|
|
2019-11-26 00:58:33 +00:00
|
|
|
pair = maps__find(&kallsyms.kmaps, mem_start);
|
2012-11-10 00:46:41 +00:00
|
|
|
if (pair == NULL || pair->priv)
|
|
|
|
continue;
|
|
|
|
|
2013-08-07 11:38:48 +00:00
|
|
|
if (pair->start == mem_start) {
|
2016-09-01 13:40:57 +00:00
|
|
|
if (!header_printed) {
|
|
|
|
pr_info("WARN: Maps in vmlinux with a different name in kallsyms:\n");
|
|
|
|
header_printed = true;
|
|
|
|
}
|
|
|
|
|
2016-09-01 13:26:49 +00:00
|
|
|
pr_info("WARN: %" PRIx64 "-%" PRIx64 " %" PRIx64 " %s in kallsyms as",
|
2015-05-22 14:52:22 +00:00
|
|
|
map->start, map->end, map->pgoff, map->dso->name);
|
2013-08-07 11:38:48 +00:00
|
|
|
if (mem_end != pair->end)
|
2016-09-01 13:26:49 +00:00
|
|
|
pr_info(":\nWARN: *%" PRIx64 "-%" PRIx64 " %" PRIx64,
|
2012-11-10 00:46:41 +00:00
|
|
|
pair->start, pair->end, pair->pgoff);
|
|
|
|
pr_info(" %s\n", pair->dso->name);
|
|
|
|
pair->priv = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-09-01 13:40:57 +00:00
|
|
|
header_printed = false;
|
2012-11-10 00:46:41 +00:00
|
|
|
|
2018-04-24 20:06:25 +00:00
|
|
|
maps = machine__kernel_maps(&kallsyms);
|
2012-11-10 00:46:41 +00:00
|
|
|
|
2019-10-28 14:31:38 +00:00
|
|
|
maps__for_each_entry(maps, map) {
|
2016-09-01 13:40:57 +00:00
|
|
|
if (!map->priv) {
|
|
|
|
if (!header_printed) {
|
|
|
|
pr_info("WARN: Maps only in kallsyms:\n");
|
|
|
|
header_printed = true;
|
|
|
|
}
|
2015-05-22 14:52:22 +00:00
|
|
|
map__fprintf(map, stderr);
|
2016-09-01 13:40:57 +00:00
|
|
|
}
|
2012-11-10 00:46:41 +00:00
|
|
|
}
|
|
|
|
out:
|
2013-01-25 02:01:50 +00:00
|
|
|
machine__exit(&kallsyms);
|
|
|
|
machine__exit(&vmlinux);
|
2012-11-10 00:46:41 +00:00
|
|
|
return err;
|
|
|
|
}
|