Merge 99d812cfd2 into f845fa04a0

std.debug: Gracefully handle process_vm_readv() EPERM in MemoryAccessor.read().
Closes #21815.
2024-11-24 13:20:14 +00:00 · 2024-11-21 08:51:35 +01:00 · 2024-11-20 23:07:46 +01:00 · 2024-11-03 09:53:00 -05:00
2 changed files with 5 additions and 3 deletions
--- a/lib/std/debug/MemoryAccessor.zig
+++ b/lib/std/debug/MemoryAccessor.zig
@ -48,7 +48,8 @@ fn read(ma: *MemoryAccessor, address: usize, buf: []u8) bool {
                switch (linux.E.init(bytes_read)) {
                    .SUCCESS => return bytes_read == buf.len,
                    .FAULT => return false,
-                    .INVAL, .PERM, .SRCH => unreachable, // own pid is always valid
+                    .INVAL, .SRCH => unreachable, // own pid is always valid
+                    .PERM => {}, // Known to happen in containers.
                    .NOMEM => {},
                    .NOSYS => {}, // QEMU is known not to implement this syscall.
                    else => unreachable, // unexpected
--- a/lib/std/mem/Allocator.zig
+++ b/lib/std/mem/Allocator.zig
@ -301,8 +301,9 @@ pub fn reallocAdvanced(
    return mem.bytesAsSlice(T, new_bytes);
 }

-/// Free an array allocated with `alloc`. To free a single item,
-/// see `destroy`.
+/// Free an array allocated with `alloc`.
+/// If memory has length 0, free is a no-op.
+/// To free a single item, see `destroy`.
 pub fn free(self: Allocator, memory: anytype) void {
    const Slice = @typeInfo(@TypeOf(memory)).pointer;
    const bytes = mem.sliceAsBytes(memory);
Author	SHA1	Message	Date
Ilia Choly	43b11ccbee	Merge `99d812cfd2` into `f845fa04a0`	2024-11-21 08:51:35 +01:00
Alex Rønne Petersen	f845fa04a0	std.debug: Gracefully handle process_vm_readv() EPERM in MemoryAccessor.read(). Closes #21815.	2024-11-20 23:07:46 +01:00
Ilia Choly	99d812cfd2	Allocator.free: document zero-length behavior It wasn't immediately clear from the implementation whether passing zero-length memory to free() was undefined behavior or intentionally supported. Since ArrayList and other core data structures rely on this behavior working correctly, this should be explicitly documented as part of the public API contract.	2024-11-03 09:53:00 -05:00