Nixyri/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-02-06 04:40:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "test_runner: workaround #1923, isolating error traces in tests"

Browse Source 
This reverts commit 1a32f2a7f4.

Sorry, this workaround is not welcome. Instead, please solve the actual
issue by doing the accepted behavior in the compiler itself:

> in a catch or else (handling a returned error), if the block does not
> try or return error.xyz, set the index to 0

This also applies to if statements, such as the one that test runner is
doing just above this hack.
This commit is contained in:
Andrew Kelley 2022-08-22 11:46:54 -07:00
parent 1a32f2a7f4
commit c955379504
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/test_runner.zig
View File

@ -96,13 +96,6 @@ pub fn main() void {
test_node.end();
},
}
// Workaround issue #1923 by clearing error stack traces between tests
//
// This is not a true fix, but helps isolate errors to the tests where they
// originate instead of confusing them all together
if (@errorReturnTrace()) |trace| {
trace.index = 0;
}
}
root_node.end();
if (ok_count == test_fn_list.len) {