Nixyri/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2025-01-23 18:31:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix check-statement-is-void. add tests

Browse Source 
see #291
This commit is contained in:
Josh Wolfe 2017-04-23 21:49:42 -07:00
parent c6605cba83
commit ac7971122d
3 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ir.cpp
View File

@ -12666,7 +12666,7 @@ static TypeTableEntry *ir_analyze_instruction_check_switch_prongs(IrAnalyze *ira
static TypeTableEntry *ir_analyze_instruction_check_statement_is_void(IrAnalyze *ira,
IrInstructionCheckStatementIsVoid *instruction)
{
IrInstruction *statement_value = instruction->statement_value;
IrInstruction *statement_value = instruction->statement_value->other;
TypeTableEntry *statement_type = statement_value->value.type;
if (type_is_invalid(statement_type))
return ira->codegen->builtin_types.entry_invalid;

2
std/debug.zig
View File

@ -217,7 +217,7 @@ fn getString(st: &ElfStackTrace, offset: u64) -> %[]u8 {
fn readAllocBytes(in_stream: &io.InStream, size: usize) -> %[]u8 {
const buf = %return global_allocator.alloc(u8, size);
%defer global_allocator.free(buf);
if (size < %return in_stream.read(buf)) return error.Eof;
if ((%return in_stream.read(buf)) < size) return error.Eof;
return buf;
}

31
test/compile_errors.zig
View File

@ -1348,6 +1348,37 @@ pub fn addCases(cases: &tests.CompileErrorContext) {
\\fn bar() -> i32 { 0 }
, ".tmp_source.zig:2:8: error: expression value is ignored");
cases.add("ignored assert-err-ok return value",
\\export fn foo() {
\\ %%bar();
\\}
\\fn bar() -> %i32 { 0 }
, ".tmp_source.zig:2:5: error: expression value is ignored");
cases.add("ignored statement value",
\\export fn foo() {
\\ 1;
\\}
, ".tmp_source.zig:2:5: error: expression value is ignored");
cases.add("ignored comptime statement value",
\\export fn foo() {
\\ comptime {1;}
\\}
, ".tmp_source.zig:2:15: error: expression value is ignored");
cases.add("ignored comptime value",
\\export fn foo() {
\\ comptime 1;
\\}
, ".tmp_source.zig:2:5: error: expression value is ignored");
cases.add("ignored defered statement value",
\\export fn foo() {
\\ defer {1;}
\\}
, ".tmp_source.zig:2:12: error: expression value is ignored");
cases.add("integer literal on a non-comptime var",
\\export fn foo() {
\\ var i = 0;