From ec62978dd0cf34e96576627393396782fad7e69b Mon Sep 17 00:00:00 2001 From: Guilherme Sousa Date: Sat, 26 Oct 2024 17:56:51 +0200 Subject: [PATCH] Fix non const animation node process function --- doc/classes/AnimationNode.xml | 2 +- misc/extension_api_validation/4.3-stable.expected | 7 +++++++ scene/animation/animation_tree.h | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/classes/AnimationNode.xml b/doc/classes/AnimationNode.xml index 4e093cb887d..3b7cd9adad7 100644 --- a/doc/classes/AnimationNode.xml +++ b/doc/classes/AnimationNode.xml @@ -63,7 +63,7 @@ When inheriting from [AnimationRootNode], implement this virtual method to return whether the [param parameter] is read-only. Parameters are custom local memory used for your animation nodes, given a resource can be reused in multiple trees. - + diff --git a/misc/extension_api_validation/4.3-stable.expected b/misc/extension_api_validation/4.3-stable.expected index 960edd0575e..9e169d474d7 100644 --- a/misc/extension_api_validation/4.3-stable.expected +++ b/misc/extension_api_validation/4.3-stable.expected @@ -95,3 +95,10 @@ Validate extension JSON: Error: Field 'classes/InputMap/methods/add_action/argum Default deadzone value was changed. No adjustments should be necessary. Compatibility method registered. + + +GH-97020 +-------- +Validate extension JSON: Error: Field 'classes/AnimationNode/methods/_process': is_const changed value in new API, from true to false. + +`_process` virtual method fixed to be non const instead. diff --git a/scene/animation/animation_tree.h b/scene/animation/animation_tree.h index d4b7bf31c9d..ec5e88b776b 100644 --- a/scene/animation/animation_tree.h +++ b/scene/animation/animation_tree.h @@ -151,7 +151,7 @@ protected: GDVIRTUAL1RC(Ref, _get_child_by_name, StringName) GDVIRTUAL1RC(Variant, _get_parameter_default_value, StringName) GDVIRTUAL1RC(bool, _is_parameter_read_only, StringName) - GDVIRTUAL4RC(double, _process, double, bool, bool, bool) + GDVIRTUAL4R(double, _process, double, bool, bool, bool) GDVIRTUAL0RC(String, _get_caption) GDVIRTUAL0RC(bool, _has_filter)