From e73e336e3ba36bc2dca2cfdf8a65704678848e2d Mon Sep 17 00:00:00 2001 From: Fredia Huya-Kouadio Date: Thu, 12 Aug 2021 22:16:14 -0700 Subject: [PATCH] Add support for prompting the user to retain app data on uninstall. Supported on Android 10 and higher. --- platform/android/export/export_plugin.cpp | 6 ++++++ platform/android/export/gradle_export_util.cpp | 6 ++++-- platform/android/java/app/AndroidManifest.xml | 1 + 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/platform/android/export/export_plugin.cpp b/platform/android/export/export_plugin.cpp index 6c2e4818561..17ee1738550 100644 --- a/platform/android/export/export_plugin.cpp +++ b/platform/android/export/export_plugin.cpp @@ -819,6 +819,7 @@ void EditorExportPlatformAndroid::_fix_manifest(const Ref &p bool backup_allowed = p_preset->get("user_data_backup/allow"); bool classify_as_game = p_preset->get("package/classify_as_game"); + bool retain_data_on_uninstall = p_preset->get("package/retain_data_on_uninstall"); Vector perms; // Write permissions into the perms variable. @@ -920,6 +921,10 @@ void EditorExportPlatformAndroid::_fix_manifest(const Ref &p encode_uint32(classify_as_game, &p_manifest.write[iofs + 16]); } + if (tname == "application" && attrname == "hasFragileUserData") { + encode_uint32(retain_data_on_uninstall, &p_manifest.write[iofs + 16]); + } + if (tname == "instrumentation" && attrname == "targetPackage") { string_table.write[attr_value] = get_package_name(package_name); } @@ -1635,6 +1640,7 @@ void EditorExportPlatformAndroid::get_export_options(List *r_optio r_options->push_back(ExportOption(PropertyInfo(Variant::STRING, "package/name", PROPERTY_HINT_PLACEHOLDER_TEXT, "Game Name [default if blank]"), "")); r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "package/signed"), true)); r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "package/classify_as_game"), true)); + r_options->push_back(ExportOption(PropertyInfo(Variant::BOOL, "package/retain_data_on_uninstall"), false)); r_options->push_back(ExportOption(PropertyInfo(Variant::STRING, launcher_icon_option, PROPERTY_HINT_FILE, "*.png"), "")); r_options->push_back(ExportOption(PropertyInfo(Variant::STRING, launcher_adaptive_icon_foreground_option, PROPERTY_HINT_FILE, "*.png"), "")); diff --git a/platform/android/export/gradle_export_util.cpp b/platform/android/export/gradle_export_util.cpp index 354287d8726..76512226bf5 100644 --- a/platform/android/export/gradle_export_util.cpp +++ b/platform/android/export/gradle_export_util.cpp @@ -241,10 +241,12 @@ String _get_application_tag(const Ref &p_preset) { " android:allowBackup=\"%s\"\n" " android:icon=\"@mipmap/icon\"\n" " android:isGame=\"%s\"\n" - " tools:replace=\"android:allowBackup,android:isGame\"\n" + " android:hasFragileUserData=\"%s\"\n" + " tools:replace=\"android:allowBackup,android:isGame,android:hasFragileUserData\"\n" " tools:ignore=\"GoogleAppIndexingWarning\">\n\n", bool_to_string(p_preset->get("user_data_backup/allow")), - bool_to_string(p_preset->get("package/classify_as_game"))); + bool_to_string(p_preset->get("package/classify_as_game")), + bool_to_string(p_preset->get("package/retain_data_on_uninstall"))); manifest_application_text += _get_activity_tag(p_preset); manifest_application_text += " \n"; diff --git a/platform/android/java/app/AndroidManifest.xml b/platform/android/java/app/AndroidManifest.xml index 0874d77645c..467a0dc3c0e 100644 --- a/platform/android/java/app/AndroidManifest.xml +++ b/platform/android/java/app/AndroidManifest.xml @@ -21,6 +21,7 @@ android:allowBackup="false" android:icon="@mipmap/icon" android:isGame="true" + android:hasFragileUserData="false" tools:ignore="GoogleAppIndexingWarning" >