mirror of
https://github.com/godotengine/godot.git
synced 2024-11-22 20:23:53 +00:00
* Small hex/float/integer parsing refactoring
* Potential bug fix on hex (cannot be used atm) * Added optional typing for floats, eg: "1f" -> "1.0" "1.f" -> "1.0" "1.99f" -> "1.99" "1." -> "1.0"
This commit is contained in:
parent
1fc7973a00
commit
e6ad5e23b4
@ -6384,7 +6384,7 @@ Map<int, TextEdit::HighlighterInfo> TextEdit::_get_line_syntax_highlighting(int
|
|||||||
}
|
}
|
||||||
|
|
||||||
// check for dot or underscore or 'x' for hex notation in floating point number
|
// check for dot or underscore or 'x' for hex notation in floating point number
|
||||||
if ((str[j] == '.' || str[j] == 'x' || str[j] == '_') && !in_word && prev_is_number && !is_number) {
|
if ((str[j] == '.' || str[j] == 'x' || str[j] == '_' || str[j] == 'f') && !in_word && prev_is_number && !is_number) {
|
||||||
is_number = true;
|
is_number = true;
|
||||||
is_symbol = false;
|
is_symbol = false;
|
||||||
is_char = false;
|
is_char = false;
|
||||||
|
@ -516,13 +516,14 @@ ShaderLanguage::Token ShaderLanguage::_get_token() {
|
|||||||
bool hexa_found = false;
|
bool hexa_found = false;
|
||||||
bool sign_found = false;
|
bool sign_found = false;
|
||||||
bool minus_exponent_found = false;
|
bool minus_exponent_found = false;
|
||||||
|
bool float_suffix_found = false;
|
||||||
|
|
||||||
String str;
|
String str;
|
||||||
int i = 0;
|
int i = 0;
|
||||||
|
|
||||||
while (true) {
|
while (true) {
|
||||||
if (GETCHAR(i) == '.') {
|
if (GETCHAR(i) == '.') {
|
||||||
if (period_found || exponent_found)
|
if (period_found || exponent_found || hexa_found || float_suffix_found)
|
||||||
return _make_token(TK_ERROR, "Invalid numeric constant");
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
period_found = true;
|
period_found = true;
|
||||||
} else if (GETCHAR(i) == 'x') {
|
} else if (GETCHAR(i) == 'x') {
|
||||||
@ -530,11 +531,16 @@ ShaderLanguage::Token ShaderLanguage::_get_token() {
|
|||||||
return _make_token(TK_ERROR, "Invalid numeric constant");
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
hexa_found = true;
|
hexa_found = true;
|
||||||
} else if (GETCHAR(i) == 'e') {
|
} else if (GETCHAR(i) == 'e') {
|
||||||
if (hexa_found || exponent_found)
|
if (hexa_found || exponent_found || float_suffix_found)
|
||||||
return _make_token(TK_ERROR, "Invalid numeric constant");
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
exponent_found = true;
|
exponent_found = true;
|
||||||
|
} else if (GETCHAR(i) == 'f') {
|
||||||
|
if (hexa_found || exponent_found)
|
||||||
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
|
float_suffix_found = true;
|
||||||
} else if (_is_number(GETCHAR(i))) {
|
} else if (_is_number(GETCHAR(i))) {
|
||||||
//all ok
|
if (float_suffix_found)
|
||||||
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
} else if (hexa_found && _is_hex(GETCHAR(i))) {
|
} else if (hexa_found && _is_hex(GETCHAR(i))) {
|
||||||
|
|
||||||
} else if ((GETCHAR(i) == '-' || GETCHAR(i) == '+') && exponent_found) {
|
} else if ((GETCHAR(i) == '-' || GETCHAR(i) == '+') && exponent_found) {
|
||||||
@ -550,21 +556,60 @@ ShaderLanguage::Token ShaderLanguage::_get_token() {
|
|||||||
i++;
|
i++;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!_is_number(str[str.length() - 1]))
|
CharType last_char = str[str.length() - 1];
|
||||||
return _make_token(TK_ERROR, "Invalid numeric constant");
|
|
||||||
|
if (hexa_found) {
|
||||||
|
//hex integers eg."0xFF" or "0x12AB", etc - NOT supported yet
|
||||||
|
return _make_token(TK_ERROR, "Invalid (hexadecimal) numeric constant - Not supported");
|
||||||
|
} else if (period_found || float_suffix_found) {
|
||||||
|
//floats
|
||||||
|
if (period_found) {
|
||||||
|
if (float_suffix_found) {
|
||||||
|
//checks for eg "1.f" or "1.99f" notations
|
||||||
|
if (last_char != 'f') {
|
||||||
|
return _make_token(TK_ERROR, "Invalid (float) numeric constant");
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
//checks for eg. "1." or "1.99" notations
|
||||||
|
if (last_char != '.' && !_is_number(last_char)) {
|
||||||
|
return _make_token(TK_ERROR, "Invalid (float) numeric constant");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} else if (float_suffix_found) {
|
||||||
|
// if no period found the float suffix must be the last character, like in "2f" for "2.0"
|
||||||
|
if (last_char != 'f') {
|
||||||
|
return _make_token(TK_ERROR, "Invalid (float) numeric constant");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (float_suffix_found) {
|
||||||
|
//strip the suffix
|
||||||
|
str = str.left(str.length() - 1);
|
||||||
|
//compensate reading cursor position
|
||||||
|
char_idx += 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!str.is_valid_float()) {
|
||||||
|
return _make_token(TK_ERROR, "Invalid (float) numeric constant");
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
//integers
|
||||||
|
if (!_is_number(last_char)) {
|
||||||
|
return _make_token(TK_ERROR, "Invalid (integer) numeric constant");
|
||||||
|
}
|
||||||
|
if (!str.is_valid_integer()) {
|
||||||
|
return _make_token(TK_ERROR, "Invalid numeric constant");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
char_idx += str.length();
|
char_idx += str.length();
|
||||||
Token tk;
|
Token tk;
|
||||||
if (period_found || minus_exponent_found)
|
if (period_found || minus_exponent_found || float_suffix_found)
|
||||||
tk.type = TK_REAL_CONSTANT;
|
tk.type = TK_REAL_CONSTANT;
|
||||||
else
|
else
|
||||||
tk.type = TK_INT_CONSTANT;
|
tk.type = TK_INT_CONSTANT;
|
||||||
|
|
||||||
if (!str.is_valid_float()) {
|
tk.constant = str.to_double(); //wont work with hex
|
||||||
return _make_token(TK_ERROR, "Invalid numeric constant");
|
|
||||||
}
|
|
||||||
|
|
||||||
tk.constant = str.to_double();
|
|
||||||
tk.line = tk_line;
|
tk.line = tk_line;
|
||||||
|
|
||||||
return tk;
|
return tk;
|
||||||
|
Loading…
Reference in New Issue
Block a user