Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-25 13:43:15 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[Core] Optimize String::join

Browse Source 
Avoid reallocation by pre-computing size
This commit is contained in:
A Thousand Ships 2024-05-30 16:52:30 +02:00
parent ee363af0ed
commit e211d08c92
No known key found for this signature in database
GPG Key ID: 2033189A662F8BD7
1 changed files with 36 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
core/string/ustring.cpp
View File

@ -1639,13 +1639,43 @@ Vector<int> String::split_ints_mk(const Vector<String> &p_splitters, bool p_allo
}
String String::join(const Vector<String> &parts) const {
String ret;
for (int i = 0; i < parts.size(); ++i) {
if (i > 0) {
ret += *this;
}
ret += parts[i];
if (parts.is_empty()) {
return String();
} else if (parts.size() == 1) {
return parts[0];
}
const int this_length = length();
int new_size = (parts.size() - 1) * this_length;
for (const String &part : parts) {
new_size += part.length();
}
new_size += 1;
String ret;
ret.resize(new_size);
char32_t *ret_ptrw = ret.ptrw();
const char32_t *this_ptr = ptr();
bool first = true;
for (const String &part : parts) {
if (first) {
first = false;
} else if (this_length) {
memcpy(ret_ptrw, this_ptr, this_length * sizeof(char32_t));
ret_ptrw += this_length;
}
const int part_length = part.length();
if (part_length) {
memcpy(ret_ptrw, part.ptr(), part_length * sizeof(char32_t));
ret_ptrw += part_length;
}
}
*ret_ptrw = 0;
return ret;
}