Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-26 22:23:04 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #23256 from JFonS/fix_17989

Browse Source 
Fix editor only lights
This commit is contained in:
Rémi Verschelde 2018-10-24 17:39:20 +02:00 committed by GitHub
commit d42fd8fa79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scene/3d/light.cpp
View File

@ -163,11 +163,6 @@ void Light::_update_visibility() {
if (!is_inside_tree())
return;
// FIXME: Since the call to VS::instance_light_set_enabled was disabled below,
// the whole logic became pointless so editor_ok triggers unused variable warnings.
// Commenting out for now but this should be fixed/reimplemented so that editor_only
// works as expected (GH-17989).
/*
bool editor_ok = true;
#ifdef TOOLS_ENABLED
@ -184,8 +179,8 @@ void Light::_update_visibility() {
}
#endif
//VS::get_singleton()->instance_light_set_enabled(get_instance(),is_visible_in_tree() && editor_ok);
*/
VS::get_singleton()->instance_set_visible(get_instance(), is_visible_in_tree() && editor_ok);
_change_notify("geometry/visible");
}