Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-23 12:43:43 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Cleanup AudioEffectRecord thread_active variable

Browse Source
This commit is contained in:
Marcel Admiraal 2022-06-16 20:34:30 +01:00
parent e047c50068
commit b257d552e7
2 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
servers/audio/effects/audio_effect_record.cpp
View File

@ -66,8 +66,6 @@ bool AudioEffectRecordInstance::process_silence() const {
}
void AudioEffectRecordInstance::_io_thread_process() {
thread_active = true;
while (is_recording) {
//Check: The current recording has been requested to stop
if (!base->recording_active) {
@ -81,8 +79,6 @@ void AudioEffectRecordInstance::_io_thread_process() {
OS::get_singleton()->delay_usec(500);
}
}
thread_active = false;
}
void AudioEffectRecordInstance::_io_store_buffer() {
@ -126,9 +122,7 @@ void AudioEffectRecordInstance::finish() {
#ifdef NO_THREADS
AudioServer::get_singleton()->remove_update_callback(&AudioEffectRecordInstance::_update, this);
#else
if (thread_active) {
io_thread.wait_to_finish();
}
io_thread.wait_to_finish();
#endif
}

4
servers/audio/effects/audio_effect_record.h
View File

@ -49,7 +49,6 @@ class AudioEffectRecordInstance : public AudioEffectInstance {
bool is_recording;
Thread io_thread;
bool thread_active;
Vector<AudioFrame> ring_buffer;
Vector<float> recording_data;
@ -70,8 +69,7 @@ public:
virtual void process(const AudioFrame *p_src_frames, AudioFrame *p_dst_frames, int p_frame_count);
virtual bool process_silence() const;
AudioEffectRecordInstance() :
thread_active(false) {}
AudioEffectRecordInstance() {}
~AudioEffectRecordInstance();
};