From 87c1e16834a21ac1e42321811cb0efcda4b91b9a Mon Sep 17 00:00:00 2001
From: Zher Huei Lee <lee.zh.92@gmail.com>
Date: Fri, 24 Jul 2015 14:09:39 +0100
Subject: [PATCH] Made RegEx API similar to old version

---
 bin/tests/test_string.cpp  |   4 ++--
 demos/misc/regex/regex.gd  |   4 ++--
 demos/misc/regex/regex.scn | Bin 1770 -> 1772 bytes
 drivers/nrex/regex.cpp     |  20 +++++++++++---------
 drivers/nrex/regex.h       |   4 ++--
 5 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/bin/tests/test_string.cpp b/bin/tests/test_string.cpp
index 7b512a5d993..93b1835b785 100644
--- a/bin/tests/test_string.cpp
+++ b/bin/tests/test_string.cpp
@@ -464,8 +464,8 @@ bool test_26() {
 	OS::get_singleton()->print("\n\nTest 26: RegEx\n");
 	RegEx regexp("(.*):(.*)");
 
-	bool res = regexp.match("name:password");
-	printf("\tmatch: %s\n", res?"true":"false");
+	int res = regexp.find("name:password");
+	printf("\tmatch: %s\n", (res>=0)?"true":"false");
 
 	printf("\t%i captures:\n", regexp.get_capture_count());
 	for (int i = 0; i<regexp.get_capture_count(); i++)
diff --git a/demos/misc/regex/regex.gd b/demos/misc/regex/regex.gd
index a2dc62bf83d..e648c180931 100644
--- a/demos/misc/regex/regex.gd
+++ b/demos/misc/regex/regex.gd
@@ -8,11 +8,11 @@ func update_expression():
 
 func update_text():
 	var text = get_node("Text").get_text()
-	regex.match(text)
+	regex.find(text)
 	var list = get_node("List")
 	for child in list.get_children():
 		child.queue_free()
-	for res in regex.get_capture_list():
+	for res in regex.get_captures():
 		var label = Label.new()
 		label.set_text(res)
 		list.add_child(label)
diff --git a/demos/misc/regex/regex.scn b/demos/misc/regex/regex.scn
index 591b60974aaf5724ac456f43abb3770d56da8b59..2b62d6b82a609fde26b7407c4b0fb7684915ec2c 100644
GIT binary patch
delta 304
zcmaFG`-WFADA?JV0R#jX7(#d%7_LkdRAgkGXq?5xe8Ay`12cn^g3QL{&zM;{a}^3F
zPh^p(uU|IT`6)94gNI84JHw9Dr|wMxN*WsWRxvSpHPLZOv6@<%N{RCv7#cJgZ#X8f
zGc_!Bc9_w?z&OphL6~7_s*t0ddlXYKgMxw_L!1IL!~X>g3S0>c4t(yL9eW%Yj?}tN
zb`W;(1>#LW9O%IAu+Kr-!P-Ik0W*U`ucL&$L$m|8yOM*sV~~TngZ%^HXvcdF;Z6+>
z?v587nq9gb%z+9W)jbb8WIGtU7e8PxcBpq+=TQGZy!rt<gS+YER8~bPPv*v6hh7I=
w2L=Xl1s1Ooho=q<2iP6Noi=P<z-r1UI+2gT)78&qol`;+14B@7kTWQl0FMS(iU0rr

delta 302
zcmaFE`-)dEDA?JV0R#jX7y@`17%oi|RAgkFXq?5xazH`Eftf){fqmohXUr^_xehs#
zC$dP?e^K*te#p$g;NjB1&afl(p?jTxl7@!8RZNUtO>~@6tfrQxQi6d4LxU#c4aWp_
zriR7N4pSN!7^gWm2s12A<#V)h4`V83P*9L#h*Mx@_`iTbfh&Q*fzN%tV}}F7kxGYI
z4#Ez;4#Ef4IRrXLyIMI&J6JnNKVW8X=yeovh_-d$c9(N7cl2{Gcd&mT9PN0^A>66P
z!QJt!L$gb}gE>&4qq^sQhinI9_xuO!#SZmOs~qYdh*v*gXK**1oX)B!<?+9<*P+)z
x*MWgST!F=_z~QL_!vS^&ai=w#7qOZ$iuUp`c)I$ztaD0eVqgdg4sr$s5&%z6R}%mL

diff --git a/drivers/nrex/regex.cpp b/drivers/nrex/regex.cpp
index d7c12bd5448..708e68cc265 100644
--- a/drivers/nrex/regex.cpp
+++ b/drivers/nrex/regex.cpp
@@ -16,13 +16,16 @@
 void RegEx::_bind_methods() {
 
 	ObjectTypeDB::bind_method(_MD("compile","pattern"),&RegEx::compile);
-	ObjectTypeDB::bind_method(_MD("match","text","start","end"),&RegEx::match, DEFVAL(0), DEFVAL(-1));
+	ObjectTypeDB::bind_method(_MD("find","text","start","end"),&RegEx::find, DEFVAL(0), DEFVAL(-1));
+	ObjectTypeDB::bind_method(_MD("clear"),&RegEx::clear);
+	ObjectTypeDB::bind_method(_MD("is_valid"),&RegEx::is_valid);
+	ObjectTypeDB::bind_method(_MD("get_capture_count"),&RegEx::get_capture_count);
 	ObjectTypeDB::bind_method(_MD("get_capture","capture"),&RegEx::get_capture);
-	ObjectTypeDB::bind_method(_MD("get_capture_list"),&RegEx::_bind_get_capture_list);
+	ObjectTypeDB::bind_method(_MD("get_captures"),&RegEx::_bind_get_captures);
 
 };
 
-StringArray RegEx::_bind_get_capture_list() const {
+StringArray RegEx::_bind_get_captures() const {
 
 	StringArray ret;
 	int count = get_capture_count();
@@ -64,22 +67,21 @@ String RegEx::get_capture(int capture) const {
 }
 
 Error RegEx::compile(const String& p_pattern) {
-	
+
 	clear();
 
 	exp.compile(p_pattern.c_str());
 
 	ERR_FAIL_COND_V( !exp.valid(), FAILED );
-	
+
 	captures.resize(exp.capture_size());
 
 	return OK;
 
 };
 
-bool RegEx::match(const String& p_text, int p_start, int p_end) const {
+int RegEx::find(const String& p_text, int p_start, int p_end) const {
 
-	
 	ERR_FAIL_COND_V( !exp.valid(), false );
 	ERR_FAIL_COND_V( p_text.length() < p_start, false );
 	ERR_FAIL_COND_V( p_text.length() < p_end, false );
@@ -88,10 +90,10 @@ bool RegEx::match(const String& p_text, int p_start, int p_end) const {
 
 	if (res) {
 		text = p_text;
-		return true;
+		return captures[0].start;
 	}
 	text.clear();
-	return false;
+	return -1;
 
 };
 
diff --git a/drivers/nrex/regex.h b/drivers/nrex/regex.h
index 3ef9ca34254..06260297055 100644
--- a/drivers/nrex/regex.h
+++ b/drivers/nrex/regex.h
@@ -28,7 +28,7 @@ class RegEx : public Reference {
 protected:
 
 	static void _bind_methods();
-	StringArray _bind_get_capture_list() const;
+	StringArray _bind_get_captures() const;
 
 public:
 
@@ -37,7 +37,7 @@ public:
 	int get_capture_count() const;
 	String get_capture(int capture) const;
 	Error compile(const String& p_pattern);
-	bool match(const String& p_text, int p_start = 0, int p_end = -1) const;
+	int find(const String& p_text, int p_start = 0, int p_end = -1) const;
 
 	RegEx();
 	RegEx(const String& p_pattern);