Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-12-15 15:42:46 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #27214 from marcelofg55/midi_note_off

Browse Source 
Fix MIDI Note Off missing on some devices
This commit is contained in:
Rémi Verschelde 2019-04-03 09:17:07 +02:00 committed by GitHub
commit 76cbe7a9ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/os/midi_driver.cpp
View File

@ -75,6 +75,11 @@ void MIDIDriver::receive_input_packet(uint64_t timestamp, uint8_t *data, uint32_
if (length >= 3) { if (length >= 3) {
event->set_pitch(data[1]); event->set_pitch(data[1]);
event->set_velocity(data[2]); event->set_velocity(data[2]);
if (event->get_message() == MIDI_MESSAGE_NOTE_ON && event->get_velocity() == 0) {
// https://www.midi.org/forum/228-writing-midi-software-send-note-off,-or-zero-velocity-note-on
event->set_message(MIDI_MESSAGE_NOTE_OFF);
}
} }
break; break;