Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-24 21:22:48 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Tests: Remove NavigationRegion3D race condition that fails on CI

Browse Source 
As the comment pointed it out, it's a race condition, and evidently no,
"it's [not] fine" ;)
This commit is contained in:
Rémi Verschelde 2024-04-13 10:22:44 +02:00
parent 029aadef56
commit 66cf38ec7c
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/scene/test_navigation_region_3d.h
View File

@ -71,15 +71,6 @@ TEST_SUITE("[Navigation]") {
CHECK_NE(navigation_mesh->get_vertices().size(), 0);
}
// Race condition is present in the below subcase, but baking should take many
// orders of magnitude longer than basic checks on the main thread, so it's fine.
SUBCASE("Asynchronous bake should not be immediate") {
navigation_region->bake_navigation_mesh(true);
CHECK(navigation_region->is_baking());
CHECK_EQ(navigation_mesh->get_polygon_count(), 0);
CHECK_EQ(navigation_mesh->get_vertices().size(), 0);
}
memdelete(mesh_instance);
memdelete(navigation_region);
memdelete(node_3d);