Merge pull request #97171 from Calinou/os-execute-windows-improve-cant-fork-error-message
Some checks failed
🔗 GHA / 📊 Static (push) Has been cancelled
🔗 GHA / 🤖 Android (push) Has been cancelled
🔗 GHA / 🍏 iOS (push) Has been cancelled
🔗 GHA / 🌐 JavaScript (push) Has been cancelled
🔗 GHA / 🐧 Linux (push) Has been cancelled
🔗 GHA / 🍎 macOS (push) Has been cancelled
🔗 GHA / ☁ Server (push) Has been cancelled
🔗 GHA / 🏁 Windows (push) Has been cancelled

[3.x] Improve error message when `OS.execute()` fails on Windows
This commit is contained in:
lawnjelly 2024-09-20 19:39:21 +01:00 committed by GitHub
commit 553030b599
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -2978,7 +2978,7 @@ Error OS_Windows::execute(const String &p_path, const List<String> &p_arguments,
CloseHandle(pipe[0]); // Cleanup pipe handles.
CloseHandle(pipe[1]);
}
ERR_FAIL_COND_V(ret == 0, ERR_CANT_FORK);
ERR_FAIL_COND_V_MSG(ret == 0, ERR_CANT_FORK, "Could not create child process: " + String(modstr.ptr()));
if (p_blocking) {
if (r_pipe) {