Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-10-24 06:01:59 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #67145 from Paulb23/tab_textedit

Browse Source 
Fix inserting tabs in TextEdit
This commit is contained in:
Rémi Verschelde 2022-10-10 13:52:42 +02:00
commit 4be5660223
2 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scene/gui/text_edit.cpp
View File

@ -2192,8 +2192,17 @@ void TextEdit::gui_input(const Ref<InputEvent> &p_gui_input) {
return;
}
// Handle Unicode (if no modifiers active). Tab has a value of 0x09.
if (allow_unicode_handling && editable && (k->get_unicode() >= 32 || k->get_keycode() == Key::TAB)) {
// Handle tab as it has no set unicode value.
if (k->is_action("ui_text_indent", true)) {
if (editable) {
insert_text_at_caret("\t");
}
accept_event();
return;
}
// Handle Unicode (if no modifiers active).
if (allow_unicode_handling && editable && k->get_unicode() >= 32) {
handle_unicode_input(k->get_unicode());
accept_event();
return;

12
tests/scene/test_text_edit.h
View File

@ -2944,6 +2944,18 @@ TEST_CASE("[SceneTree][TextEdit] text entry") {
SIGNAL_CHECK("lines_edited_from", lines_edited_args);
text_edit->set_overtype_mode_enabled(false);
CHECK_FALSE(text_edit->is_overtype_mode_enabled());
lines_edited_args.remove_at(0);
lines_edited_args.remove_at(1);
SEND_GUI_KEY_EVENT(text_edit, Key::TAB);
CHECK(text_edit->get_viewport()->is_input_handled());
CHECK(text_edit->get_text() == "A\tB\nA\tB");
CHECK(text_edit->get_caret_column() == 2);
CHECK(text_edit->get_caret_column(1) == 2);
SIGNAL_CHECK("caret_changed", empty_signal_args);
SIGNAL_CHECK("text_changed", empty_signal_args);
SIGNAL_CHECK("lines_edited_from", lines_edited_args);
}
SIGNAL_UNWATCH(text_edit, "text_set");