Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-26 22:23:04 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix "p_from_line > p_to_line" errors in text edit

Browse Source 
Done via making the function more robust to different inputs
This commit is contained in:
nova++ 2022-03-10 20:25:59 -05:00 committed by Nova
parent 7866c98479
commit 4b8fa3716f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scene/gui/text_edit.cpp
View File

@ -4469,7 +4469,11 @@ int TextEdit::get_visible_line_count() const {
int TextEdit::get_visible_line_count_in_range(int p_from_line, int p_to_line) const {
ERR_FAIL_INDEX_V(p_from_line, text.size(), 0);
ERR_FAIL_INDEX_V(p_to_line, text.size(), 0);
ERR_FAIL_COND_V(p_from_line > p_to_line, 0);
// So we can handle inputs in whatever order
if (p_from_line > p_to_line) {
SWAP(p_from_line, p_to_line);
}
/* Returns the total number of (lines + wrapped - hidden). */
if (!_is_hiding_enabled() && get_line_wrapping_mode() == LineWrappingMode::LINE_WRAPPING_NONE) {