Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-24 21:22:48 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #97765 from bruvzg/gde_export_errors

Browse Source 
[GDExtension] Improve error messages during export.
This commit is contained in:
Rémi Verschelde 2024-10-03 15:27:27 +02:00
commit 45d3ea32f8
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
editor/export/editor_export_platform_pc.cpp
View File

@ -222,9 +222,15 @@ Error EditorExportPlatformPC::export_project_data(const Ref<EditorExportPreset>
err = da->make_dir_recursive(target_path); err = da->make_dir_recursive(target_path);
if (err == OK) { if (err == OK) {
err = da->copy_dir(src_path, target_path, -1, true); err = da->copy_dir(src_path, target_path, -1, true);
if (err != OK) {
add_message(EXPORT_MESSAGE_ERROR, TTR("GDExtension"), TTR(vformat("Failed to copy shared object \"%s\".", src_path)));
}
} }
} else { } else {
err = da->copy(src_path, target_path); err = da->copy(src_path, target_path);
if (err != OK) {
add_message(EXPORT_MESSAGE_ERROR, TTR("GDExtension"), TTR(vformat("Failed to copy shared object \"%s\".", src_path)));
}
if (err == OK) { if (err == OK) {
err = sign_shared_object(p_preset, p_debug, target_path); err = sign_shared_object(p_preset, p_debug, target_path);
} }

5
editor/plugins/gdextension_export_plugin.h
View File

@ -127,7 +127,10 @@ void GDExtensionExportPlugin::_export_file(const String &p_path, const String &p
for (const String &E : p_features) { for (const String &E : p_features) {
features_vector.append(E); features_vector.append(E);
} }
ERR_FAIL_MSG(vformat("No suitable library found for GDExtension: %s. Possible feature flags for your platform: %s", p_path, String(", ").join(features_vector))); if (get_export_platform().is_valid()) {
get_export_platform()->add_message(EditorExportPlatform::EXPORT_MESSAGE_WARNING, TTR("GDExtension"), vformat(TTR("No suitable library found for GDExtension: \"%s\". Possible feature flags for your platform: %s"), p_path, String(", ").join(features_vector)));
}
return;
} }
Vector<SharedObject> dependencies_shared_objects = GDExtensionLibraryLoader::find_extension_dependencies(p_path, config, [p_features](String p_feature) { return p_features.has(p_feature); }); Vector<SharedObject> dependencies_shared_objects = GDExtensionLibraryLoader::find_extension_dependencies(p_path, config, [p_features](String p_feature) { return p_features.has(p_feature); });