Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-02-14 23:01:25 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

[HTML5] Handle contextmenu, webglcontextlost internally.

Browse Source 
This way they are automatically cleaned up when the engine exits,
landing a hand to browsers garbage collectors.
This commit is contained in:
Fabio Alessandrelli 2021-02-10 16:22:48 +01:00
parent e9e2dedb76
commit 3366122e1a
4 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
platform/javascript/display_server_javascript.cpp
View File

@ -703,6 +703,9 @@ DisplayServerJavaScript::DisplayServerJavaScript(const String &p_rendering_drive
// Ensure the canvas ID.
godot_js_config_canvas_id_get(canvas_id, 256);
// Handle contextmenu, webglcontextlost
godot_js_display_setup_canvas();
// Check if it's windows.
swap_cancel_ok = godot_js_display_is_swap_ok_cancel() == 1;

1
platform/javascript/godot_js.h
View File

@ -86,6 +86,7 @@ extern int godot_js_display_gamepad_sample_get(int p_idx, float r_btns[16], int3
extern void godot_js_display_notification_cb(void (*p_callback)(int p_notification), int p_enter, int p_exit, int p_in, int p_out);
extern void godot_js_display_paste_cb(void (*p_callback)(const char *p_text));
extern void godot_js_display_drop_files_cb(void (*p_callback)(char **p_filev, int p_filec));
extern void godot_js_display_setup_canvas();
#ifdef __cplusplus
}
#endif

11
platform/javascript/js/engine/engine.js
View File

@ -107,17 +107,6 @@ const Engine = (function () {
me.canvas.tabIndex = 0;
}
// Disable right-click context menu.
me.canvas.addEventListener('contextmenu', function (ev) {
ev.preventDefault();
}, false);
// Until context restoration is implemented warn the user of context loss.
me.canvas.addEventListener('webglcontextlost', function (ev) {
alert('WebGL context lost, please reload the page'); // eslint-disable-line no-alert
ev.preventDefault();
}, false);
// Browser locale, or custom one if defined.
let locale = me.customLocale;
if (!locale) {

12
platform/javascript/js/libs/library_godot_display.js
View File

@ -619,6 +619,18 @@ const GodotDisplay = {
GodotDisplayListeners.add(canvas, 'drop', GodotDisplayDragDrop.handler(dropFiles));
},
godot_js_display_setup_canvas__sig: 'v',
godot_js_display_setup_canvas: function () {
const canvas = GodotConfig.canvas;
GodotDisplayListeners.add(canvas, 'contextmenu', function (ev) {
ev.preventDefault();
}, false);
GodotDisplayListeners.add(canvas, 'webglcontextlost', function (ev) {
alert('WebGL context lost, please reload the page'); // eslint-disable-line no-alert
ev.preventDefault();
}, false);
},
/*
* Gamepads
*/