Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-22 12:12:28 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #73693 from vnen/gdscript-fix-script-signature-check

Browse Source 
GDScript: Fix override signature check of script inheritance
This commit is contained in:
Rémi Verschelde 2023-02-21 21:19:39 +01:00
commit 253396ba39
No known key found for this signature in database
GPG Key ID: C3336907360768E1
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/gdscript/gdscript_analyzer.cpp
View File

@ -1538,6 +1538,7 @@ void GDScriptAnalyzer::resolve_function_signature(GDScriptParser::FunctionNode *
// Check if the function signature matches the parent. If not it's an error since it breaks polymorphism.
// Not for the constructor which can vary in signature.
GDScriptParser::DataType base_type = parser->current_class->base_type;
base_type.is_meta_type = false;
GDScriptParser::DataType parent_return_type;
List<GDScriptParser::DataType> parameters_types;
int default_par_count = 0;

10
modules/gdscript/tests/scripts/analyzer/features/inheritance_signature_check_no_meta.gd Normal file
View File

@ -0,0 +1,10 @@
func test():
print("ok")
# https://github.com/godotengine/godot/issues/71994
class A:
extends RefCounted
class B:
extends A
func duplicate():
pass

2
modules/gdscript/tests/scripts/analyzer/features/inheritance_signature_check_no_meta.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_OK
ok