Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-10-24 14:12:02 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #63752 from raulsntos/csharp-rename-phi

Browse Source 
Rename math 'phi' arguments to 'angle' in C#
This commit is contained in:
Ignacio Roldán Etcheverry 2022-08-01 05:48:43 +02:00 committed by GitHub
commit 19e0e06dd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/mono/glue/GodotSharp/GodotSharp/Core/Basis.cs
View File

@ -531,9 +531,9 @@ namespace Godot
/// <param name="axis">The axis to rotate around. Must be normalized.</param>
/// <param name="angle">The angle to rotate, in radians.</param>
/// <returns>The rotated basis matrix.</returns>
public Basis Rotated(Vector3 axis, real_t phi)
public Basis Rotated(Vector3 axis, real_t angle)
{
return new Basis(axis, phi) * this;
return new Basis(axis, angle) * this;
}
/// <summary>
@ -774,15 +774,15 @@ namespace Godot
/// </summary>
/// <param name="axis">The axis to rotate around. Must be normalized.</param>
/// <param name="angle">The angle to rotate, in radians.</param>
public Basis(Vector3 axis, real_t phi)
public Basis(Vector3 axis, real_t angle)
{
Vector3 axisSq = new Vector3(axis.x * axis.x, axis.y * axis.y, axis.z * axis.z);
real_t cosine = Mathf.Cos(phi);
real_t cosine = Mathf.Cos(angle);
Row0.x = axisSq.x + cosine * (1.0f - axisSq.x);
Row1.y = axisSq.y + cosine * (1.0f - axisSq.y);
Row2.z = axisSq.z + cosine * (1.0f - axisSq.z);
real_t sine = Mathf.Sin(phi);
real_t sine = Mathf.Sin(angle);
real_t t = 1.0f - cosine;
real_t xyzt = axis.x * axis.y * t;

4
modules/mono/glue/GodotSharp/GodotSharp/Core/Transform2D.cs
View File

@ -301,9 +301,9 @@ namespace Godot
/// </summary>
/// <param name="angle">The angle to rotate, in radians.</param>
/// <returns>The rotated transformation matrix.</returns>
public Transform2D Rotated(real_t phi)
public Transform2D Rotated(real_t angle)
{
return this * new Transform2D(phi, new Vector2());
return this * new Transform2D(angle, new Vector2());
}
/// <summary>

4
modules/mono/glue/GodotSharp/GodotSharp/Core/Transform3D.cs
View File

@ -192,9 +192,9 @@ namespace Godot
/// <param name="axis">The axis to rotate around. Must be normalized.</param>
/// <param name="angle">The angle to rotate, in radians.</param>
/// <returns>The rotated transformation matrix.</returns>
public Transform3D Rotated(Vector3 axis, real_t phi)
public Transform3D Rotated(Vector3 axis, real_t angle)
{
return new Transform3D(new Basis(axis, phi), new Vector3()) * this;
return new Transform3D(new Basis(axis, angle), new Vector3()) * this;
}
/// <summary>

6
modules/mono/glue/GodotSharp/GodotSharp/Core/Vector2.cs
View File

@ -495,10 +495,10 @@ namespace Godot
/// </summary>
/// <param name="angle">The angle to rotate by, in radians.</param>
/// <returns>The rotated vector.</returns>
public Vector2 Rotated(real_t phi)
public Vector2 Rotated(real_t angle)
{
real_t sine = Mathf.Sin(phi);
real_t cosi = Mathf.Cos(phi);
real_t sine = Mathf.Sin(angle);
real_t cosi = Mathf.Cos(angle);
return new Vector2(
x * cosi - y * sine,
x * sine + y * cosi);

4
modules/mono/glue/GodotSharp/GodotSharp/Core/Vector3.cs
View File

@ -515,7 +515,7 @@ namespace Godot
/// <param name="axis">The vector to rotate around. Must be normalized.</param>
/// <param name="angle">The angle to rotate by, in radians.</param>
/// <returns>The rotated vector.</returns>
public Vector3 Rotated(Vector3 axis, real_t phi)
public Vector3 Rotated(Vector3 axis, real_t angle)
{
#if DEBUG
if (!axis.IsNormalized())
@ -523,7 +523,7 @@ namespace Godot
throw new ArgumentException("Argument is not normalized", nameof(axis));
}
#endif
return new Basis(axis, phi).Xform(this);
return new Basis(axis, angle).Xform(this);
}
/// <summary>