Nixyri/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-25 05:33:11 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #55214 from Scony/fix-gdscript-crash-2

Browse Source 
Fix GDScript parser crash on 'dollar mixed with assignment' expression
This commit is contained in:
Rémi Verschelde 2022-01-22 20:30:54 +01:00 committed by GitHub
commit 182a36db47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/gdscript/gdscript_parser.cpp
View File

@ -2415,6 +2415,9 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_assignment(ExpressionNode
push_error("Assignment is not allowed inside an expression.");
return parse_expression(false); // Return the following expression.
}
if (p_previous_operand == nullptr) {
return parse_expression(false); // Return the following expression.
}
#ifdef DEBUG_ENABLED
VariableNode *source_variable = nullptr;

2
modules/gdscript/tests/scripts/parser/errors/dollar-assignment-bug-53696.gd Normal file
View File

@ -0,0 +1,2 @@
func test():
$=$

2
modules/gdscript/tests/scripts/parser/errors/dollar-assignment-bug-53696.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
Expect node path as string or identifier after "$".