Nixyri/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2024-11-22 04:05:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

GT-2724 - review fixes

Browse Source
This commit is contained in:
dragonmacher 2019-04-10 17:38:33 -04:00
parent d474d83166
commit c65c60a042
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserDialog.java
View File

@ -51,7 +51,7 @@ import resources.ResourceManager;
* to perform the action defined by the executor. * to perform the action defined by the executor.
* *
* <p>Each button press will use the selected items as the items to be processed. While the * <p>Each button press will use the selected items as the items to be processed. While the
* items are schedule to be processed, they will still be in the table, painted light gray. * items are scheduled to be processed, they will still be in the table, painted light gray.
* Attempting to reschedule any of these pending items will have no effect. Each time the * Attempting to reschedule any of these pending items will have no effect. Each time the
* button is pressed, a new {@link SwingWorker} is created, which will put the processing into * button is pressed, a new {@link SwingWorker} is created, which will put the processing into
* a background thread. Further, by using multiple workers, the work will be performed in * a background thread. Further, by using multiple workers, the work will be performed in
@ -115,7 +115,7 @@ public class TableChooserDialog extends DialogComponentProvider
e -> setOkEnabled(table.getSelectedRowCount() > 0)); e -> setOkEnabled(table.getSelectedRowCount() > 0));
GhidraTableFilterPanel<AddressableRowObject> filterPanel = GhidraTableFilterPanel<AddressableRowObject> filterPanel =
new GhidraTableFilterPanel<AddressableRowObject>(table, model); new GhidraTableFilterPanel<>(table, model);
panel.add(tablePanel, BorderLayout.CENTER); panel.add(tablePanel, BorderLayout.CENTER);
panel.add(filterPanel, BorderLayout.SOUTH); panel.add(filterPanel, BorderLayout.SOUTH);
return panel; return panel;
@ -270,7 +270,7 @@ public class TableChooserDialog extends DialogComponentProvider
private List<AddressableRowObject> doProcessRowObjects(List<AddressableRowObject> rowObjects, private List<AddressableRowObject> doProcessRowObjects(List<AddressableRowObject> rowObjects,
TaskMonitor monitor) { TaskMonitor monitor) {
List<AddressableRowObject> deleted = new ArrayList<AddressableRowObject>(); List<AddressableRowObject> deleted = new ArrayList<>();
for (AddressableRowObject rowObject : rowObjects) { for (AddressableRowObject rowObject : rowObjects) {
if (monitor.isCancelled()) { if (monitor.isCancelled()) {
break; break;

2
Ghidra/Features/Base/src/main/java/ghidra/app/tablechooser/TableChooserTableModel.java
View File

@ -30,7 +30,7 @@ import ghidra.util.task.TaskMonitor;
public class TableChooserTableModel extends AddressBasedTableModel<AddressableRowObject> { public class TableChooserTableModel extends AddressBasedTableModel<AddressableRowObject> {
// we maintain this list so that any future reload operations can load the original user data // we maintain this list so that any future reload operations can load the original user data
// (this downside of this is that two lists are maintained) // (the downside of this is that two lists are maintained)
Set<AddressableRowObject> myPrivateList = new HashSet<AddressableRowObject>(); Set<AddressableRowObject> myPrivateList = new HashSet<AddressableRowObject>();
public TableChooserTableModel(String title, ServiceProvider serviceProvider, Program program, public TableChooserTableModel(String title, ServiceProvider serviceProvider, Program program,