From 9cd01c9a081066a5a49a6faca5dca3b4e15154ec Mon Sep 17 00:00:00 2001
From: caheckman <caheckman@users.noreply.github.com>
Date: Tue, 26 Mar 2019 16:29:44 -0400
Subject: [PATCH] Fix for GT-2704

---
 .../ghidra/program/model/pcode/PcodeDataTypeManager.java   | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/PcodeDataTypeManager.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/PcodeDataTypeManager.java
index d75023a482..8a8bd055f2 100644
--- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/PcodeDataTypeManager.java
+++ b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/pcode/PcodeDataTypeManager.java
@@ -261,10 +261,7 @@ public class PcodeDataTypeManager {
 		if (type instanceof Array) {
 			return buildType(type, size);
 		}
-		if (type instanceof FunctionDefinition) {
-			return buildType(type, size);
-		}
-		if (type.getLength() <= 0) {
+		if (!(type instanceof FunctionDefinition) && type.getLength() <= 0) {
 			return buildType(type, size);
 		}
 		StringBuilder resBuf = new StringBuilder();
@@ -541,7 +538,7 @@ public class PcodeDataTypeManager {
 		}
 		resBuf.append("<type");
 		if ((type instanceof Pointer) || (type instanceof Array) ||
-			(type instanceof FunctionDefinition) || (type.getLength() <= 0)) {
+			(!(type instanceof FunctionDefinition) && type.getLength() <= 0)) {
 			SpecXmlUtils.encodeStringAttribute(resBuf, "name", "");
 		}
 		else {