From 8b67e8f53f3a11112d80f789c0113acb86fec6ff Mon Sep 17 00:00:00 2001
From: dev747368 <48332326+dev747368@users.noreply.github.com>
Date: Mon, 1 Apr 2019 11:46:07 -0400
Subject: [PATCH] Codereview fixes

---
 .../ghidra/app/plugin/core/data/AbstractDataActionTest.java | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/data/AbstractDataActionTest.java b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/data/AbstractDataActionTest.java
index c324bfd1bf..0072b10fb9 100644
--- a/Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/data/AbstractDataActionTest.java
+++ b/Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/data/AbstractDataActionTest.java
@@ -1271,8 +1271,7 @@ public abstract class AbstractDataActionTest extends AbstractGhidraHeadedIntegra
 			pdata != null && (pdata.isStructure() || pdata.isUnion()), caseName);
 		checkAction(actions, CREATE_ARRAY, true, caseName);
 		checkAction(actions, DEFAULT_DATA_SETTINGS,
-			(hasSelection == false || isSelectionJustSingleDataInstance(sel, d)) && hasSettings,
-			caseName);
+			(!hasSelection || isSelectionJustSingleDataInstance(sel, d)) && hasSettings, caseName);
 		checkAction(actions, DATA_SETTINGS, hasNormalUnitSelection || hasSettings, caseName);
 		checkAction(actions, CYCLE_FLOAT_DOUBLE, onFloatDoubleData, caseName);
 		checkAction(actions, CYCLE_BYTE_WORD_DWORD_QWORD, onByteWordData, caseName);
@@ -1335,8 +1334,7 @@ public abstract class AbstractDataActionTest extends AbstractGhidraHeadedIntegra
 			pdata != null && (pdata.isStructure() || pdata.isUnion()), caseName);
 		checkAction(actions, CREATE_ARRAY, true, caseName);
 		checkAction(actions, DEFAULT_DATA_SETTINGS,
-			hasSettings && (hasSelection == false || isSelectionJustSingleDataInstance(sel, d)),
-			caseName);
+			hasSettings && (!hasSelection || isSelectionJustSingleDataInstance(sel, d)), caseName);
 		checkAction(actions, DATA_SETTINGS, hasSettings, caseName);
 		checkAction(actions, CYCLE_FLOAT_DOUBLE, true, caseName);
 		checkAction(actions, CYCLE_BYTE_WORD_DWORD_QWORD, true, caseName);