GP-4779 fixed issue in add references dialog where moving mouse would

sometimes reset address space choice in comboBox.
This commit is contained in:
ghidragon 2024-07-18 13:00:29 -04:00
parent aced7d387b
commit 8225c10b6c
5 changed files with 16 additions and 16 deletions

View File

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -235,7 +235,7 @@ public abstract class AbstractEditFunctionSignatureDialog extends DialogComponen
private void installInlineWidget(JPanel parentPanel) {
inlineCheckBox = new GCheckBox("Inline");
inlineCheckBox.addChangeListener(e -> {
inlineCheckBox.addItemListener(e -> {
if (inlineCheckBox.isSelected() && callFixupComboBox != null) {
callFixupComboBox.setSelectedItem(NONE_CHOICE);
}

View File

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -103,7 +103,7 @@ class EditMemoryReferencePanel extends EditReferencePanel {
.setAccessibleDescription(
"Selecting this checkbox allows entering a refernce offset");
offsetCheckbox.setHorizontalAlignment(SwingConstants.RIGHT);
offsetCheckbox.addChangeListener(e -> enableOffsetField(offsetCheckbox.isSelected()));
offsetCheckbox.addItemListener(e -> enableOffsetField(offsetCheckbox.isSelected()));
offsetField = new JTextField();
offsetField.getAccessibleContext().setAccessibleName("Enter Offset");
@ -123,7 +123,7 @@ class EditMemoryReferencePanel extends EditReferencePanel {
includeOtherOverlaysCheckbox = new JCheckBox("Include OTHER overlay spaces",
Boolean.getBoolean(Preferences.getProperty(INCLUDE_OTHER_OVERLAY_PREFERENCE, "false")));
includeOtherOverlaysCheckbox.addChangeListener(e -> refreshToAddressField());
includeOtherOverlaysCheckbox.addItemListener(e -> refreshToAddressField());
refTypes = new GhidraComboBox<>(MEM_REF_TYPES);
refTypes.getAccessibleContext().setAccessibleName("Memory Ref Types");

View File

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -416,7 +416,7 @@ public class AddressInput extends JPanel implements FocusableEditor {
remove(combo);
comboAdded = false;
}
invalidate();
revalidate();
}
@Override

View File

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -838,7 +838,7 @@ public class ApplyMarkupPropertyEditor implements OptionsEditor {
private JCheckBox createCheckBox(String optionName) {
JCheckBox applyCheckBox = new GCheckBox(optionName);
applyCheckBox.addChangeListener(e -> changesMade(true));
applyCheckBox.addItemListener(e -> changesMade(true));
return applyCheckBox;
}

View File

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -376,7 +376,7 @@ public class ConditionTestPanel extends JPanel {
label = new GDLabel(test.getName());
add(label);
label.setToolTipText(test.getDescription());
checkbox.addChangeListener(e -> {
checkbox.addItemListener(e -> {
conditionTestModel.setEnabled(test, checkbox.isSelected());
label.setEnabled(checkbox.isSelected());
});