From 515aa0962cbb51350334d3b300dc2ecb0719f95b Mon Sep 17 00:00:00 2001 From: Ryan Kurtz Date: Thu, 25 Apr 2019 13:15:39 -0400 Subject: [PATCH] Fixing a couple of comments. --- .../main/java/ghidra/app/cmd/label/SetLabelPrimaryCmd.java | 5 ++++- .../src/main/java/ghidra/program/model/symbol/Symbol.java | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/label/SetLabelPrimaryCmd.java b/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/label/SetLabelPrimaryCmd.java index 20831240d1..13b0b9a046 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/label/SetLabelPrimaryCmd.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/cmd/label/SetLabelPrimaryCmd.java @@ -26,7 +26,7 @@ import ghidra.util.exception.InvalidInputException; /** * Command to make a label the primary label at an address. Only really - * makes sense if there is more that one label at the address - otherwise + * makes sense if there is more than one label at the address - otherwise * the label will already be primary. */ public class SetLabelPrimaryCmd implements Command { @@ -52,6 +52,7 @@ public class SetLabelPrimaryCmd implements Command { * * @see ghidra.framework.cmd.Command#applyTo(ghidra.framework.model.DomainObject) */ + @Override public boolean applyTo(DomainObject obj) { Program program = (Program) obj; st = program.getSymbolTable(); @@ -117,6 +118,7 @@ public class SetLabelPrimaryCmd implements Command { /** * @see ghidra.framework.cmd.Command#getStatusMsg() */ + @Override public String getStatusMsg() { return errorMsg; } @@ -124,6 +126,7 @@ public class SetLabelPrimaryCmd implements Command { /** * @see ghidra.framework.cmd.Command#getName() */ + @Override public String getName() { return "Set Primary Label"; } diff --git a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Symbol.java b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Symbol.java index 35330b727a..2d6d15ee20 100644 --- a/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Symbol.java +++ b/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/Symbol.java @@ -233,8 +233,8 @@ public interface Symbol { public boolean isPrimary(); /** - * Sets this symbol to be primary. All other symbols - * at the same address will be set to !primary. + * Sets this symbol to be primary. All other symbols at the same address will be set to + * !primary. Only applies to non-function symbols. * @return returns true if the symbol was not primary and now it is, otherwise false */ public boolean setPrimary();