From 3943dd39f2d4d3b5c2bb9d73c8c7eefac5e25bb6 Mon Sep 17 00:00:00 2001 From: hippietrail Date: Thu, 17 Oct 2024 00:24:34 +0800 Subject: [PATCH] Let FileSystem extensions set filetype icons in filesystem browser --- .../gfilesystem/fileinfo/FileAttributeType.java | 1 + .../ghidra/plugins/fsbrowser/FSBComponentProvider.java | 10 +++++++++- .../java/ghidra/plugins/fsbrowser/FSBFileNode.java | 6 ++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/formats/gfilesystem/fileinfo/FileAttributeType.java b/Ghidra/Features/Base/src/main/java/ghidra/formats/gfilesystem/fileinfo/FileAttributeType.java index a7bffc7d57..f112d7496c 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/formats/gfilesystem/fileinfo/FileAttributeType.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/formats/gfilesystem/fileinfo/FileAttributeType.java @@ -56,6 +56,7 @@ public enum FileAttributeType { SYMLINK_DEST_ATTR("Symbolic link destination", MISC_INFO, String.class), COMMENT_ATTR("Comment", MISC_INFO, String.class), + FILENAME_EXT_OVERRIDE("Extension override", MISC_INFO, String.class), UNKNOWN_ATTRIBUTE("Other attribute", ADDITIONAL_INFO, Object.class); diff --git a/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBComponentProvider.java b/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBComponentProvider.java index d5b8e32b55..3cbd3808c3 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBComponentProvider.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBComponentProvider.java @@ -192,9 +192,17 @@ public class FSBComponentProvider extends ComponentProviderAdapter overlays.add(FSBIcons.MISSING_PASSWORD_OVERLAY_ICON); } + String ext = node.getFilenameExtOverride(); + if (ext != null && !ext.isEmpty()) { + if (!ext.startsWith(".")) { + Msg.error(this, "Extension override '" + ext + "' does not begin with a dot"); + } else { + filename += ext; + } + } + Icon icon = fsbIcons.getIcon(filename, overlays); setIcon(icon); - } }); } diff --git a/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBFileNode.java b/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBFileNode.java index 4c6b6c4347..17391b73ec 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBFileNode.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/plugins/fsbrowser/FSBFileNode.java @@ -38,6 +38,7 @@ public class FSBFileNode extends FSBNode { protected boolean hasPassword; protected String symlinkDest; protected long lastModified; + protected String filenameExtOverride; FSBFileNode(GFile file) { this.file = file; @@ -83,6 +84,10 @@ public class FSBFileNode extends FSBNode { return symlinkDest != null; } + public String getFilenameExtOverride() { + return filenameExtOverride; + } + @Override public int hashCode() { return file.hashCode(); @@ -95,6 +100,7 @@ public class FSBFileNode extends FSBNode { symlinkDest = fattrs.get(SYMLINK_DEST_ATTR, String.class, null); Date lastModDate = fattrs.get(MODIFIED_DATE_ATTR, Date.class, null); lastModified = lastModDate != null ? lastModDate.getTime() : 0; + filenameExtOverride = fattrs.get(FILENAME_EXT_OVERRIDE, String.class, null); } @Override