Nixyri/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2024-11-21 19:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/GP-4975_ghizard_PDB_allow_VxTable_mangled_symbols_to_be_primary'

Browse Source
This commit is contained in:
Ryan Kurtz 2024-10-01 13:48:51 -04:00
commit 23b75ec040
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Ghidra/Features/PDB/src/main/java/ghidra/app/util/pdb/pdbapplicator/DefaultPdbApplicator.java
View File

@ -2335,8 +2335,10 @@ public class DefaultPdbApplicator implements PdbApplicator {
} }
if (!existingSymbol.getParentNamespace().equals(program.getGlobalNamespace())) { if (!existingSymbol.getParentNamespace().equals(program.getGlobalNamespace())) {
// existing symbol has a non-global namespace // Existing symbol has a non-global namespace
return doCreateSymbol(address, symbolPath, false, plateAddition); if (!preferNewSymbolOverExistingNamespacedSymbol(symbolPath)) {
return doCreateSymbol(address, symbolPath, false, plateAddition);
}
} }
if (symbolPath.getParent() != null) { if (symbolPath.getParent() != null) {
@ -2353,6 +2355,22 @@ public class DefaultPdbApplicator implements PdbApplicator {
return doCreateSymbol(address, symbolPath, false, plateAddition); return doCreateSymbol(address, symbolPath, false, plateAddition);
} }
// We've found that a mangled version of vxtables can present more detailed information
// than a non-mangled vxtable symbol that has a namespace (the information is not
// as descriptive regarding vxtables owned by the child for a parent). So do not
// accept these existing symbol with namespace to maintain their primary status.
//
// Kludge... this mechanism might go away later if/when instead we evaluate all symbols at
// an address to do the right thing or if/when we process the tables in some place other
// than or besides the Demangler.
private boolean preferNewSymbolOverExistingNamespacedSymbol(SymbolPath symbolPath) {
String name = symbolPath.getName();
if (name.startsWith("??_7") || name.startsWith("??_8")) {
return true;
}
return false;
}
private Symbol doCreateSymbol(Address address, SymbolPath symbolPath, boolean makePrimary, private Symbol doCreateSymbol(Address address, SymbolPath symbolPath, boolean makePrimary,
String plateAddition) { String plateAddition) {
Symbol symbol = null; Symbol symbol = null;