diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/exporter/ExporterDialog.java b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/exporter/ExporterDialog.java index 2846aa1915..f835e6e7c2 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/exporter/ExporterDialog.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/exporter/ExporterDialog.java @@ -64,12 +64,12 @@ import ghidra.util.task.*; public class ExporterDialog extends DialogComponentProvider implements AddressFactoryService { private static final String XML_WARNING = - " Warning: XML is lossy and intended only for transfering data to external tools. " + - "GZF is the recommended format for saving and sharing program data."; + " Warning: XML is lossy and intended only for transfering data to external tools. " + + "GZF is the recommended format for saving and sharing program data."; private static final String SARIF_WARNING = - " Warning: SARIF is lossy and intended only for transfering data to external tools. " + - "GZF is the recommended format for saving and sharing program data."; + " Warning: SARIF is lossy and intended only for transfering data to external tools. " + + "GZF is the recommended format for saving and sharing program data."; private static String lastUsedExporterName = GzfExporter.NAME; // default to GZF first time @@ -216,6 +216,8 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa selectionOnlyLabel = new GLabel("Selection Only:"); if (!isFrontEndPlugin()) { selectionCheckBox = new GCheckBox(""); + selectionCheckBox.setToolTipText("Select to only export from selected program areas"); + selectionCheckBox.getAccessibleContext().setAccessibleName("Selection Only"); updateSelectionCheckbox(); panel.add(selectionOnlyLabel); panel.add(selectionCheckBox); @@ -226,6 +228,7 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa private Component buildFilePanel() { filePathTextField = new JTextField(); filePathTextField.setName("OUTPUT_FILE_TEXTFIELD"); + filePathTextField.getAccessibleContext().setAccessibleName("Output File"); filePathTextField.setText(getFileName()); filePathTextField.getDocument().addDocumentListener(new DocumentListener() { @Override @@ -246,6 +249,8 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa }); fileChooserButton = new BrowseButton(); + fileChooserButton.getAccessibleContext() + .setAccessibleDescription("Invoke file chooser dialog to pick output file"); fileChooserButton.addActionListener(e -> chooseDestinationFile()); JPanel panel = new JPanel(new BorderLayout()); @@ -308,6 +313,7 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa comboBox.setSelectedItem(defaultExporter); } comboBox.addItemListener(e -> selectedFormatChanged()); + comboBox.getAccessibleContext().setAccessibleName("Format"); return comboBox; } @@ -490,10 +496,8 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa String msg = "Could not open file: " + domainFile.getName() + "\n\nAvailable export options will be limited."; if (e.isUpgradable()) { - msg += - "\n\nA data upgrade is required. You may open file" + - "\nin a tool first then Export if a different exporter" + - "\nis required."; + msg += "\n\nA data upgrade is required. You may open file" + + "\nin a tool first then Export if a different exporter" + "\nis required."; } else { msg += "\nFile was created with a newer version of Ghidra"; @@ -621,9 +625,8 @@ public class ExporterDialog extends DialogComponentProvider implements AddressFa try { Map metadata = domainObject != null ? domainObject.getMetadata() : domainFile.getMetadata(); - AboutDomainObjectUtils.displayInformation(tool, domainFile, - metadata, "Export Results Summary", resultsBuffer.toString(), - helpLocation); + AboutDomainObjectUtils.displayInformation(tool, domainFile, metadata, + "Export Results Summary", resultsBuffer.toString(), helpLocation); } finally { if (domainObject != null) { diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/OptionsEditorPanel.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/OptionsEditorPanel.java index c893ec730a..d83f0de852 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/OptionsEditorPanel.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/OptionsEditorPanel.java @@ -21,7 +21,6 @@ import java.util.List; import javax.swing.*; import javax.swing.border.Border; -import javax.swing.border.EtchedBorder; import javax.swing.event.DocumentEvent; import javax.swing.event.DocumentListener; @@ -72,36 +71,42 @@ public class OptionsEditorPanel extends JPanel { } private Component buildOptionGroupPanel(List