mirror of
https://github.com/torvalds/linux.git
synced 2024-12-04 10:01:41 +00:00
0bec8b7e5c
We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.
// <smpl>
@@
expression ret;
struct platform_device *E;
@@
ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);
if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>
While we're here, remove braces on if statements that only have one
statement (manually).
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
104 lines
2.3 KiB
C
104 lines
2.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Rockchip RK805 PMIC Power Key driver
|
|
*
|
|
* Copyright (c) 2017, Fuzhou Rockchip Electronics Co., Ltd
|
|
*
|
|
* Author: Joseph Chen <chenjh@rock-chips.com>
|
|
*/
|
|
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
#include <linux/input.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
static irqreturn_t pwrkey_fall_irq(int irq, void *_pwr)
|
|
{
|
|
struct input_dev *pwr = _pwr;
|
|
|
|
input_report_key(pwr, KEY_POWER, 1);
|
|
input_sync(pwr);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static irqreturn_t pwrkey_rise_irq(int irq, void *_pwr)
|
|
{
|
|
struct input_dev *pwr = _pwr;
|
|
|
|
input_report_key(pwr, KEY_POWER, 0);
|
|
input_sync(pwr);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int rk805_pwrkey_probe(struct platform_device *pdev)
|
|
{
|
|
struct input_dev *pwr;
|
|
int fall_irq, rise_irq;
|
|
int err;
|
|
|
|
pwr = devm_input_allocate_device(&pdev->dev);
|
|
if (!pwr) {
|
|
dev_err(&pdev->dev, "Can't allocate power button\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
pwr->name = "rk805 pwrkey";
|
|
pwr->phys = "rk805_pwrkey/input0";
|
|
pwr->id.bustype = BUS_HOST;
|
|
input_set_capability(pwr, EV_KEY, KEY_POWER);
|
|
|
|
fall_irq = platform_get_irq(pdev, 0);
|
|
if (fall_irq < 0)
|
|
return fall_irq;
|
|
|
|
rise_irq = platform_get_irq(pdev, 1);
|
|
if (rise_irq < 0)
|
|
return rise_irq;
|
|
|
|
err = devm_request_any_context_irq(&pwr->dev, fall_irq,
|
|
pwrkey_fall_irq,
|
|
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
|
|
"rk805_pwrkey_fall", pwr);
|
|
if (err < 0) {
|
|
dev_err(&pdev->dev, "Can't register fall irq: %d\n", err);
|
|
return err;
|
|
}
|
|
|
|
err = devm_request_any_context_irq(&pwr->dev, rise_irq,
|
|
pwrkey_rise_irq,
|
|
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
|
|
"rk805_pwrkey_rise", pwr);
|
|
if (err < 0) {
|
|
dev_err(&pdev->dev, "Can't register rise irq: %d\n", err);
|
|
return err;
|
|
}
|
|
|
|
err = input_register_device(pwr);
|
|
if (err) {
|
|
dev_err(&pdev->dev, "Can't register power button: %d\n", err);
|
|
return err;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, pwr);
|
|
device_init_wakeup(&pdev->dev, true);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver rk805_pwrkey_driver = {
|
|
.probe = rk805_pwrkey_probe,
|
|
.driver = {
|
|
.name = "rk805-pwrkey",
|
|
},
|
|
};
|
|
module_platform_driver(rk805_pwrkey_driver);
|
|
|
|
MODULE_AUTHOR("Joseph Chen <chenjh@rock-chips.com>");
|
|
MODULE_DESCRIPTION("RK805 PMIC Power Key driver");
|
|
MODULE_LICENSE("GPL");
|