mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 16:41:39 +00:00
a780278472
Acquire the buffer object's reservation lock in drm_gem_pin() and remove locking the drivers' GEM callbacks where necessary. Same for unpin(). DRM drivers and memory managers modified by this patch will now have correct dma-buf locking semantics: the caller is responsible for holding the reservation lock when calling the pin or unpin callback. DRM drivers and memory managers that are not modified will now be protected against concurent invocation of their pin and unpin callbacks. PRIME does not implement struct dma_buf_ops.pin, which requires the caller to hold the reservation lock. It does implement struct dma_buf_ops.attach, which requires to callee to acquire the reservation lock. The PRIME code uses drm_gem_pin(), so locks are now taken as specified. Same for unpin and detach. The patch harmonizes GEM pin and unpin to have non-interruptible reservation locking across all drivers, as is already the case for vmap and vunmap. This affects gem-shmem, gem-vram, loongson, qxl and radeon. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Christian König <christian.koenig@amd.com> Reviewed-by: Zack Rusin <zack.rusin@broadcom.com> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> # virtio-gpu Link: https://patchwork.freedesktop.org/patch/msgid/20240227113853.8464-10-tzimmermann@suse.de
76 lines
2.2 KiB
C
76 lines
2.2 KiB
C
/*
|
|
* Copyright 2014 Canonical
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* Authors: Andreas Pokorny
|
|
*/
|
|
|
|
#include "qxl_drv.h"
|
|
#include "qxl_object.h"
|
|
|
|
/* Empty Implementations as there should not be any other driver for a virtual
|
|
* device that might share buffers with qxl */
|
|
|
|
int qxl_gem_prime_pin(struct drm_gem_object *obj)
|
|
{
|
|
struct qxl_bo *bo = gem_to_qxl_bo(obj);
|
|
|
|
return qxl_bo_pin_locked(bo);
|
|
}
|
|
|
|
void qxl_gem_prime_unpin(struct drm_gem_object *obj)
|
|
{
|
|
struct qxl_bo *bo = gem_to_qxl_bo(obj);
|
|
|
|
qxl_bo_unpin_locked(bo);
|
|
}
|
|
|
|
struct sg_table *qxl_gem_prime_get_sg_table(struct drm_gem_object *obj)
|
|
{
|
|
return ERR_PTR(-ENOSYS);
|
|
}
|
|
|
|
struct drm_gem_object *qxl_gem_prime_import_sg_table(
|
|
struct drm_device *dev, struct dma_buf_attachment *attach,
|
|
struct sg_table *table)
|
|
{
|
|
return ERR_PTR(-ENOSYS);
|
|
}
|
|
|
|
int qxl_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
|
|
{
|
|
struct qxl_bo *bo = gem_to_qxl_bo(obj);
|
|
int ret;
|
|
|
|
ret = qxl_bo_vmap_locked(bo, map);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
void qxl_gem_prime_vunmap(struct drm_gem_object *obj,
|
|
struct iosys_map *map)
|
|
{
|
|
struct qxl_bo *bo = gem_to_qxl_bo(obj);
|
|
|
|
qxl_bo_vunmap_locked(bo);
|
|
}
|