mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 04:31:50 +00:00
83d0d4cc14
Fixes this compiler warning: In file included from include/linux/property.h:14, from include/linux/acpi.h:16, from drivers/media/pci/intel/ipu-bridge.c:4: In function 'ipu_bridge_init_swnode_names', inlined from 'ipu_bridge_create_connection_swnodes' at drivers/media/pci/intel/ipu-bridge.c:445:2, inlined from 'ipu_bridge_connect_sensor' at drivers/media/pci/intel/ipu-bridge.c:656:3: include/linux/fwnode.h:81:49: warning: '%u' directive output may be truncated writing between 1 and 3 bytes into a region of size 2 [-Wformat-truncation=] 81 | #define SWNODE_GRAPH_PORT_NAME_FMT "port@%u" | ^~~~~~~~~ drivers/media/pci/intel/ipu-bridge.c:384:18: note: in expansion of macro 'SWNODE_GRAPH_PORT_NAME_FMT' 384 | SWNODE_GRAPH_PORT_NAME_FMT, sensor->link); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/fwnode.h: In function 'ipu_bridge_connect_sensor': include/linux/fwnode.h:81:55: note: format string is defined here 81 | #define SWNODE_GRAPH_PORT_NAME_FMT "port@%u" | ^~ In function 'ipu_bridge_init_swnode_names', inlined from 'ipu_bridge_create_connection_swnodes' at drivers/media/pci/intel/ipu-bridge.c:445:2, inlined from 'ipu_bridge_connect_sensor' at drivers/media/pci/intel/ipu-bridge.c:656:3: include/linux/fwnode.h:81:49: note: directive argument in the range [0, 255] 81 | #define SWNODE_GRAPH_PORT_NAME_FMT "port@%u" | ^~~~~~~~~ drivers/media/pci/intel/ipu-bridge.c:384:18: note: in expansion of macro 'SWNODE_GRAPH_PORT_NAME_FMT' 384 | SWNODE_GRAPH_PORT_NAME_FMT, sensor->link); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/pci/intel/ipu-bridge.c:382:9: note: 'snprintf' output between 7 and 9 bytes into a destination of size 7 382 | snprintf(sensor->node_names.remote_port, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 383 | sizeof(sensor->node_names.remote_port), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 384 | SWNODE_GRAPH_PORT_NAME_FMT, sensor->link); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Acked-by: Arnd Bergmann <arnd@arndb.de>
182 lines
4.3 KiB
C
182 lines
4.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/* Author: Dan Scally <djrscally@gmail.com> */
|
|
#ifndef __IPU_BRIDGE_H
|
|
#define __IPU_BRIDGE_H
|
|
|
|
#include <linux/property.h>
|
|
#include <linux/types.h>
|
|
#include <media/v4l2-fwnode.h>
|
|
|
|
#define IPU_HID "INT343E"
|
|
#define IPU_MAX_LANES 4
|
|
#define IPU_MAX_PORTS 4
|
|
#define MAX_NUM_LINK_FREQS 3
|
|
|
|
/* Values are educated guesses as we don't have a spec */
|
|
#define IPU_SENSOR_ROTATION_NORMAL 0
|
|
#define IPU_SENSOR_ROTATION_INVERTED 1
|
|
|
|
#define IPU_SENSOR_CONFIG(_HID, _NR, ...) \
|
|
(const struct ipu_sensor_config) { \
|
|
.hid = _HID, \
|
|
.nr_link_freqs = _NR, \
|
|
.link_freqs = { __VA_ARGS__ } \
|
|
}
|
|
|
|
#define NODE_SENSOR(_HID, _PROPS) \
|
|
(const struct software_node) { \
|
|
.name = _HID, \
|
|
.properties = _PROPS, \
|
|
}
|
|
|
|
#define NODE_PORT(_PORT, _SENSOR_NODE) \
|
|
(const struct software_node) { \
|
|
.name = _PORT, \
|
|
.parent = _SENSOR_NODE, \
|
|
}
|
|
|
|
#define NODE_ENDPOINT(_EP, _PORT, _PROPS) \
|
|
(const struct software_node) { \
|
|
.name = _EP, \
|
|
.parent = _PORT, \
|
|
.properties = _PROPS, \
|
|
}
|
|
|
|
#define NODE_VCM(_TYPE) \
|
|
(const struct software_node) { \
|
|
.name = _TYPE, \
|
|
}
|
|
|
|
enum ipu_sensor_swnodes {
|
|
SWNODE_SENSOR_HID,
|
|
SWNODE_SENSOR_PORT,
|
|
SWNODE_SENSOR_ENDPOINT,
|
|
SWNODE_IPU_PORT,
|
|
SWNODE_IPU_ENDPOINT,
|
|
/* below are optional / maybe empty */
|
|
SWNODE_IVSC_HID,
|
|
SWNODE_IVSC_SENSOR_PORT,
|
|
SWNODE_IVSC_SENSOR_ENDPOINT,
|
|
SWNODE_IVSC_IPU_PORT,
|
|
SWNODE_IVSC_IPU_ENDPOINT,
|
|
SWNODE_VCM,
|
|
SWNODE_COUNT
|
|
};
|
|
|
|
/* Data representation as it is in ACPI SSDB buffer */
|
|
struct ipu_sensor_ssdb {
|
|
u8 version;
|
|
u8 sku;
|
|
u8 guid_csi2[16];
|
|
u8 devfunction;
|
|
u8 bus;
|
|
u32 dphylinkenfuses;
|
|
u32 clockdiv;
|
|
u8 link;
|
|
u8 lanes;
|
|
u32 csiparams[10];
|
|
u32 maxlanespeed;
|
|
u8 sensorcalibfileidx;
|
|
u8 sensorcalibfileidxInMBZ[3];
|
|
u8 romtype;
|
|
u8 vcmtype;
|
|
u8 platforminfo;
|
|
u8 platformsubinfo;
|
|
u8 flash;
|
|
u8 privacyled;
|
|
u8 degree;
|
|
u8 mipilinkdefined;
|
|
u32 mclkspeed;
|
|
u8 controllogicid;
|
|
u8 reserved1[3];
|
|
u8 mclkport;
|
|
u8 reserved2[13];
|
|
} __packed;
|
|
|
|
struct ipu_property_names {
|
|
char clock_frequency[16];
|
|
char rotation[9];
|
|
char orientation[12];
|
|
char bus_type[9];
|
|
char data_lanes[11];
|
|
char remote_endpoint[16];
|
|
char link_frequencies[17];
|
|
};
|
|
|
|
struct ipu_node_names {
|
|
char port[7];
|
|
char ivsc_sensor_port[7];
|
|
char ivsc_ipu_port[7];
|
|
char endpoint[11];
|
|
char remote_port[9];
|
|
char vcm[16];
|
|
};
|
|
|
|
struct ipu_sensor_config {
|
|
const char *hid;
|
|
const u8 nr_link_freqs;
|
|
const u64 link_freqs[MAX_NUM_LINK_FREQS];
|
|
};
|
|
|
|
struct ipu_sensor {
|
|
/* append ssdb.link(u8) in "-%u" format as suffix of HID */
|
|
char name[ACPI_ID_LEN + 4];
|
|
struct acpi_device *adev;
|
|
|
|
struct device *csi_dev;
|
|
struct acpi_device *ivsc_adev;
|
|
char ivsc_name[ACPI_ID_LEN + 4];
|
|
|
|
/* SWNODE_COUNT + 1 for terminating NULL */
|
|
const struct software_node *group[SWNODE_COUNT + 1];
|
|
struct software_node swnodes[SWNODE_COUNT];
|
|
struct ipu_node_names node_names;
|
|
|
|
u8 link;
|
|
u8 lanes;
|
|
u32 mclkspeed;
|
|
u32 rotation;
|
|
enum v4l2_fwnode_orientation orientation;
|
|
const char *vcm_type;
|
|
|
|
struct ipu_property_names prop_names;
|
|
struct property_entry ep_properties[5];
|
|
struct property_entry dev_properties[5];
|
|
struct property_entry ipu_properties[3];
|
|
struct property_entry ivsc_properties[1];
|
|
struct property_entry ivsc_sensor_ep_properties[4];
|
|
struct property_entry ivsc_ipu_ep_properties[4];
|
|
|
|
struct software_node_ref_args local_ref[1];
|
|
struct software_node_ref_args remote_ref[1];
|
|
struct software_node_ref_args vcm_ref[1];
|
|
struct software_node_ref_args ivsc_sensor_ref[1];
|
|
struct software_node_ref_args ivsc_ipu_ref[1];
|
|
};
|
|
|
|
typedef int (*ipu_parse_sensor_fwnode_t)(struct acpi_device *adev,
|
|
struct ipu_sensor *sensor);
|
|
|
|
struct ipu_bridge {
|
|
struct device *dev;
|
|
ipu_parse_sensor_fwnode_t parse_sensor_fwnode;
|
|
char ipu_node_name[ACPI_ID_LEN];
|
|
struct software_node ipu_hid_node;
|
|
u32 data_lanes[4];
|
|
unsigned int n_sensors;
|
|
struct ipu_sensor sensors[IPU_MAX_PORTS];
|
|
};
|
|
|
|
#if IS_ENABLED(CONFIG_IPU_BRIDGE)
|
|
int ipu_bridge_init(struct device *dev,
|
|
ipu_parse_sensor_fwnode_t parse_sensor_fwnode);
|
|
int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor);
|
|
int ipu_bridge_instantiate_vcm(struct device *sensor);
|
|
#else
|
|
/* Use a define to avoid the @parse_sensor_fwnode argument getting evaluated */
|
|
#define ipu_bridge_init(dev, parse_sensor_fwnode) (0)
|
|
static inline int ipu_bridge_instantiate_vcm(struct device *s) { return 0; }
|
|
#endif
|
|
|
|
#endif
|