mirror of
https://github.com/torvalds/linux.git
synced 2024-12-03 09:31:26 +00:00
fe35317865
readlink() never zero terminates the provided buffer.
Therefore we already do
buffer[count] = 0;
This leads to an off-by-one buffer corruption as readlink()
might return the full size of the buffer.
The common technique is to reduce the buffer size by one.
Another fix would be to check
if (count < 0 || count == sizeof(buffer))
fatal();
Reducing the buffer size by one is easier IMHO.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Christoph Lameter <cl@gentwo.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
|
||
|---|---|---|
| .. | ||
| firewire | ||
| perf | ||
| power | ||
| slub | ||
| testing/ktest | ||
| usb | ||
| virtio | ||