mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 21:21:41 +00:00
fde192511b
I previously submitted a fix for a bug in the choice feature [1], where
I mentioned, "Another (much cleaner) approach would be to remove the
tristate choice support entirely".
There are more issues in the tristate choice feature. For example, you
can observe a couple of bugs in the following test code.
[Test Code]
config MODULES
def_bool y
modules
choice
prompt "tristate choice"
default A
config A
tristate "A"
config B
tristate "B"
endchoice
Bug 1: the 'default' property is not correctly processed
'make alldefconfig' produces:
CONFIG_MODULES=y
# CONFIG_A is not set
# CONFIG_B is not set
However, the correct output should be:
CONFIG_MODULES=y
CONFIG_A=y
# CONFIG_B is not set
The unit test file, scripts/kconfig/tests/choice/alldef_expected_config,
is wrong as well.
Bug 2: choice members never get 'y' with randconfig
For the test code above, the following combinations are possible:
A B
(1) y n
(2) n y
(3) m m
(4) m n
(5) n m
(6) n n
'make randconfig' never produces (1) or (2).
These bugs are fixable, but a more critical problem is the lack of a
sensible syntax to specify the default for the tristate choice.
The default for the choice must be one of the choice members, which
cannot specify any of the patterns (3) through (6) above.
In addition, I have never seen it being used in a useful way.
The following commits removed unnecessary use of tristate choices:
-
|
||
|---|---|---|
| .. | ||
| gcc-plugins.rst | ||
| headers_install.rst | ||
| index.rst | ||
| issues.rst | ||
| kbuild.rst | ||
| kconfig-language.rst | ||
| kconfig-macro-language.rst | ||
| Kconfig.recursion-issue-01 | ||
| Kconfig.recursion-issue-02 | ||
| kconfig.rst | ||
| Kconfig.select-break | ||
| llvm.rst | ||
| makefiles.rst | ||
| modules.rst | ||
| reproducible-builds.rst | ||