mirror of
https://github.com/torvalds/linux.git
synced 2024-12-12 14:12:51 +00:00
b6dcde5c74
Profiling of a page fault scalability microbenchmark shows flush_hash_range is not calling the batch hpte invalidate hcall (H_BULK_REMOVE). It turns out we have a duplicate firmware feature for hcall-bulk and the current setup code stops after finding the first match. This meant we never batch and always do individual invalidates. The patch below removes the duplicate and shifts FW_FEATURE_CMO to close the gap. With the patch applied the single threaded page fault rate improves from 217169 to 238755 per second on a POWER5 test box, a 10% improvement. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
87 lines
2.5 KiB
C
87 lines
2.5 KiB
C
/*
|
|
* pSeries firmware setup code.
|
|
*
|
|
* Portions from arch/powerpc/platforms/pseries/setup.c:
|
|
* Copyright (C) 1995 Linus Torvalds
|
|
* Adapted from 'alpha' version by Gary Thomas
|
|
* Modified by Cort Dougan (cort@cs.nmt.edu)
|
|
* Modified by PPC64 Team, IBM Corp
|
|
*
|
|
* Portions from arch/powerpc/kernel/firmware.c
|
|
* Copyright (C) 2001 Ben. Herrenschmidt (benh@kernel.crashing.org)
|
|
* Modifications for ppc64:
|
|
* Copyright (C) 2003 Dave Engebretsen <engebret@us.ibm.com>
|
|
* Copyright (C) 2005 Stephen Rothwell, IBM Corporation
|
|
*
|
|
* Copyright 2006 IBM Corporation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
|
|
#include <asm/firmware.h>
|
|
#include <asm/prom.h>
|
|
#include <asm/udbg.h>
|
|
|
|
#include "pseries.h"
|
|
|
|
typedef struct {
|
|
unsigned long val;
|
|
char * name;
|
|
} firmware_feature_t;
|
|
|
|
static __initdata firmware_feature_t
|
|
firmware_features_table[FIRMWARE_MAX_FEATURES] = {
|
|
{FW_FEATURE_PFT, "hcall-pft"},
|
|
{FW_FEATURE_TCE, "hcall-tce"},
|
|
{FW_FEATURE_SPRG0, "hcall-sprg0"},
|
|
{FW_FEATURE_DABR, "hcall-dabr"},
|
|
{FW_FEATURE_COPY, "hcall-copy"},
|
|
{FW_FEATURE_ASR, "hcall-asr"},
|
|
{FW_FEATURE_DEBUG, "hcall-debug"},
|
|
{FW_FEATURE_PERF, "hcall-perf"},
|
|
{FW_FEATURE_DUMP, "hcall-dump"},
|
|
{FW_FEATURE_INTERRUPT, "hcall-interrupt"},
|
|
{FW_FEATURE_MIGRATE, "hcall-migrate"},
|
|
{FW_FEATURE_PERFMON, "hcall-perfmon"},
|
|
{FW_FEATURE_CRQ, "hcall-crq"},
|
|
{FW_FEATURE_VIO, "hcall-vio"},
|
|
{FW_FEATURE_RDMA, "hcall-rdma"},
|
|
{FW_FEATURE_LLAN, "hcall-lLAN"},
|
|
{FW_FEATURE_BULK_REMOVE, "hcall-bulk"},
|
|
{FW_FEATURE_XDABR, "hcall-xdabr"},
|
|
{FW_FEATURE_MULTITCE, "hcall-multi-tce"},
|
|
{FW_FEATURE_SPLPAR, "hcall-splpar"},
|
|
};
|
|
|
|
/* Build up the firmware features bitmask using the contents of
|
|
* device-tree/ibm,hypertas-functions. Ultimately this functionality may
|
|
* be moved into prom.c prom_init().
|
|
*/
|
|
void __init fw_feature_init(const char *hypertas, unsigned long len)
|
|
{
|
|
const char *s;
|
|
int i;
|
|
|
|
pr_debug(" -> fw_feature_init()\n");
|
|
|
|
for (s = hypertas; s < hypertas + len; s += strlen(s) + 1) {
|
|
for (i = 0; i < FIRMWARE_MAX_FEATURES; i++) {
|
|
/* check value against table of strings */
|
|
if (!firmware_features_table[i].name ||
|
|
strcmp(firmware_features_table[i].name, s))
|
|
continue;
|
|
|
|
/* we have a match */
|
|
powerpc_firmware_features |=
|
|
firmware_features_table[i].val;
|
|
break;
|
|
}
|
|
}
|
|
|
|
pr_debug(" <- fw_feature_init()\n");
|
|
}
|