mirror of
https://github.com/torvalds/linux.git
synced 2024-12-02 09:01:34 +00:00
87875c1084
The caller of this function (parisc_driver_remove() in arch/parisc/kernel/drivers.c) ignores the return value, so better don't return any value at all to not wake wrong expectations in driver authors. The only function that could return a non-zero value before was ipmi_parisc_remove() which returns the return value of ipmi_si_remove_by_dev(). Make this function return void, too, as for all other callers the value is ignored, too. Also fold in a small checkpatch fix for: WARNING: Unnecessary space before function pointer arguments + void (*remove) (struct parisc_device *dev); Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input) Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Acked-by: Jiri Slaby <jirislaby@kernel.org> Signed-off-by: Helge Deller <deller@gmx.de>
172 lines
4.0 KiB
C
172 lines
4.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
/* PARISC LASI driver for the 53c700 chip
|
|
*
|
|
* Copyright (C) 2001 by James.Bottomley@HansenPartnership.com
|
|
**-----------------------------------------------------------------------------
|
|
**
|
|
**
|
|
**-----------------------------------------------------------------------------
|
|
*/
|
|
|
|
/*
|
|
* Many thanks to Richard Hirst <rhirst@linuxcare.com> for patiently
|
|
* debugging this driver on the parisc architecture and suggesting
|
|
* many improvements and bug fixes.
|
|
*
|
|
* Thanks also go to Linuxcare Inc. for providing several PARISC
|
|
* machines for me to debug the driver on.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/types.h>
|
|
#include <linux/stat.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/blkdev.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <asm/page.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/hardware.h>
|
|
#include <asm/parisc-device.h>
|
|
#include <asm/delay.h>
|
|
|
|
#include <scsi/scsi_host.h>
|
|
#include <scsi/scsi_device.h>
|
|
#include <scsi/scsi_transport.h>
|
|
#include <scsi/scsi_transport_spi.h>
|
|
|
|
#include "53c700.h"
|
|
|
|
MODULE_AUTHOR("James Bottomley");
|
|
MODULE_DESCRIPTION("lasi700 SCSI Driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
#define LASI_700_SVERSION 0x00071
|
|
#define LASI_710_SVERSION 0x00082
|
|
|
|
#define LASI700_ID_TABLE { \
|
|
.hw_type = HPHW_FIO, \
|
|
.sversion = LASI_700_SVERSION, \
|
|
.hversion = HVERSION_ANY_ID, \
|
|
.hversion_rev = HVERSION_REV_ANY_ID, \
|
|
}
|
|
|
|
#define LASI710_ID_TABLE { \
|
|
.hw_type = HPHW_FIO, \
|
|
.sversion = LASI_710_SVERSION, \
|
|
.hversion = HVERSION_ANY_ID, \
|
|
.hversion_rev = HVERSION_REV_ANY_ID, \
|
|
}
|
|
|
|
#define LASI700_CLOCK 25
|
|
#define LASI710_CLOCK 40
|
|
#define LASI_SCSI_CORE_OFFSET 0x100
|
|
|
|
static const struct parisc_device_id lasi700_ids[] __initconst = {
|
|
LASI700_ID_TABLE,
|
|
LASI710_ID_TABLE,
|
|
{ 0 }
|
|
};
|
|
|
|
static struct scsi_host_template lasi700_template = {
|
|
.name = "LASI SCSI 53c700",
|
|
.proc_name = "lasi700",
|
|
.this_id = 7,
|
|
.module = THIS_MODULE,
|
|
};
|
|
MODULE_DEVICE_TABLE(parisc, lasi700_ids);
|
|
|
|
static int __init
|
|
lasi700_probe(struct parisc_device *dev)
|
|
{
|
|
unsigned long base = dev->hpa.start + LASI_SCSI_CORE_OFFSET;
|
|
struct NCR_700_Host_Parameters *hostdata;
|
|
struct Scsi_Host *host;
|
|
|
|
hostdata = kzalloc(sizeof(*hostdata), GFP_KERNEL);
|
|
if (!hostdata) {
|
|
dev_printk(KERN_ERR, &dev->dev, "Failed to allocate host data\n");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
hostdata->dev = &dev->dev;
|
|
dma_set_mask(&dev->dev, DMA_BIT_MASK(32));
|
|
hostdata->base = ioremap(base, 0x100);
|
|
hostdata->differential = 0;
|
|
|
|
if (dev->id.sversion == LASI_700_SVERSION) {
|
|
hostdata->clock = LASI700_CLOCK;
|
|
hostdata->force_le_on_be = 1;
|
|
} else {
|
|
hostdata->clock = LASI710_CLOCK;
|
|
hostdata->force_le_on_be = 0;
|
|
hostdata->chip710 = 1;
|
|
hostdata->dmode_extra = DMODE_FC2;
|
|
hostdata->burst_length = 8;
|
|
}
|
|
|
|
host = NCR_700_detect(&lasi700_template, hostdata, &dev->dev);
|
|
if (!host)
|
|
goto out_kfree;
|
|
host->this_id = 7;
|
|
host->base = base;
|
|
host->irq = dev->irq;
|
|
if(request_irq(dev->irq, NCR_700_intr, IRQF_SHARED, "lasi700", host)) {
|
|
printk(KERN_ERR "lasi700: request_irq failed!\n");
|
|
goto out_put_host;
|
|
}
|
|
|
|
dev_set_drvdata(&dev->dev, host);
|
|
scsi_scan_host(host);
|
|
|
|
return 0;
|
|
|
|
out_put_host:
|
|
scsi_host_put(host);
|
|
out_kfree:
|
|
iounmap(hostdata->base);
|
|
kfree(hostdata);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static void __exit
|
|
lasi700_driver_remove(struct parisc_device *dev)
|
|
{
|
|
struct Scsi_Host *host = dev_get_drvdata(&dev->dev);
|
|
struct NCR_700_Host_Parameters *hostdata =
|
|
(struct NCR_700_Host_Parameters *)host->hostdata[0];
|
|
|
|
scsi_remove_host(host);
|
|
NCR_700_release(host);
|
|
free_irq(host->irq, host);
|
|
iounmap(hostdata->base);
|
|
kfree(hostdata);
|
|
}
|
|
|
|
static struct parisc_driver lasi700_driver __refdata = {
|
|
.name = "lasi_scsi",
|
|
.id_table = lasi700_ids,
|
|
.probe = lasi700_probe,
|
|
.remove = __exit_p(lasi700_driver_remove),
|
|
};
|
|
|
|
static int __init
|
|
lasi700_init(void)
|
|
{
|
|
return register_parisc_driver(&lasi700_driver);
|
|
}
|
|
|
|
static void __exit
|
|
lasi700_exit(void)
|
|
{
|
|
unregister_parisc_driver(&lasi700_driver);
|
|
}
|
|
|
|
module_init(lasi700_init);
|
|
module_exit(lasi700_exit);
|