Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-26 14:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
fbb123e248
linux/sound/soc/samsung
History
Pierre-Louis Bossart fbb123e248
ASoC: samsung: smdk_wm8994: add missing return 
cppcheck warning:

sound/soc/samsung/smdk_wm8994.c:179:6: style: Variable 'ret' is
reassigned a value before the old one has been
used. [redundantAssignment]
 ret = devm_snd_soc_register_card(&pdev->dev, card);
     ^
sound/soc/samsung/smdk_wm8994.c:166:8: note: ret is assigned
   ret = -EINVAL;
       ^
sound/soc/samsung/smdk_wm8994.c:179:6: note: ret is overwritten
 ret = devm_snd_soc_register_card(&pdev->dev, card);
     ^

The initial authors bothered to set ret to -EINVAL and throw a
dev_err() message, so it looks like there is a missing return to avoid
continuing if the property is missing.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210219230918.5058-4-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-03-10 13:06:51 +00:00
..
aries_wm8994.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
arndale.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
bells.c ASoC: samsung: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:45 +00:00
dma.h ASoC: samsung: dmaengine: Convert to SPDX License Indentifier 2019-04-19 16:48:52 +01:00
dmaengine.c ASoC: samsung: dmaengine: Convert to SPDX License Indentifier 2019-04-19 16:48:52 +01:00
h1940_uda1380.c ASoC: samsung: h1940: turn into platform driver 2020-08-19 20:15:42 +01:00
i2s-regs.h ASoC: samsung: i2s: Convert to SPDX License Identifier 2019-04-19 16:49:49 +01:00
i2s.c ASoC: samsung: i2s: remove unassigned variable 2021-03-10 13:06:49 +00:00
i2s.h ASoC: samsung: i2s: Convert to SPDX License Identifier 2019-04-19 16:49:49 +01:00
idma.c ASoC: samsung: Drop superfluous ioctl PCM ops 2019-12-11 15:58:41 +00:00
idma.h ASoC: samsung: idma: Convert to SPDX License Identifier 2019-04-19 16:50:17 +01:00
jive_wm8750.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
Kconfig ARM: s5pv210: don't imply CONFIG_PLAT_SAMSUNG 2020-08-19 21:34:26 +02:00
littlemill.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
lowland.c ASoC: samsung: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:45 +00:00
Makefile ASoC: samsung: Add sound support for Midas boards 2020-07-30 21:00:29 +01:00
midas_wm1811.c ASoC: samsung: fix platform_no_drv_owner.cocci warnings 2020-11-18 18:00:24 +00:00
neo1973_wm8753.c ASoC: samsung: neo1973: turn into platform driver 2020-08-19 20:15:43 +01:00
odroid.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
pcm.c ASoC: samsung: sync parameter naming (rate/sample_bits) 2021-01-21 12:37:51 +00:00
pcm.h ASoC: samsung: pcm: Convert to SPDX License Identifier 2019-04-19 16:53:12 +01:00
regs-i2s-v2.h ASoC: samsung: s3c-i2s-v2: Convert to SPDX License Identifier 2019-04-19 16:53:40 +01:00
regs-iis.h ASoC: samsung: s3c24xx-i2s: Convert to SPDX License Identifier 2019-04-19 16:54:00 +01:00
rx1950_uda1380.c ASoC: samsung: rx1950: turn into platform driver 2020-08-19 20:15:44 +01:00
s3c24xx_simtec_hermes.c ASoC: samsung: s3c24xx_simtec_hermes: use modern dai_link style 2019-06-06 21:30:41 +01:00
s3c24xx_simtec_tlv320aic23.c ASoC: samsung: s3c24xx_simtec_tlv320aic23: use modern dai_link style 2019-06-06 21:30:31 +01:00
s3c24xx_simtec.c ASoC: samsung: s3c24xx_simtec: add missing error check 2021-03-10 13:06:50 +00:00
s3c24xx_simtec.h ASoC: samsung: s3c24xx_simtec*: Convert to SPDX License Identifier 2019-04-19 16:54:45 +01:00
s3c24xx_uda134x.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
s3c24xx-i2s.c ARM: s3c24xx: move iis pinctrl config into boards 2020-08-20 17:40:57 +02:00
s3c24xx-i2s.h ASoC: samsung: s3c24xx-i2s: Convert to SPDX License Identifier 2019-04-19 16:54:00 +01:00
s3c2412-i2s.c ARM: s3c24xx: move iis pinctrl config into boards 2020-08-20 17:40:57 +02:00
s3c2412-i2s.h ASoC: samsung: s3c2412-i2s: Convert to SPDX License Identifier 2019-04-19 16:54:29 +01:00
s3c-i2s-v2.c ASoC: samsung: s3c2412-i2s: avoid hardcoded S3C2410_PA_IIS 2020-08-19 20:15:45 +01:00
s3c-i2s-v2.h ASoC: samsung: s3c2412-i2s: avoid hardcoded S3C2410_PA_IIS 2020-08-19 20:15:45 +01:00
smartq_wm8987.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
smdk_spdif.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
smdk_wm8580.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
smdk_wm8994.c ASoC: samsung: smdk_wm8994: add missing return 2021-03-10 13:06:51 +00:00
smdk_wm8994pcm.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
snow.c ASoC: samsung: snow: use semicolons rather than commas to separate statements 2020-10-26 15:28:08 +00:00
spdif.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
spdif.h ASoC: samsung: spdif: Convert to SPDX License Identifier 2019-04-19 16:58:21 +01:00
speyside.c ASoC: samsung: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:45 +00:00
tm2_wm5110.c ASoC: samsung: use asoc_substream_to_rtd() 2020-07-23 19:07:26 +01:00
tobermory.c ASoC: samsung: use asoc_rtd_to_cpu() / asoc_rtd_to_codec() macro for DAI pointer 2020-03-27 14:44:45 +00:00