mirror of
https://github.com/torvalds/linux.git
synced 2024-12-20 01:52:13 +00:00
13b25489b6
Currently, Kbuild always operates in the output directory of the kernel,
even when building external modules. This increases the risk of external
module Makefiles attempting to write to the kernel directory.
This commit switches the working directory to the external module
directory, allowing the removal of the $(KBUILD_EXTMOD)/ prefix from
some build artifacts.
The command for building external modules maintains backward
compatibility, but Makefiles that rely on working in the kernel
directory may break. In such cases, $(objtree) and $(srctree) should
be used to refer to the output and source directories of the kernel.
The appearance of the build log will change as follows:
[Before]
$ make -C /path/to/my/linux M=/path/to/my/externel/module
make: Entering directory '/path/to/my/linux'
CC [M] /path/to/my/externel/module/helloworld.o
MODPOST /path/to/my/externel/module/Module.symvers
CC [M] /path/to/my/externel/module/helloworld.mod.o
CC [M] /path/to/my/externel/module/.module-common.o
LD [M] /path/to/my/externel/module/helloworld.ko
make: Leaving directory '/path/to/my/linux'
[After]
$ make -C /path/to/my/linux M=/path/to/my/externel/module
make: Entering directory '/path/to/my/linux'
make[1]: Entering directory '/path/to/my/externel/module'
CC [M] helloworld.o
MODPOST Module.symvers
CC [M] helloworld.mod.o
CC [M] .module-common.o
LD [M] helloworld.ko
make[1]: Leaving directory '/path/to/my/externel/module'
make: Leaving directory '/path/to/my/linux'
Printing "Entering directory" twice is cumbersome. This will be
addressed later.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <n.schier@avm.de>
64 lines
1.9 KiB
Makefile
64 lines
1.9 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
# ==========================================================================
|
|
# Cleaning up
|
|
# ==========================================================================
|
|
|
|
src := $(srcroot)/$(obj)
|
|
|
|
PHONY := __clean
|
|
__clean:
|
|
|
|
include $(srctree)/scripts/Kbuild.include
|
|
include $(kbuild-file)
|
|
|
|
# Figure out what we need to build from the various variables
|
|
# ==========================================================================
|
|
|
|
subdir-ymn := $(sort $(subdir-y) $(subdir-m) $(subdir-) \
|
|
$(patsubst %/,%, $(filter %/, $(obj-y) $(obj-m) $(obj-))))
|
|
|
|
# Add subdir path
|
|
|
|
subdir-ymn := $(addprefix $(obj)/,$(subdir-ymn))
|
|
|
|
# build a list of files to remove, usually relative to the current
|
|
# directory
|
|
|
|
__clean-files := \
|
|
$(clean-files) $(targets) $(hostprogs) $(userprogs) \
|
|
$(extra-y) $(extra-m) $(extra-) \
|
|
$(always-y) $(always-m) $(always-) \
|
|
$(hostprogs-always-y) $(hostprogs-always-m) $(hostprogs-always-) \
|
|
$(userprogs-always-y) $(userprogs-always-m) $(userprogs-always-)
|
|
|
|
__clean-files := $(filter-out $(no-clean-files), $(__clean-files))
|
|
|
|
__clean-files := $(wildcard $(addprefix $(obj)/, $(__clean-files)))
|
|
|
|
# ==========================================================================
|
|
|
|
# To make this rule robust against "Argument list too long" error,
|
|
# remove $(obj)/ prefix, and restore it by a shell command.
|
|
quiet_cmd_clean = CLEAN $(obj)
|
|
cmd_clean = printf '$(obj)/%s ' $(patsubst $(obj)/%,%,$(__clean-files)) | xargs rm -rf
|
|
|
|
__clean: $(subdir-ymn)
|
|
ifneq ($(strip $(__clean-files)),)
|
|
$(call cmd,clean)
|
|
endif
|
|
@:
|
|
|
|
|
|
# ===========================================================================
|
|
# Generic stuff
|
|
# ===========================================================================
|
|
|
|
# Descending
|
|
# ---------------------------------------------------------------------------
|
|
|
|
PHONY += $(subdir-ymn)
|
|
$(subdir-ymn):
|
|
$(Q)$(MAKE) $(clean)=$@
|
|
|
|
.PHONY: $(PHONY)
|