mirror of
https://github.com/torvalds/linux.git
synced 2024-12-15 15:41:58 +00:00
fa95d206e4
This patch fixes 4 bugs in the connection connect/disconnect cleanup path. 1. If beiscsi_open_conn fails beiscsi_free_ep was always being called, and if beiscsi_open_conn failed because beiscsi_get_cid failed then we would free an unallocated cid. 2. If beiscsi_ep_connect failed due to a beiscsi_open_conn failure it was leaking iscsi_endpoints. 3. beiscsi_ep_disconnect was leaking iscsi_endpoints. beiscsi_ep_disconnect should free the iscsi_endpoint. We cannot do it in beiscsi_conn_stop because that is only called for iscsi connection cleanup. If beiscsi_ep_connect returns success, but then the poll function fails or the connect times out then beiscsi_ep_disconnect will be called to clean up the ep. The conn_stop callout will not be called in that path. 4. beiscsi_conn_stop was freeing the iscsi_endpoint then accessing it a couple lines later. Signed-off-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <James.Bottomley@suse.de> |
||
|---|---|---|
| .. | ||
| be_cmds.c | ||
| be_cmds.h | ||
| be_iscsi.c | ||
| be_iscsi.h | ||
| be_main.c | ||
| be_main.h | ||
| be_mgmt.c | ||
| be_mgmt.h | ||
| be.h | ||
| Kconfig | ||
| Makefile | ||