Davide Caratti fa4e0f8855 net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions ... the following script: # tc qdisc add dev eth0 clsact # tc filter add dev eth0 egress protocol ip matchall \ > action mpls push protocol mpls_uc label 0x355aa bos 1 causes corruption of all IP packets transmitted by eth0. On TC egress, we can't rely on the value of skb->mac_len, because it's 0 and a MPLS 'push' operation will result in an overwrite of the first 4 octets in the packet L2 header (e.g. the Destination Address if eth0 is an Ethernet); the same error pattern is present also in the MPLS 'pop' operation. Fix this error in act_mpls data plane, computing 'mac_len' as the difference between the network header and the mac header (when not at TC ingress), and use it in MPLS 'push'/'pop' core functions. v2: unbreak 'make htmldocs' because of missing documentation of 'mac_len' in skb_mpls_pop(), reported by kbuild test robot CC: Lorenzo Bianconi <lorenzo@kernel.org> Fixes: 2a2ea50870 ("net: sched: add mpls manipulation actions to TC") Reviewed-by: Simon Horman <simon.horman@netronome.com> Acked-by: John Hurley <john.hurley@netronome.com> Signed-off-by: Davide Caratti <dcaratti@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-10-15 17:14:48 -07:00
..
act_api.c	net_sched: fix backward compatibility for TCA_ACT_KIND	2019-10-08 16:29:35 -07:00
act_bpf.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_connmark.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_csum.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ct.c	netfilter: update include directives.	2019-09-13 12:33:06 +02:00
act_ctinfo.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_gact.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ife.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ipt.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	act_mirred: Fix mirred_init_module error handling	2019-10-09 19:19:35 -07:00
act_mpls.c	net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions	2019-10-15 17:14:48 -07:00
act_nat.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_pedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_police.c	net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate	2019-09-06 15:02:16 +02:00
act_sample.c	net/sched: act_sample: don't push mac header on ip6gre ingress	2019-09-20 17:01:59 -07:00
act_simple.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbmod.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_tunnel_key.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_vlan.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-02 11:20:17 -07:00
cls_api.c	net_sched: fix backward compatibility for TCA_KIND	2019-10-08 16:21:58 -07:00
cls_basic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_bpf.c	net: sched: refactor block offloads counter usage	2019-08-26 14:17:43 -07:00
cls_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flow.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flower.c	net: sched: flower: don't take rtnl lock for cls hw offloads API	2019-08-26 14:17:43 -07:00
cls_fw.c	net: sched: remove NET_CLS_IND config option	2019-06-15 14:06:13 -07:00
cls_matchall.c	net: sched: cls_matchall: cleanup flow_action before deallocating	2019-08-30 15:12:05 -07:00
cls_route.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_tcindex.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
cls_u32.c	net: sched: refactor block offloads counter usage	2019-08-26 14:17:43 -07:00
em_canid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11	2019-05-21 11:28:45 +02:00
em_cmp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_ipset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
em_ipt.c	net: sched: em_ipt: add support for addrtype matching	2019-06-29 11:15:12 -07:00
em_meta.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
em_nbyte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Kconfig	net/sched: Set default of CONFIG_NET_TC_SKB_EXT to N	2019-09-27 20:08:28 +02:00
Makefile	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
sch_api.c	net_sched: fix backward compatibility for TCA_KIND	2019-10-08 16:21:58 -07:00
sch_atm.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_blackhole.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cake.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_cbq.c	sch_cbq: validate TCA_CBQ_WRROPT to avoid crash	2019-09-30 11:07:46 -07:00
sch_cbs.c	net: sched: cbs: Avoid division by zero when calculating the port rate	2019-10-01 09:51:39 -07:00
sch_choke.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_codel.c	net: sched: Fix a possible null-pointer dereference in dequeue_func()	2019-07-29 09:46:58 -07:00
sch_drr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_dsmark.c	sch_dsmark: fix potential NULL deref in dsmark_init()	2019-10-04 18:28:30 -07:00
sch_etf.c	etf: Add skip_sock_check	2019-06-28 14:45:33 -07:00
sch_fifo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_fq_codel.c	fq_codel: remove set but not used variables 'prev_ecn_mark' and 'prev_drop_count'	2019-08-08 22:32:19 -07:00
sch_fq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_generic.c	net_sched: let qdisc_put() accept NULL pointer	2019-09-15 20:54:14 +02:00
sch_gred.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_hfsc.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_hhf.c	sch_hhf: ensure quantum and hhf_non_hh_weight are non-zero	2019-09-10 18:31:00 +01:00
sch_htb.c	net: sched: sch_htb: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_ingress.c	net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*	2019-07-09 14:38:50 -07:00
sch_mq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_mqprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_multiq.c	net: sched: multiq: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_netem.c	sch_netem: fix rcu splat in netem_enqueue()	2019-09-27 10:29:11 +02:00
sch_pie.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
sch_plug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_prio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_qfq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_red.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_sfb.c	net: sched: sch_sfb: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_sfq.c	net_sched: unset TCQ_F_CAN_BYPASS when adding filters	2019-07-17 13:34:09 -07:00
sch_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_taprio.c	net: taprio: Fix returning EINVAL when configuring without flags	2019-10-09 18:49:19 -07:00
sch_tbf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_teql.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00