mirror of
https://github.com/torvalds/linux.git
synced 2024-12-15 15:41:58 +00:00
8bd26e3a7e
The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications. For example, the fix in
commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.
After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out. Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.
Note that some harmless section mismatch warnings may result, since
notify_cpu_starting() and cpu_up() are arch independent (kernel/cpu.c)
and are flagged as __cpuinit -- so if we remove the __cpuinit from
the arch specific callers, we will also get section mismatch warnings.
As an intermediate step, we intend to turn the linux/init.h cpuinit
related content into no-ops as early as possible, since that will get
rid of these warnings. In any case, they are temporary and harmless.
This removes all the ARM uses of the __cpuinit macros from C code,
and all __CPUINIT from assembly code. It also had two ".previous"
section statements that were paired off against __CPUINIT
(aka .section ".cpuinit.text") that also get removed here.
[1] https://lkml.org/lkml/2013/5/20/589
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
48 lines
1.3 KiB
ArmAsm
48 lines
1.3 KiB
ArmAsm
/*
|
|
* SMP support: Entry point for secondary CPUs
|
|
*
|
|
* Copyright (C) 2012 Marvell
|
|
*
|
|
* Yehuda Yitschak <yehuday@marvell.com>
|
|
* Gregory CLEMENT <gregory.clement@free-electrons.com>
|
|
* Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*
|
|
* This file implements the assembly entry point for secondary CPUs in
|
|
* an SMP kernel. The only thing we need to do is to add the CPU to
|
|
* the coherency fabric by writing to 2 registers. Currently the base
|
|
* register addresses are hard coded due to the early initialisation
|
|
* problems.
|
|
*/
|
|
|
|
#include <linux/linkage.h>
|
|
#include <linux/init.h>
|
|
|
|
/*
|
|
* Armada XP specific entry point for secondary CPUs.
|
|
* We add the CPU to the coherency fabric and then jump to secondary
|
|
* startup
|
|
*/
|
|
ENTRY(armada_xp_secondary_startup)
|
|
/* Get coherency fabric base physical address */
|
|
adr r0, 1f
|
|
ldr r1, [r0]
|
|
ldr r0, [r0, r1]
|
|
|
|
/* Read CPU id */
|
|
mrc p15, 0, r1, c0, c0, 5
|
|
and r1, r1, #0xF
|
|
|
|
/* Add CPU to coherency fabric */
|
|
bl ll_set_cpu_coherent
|
|
b secondary_startup
|
|
|
|
ENDPROC(armada_xp_secondary_startup)
|
|
|
|
.align 2
|
|
1:
|
|
.long coherency_phys_base - .
|