Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-30 14:52:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
f61d500820
linux/drivers/media/platform/exynos4-is
History
Sylwester Nawrocki f61d500820 [media] exynos4-is: Fix buffer release issue on fimc m2m video nodes 
This fixes dropping ownership of buffers in the driver's stop_streaming
callback, so buffers on the memory-to-memory video nodes are properly
released, also in case when the driver has a buffer only on one of the
queues (OUTPUT, CAPTURE) before the video node close.
The issue was being reported by videobuf2 with a following warning while
checking q->owned_by_drv_count:

[ 2498.310766] WARNING: CPU: 0 PID: 9358 at drivers/media/v4l2-core/videobuf2-core.c:1818 __vb2_queue_cancel+0xe8/0x14c
[ 2498.320258] Modules linked in:
[ 2498.323212] CPU: 0 PID: 9358 Comm: v4l2_decode Not tainted 4.7.0-rc4-next-20160627 #1210
[ 2498.331284] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[ 2498.331327] [<c010d738>] (unwind_backtrace) from [<c010a4b0>] (show_stack+0x10/0x14)
[ 2498.331344] [<c010a4b0>] (show_stack) from [<c031a4ac>] (dump_stack+0x74/0x94)
[ 2498.331358] [<c031a4ac>] (dump_stack) from [<c011a52c>] (__warn+0xd4/0x100)
[ 2498.331369] [<c011a52c>] (__warn) from [<c011a578>] (warn_slowpath_null+0x20/0x28)
[ 2498.331381] [<c011a578>] (warn_slowpath_null) from [<c04ed420>] (__vb2_queue_cancel+0xe8/0x14c)
[ 2498.331395] [<c04ed420>] (__vb2_queue_cancel) from [<c04ee10c>] (vb2_core_queue_release+0x18/0x38)
[ 2498.331406] [<c04ee10c>] (vb2_core_queue_release) from [<c04eab50>] (v4l2_m2m_ctx_release+0x1c/0x28)
[ 2498.331420] [<c04eab50>] (v4l2_m2m_ctx_release) from [<c04fe184>] (fimc_m2m_release+0x24/0x78)
[ 2498.331437] [<c04fe184>] (fimc_m2m_release) from [<c04d76c8>] (v4l2_release+0x34/0x74)
[ 2498.331455] [<c04d76c8>] (v4l2_release) from [<c01dc8d4>] (__fput+0x80/0x1bc)
[ 2498.331469] [<c01dc8d4>] (__fput) from [<c0132edc>] (task_work_run+0xc0/0xe4)
[ 2498.331482] [<c0132edc>] (task_work_run) from [<c011d460>] (do_exit+0x304/0xa24)
[ 2498.331493] [<c011d460>] (do_exit) from [<c011dccc>] (do_group_exit+0x3c/0xbc)
[ 2498.331505] [<c011dccc>] (do_group_exit) from [<c0126cac>] (get_signal+0x200/0x65c)
[ 2498.331517] [<c0126cac>] (get_signal) from [<c010e928>] (do_signal+0x84/0x3c4)
[ 2498.331532] [<c010e928>] (do_signal) from [<c010a0ec>] (do_work_pending+0xa4/0xb4)
[ 2498.331545] [<c010a0ec>] (do_work_pending) from [<c0107954>] (slow_work_pending+0xc/0x20)

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2016-07-08 14:26:29 -03:00
..
common.c [media] media: use macros to check for V4L2 subdev entities 2016-01-11 12:18:50 -02:00
common.h
fimc-capture.c [media] media framework: rename pads init function to media_entity_pads_init() 2016-01-11 12:19:03 -02:00
fimc-core.c media: set proper max seg size for devices on Exynos SoCs 2016-06-03 11:13:11 +02:00
fimc-core.h [media] include/media: move driver interface headers to a separate dir 2015-11-17 06:57:29 -02:00
fimc-is-command.h
fimc-is-errno.c [media] fimc-is-param: get rid of warnings 2014-08-26 18:52:12 -03:00
fimc-is-errno.h [media] fimc-is-param: get rid of warnings 2014-08-26 18:52:12 -03:00
fimc-is-i2c.c Driver core patches for 3.19-rc1 2014-12-14 16:10:09 -08:00
fimc-is-i2c.h
fimc-is-param.c [media] fimc-is-param: get rid of warnings 2014-08-26 18:52:12 -03:00
fimc-is-param.h [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver 2014-03-14 10:37:12 -03:00
fimc-is-regs.c [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver 2014-03-14 10:37:12 -03:00
fimc-is-regs.h [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver 2014-03-14 10:37:12 -03:00
fimc-is-sensor.c [media] exynos4-is: Use external s5k6a3 sensor driver 2014-03-14 10:34:13 -03:00
fimc-is-sensor.h [media] exynos4-is: Use external s5k6a3 sensor driver 2014-03-14 10:34:13 -03:00
fimc-is.c media: set proper max seg size for devices on Exynos SoCs 2016-06-03 11:13:11 +02:00
fimc-is.h [media] media: videobuf2: Replace videobuf2-core with videobuf2-v4l2 2015-10-01 08:48:18 -03:00
fimc-isp-video.c [media] exynos4-is: fix a format string bug 2016-01-25 09:20:16 -02:00
fimc-isp-video.h [media] media: videobuf2: Replace videobuf2-core with videobuf2-v4l2 2015-10-01 08:48:18 -03:00
fimc-isp.c [media] media framework: rename pads init function to media_entity_pads_init() 2016-01-11 12:19:03 -02:00
fimc-isp.h [media] include/media: move driver interface headers to a separate dir 2015-11-17 06:57:29 -02:00
fimc-lite-reg.c [media] include/media: move driver interface headers to a separate dir 2015-11-17 06:57:29 -02:00
fimc-lite-reg.h
fimc-lite.c media: set proper max seg size for devices on Exynos SoCs 2016-06-03 11:13:11 +02:00
fimc-lite.h [media] include/media: move driver interface headers to a separate dir 2015-11-17 06:57:29 -02:00
fimc-m2m.c [media] exynos4-is: Fix buffer release issue on fimc m2m video nodes 2016-07-08 14:26:29 -03:00
fimc-reg.c [media] include/media: move driver interface headers to a separate dir 2015-11-17 06:57:29 -02:00
fimc-reg.h
Kconfig [media] exynos4-is: make VIDEO_SAMSUNG_EXYNOS4_IS tristate 2016-01-25 12:53:17 -02:00
Makefile [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver 2014-03-14 10:37:12 -03:00
media-dev.c Linux 4.6-rc7 2016-05-09 12:21:49 -03:00
media-dev.h [media] v4l: exynos4-is: Use the new media graph walk interface 2016-01-11 12:19:19 -02:00
mipi-csis.c exynos4-is: remove some unused vars 2016-06-24 08:36:13 -03:00
mipi-csis.h