mirror of
https://github.com/torvalds/linux.git
synced 2024-11-26 06:02:05 +00:00
b05ddad009
GPIOLIB core: - provide interfaces allowing users to retrieve, manage and query the reference counted GPIO device instead of accessing the private gpio_chip structure - replace gpiochip_find() with gpio_device_find() - remove unused acpi_get_and_request_gpiod() - improve the ignore_interrupt functionality in GPIO ACPI - correct notifier return codes in gpiolib-of - unexport gpiod_set_transitory() as it's unused outside of core GPIO code - while there are still external users accessing struct gpio_chip, let's make gpiochip_get_desc() public so that they at least use the preferred helper - improve locking for lookup tables - annotate struct linereq with __counted_by - improve GPIOLIB docs - add an OF quirk for LED trigger sources Driver improvements: - convert all GPIO drivers with .remove() callbacks to using the new variant returning void instead of int - stop accessing the GPIOLIB private structures in gpio-mockup, i2c-mux-gpio, hte-tegra194, gpio-sim - use the recommended pattern for autofree variables in gpio-sim - add support for more models to gpio-loongson - use a notifier chain to notify other blocks about interrupts in gpio-eic-sprd instead of looking up GPIO devices on every interrupt - convert gpio-pca953x and gpio-fx6408 to using the maple tree regmap cache - don't include GPIOLIB internal headers in drivers which don't need them - move the ingenic NAND quirk into gpiolib-of - add an ignore interrupt quirk for Peaq C1010 - drop static GPIO base from gpio-omap, gpio-f7188x - use the preferred device_get_match_data() function in drivers that still don't - refactor gpio-pca953x: switch to using DEFINE_SIMPLE_DEV_PM_OPS(), use cleanup helpers, use dev_err_probe() where it makes sense, fully convert to using devres and some other minor tweaks DT bindings: - add support for a new model to gpio-vf610 and update existing properties - add support for more loongson models - add missing support for imx models that are used but undocumented - convert bindings for Intel IXP4xx to schema Minor stuff: - deprecate gpio-mockup in favor of gpio-sim - include missing headers here and there - stop using gpiochip_find() in OMAP1 board files - minor tweaks in gpio-vf610, gpio-hisi - remove unneeded 'extern' specifiers from headers -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFp3rbAvDxGAT0sefEacuoBRx13IFAmU7ixgACgkQEacuoBRx 13JwfxAA4CeZdXdUpx6EMUw+6ST4EWb5JanrPjNcQbyBxNFrHx+6yJJL4AOQJStQ WkG+Zi8Li9uV3wZQixBDs0WN8xVwJU+4QLSwwtNhEjl2x9MkVjghh4la6TqBrMj8 e/iJufTyKUgcm2P4MRTDXFarAin4doBQUPKWfCgL18VvlKxLXG0KMndUl3jAd/Rm YZLm4Z/iqWaxjfrm+E9LfWFmWS5T7t/g+7TYzMp2AHQ9dHFiwoodpiHTkdWH4dfL zxF8Ek2132Up0BYC1lQlwz1aoLIlHcr9xVOqOrIxZI/B5xRcUfoXnQQmCCfH2UYr wtfwKMI7IO2d5E+F7anFC67d9wm7tWacKEifw9lWUAD6xr6yv/13ZOU6aoWXj1Vq xOMe6gEeZSboF/XiqlmrpZYH+ljDp/mYWkGcOJrUg7WYUgvUCFWu6l6DmuUFMr7m ACtOUqwbTuWTXN28QtMOpjiQRqlAWyrY6PqhBCllhmcjsoVaZNgWEfriPlSOyoBg EBRBcURXLs7/h86nEsK/8BIsC0myHbpNiNpG5qaMjrrYJxMh4qS4MIG83MWAy1dZ 8ZtYrxx4XClyaYwYomsIkseLaSCrBTIoYws7wmyTjYfKC7P/t6/XXPS1suyMnf9I /n5tN8Rv1pDrnS3iQflHQVl9H5m4yezHOOBJUiWW+gs5MUr4vK0= =1QF8 -----END PGP SIGNATURE----- Merge tag 'gpio-updates-for-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux Pull gpio updates from Bartosz Golaszewski: "We don't have any new drivers. The loongson driver is getting extended with support for new models. There's a big refactor of gpio-pca953x and many small improvements to others. The GPIO code in the kernel has acquired a lot of cruft over the years as well as many abusers of the API across the kernel tree. This release cycle we have started a major cleanup and improvement effort that will most likely span several releases. We have started by converting external users of struct gpio_chip to accessing the wrapper around it - struct gpio_device. This is because the latter is reference counted while the former is removed when the provider is unbound. We also removed several instances of drivers accessing private GPIOLIB structures and including the private header from drivers/gpio/. To that end you'll see several commits aimed at different subsystems (acked by relevant maintainers) as well as two merges from the x86/platform tree. We'll then rework the locking in GPIOLIB which currently uses a big spinlock for many different things and could use becoming more fine-grained, especially as it doesn't even get the locking right. We'll also use SRCU for protecting the gpio_chip pointer against in-kernel hot-unplug crashes similar to what we saw triggered from user-space and fixed with semaphores in gpiolib-cdev. The core GPIOLIB is still vulnerable to these use-cases. I'm just mentioning the plans here, this is not part of this PR. You'll see some new instances of using __free(). We've added a gpio_device_put cleanup helper similar to the put_device one introduced by Peter Zijlstra and used it according to the preferred pattern except where it didn't make sense. GPIOLIB core: - provide interfaces allowing users to retrieve, manage and query the reference counted GPIO device instead of accessing the private gpio_chip structure - replace gpiochip_find() with gpio_device_find() - remove unused acpi_get_and_request_gpiod() - improve the ignore_interrupt functionality in GPIO ACPI - correct notifier return codes in gpiolib-of - unexport gpiod_set_transitory() as it's unused outside of core GPIO code - while there are still external users accessing struct gpio_chip, let's make gpiochip_get_desc() public so that they at least use the preferred helper - improve locking for lookup tables - annotate struct linereq with __counted_by - improve GPIOLIB docs - add an OF quirk for LED trigger sources Driver improvements: - convert all GPIO drivers with .remove() callbacks to using the new variant returning void instead of int - stop accessing the GPIOLIB private structures in gpio-mockup, i2c-mux-gpio, hte-tegra194, gpio-sim - use the recommended pattern for autofree variables in gpio-sim - add support for more models to gpio-loongson - use a notifier chain to notify other blocks about interrupts in gpio-eic-sprd instead of looking up GPIO devices on every interrupt - convert gpio-pca953x and gpio-fx6408 to using the maple tree regmap cache - don't include GPIOLIB internal headers in drivers which don't need them - move the ingenic NAND quirk into gpiolib-of - add an ignore interrupt quirk for Peaq C1010 - drop static GPIO base from gpio-omap, gpio-f7188x - use the preferred device_get_match_data() function in drivers that still don't - refactor gpio-pca953x: switch to using DEFINE_SIMPLE_DEV_PM_OPS(), use cleanup helpers, use dev_err_probe() where it makes sense, fully convert to using devres and some other minor tweaks DT bindings: - add support for a new model to gpio-vf610 and update existing properties - add support for more loongson models - add missing support for imx models that are used but undocumented - convert bindings for Intel IXP4xx to schema Minor stuff: - deprecate gpio-mockup in favor of gpio-sim - include missing headers here and there - stop using gpiochip_find() in OMAP1 board files - minor tweaks in gpio-vf610, gpio-hisi - remove unneeded 'extern' specifiers from headers" * tag 'gpio-updates-for-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux: (108 commits) hte: tegra194: add GPIOLIB dependency hte: tegra194: don't access struct gpio_chip gpiolib: provide gpio_device_get_base() i2c: mux: gpio: don't fiddle with GPIOLIB internals gpiolib: provide gpiod_to_gpio_device() gpiolib: provide gpio_device_to_device() gpio: hisi: Fix format specifier gpiolib: provide gpio_device_find_by_fwnode() gpio: acpi: remove acpi_get_and_request_gpiod() gpio: Use device_get_match_data() gpio: vf610: update comment for i.MX8ULP and i.MX93 legacy compatibles platform/x86: int3472: Switch to devm_get_gpiod() platform/x86: int3472: Stop using gpiod_toggle_active_low() platform/x86: int3472: Add new skl_int3472_gpiod_get_from_temp_lookup() helper platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper gpio: vf610: simplify code by dropping data check gpio: vf610: add i.MX8ULP of_device_id entry dt-bindings: gpio: vf610: add i.MX95 compatible dt-bindings: gpio: vf610: correct i.MX8ULP and i.MX93 dt-bindings: gpio: vf610: update gpio-ranges ...
248 lines
6.4 KiB
C
248 lines
6.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/* Abilis Systems MODULE DESCRIPTION
|
|
*
|
|
* Copyright (C) Abilis Systems 2013
|
|
*
|
|
* Authors: Sascha Leuenberger <sascha.leuenberger@abilis.com>
|
|
* Christian Ruppert <christian.ruppert@abilis.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/gpio/driver.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/irqdomain.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/bitops.h>
|
|
#include <linux/pinctrl/consumer.h>
|
|
|
|
#define TB10X_GPIO_DIR_IN (0x00000000)
|
|
#define TB10X_GPIO_DIR_OUT (0x00000001)
|
|
#define OFFSET_TO_REG_DDR (0x00)
|
|
#define OFFSET_TO_REG_DATA (0x04)
|
|
#define OFFSET_TO_REG_INT_EN (0x08)
|
|
#define OFFSET_TO_REG_CHANGE (0x0C)
|
|
#define OFFSET_TO_REG_WRMASK (0x10)
|
|
#define OFFSET_TO_REG_INT_TYPE (0x14)
|
|
|
|
|
|
/**
|
|
* @base: register base address
|
|
* @domain: IRQ domain of GPIO generated interrupts managed by this controller
|
|
* @irq: Interrupt line of parent interrupt controller
|
|
* @gc: gpio_chip structure associated to this GPIO controller
|
|
*/
|
|
struct tb10x_gpio {
|
|
void __iomem *base;
|
|
struct irq_domain *domain;
|
|
int irq;
|
|
struct gpio_chip gc;
|
|
};
|
|
|
|
static inline u32 tb10x_reg_read(struct tb10x_gpio *gpio, unsigned int offs)
|
|
{
|
|
return ioread32(gpio->base + offs);
|
|
}
|
|
|
|
static inline void tb10x_reg_write(struct tb10x_gpio *gpio, unsigned int offs,
|
|
u32 val)
|
|
{
|
|
iowrite32(val, gpio->base + offs);
|
|
}
|
|
|
|
static inline void tb10x_set_bits(struct tb10x_gpio *gpio, unsigned int offs,
|
|
u32 mask, u32 val)
|
|
{
|
|
u32 r;
|
|
unsigned long flags;
|
|
|
|
raw_spin_lock_irqsave(&gpio->gc.bgpio_lock, flags);
|
|
|
|
r = tb10x_reg_read(gpio, offs);
|
|
r = (r & ~mask) | (val & mask);
|
|
|
|
tb10x_reg_write(gpio, offs, r);
|
|
|
|
raw_spin_unlock_irqrestore(&gpio->gc.bgpio_lock, flags);
|
|
}
|
|
|
|
static int tb10x_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
|
|
{
|
|
struct tb10x_gpio *tb10x_gpio = gpiochip_get_data(chip);
|
|
|
|
return irq_create_mapping(tb10x_gpio->domain, offset);
|
|
}
|
|
|
|
static int tb10x_gpio_irq_set_type(struct irq_data *data, unsigned int type)
|
|
{
|
|
if ((type & IRQF_TRIGGER_MASK) != IRQ_TYPE_EDGE_BOTH) {
|
|
pr_err("Only (both) edge triggered interrupts supported.\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
irqd_set_trigger_type(data, type);
|
|
|
|
return IRQ_SET_MASK_OK;
|
|
}
|
|
|
|
static irqreturn_t tb10x_gpio_irq_cascade(int irq, void *data)
|
|
{
|
|
struct tb10x_gpio *tb10x_gpio = data;
|
|
u32 r = tb10x_reg_read(tb10x_gpio, OFFSET_TO_REG_CHANGE);
|
|
u32 m = tb10x_reg_read(tb10x_gpio, OFFSET_TO_REG_INT_EN);
|
|
const unsigned long bits = r & m;
|
|
int i;
|
|
|
|
for_each_set_bit(i, &bits, 32)
|
|
generic_handle_domain_irq(tb10x_gpio->domain, i);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int tb10x_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct tb10x_gpio *tb10x_gpio;
|
|
struct device *dev = &pdev->dev;
|
|
struct device_node *np = dev->of_node;
|
|
int ret = -EBUSY;
|
|
u32 ngpio;
|
|
|
|
if (!np)
|
|
return -EINVAL;
|
|
|
|
if (of_property_read_u32(np, "abilis,ngpio", &ngpio))
|
|
return -EINVAL;
|
|
|
|
tb10x_gpio = devm_kzalloc(dev, sizeof(*tb10x_gpio), GFP_KERNEL);
|
|
if (tb10x_gpio == NULL)
|
|
return -ENOMEM;
|
|
|
|
tb10x_gpio->base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(tb10x_gpio->base))
|
|
return PTR_ERR(tb10x_gpio->base);
|
|
|
|
tb10x_gpio->gc.label =
|
|
devm_kasprintf(dev, GFP_KERNEL, "%pOF", pdev->dev.of_node);
|
|
if (!tb10x_gpio->gc.label)
|
|
return -ENOMEM;
|
|
|
|
/*
|
|
* Initialize generic GPIO with one single register for reading and setting
|
|
* the lines, no special set or clear registers and a data direction register
|
|
* wher 1 means "output".
|
|
*/
|
|
ret = bgpio_init(&tb10x_gpio->gc, dev, 4,
|
|
tb10x_gpio->base + OFFSET_TO_REG_DATA,
|
|
NULL,
|
|
NULL,
|
|
tb10x_gpio->base + OFFSET_TO_REG_DDR,
|
|
NULL,
|
|
0);
|
|
if (ret) {
|
|
dev_err(dev, "unable to init generic GPIO\n");
|
|
return ret;
|
|
}
|
|
tb10x_gpio->gc.base = -1;
|
|
tb10x_gpio->gc.parent = dev;
|
|
tb10x_gpio->gc.owner = THIS_MODULE;
|
|
/*
|
|
* ngpio is set by bgpio_init() but we override it, this .request()
|
|
* callback also overrides the one set up by generic GPIO.
|
|
*/
|
|
tb10x_gpio->gc.ngpio = ngpio;
|
|
tb10x_gpio->gc.request = gpiochip_generic_request;
|
|
tb10x_gpio->gc.free = gpiochip_generic_free;
|
|
|
|
ret = devm_gpiochip_add_data(dev, &tb10x_gpio->gc, tb10x_gpio);
|
|
if (ret < 0) {
|
|
dev_err(dev, "Could not add gpiochip.\n");
|
|
return ret;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, tb10x_gpio);
|
|
|
|
if (of_property_read_bool(np, "interrupt-controller")) {
|
|
struct irq_chip_generic *gc;
|
|
|
|
ret = platform_get_irq(pdev, 0);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
tb10x_gpio->gc.to_irq = tb10x_gpio_to_irq;
|
|
tb10x_gpio->irq = ret;
|
|
|
|
ret = devm_request_irq(dev, ret, tb10x_gpio_irq_cascade,
|
|
IRQF_TRIGGER_NONE | IRQF_SHARED,
|
|
dev_name(dev), tb10x_gpio);
|
|
if (ret != 0)
|
|
return ret;
|
|
|
|
tb10x_gpio->domain = irq_domain_add_linear(np,
|
|
tb10x_gpio->gc.ngpio,
|
|
&irq_generic_chip_ops, NULL);
|
|
if (!tb10x_gpio->domain) {
|
|
return -ENOMEM;
|
|
}
|
|
|
|
ret = irq_alloc_domain_generic_chips(tb10x_gpio->domain,
|
|
tb10x_gpio->gc.ngpio, 1, tb10x_gpio->gc.label,
|
|
handle_edge_irq, IRQ_NOREQUEST, IRQ_NOPROBE,
|
|
IRQ_GC_INIT_MASK_CACHE);
|
|
if (ret)
|
|
goto err_remove_domain;
|
|
|
|
gc = tb10x_gpio->domain->gc->gc[0];
|
|
gc->reg_base = tb10x_gpio->base;
|
|
gc->chip_types[0].type = IRQ_TYPE_EDGE_BOTH;
|
|
gc->chip_types[0].chip.irq_ack = irq_gc_ack_set_bit;
|
|
gc->chip_types[0].chip.irq_mask = irq_gc_mask_clr_bit;
|
|
gc->chip_types[0].chip.irq_unmask = irq_gc_mask_set_bit;
|
|
gc->chip_types[0].chip.irq_set_type = tb10x_gpio_irq_set_type;
|
|
gc->chip_types[0].regs.ack = OFFSET_TO_REG_CHANGE;
|
|
gc->chip_types[0].regs.mask = OFFSET_TO_REG_INT_EN;
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_remove_domain:
|
|
irq_domain_remove(tb10x_gpio->domain);
|
|
return ret;
|
|
}
|
|
|
|
static void tb10x_gpio_remove(struct platform_device *pdev)
|
|
{
|
|
struct tb10x_gpio *tb10x_gpio = platform_get_drvdata(pdev);
|
|
|
|
if (tb10x_gpio->gc.to_irq) {
|
|
irq_remove_generic_chip(tb10x_gpio->domain->gc->gc[0],
|
|
BIT(tb10x_gpio->gc.ngpio) - 1, 0, 0);
|
|
kfree(tb10x_gpio->domain->gc);
|
|
irq_domain_remove(tb10x_gpio->domain);
|
|
}
|
|
}
|
|
|
|
static const struct of_device_id tb10x_gpio_dt_ids[] = {
|
|
{ .compatible = "abilis,tb10x-gpio" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tb10x_gpio_dt_ids);
|
|
|
|
static struct platform_driver tb10x_gpio_driver = {
|
|
.probe = tb10x_gpio_probe,
|
|
.remove_new = tb10x_gpio_remove,
|
|
.driver = {
|
|
.name = "tb10x-gpio",
|
|
.of_match_table = tb10x_gpio_dt_ids,
|
|
}
|
|
};
|
|
|
|
module_platform_driver(tb10x_gpio_driver);
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("tb10x gpio.");
|