mirror of
https://github.com/torvalds/linux.git
synced 2024-12-17 16:43:08 +00:00
edb6689386
snd_miro_probe is a static function that is only called twice in the file that defines it. At each call site, its argument is freed using snd_card_free. Thus, there is no need for snd_miro_probe to call snd_card_free on its argument on any of its error exit paths. Because snd_card_free both reads the fields of its argument and kfrees its argments, the results of the second snd_card_free should be unpredictable. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier f,free,a; parameter list[n] ps; type T; expression e; @@ f(ps,T a,...) { ... when any when != a = e if(...) { ... free(a); ... return ...; } ... when any } @@ identifier r.f,r.free; expression x,a; expression list[r.n] xs; @@ * x = f(xs,a,...); if (...) { ... free(a); ... return ...; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Takashi Iwai <tiwai@suse.de> |
||
---|---|---|
.. | ||
ad1816a | ||
ad1848 | ||
cs423x | ||
es1688 | ||
galaxy | ||
gus | ||
msnd | ||
opti9xx | ||
sb | ||
wavefront | ||
wss | ||
adlib.c | ||
als100.c | ||
azt2320.c | ||
cmi8328.c | ||
cmi8330.c | ||
es18xx.c | ||
Kconfig | ||
Makefile | ||
opl3sa2.c | ||
sc6000.c | ||
sscape.c |