mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 00:21:32 +00:00
340cb392a0
The clk_disable_unprepare() should be called in the error handling
of caps->has_mpddr_clk, fix it by replacing devm_clk_get and
clk_prepare_enable by devm_clk_get_enabled.
Fixes: e81b6abebc ("memory: add a driver for atmel ram controllers")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221125073757.3535219-1-cuigaosheng1@huawei.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
75 lines
1.7 KiB
C
75 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Atmel (Multi-port DDR-)SDRAM Controller driver
|
|
*
|
|
* Author: Alexandre Belloni <alexandre.belloni@free-electrons.com>
|
|
*
|
|
* Copyright (C) 2014 Atmel
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
struct at91_ramc_caps {
|
|
bool has_ddrck;
|
|
bool has_mpddr_clk;
|
|
};
|
|
|
|
static const struct at91_ramc_caps at91rm9200_caps = { };
|
|
|
|
static const struct at91_ramc_caps at91sam9g45_caps = {
|
|
.has_ddrck = 1,
|
|
.has_mpddr_clk = 0,
|
|
};
|
|
|
|
static const struct at91_ramc_caps sama5d3_caps = {
|
|
.has_ddrck = 1,
|
|
.has_mpddr_clk = 1,
|
|
};
|
|
|
|
static const struct of_device_id atmel_ramc_of_match[] = {
|
|
{ .compatible = "atmel,at91rm9200-sdramc", .data = &at91rm9200_caps, },
|
|
{ .compatible = "atmel,at91sam9260-sdramc", .data = &at91rm9200_caps, },
|
|
{ .compatible = "atmel,at91sam9g45-ddramc", .data = &at91sam9g45_caps, },
|
|
{ .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },
|
|
{},
|
|
};
|
|
|
|
static int atmel_ramc_probe(struct platform_device *pdev)
|
|
{
|
|
const struct at91_ramc_caps *caps;
|
|
struct clk *clk;
|
|
|
|
caps = of_device_get_match_data(&pdev->dev);
|
|
|
|
if (caps->has_ddrck) {
|
|
clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
|
|
if (IS_ERR(clk))
|
|
return PTR_ERR(clk);
|
|
}
|
|
|
|
if (caps->has_mpddr_clk) {
|
|
clk = devm_clk_get_enabled(&pdev->dev, "mpddr");
|
|
if (IS_ERR(clk)) {
|
|
pr_err("AT91 RAMC: couldn't get mpddr clock\n");
|
|
return PTR_ERR(clk);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver atmel_ramc_driver = {
|
|
.probe = atmel_ramc_probe,
|
|
.driver = {
|
|
.name = "atmel-ramc",
|
|
.of_match_table = atmel_ramc_of_match,
|
|
},
|
|
};
|
|
|
|
builtin_platform_driver(atmel_ramc_driver);
|