mirror of
https://github.com/torvalds/linux.git
synced 2024-12-21 18:42:44 +00:00
5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
285 lines
6.3 KiB
C
285 lines
6.3 KiB
C
/*
|
|
* Rotary counter driver for Analog Devices Blackfin Processors
|
|
*
|
|
* Copyright 2008-2009 Analog Devices Inc.
|
|
* Licensed under the GPL-2 or later.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/version.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/pm.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/input.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <asm/portmux.h>
|
|
#include <asm/bfin_rotary.h>
|
|
|
|
static const u16 per_cnt[] = {
|
|
P_CNT_CUD,
|
|
P_CNT_CDG,
|
|
P_CNT_CZM,
|
|
0
|
|
};
|
|
|
|
struct bfin_rot {
|
|
struct input_dev *input;
|
|
int irq;
|
|
unsigned int up_key;
|
|
unsigned int down_key;
|
|
unsigned int button_key;
|
|
unsigned int rel_code;
|
|
unsigned short cnt_config;
|
|
unsigned short cnt_imask;
|
|
unsigned short cnt_debounce;
|
|
};
|
|
|
|
static void report_key_event(struct input_dev *input, int keycode)
|
|
{
|
|
/* simulate a press-n-release */
|
|
input_report_key(input, keycode, 1);
|
|
input_sync(input);
|
|
input_report_key(input, keycode, 0);
|
|
input_sync(input);
|
|
}
|
|
|
|
static void report_rotary_event(struct bfin_rot *rotary, int delta)
|
|
{
|
|
struct input_dev *input = rotary->input;
|
|
|
|
if (rotary->up_key) {
|
|
report_key_event(input,
|
|
delta > 0 ? rotary->up_key : rotary->down_key);
|
|
} else {
|
|
input_report_rel(input, rotary->rel_code, delta);
|
|
input_sync(input);
|
|
}
|
|
}
|
|
|
|
static irqreturn_t bfin_rotary_isr(int irq, void *dev_id)
|
|
{
|
|
struct platform_device *pdev = dev_id;
|
|
struct bfin_rot *rotary = platform_get_drvdata(pdev);
|
|
int delta;
|
|
|
|
switch (bfin_read_CNT_STATUS()) {
|
|
|
|
case ICII:
|
|
break;
|
|
|
|
case UCII:
|
|
case DCII:
|
|
delta = bfin_read_CNT_COUNTER();
|
|
if (delta)
|
|
report_rotary_event(rotary, delta);
|
|
break;
|
|
|
|
case CZMII:
|
|
report_key_event(rotary->input, rotary->button_key);
|
|
break;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
bfin_write_CNT_COMMAND(W1LCNT_ZERO); /* Clear COUNTER */
|
|
bfin_write_CNT_STATUS(-1); /* Clear STATUS */
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int __devinit bfin_rotary_probe(struct platform_device *pdev)
|
|
{
|
|
struct bfin_rotary_platform_data *pdata = pdev->dev.platform_data;
|
|
struct bfin_rot *rotary;
|
|
struct input_dev *input;
|
|
int error;
|
|
|
|
/* Basic validation */
|
|
if ((pdata->rotary_up_key && !pdata->rotary_down_key) ||
|
|
(!pdata->rotary_up_key && pdata->rotary_down_key)) {
|
|
return -EINVAL;
|
|
}
|
|
|
|
error = peripheral_request_list(per_cnt, dev_name(&pdev->dev));
|
|
if (error) {
|
|
dev_err(&pdev->dev, "requesting peripherals failed\n");
|
|
return error;
|
|
}
|
|
|
|
rotary = kzalloc(sizeof(struct bfin_rot), GFP_KERNEL);
|
|
input = input_allocate_device();
|
|
if (!rotary || !input) {
|
|
error = -ENOMEM;
|
|
goto out1;
|
|
}
|
|
|
|
rotary->input = input;
|
|
|
|
rotary->up_key = pdata->rotary_up_key;
|
|
rotary->down_key = pdata->rotary_down_key;
|
|
rotary->button_key = pdata->rotary_button_key;
|
|
rotary->rel_code = pdata->rotary_rel_code;
|
|
|
|
error = rotary->irq = platform_get_irq(pdev, 0);
|
|
if (error < 0)
|
|
goto out1;
|
|
|
|
input->name = pdev->name;
|
|
input->phys = "bfin-rotary/input0";
|
|
input->dev.parent = &pdev->dev;
|
|
|
|
input_set_drvdata(input, rotary);
|
|
|
|
input->id.bustype = BUS_HOST;
|
|
input->id.vendor = 0x0001;
|
|
input->id.product = 0x0001;
|
|
input->id.version = 0x0100;
|
|
|
|
if (rotary->up_key) {
|
|
__set_bit(EV_KEY, input->evbit);
|
|
__set_bit(rotary->up_key, input->keybit);
|
|
__set_bit(rotary->down_key, input->keybit);
|
|
} else {
|
|
__set_bit(EV_REL, input->evbit);
|
|
__set_bit(rotary->rel_code, input->relbit);
|
|
}
|
|
|
|
if (rotary->button_key) {
|
|
__set_bit(EV_KEY, input->evbit);
|
|
__set_bit(rotary->button_key, input->keybit);
|
|
}
|
|
|
|
error = request_irq(rotary->irq, bfin_rotary_isr,
|
|
0, dev_name(&pdev->dev), pdev);
|
|
if (error) {
|
|
dev_err(&pdev->dev,
|
|
"unable to claim irq %d; error %d\n",
|
|
rotary->irq, error);
|
|
goto out1;
|
|
}
|
|
|
|
error = input_register_device(input);
|
|
if (error) {
|
|
dev_err(&pdev->dev,
|
|
"unable to register input device (%d)\n", error);
|
|
goto out2;
|
|
}
|
|
|
|
if (pdata->rotary_button_key)
|
|
bfin_write_CNT_IMASK(CZMIE);
|
|
|
|
if (pdata->mode & ROT_DEBE)
|
|
bfin_write_CNT_DEBOUNCE(pdata->debounce & DPRESCALE);
|
|
|
|
if (pdata->mode)
|
|
bfin_write_CNT_CONFIG(bfin_read_CNT_CONFIG() |
|
|
(pdata->mode & ~CNTE));
|
|
|
|
bfin_write_CNT_IMASK(bfin_read_CNT_IMASK() | UCIE | DCIE);
|
|
bfin_write_CNT_CONFIG(bfin_read_CNT_CONFIG() | CNTE);
|
|
|
|
platform_set_drvdata(pdev, rotary);
|
|
device_init_wakeup(&pdev->dev, 1);
|
|
|
|
return 0;
|
|
|
|
out2:
|
|
free_irq(rotary->irq, pdev);
|
|
out1:
|
|
input_free_device(input);
|
|
kfree(rotary);
|
|
peripheral_free_list(per_cnt);
|
|
|
|
return error;
|
|
}
|
|
|
|
static int __devexit bfin_rotary_remove(struct platform_device *pdev)
|
|
{
|
|
struct bfin_rot *rotary = platform_get_drvdata(pdev);
|
|
|
|
bfin_write_CNT_CONFIG(0);
|
|
bfin_write_CNT_IMASK(0);
|
|
|
|
free_irq(rotary->irq, pdev);
|
|
input_unregister_device(rotary->input);
|
|
peripheral_free_list(per_cnt);
|
|
|
|
kfree(rotary);
|
|
platform_set_drvdata(pdev, NULL);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int bfin_rotary_suspend(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct bfin_rot *rotary = platform_get_drvdata(pdev);
|
|
|
|
rotary->cnt_config = bfin_read_CNT_CONFIG();
|
|
rotary->cnt_imask = bfin_read_CNT_IMASK();
|
|
rotary->cnt_debounce = bfin_read_CNT_DEBOUNCE();
|
|
|
|
if (device_may_wakeup(&pdev->dev))
|
|
enable_irq_wake(rotary->irq);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int bfin_rotary_resume(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct bfin_rot *rotary = platform_get_drvdata(pdev);
|
|
|
|
bfin_write_CNT_DEBOUNCE(rotary->cnt_debounce);
|
|
bfin_write_CNT_IMASK(rotary->cnt_imask);
|
|
bfin_write_CNT_CONFIG(rotary->cnt_config & ~CNTE);
|
|
|
|
if (device_may_wakeup(&pdev->dev))
|
|
disable_irq_wake(rotary->irq);
|
|
|
|
if (rotary->cnt_config & CNTE)
|
|
bfin_write_CNT_CONFIG(rotary->cnt_config);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct dev_pm_ops bfin_rotary_pm_ops = {
|
|
.suspend = bfin_rotary_suspend,
|
|
.resume = bfin_rotary_resume,
|
|
};
|
|
#endif
|
|
|
|
static struct platform_driver bfin_rotary_device_driver = {
|
|
.probe = bfin_rotary_probe,
|
|
.remove = __devexit_p(bfin_rotary_remove),
|
|
.driver = {
|
|
.name = "bfin-rotary",
|
|
.owner = THIS_MODULE,
|
|
#ifdef CONFIG_PM
|
|
.pm = &bfin_rotary_pm_ops,
|
|
#endif
|
|
},
|
|
};
|
|
|
|
static int __init bfin_rotary_init(void)
|
|
{
|
|
return platform_driver_register(&bfin_rotary_device_driver);
|
|
}
|
|
module_init(bfin_rotary_init);
|
|
|
|
static void __exit bfin_rotary_exit(void)
|
|
{
|
|
platform_driver_unregister(&bfin_rotary_device_driver);
|
|
}
|
|
module_exit(bfin_rotary_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
|
|
MODULE_DESCRIPTION("Rotary Counter driver for Blackfin Processors");
|
|
MODULE_ALIAS("platform:bfin-rotary");
|